- 23 Apr, 2018 2 commits
-
-
Aleksey Kozyatinskiy authored
This reverts commit bd7f5cf0. Reason for revert: does not work well. Original change's description: > Roll third_party/inspector_protocol to 59ca26e > > This roll includes: > - [inspector_protocol] first class citizien .pdl support > - [inspector_protocol] node uses script names inside own repository > > + removed .json file > > R=pfeldman@chromium.org,yangguo@chromium.org > > Bug: none > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel > Change-Id: Idd87e80a3ce42198858ade4bcf6e6fec4b2f0731 > Reviewed-on: https://chromium-review.googlesource.com/804635 > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> > Reviewed-by: Pavel Feldman <pfeldman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#52734} TBR=pfeldman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org Change-Id: I64cfa2740c03a2c15db1eb483212adec8f5f6a76 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/1024350Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#52740}
-
Alexey Kozyatinskiy authored
This roll includes: - [inspector_protocol] first class citizien .pdl support - [inspector_protocol] node uses script names inside own repository + removed .json file R=pfeldman@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: Idd87e80a3ce42198858ade4bcf6e6fec4b2f0731 Reviewed-on: https://chromium-review.googlesource.com/804635 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#52734}
-
- 02 Dec, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
All these warnings were fixed long time ago. TBR=dgozman@chromium.org Bug: none Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I066136ce685f95d07b7cbbb4efa8255f5aeaf1a8 Reviewed-on: https://chromium-review.googlesource.com/804816Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49808}
-
- 06 Oct, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
This split is required for adding scriptHash argument. R=dgozman@chromium.org TBR=machenbach@chromium.org Bug: chromium:459499 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I0266cd22be4053829af47ba445e0ddfb6b726e71 Reviewed-on: https://chromium-review.googlesource.com/703863 Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#48355}
-
- 02 Aug, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
My goal was to move breakpoint API to native with minimal changes around, so on inspector side we use v8::debug::BreakpointId instead of String16, on v8::internal::Debug we use i::BreakPoint object instead of break point object created inside of debug.js. There are a lot of opportunities how we can improve breakpoints (at least we can avoid some of linear lookups to speedup implementation) but I think that as first step we need to remove mirrors/debug.js APIs. Drive by: debugger-script.js and usage of debugger context in inspector code base. R=yangguo@chromium.org,jgruber@chromium.org,clemensh@chromium.org Bug: v8:5510,chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0b17972c39053dd4989bbe26db2bb0b88ca378f7 Reviewed-on: https://chromium-review.googlesource.com/593156Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#47091}
-
- 27 Jul, 2017 1 commit
-
-
Alexey Kozyatinskiy authored
This CL moves us much closer to the point where we can remove debugger-script.js and usage of debugger context from inspector. There are three main parts left: - managing breakpoints, - inspecting stack and scopes (this CL), - LiveEdit. In this CL I moved all stack/scope inspection to native. As side effect running debugger and inspector tests are 10-20% faster (it's significant since not all of tests requesting break). R=yangguo@chromium.org,jgruber@chromium.org Bug: chromium:652939 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I409396a687e18e9c0554c0c9c35b6e1064627be8 Reviewed-on: https://chromium-review.googlesource.com/580645Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#46947}
-
- 02 Jun, 2017 1 commit
-
-
dgozman authored
This is just a cleanup patch. BUG=none Review-Url: https://codereview.chromium.org/2921623006 Cr-Commit-Position: refs/heads/master@{#45669}
-
- 18 Dec, 2016 1 commit
-
-
kozyatinskiy authored
BUG=v8:5738 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2579403002 Cr-Commit-Position: refs/heads/master@{#41783}
-
- 22 Nov, 2016 1 commit
-
-
kozyatinskiy authored
This roll includes: - Support config.protocol.options which defines which part of protocol definition should be generated. [1] - [inspector_protocol] Allow custom json parser. [2] - [inspector_protocol] Allow overriding specific config values. [3] - [inspector_protocol] Fix NoneType error when parsing config_values. [4] - [inspector_protocol] Support chromium code style. [5] - [inspector_protocol] Support features for content/ generator. [6] - [inspector_protocol] Fixed domain_json["has_exports"] flag for exported domains [7] [1] https://codereview.chromium.org/2482993002 [2] https://codereview.chromium.org/2490733002 [3] https://codereview.chromium.org/2482093004 [4] https://codereview.chromium.org/2490823002 [5] https://codereview.chromium.org/2495353004 [6] https://codereview.chromium.org/2509573006 [7] https://codereview.chromium.org/2515343005 BUG=none R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2523743003 Cr-Commit-Position: refs/heads/master@{#41195}
-
- 16 Nov, 2016 1 commit
-
-
clemensh authored
This allows to show wasm source (disassembled wasm code) in DevTools. See design doc for details. More tests for the disassembly will have to follow. Also, the text format (generated by V8) will be changed. BUG=chromium:659715 R=yangguo@chromium.org, kozyatinskiy@chromium.org, titzer@chromium.org, dgozman@chromium.org Review-Url: https://codereview.chromium.org/2493773003 Cr-Commit-Position: refs/heads/master@{#41055}
-
- 28 Oct, 2016 1 commit
-
-
kozyatinskiy authored
When Chromium and V8 use the same version of inspector_protocol, any protocol change takes at least 4 patches and 3 waiting for rolls. To simplify this process we need to have two diffrent versions of inspector_protocol in Chromium and V8. Current state of inspector_protocol was extracted into separate repository [1]. This CL puts last version of inspector_protocol into third_party/inspector_protocol and removes dependency on inspector_protocol in Webkit. [1] https://chromium.googlesource.com/deps/inspector_protocol/ BUG=chromium:637032 R=dgozman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel Review-Url: https://codereview.chromium.org/2447323002 Cr-Commit-Position: refs/heads/master@{#40655}
-
- 21 Sep, 2016 2 commits
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org TBR=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2338413003 Cr-Commit-Position: refs/heads/master@{#39608}
-
kozyatinskiy authored
BUG=chromium:635948 R=alph@chromium.org Review-Url: https://codereview.chromium.org/2359533002 Cr-Commit-Position: refs/heads/master@{#39572}
-
- 20 Sep, 2016 2 commits
-
-
jgruber authored
This commit ensures that the d8 shared library build uses the same logic as the standard static build by exporting relevant functions and classes. BUG=chromium:646337 Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65 Review-Url: https://codereview.chromium.org/2342563002 Cr-Original-Commit-Position: refs/heads/master@{#39503} Cr-Commit-Position: refs/heads/master@{#39547}
-
machenbach authored
Revert of [d8] Fix the shared-library build (patchset #12 id:20002 of https://codereview.chromium.org/2342563002/ ) Reason for revert: Unblocking roll Original issue's description: > [d8] Fix the shared-library build > > This commit ensures that the d8 shared library build uses the same logic as > the standard static build by exporting relevant functions and classes. > > BUG=chromium:646337 > > Committed: https://crrev.com/2c10ca8086a4d595ecf9aa843d2031b068470d65 > Cr-Commit-Position: refs/heads/master@{#39503} TBR=jochen@chromium.org,vogelheim@chromium.org,bmeurer@chromium.org,titzer@chromium.org,jgruber@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:646337 Review-Url: https://codereview.chromium.org/2356703003 Cr-Commit-Position: refs/heads/master@{#39526}
-
- 19 Sep, 2016 1 commit
-
-
jgruber authored
This commit ensures that the d8 shared library build uses the same logic as the standard static build by exporting relevant functions and classes. BUG=chromium:646337 Review-Url: https://codereview.chromium.org/2342563002 Cr-Commit-Position: refs/heads/master@{#39503}
-
- 15 Sep, 2016 1 commit
-
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2340763003 Cr-Commit-Position: refs/heads/master@{#39453}
-
- 06 Sep, 2016 1 commit
-
-
dgozman authored
- inspector becomes a dependency of v8_base; - generated public protocol files are placed to gen/v8/include/inspector/<Domain.h>; - added v8_enable_inspector_override to be used in embedders (gn only); - combined public headers into v8-inspector.h and v8-inspector-protocol.h. BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2292053003 Cr-Commit-Position: refs/heads/master@{#39226}
-
- 11 Aug, 2016 1 commit
-
-
dgozman authored
This target introduces a dependency on WebKit/platform which is not the way we want it. Keeping the build files in src/inspector, as they are not used and will be useful later on. BUG=none NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2239603002 Cr-Commit-Position: refs/heads/master@{#38587}
-
- 03 Aug, 2016 3 commits
-
-
yangguo authored
The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 Review-Url: https://codereview.chromium.org/2199253002 Cr-Original-Commit-Position: refs/heads/master@{#38268} Cr-Commit-Position: refs/heads/master@{#38273}
-
yangguo authored
Revert of [inspector] include additional outputs from protocol handler generator. (patchset #2 id:20001 of https://codereview.chromium.org/2199253002/ ) Reason for revert: Compile warnings: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/1901/steps/compile/logs/stdio Original issue's description: > [inspector] include additional outputs from protocol handler generator. > > The protocol handler generator generates these files into a default location if > not specified by flag as output. We should account for these files and > explicitly set its output location. > > R=machenbach@chromium.org > > Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9 > Cr-Commit-Position: refs/heads/master@{#38268} TBR=machenbach@chromium.org,faith4roy16@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2206573004 Cr-Commit-Position: refs/heads/master@{#38272}
-
yangguo authored
The protocol handler generator generates these files into a default location if not specified by flag as output. We should account for these files and explicitly set its output location. R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2199253002 Cr-Commit-Position: refs/heads/master@{#38268}
-
- 01 Aug, 2016 1 commit
-
-
yangguo authored
BUG=chromium:580337 Committed: https://crrev.com/b8229434c9fd3bfef81fb77d88779d0e78d06662 Review-Url: https://codereview.chromium.org/2190833004 Cr-Original-Commit-Position: refs/heads/master@{#38135} Cr-Commit-Position: refs/heads/master@{#38190}
-
- 29 Jul, 2016 1 commit
-
-
machenbach authored
Revert of Reland [inspector] add inspector protocol parser test build target. (patchset #2 id:20001 of https://codereview.chromium.org/2190833004/ ) Reason for revert: Remaining win x64 errors: https://codereview.chromium.org/2187753004/ Original issue's description: > Reland [inspector] add inspector protocol parser test build target. > > BUG=chromium:580337 > > Committed: https://crrev.com/b8229434c9fd3bfef81fb77d88779d0e78d06662 > Cr-Commit-Position: refs/heads/master@{#38135} TBR=yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:580337 Review-Url: https://codereview.chromium.org/2193143002 Cr-Commit-Position: refs/heads/master@{#38156}
-
- 28 Jul, 2016 3 commits
-
-
yangguo authored
BUG=chromium:580337 Review-Url: https://codereview.chromium.org/2190833004 Cr-Commit-Position: refs/heads/master@{#38135}
-
machenbach authored
Breaks chromium win. This also includes: Revert "[gn] Add missing deps to inspector_protocol_parser_test" Revert "Fix gitignores after moving inspector_protocol" NOTRY=true BUG=chromium:580337 TBR=yangguo@chromium.org, jochen@chromium.org, pfeldman@chromium.org Review-Url: https://codereview.chromium.org/2187263002 Cr-Commit-Position: refs/heads/master@{#38128}
-
yangguo authored
This adds the build target inspector_protocol_parser_test, which depends on several more inspector protocol related targets. The resulting gtest executable runs, but has failures that have to be fixed. GN build configuration will follow. A copy of v8-inspector/js_protocol.json has been included to be able to use it before the actual migration. BUG=chromium:580337 Review-Url: https://codereview.chromium.org/2184733002 Cr-Commit-Position: refs/heads/master@{#38111}
-