Skip to content

V
V8
Commit dfcaaeb7 authored by yangguo's avatar yangguo Committed by Commit bot
Browse files
Options

Revert of [inspector] include additional outputs from protocol handler... 

Revert of [inspector] include additional outputs from protocol handler generator. (patchset #2 id:20001 of https://codereview.chromium.org/2199253002/ )

Reason for revert:
Compile warnings: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20clang/builds/1901/steps/compile/logs/stdio

Original issue's description:
> [inspector] include additional outputs from protocol handler generator.
>
> The protocol handler generator generates these files into a default location if
> not specified by flag as output. We should account for these files and
> explicitly set its output location.
>
> R=machenbach@chromium.org
>
> Committed: https://crrev.com/ac1d077db39dcabb74e36ad5d4bc7ea9fad96ed9
> Cr-Commit-Position: refs/heads/master@{#38268}

TBR=machenbach@chromium.org,faith4roy16@gmail.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2206573004
Cr-Commit-Position: refs/heads/master@{#38272}
parent 57fc9a79
Hide whitespace changes
Inline Side-by-side
Showing with 2 additions and 33 deletions
src/inspector/BUILD.gn
View file @ dfcaaeb7
......@@ -12,8 +12,6 @@ protocol_sources = [
"$target_gen_dir/HeapProfiler.h",
"$target_gen_dir/Profiler.cpp",
"$target_gen_dir/Profiler.h",
"$target_gen_dir/public/Debugger.h",
"$target_gen_dir/public/Runtime.h",
"$target_gen_dir/Runtime.cpp",
"$target_gen_dir/Runtime.h",
]
......@@ -43,10 +41,6 @@ action("inspector_protocol_sources") {
rebase_path(target_gen_dir, root_build_dir),
"--output_package",
"inspector",
"--exported_dir",
rebase_path("$target_gen_dir/public", root_build_dir),
"--exported_package",
"inspector/public",
]
}
......
src/inspector/inspector.gyp
View file @ dfcaaeb7
......@@ -13,8 +13,6 @@
'<(SHARED_INTERMEDIATE_DIR)/inspector/HeapProfiler.h',
'<(SHARED_INTERMEDIATE_DIR)/inspector/Profiler.cpp',
'<(SHARED_INTERMEDIATE_DIR)/inspector/Profiler.h',
'<(SHARED_INTERMEDIATE_DIR)/inspector/public/Debugger.h',
'<(SHARED_INTERMEDIATE_DIR)/inspector/public/Runtime.h',
'<(SHARED_INTERMEDIATE_DIR)/inspector/Runtime.cpp',
'<(SHARED_INTERMEDIATE_DIR)/inspector/Runtime.h',
]
......@@ -54,8 +52,6 @@
'--export_macro', 'PLATFORM_EXPORT',
'--output_dir', '<(SHARED_INTERMEDIATE_DIR)/inspector',
'--output_package', 'inspector',
'--exported_dir', '<(SHARED_INTERMEDIATE_DIR)/inspector/public',
'--exported_package', 'inspector/public',
],
'message': 'Generating Inspector protocol backend sources from json definitions',
},
......
src/inspector/js_protocol.json
View file @ dfcaaeb7
......@@ -18,7 +18,6 @@
"id": "RemoteObject",
"type": "object",
"description": "Mirror object referencing original JavaScript object.",
"exported": true,
"properties": [
{ "name": "type", "type": "string", "enum": ["object", "function", "undefined", "string", "number", "boolean", "symbol"], "description": "Object type." },
{ "name": "subtype", "type": "string", "optional": true, "enum": ["array", "null", "node", "regexp", "date", "map", "set", "iterator", "generator", "error"], "description": "Object subtype hint. Specified for <code>object</code> type values only." },
......@@ -167,7 +166,6 @@
"id": "StackTrace",
"type": "object",
"description": "Call frames for assertions or error messages.",
"exported": true,
"properties": [
{ "name": "description", "type": "string", "optional": true, "description": "String label of this stack trace. For async traces this may be a name of the function that initiated the async call." },
{ "name": "callFrames", "type": "array", "items": { "$ref": "CallFrame" }, "description": "JavaScript function name." },
......@@ -178,7 +176,6 @@
"commands": [
{
"name": "evaluate",
"async": true,
"parameters": [
{ "name": "expression", "type": "string", "description": "Expression to evaluate." },
{ "name": "objectGroup", "type": "string", "optional": true, "description": "Symbolic group name that can be used to release multiple objects." },
......@@ -187,8 +184,7 @@
{ "name": "contextId", "$ref": "ExecutionContextId", "optional": true, "description": "Specifies in which isolated context to perform evaluation. Each content script lives in an isolated context and this parameter may be used to specify one of those contexts. If the parameter is omitted or 0 the evaluation will be performed in the context of the inspected page." },
{ "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object that should be sent by value." },
{ "name": "generatePreview", "type": "boolean", "optional": true, "hidden": true, "description": "Whether preview should be generated for the result." },
{ "name": "userGesture", "type": "boolean", "optional": true, "hidden": true, "description": "Whether execution should be treated as initiated by user in the UI." },
{ "name": "awaitPromise", "type": "boolean", "optional":true, "hidden": true, "description": "Whether execution should wait for promise to be resolved. If the result of evaluation is not a Promise, it's considered to be an error." }
{ "name": "userGesture", "type": "boolean", "optional": true, "hidden": true, "description": "Whether execution should be treated as initiated by user in the UI." }
],
"returns": [
{ "name": "result", "$ref": "RemoteObject", "description": "Evaluation result." },
......@@ -197,22 +193,6 @@
],
"description": "Evaluates expression on global object."
},
{
"name": "awaitPromise",
"hidden": true,
"async": true,
"parameters": [
{ "name": "promiseObjectId", "$ref": "RemoteObjectId", "description": "Identifier of the promise." },
{ "name": "returnByValue", "type": "boolean", "optional": true, "description": "Whether the result is expected to be a JSON object that should be sent by value." },
{ "name": "generatePreview", "type": "boolean", "optional": true, "description": "Whether preview should be generated for the result." }
],
"returns": [
{ "name": "result", "$ref": "RemoteObject", "description": "Promise result. Will contain rejected value if promise was rejected." },
{ "name": "wasThrown", "type": "boolean", "optional": true, "description": "True if the promise was rejected." },
{ "name": "exceptionDetails", "$ref": "ExceptionDetails", "optional": true, "description": "Exception details if stack strace is available."}
],
"description": "Add handler to promise with given promise object id."
},
{
"name": "callFunctionOn",
"parameters": [
......@@ -447,7 +427,6 @@
"id": "SearchMatch",
"type": "object",
"description": "Search match for resource.",
"exported": true,
"properties": [
{ "name": "lineNumber", "type": "number", "description": "Line number in resource content." },
{ "name": "lineContent", "type": "string", "description": "Line with match content." }
......@@ -721,7 +700,7 @@
"name": "paused",
"parameters": [
{ "name": "callFrames", "type": "array", "items": { "$ref": "CallFrame" }, "description": "Call stack the virtual machine stopped on." },
{ "name": "reason", "type": "string", "enum": [ "XHR", "DOM", "EventListener", "exception", "assert", "debugCommand", "promiseRejection", "other" ], "description": "Pause reason.", "exported": true },
{ "name": "reason", "type": "string", "enum": [ "XHR", "DOM", "EventListener", "exception", "assert", "debugCommand", "promiseRejection", "other" ], "description": "Pause reason." },
{ "name": "data", "type": "object", "optional": true, "description": "Object containing break-specific auxiliary properties." },
{ "name": "hitBreakpoints", "type": "array", "optional": true, "items": { "type": "string" }, "description": "Hit breakpoints IDs", "hidden": true },
{ "name": "asyncStackTrace", "$ref": "Runtime.StackTrace", "optional": true, "description": "Async stack trace, if any.", "hidden": true }
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment