- 09 May, 2019 8 commits
-
-
Yang Guo authored
R=alph@chromium.org Change-Id: I615b9274cd0f6128d3f2377ef9dacb6aa1980446 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601494Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61365}
-
Seth Brenith authored
Gcov builds such as https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20gcov%20coverage/18276 are failing because they can't find std::copy_if. Including the right header fixes it. Change-Id: I3f0e3fabfe1b32cc4492aee64d2b9f23fa4afdcb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600431Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61364}
-
Maya Lekova authored
This reverts commit 2b24cd03. Reason for revert: Causes layout test failures https://ci.chromium.org/p/chromium/builders/try/linux-chromeos-rel/275121 and https://ci.chromium.org/p/chromium/builders/try/win7-rel/86354 Original change's description: > [heap] Skip read-only space in Heap::Contains > > Bug: v8:7464 > Change-Id: I27e82cdf0f8cc56ff68dcfaecab9644fe74916c7 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559861 > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61350} TBR=ulan@chromium.org,delphick@chromium.org,goszczycki@google.com Change-Id: I13cc09dd44a10bad854fa861b6e43149babb1b5e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601498Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#61363}
-
Dan Elphick authored
Puts back source position collection for inlined functions when concurrent inlining is not enabled. Bug: v8:8510 Change-Id: I8e8a7ef15c0854b1e37299a007303b3213988cf6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601266 Auto-Submit: Dan Elphick <delphick@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
The implementation of the method is long gone, just the declaration was left for some reason. Bug: v8:9183 Change-Id: Id68fc6afa63c3663769f9d8e0a6bc1a7a3aa5e35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601497 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#61361}
-
Z Duong Nguyen-Huu authored
Bug: v8:8996 Change-Id: I63ae821086c42c14a317e866fb4f0f799f4c4f7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1597555 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61360}
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/63246bb..cfe8887 Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/d376ad0..4e921e4 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/f8847c1..09e818b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e7f0b4c..43d3bb8 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/ae4b77d..3a162e7 TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: Ib4ed22461db8ae917a66a1a1799ed09336b685c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601580Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61359}
-
tzik authored
A DCHECK in LookupIterator::name hits when we add a indexed property, as it requires a named property. This replaces it with GetName to avoid the failure. Bug: chromium:959727 Change-Id: I1e98b313ec9257db80460a34d691016acbceb3c9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1597372 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#61358}
-
- 08 May, 2019 32 commits
-
-
Frank Tang authored
Bug: v8:7729 Change-Id: Ide6422a9315f56ada584156124037039ea591086 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600368Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#61357}
-
Frank Tang authored
https://chromium.googlesource.com/external/github.com/tc39/test262/+log/ba013cf7f..2682ab57c Bug: v8:7834 Change-Id: I918c223d7fee5d70f9ca645a44eb23e03ef745c6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600367Reviewed-by:
-
Johannes Henkel authored
This will allow me to reuse the routines for the inspector_protocol/encoding/encoding_test, rather than copy them. I've already verified that this works. Change-Id: I5b61e4f48c2d00d9d0a5305c9790093c66b3c765 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600360 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Hannes Payer authored
Bug: v8:9093 Change-Id: If899e36d4fbef711118ff8d7730ff9acd118d8b3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599600Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#61354}
-
Aleksei Koziatinskii authored
There are two possible type: - scriptParsed - breakpoint for any script, - scriptWithSourceMapParsed - breakpoint for script with sourceMappingURL. When one of the breakpoints is set then for each matched script we add breakpoint on call to top level function of that script. Node: https://github.com/nodejs/node/issues/24687 R=dgozman@chromium.org Bug: chromium:887384,chromium:724793,chromium:882909 Change-Id: I9c08b2a2a5ba7006adfedd85fc92ae191517af00 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1354245Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Andrew Comminos authored
To prevent OOMs for leaked CPU profilers, add the option to limit the maximum number of samples that are included in a CPU profile. Bug: chromium:956688 Change-Id: I119d0622e7d39c187f8e09e2d49dec91fd724ecb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588412 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
Spec: https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-set-p-v-receiver Bug: v8:6664 Change-Id: Ieddb645669a72d78ff9c0a45267165de3c5276f1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1585269 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:7464 Change-Id: I27e82cdf0f8cc56ff68dcfaecab9644fe74916c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1559861 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Seth Brenith authored
This change introduces a new decorator syntax @ifdef which can be used on any class fields in .tq files, and updates SharedFunctionInfo to use it as an example. Bug: v8:7793 Change-Id: I690ae2a10d6cab044eedf5b931e4f95e757ed469 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536985 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#61349}
-
Z Duong Nguyen-Huu authored
Bug: chromium:959747 Change-Id: I2518a35508b97ae1c2df7f30c1c2b9755ba6f495 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1597116Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#61348}
-
Michael Starzinger authored
The involved code kinds should no longer appear as part of frames for {Code} objects since they have been moved to {WasmCode} for quite a while now. R=jkummerow@chromium.org Change-Id: Iadc4ef668ebb56bf418fb706c3f118d9c3b553bd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1598755 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61347}
-
Milad Farazmand authored
Port 1a7d847c R=sigurds@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I13df37162f26a32512ac4897e4f6657db28d0fb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600756Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#61346}
-
Toon Verwaest authored
Otherwise (this) will leak into a later this=> making it seem like a valid arrow function head. Bug: chromium:941703 Change-Id: I5c3ff70f1d525ec0da53b401a0bfec4c1ee7812f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601260 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#61345}
-
Ulan Degenbaev authored
If concurrent sweeping is not making progress, then the slow path of allocation tries to sweep one page before allocating a new page. If that one page happens to be a never-evacuate page, then sweeping it will not produce any free space. This is problematic for tests that disable page allocation by setting the force_oom flag. Such tests become sensitive to the number of pages marked as never-evacuate (i.e. pages that were deserialized from the snapshot). Bug: v8:9205 Change-Id: If19a036b67319a5a2170f378f2c07ffa01bb7b27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601259Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61344}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/dd46a42..d376ad0 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/cca9447..f8847c1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/ccd2b4d..e7f0b4c Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2335bfa..d9d55ae TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I3b17179898e2572105ab828f1b3234f8a3e3dd66 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601313Reviewed-by:
-
Tom Tan authored
Below change canceled removing x18 from restore_list for deoptimization entries, but it also doesn't remove it from the saved_register list which causes x18 be restored incorrectly when deopt happens. https://chromium-review.googlesource.com/c/v8/v8/+/1583762 Bug: chromium:893460 Change-Id: Iccb950150a07119a3642dc42f044e94eb49db76e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1600674Reviewed-by:
-
Balaram Makam authored
Patch from Chukwuchebem Orakwue <c.orakwue@samsung.com> Change-Id: Ic5b302f4965b0f032839ef06e1221f56c37f76a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582055Reviewed-by:
-
Mythri A authored
Bug: v8:8394, v8:8395 Change-Id: I1cbb87b67bef4d469abde99070b7870e2b8d0c90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601149 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#61340}
-
Santiago Aboy Solanes authored
Going back on https://chromium-review.googlesource.com/c/v8/v8/+/1445978 since now 'tagged' means 'full tagged' again. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977, v8:7703 Change-Id: I3e39d631cc720a28577dad482dadfcc8332b6b18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593301 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#61339}
-
Jakob Kummerow authored
For faster calls from Wasm to C-API functions, passing parameter values directly instead of through JavaScript wrapper objects. Change-Id: I31e7d1622dedaf3154483306ab159427ac167663 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1591601Reviewed-by:
Andreas Haas <ahaas@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61338}
-
Pierre Langlois authored
This fixes a crash when using --trace-ic on Arm64 debug. For a given return address, the assembler's `target_address_from_return_address()` method will displace it to give you the call-site address. However, this is fragile because it needs to decode the instruction stream to distinguish between different call sequences. So it triggered an assertion on Arm64 because we now use BL for builtin to buitin calls. We only use this when tracing IC states to detect if the caller is a deoptimized function. But to do this it doesn't matter if the address we have is the return or the call-site address. So we can just remove the need for the fragile Assembler method. As a drive-by, also remove `return_address_from_call_start()` which was doing the opposite and was unused. Change-Id: I5988d17eadd1652ed85d662e62bc4c579665dd31 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1594566 Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Reviewed-by:
-
Frederik Gossen authored
Lazy compilation no longer asserts the non-existence of code. Code may exist when tiering finishes (and publishes code) after {CompileLazy} started execution and before it reached the DCHECK. Bug: v8:9211 Change-Id: I03ed44da7e16f1e4b4dca4b314a56cf6828bf1a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596447Reviewed-by:Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Nico Hartmann authored
Bug: v8:9213 Change-Id: If1299bb11a238b7732dde6931a79b991119cec2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596730Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Nico Hartmann <nicohartmann@google.com> Cr-Commit-Position: refs/heads/master@{#61335}
-
Sigurd Schneider authored
This CL introduces an AnnotationSet to unify annotation handling. Grammar rules now accept a list of annotations (via annotations Symbol), where an annotation is an Identifier starting with '@'. The new class AnnotationSet can be used to restrict the allowed annotations and query presence of annotations in the Make* functions. Bug: v8:7793 Change-Id: Iad5435d4a94a3bea99aca76c23d2cffffe78a97f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601142 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Toon Verwaest authored
Flatten cons strings into a buffer instead, as we already did for strings larger than 64 anyway. Change-Id: Ida7afb9f7ceb38505d67bedfdfbc43c8b4d8c303 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599428 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Mythri A authored
This is a reland of 289b2576. The fix for failures landed here: https://chromium-review.googlesource.com/c/v8/v8/+/1599388 Original change's description: > [Test] Update tests to work with lazy feedback allocation. > > This adds either %EnsureFeedbackVectorForFunction or > %PrepareFunctionForOptimization to allocate feedback vectors when testing > optimization, allocation sites, IC transitions etc., > > Bug: v8:8394 > Change-Id: I6ad1b6d460e4abda693b326cddb87754e080a0a1 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593303 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Auto-Submit: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61212} Bug: v8:8394 Change-Id: Idb5bba221d138e6fd73155f959b9e16fc948c709 TBR: rmcilroy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599607Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Auto-Submit: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61332}
-
Clemens Hammacher authored
The {DiscardSystemPages} call occasionally fails on win32, thus disable it until the error is found. R=mstarzinger@chromium.org Bug: v8:8217, chromium:960707 Change-Id: Idf77dd8e85d3d38cc12a9f4d2db5cc98eb2c7d08 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601150Reviewed-by: -
Santiago Aboy Solanes authored
This is a reland of 3c510438 TBR=jarin@chromium.org Original change's description: > [ptr-compr][turbofan] Calling the non-compressed Tagged loads and stores > > This CL changes the instruction selector so that we use the normal load > and store, instead of the one that (de)compresses. > > Also removed "return;"s and "break;"s that were unnecessary. > > Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng > Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng > Bug: v8:8977, v8:7703 > Change-Id: I4f2a82bfc4d300dd56300f394f59c3f9da242ba8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593296 > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Reviewed-by: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61304} Bug: v8:8977, v8:7703 Change-Id: I3a587662248fad0d633b543ec03f1aba88410ff1 Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601151Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#61330}
-
Benedikt Meurer authored
Pass the FunctionLiteral to `SharedFunctionInfo::ToTracedValue()` and take the source position from that for logging, as the SFI itself might not have a way to get to the source position in the beginning (currently that's the case for functions that are marked for eager compilation). Tbr: ulan@chromium.org Bug: chromium:956848, v8:8598, v8:9039 Change-Id: I05c31c7d48734f1f301930ba455d3d5a77b9df13 Doc: bit.ly/v8-tracing-signals Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601146 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: Idbfc2ddb46e258eee2ef23528531b666a532d72c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1599775Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#61328}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I4ef23446609e0b276877aedaccbd738497f2853f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601145Reviewed-by:
-
Toon Verwaest authored
MakeExternal can change byteness of strings without updating wrappers; hence we cannot trust byteness of wrappers. Unwrap the string before checking encoding. Bug: chromium:960680 Change-Id: I95d2bca906141c0d8b3de8fdac44b9fdb2ef2c43 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601140Reviewed-by:
-
