- 02 Dec, 2021 20 commits
-
-
Clemens Backes authored
This reverts commit f68242bc. Reason for revert: UBSan error: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket/8828943333104509889/+/u/build/compile/stdout Original change's description: > [codegen] Reduce size of safepoint table fields > > Code objects are often small and do not use the full integer range of PC > offsets and deoptimization indexes. Reducing the size of these fields to > the required size per table reduces the overall size of safepoint tables > by roughly 25%. > > R=jkummerow@chromium.org > > Bug: v8:12401 > Change-Id: Ie6889a70782f5510436a1d05d31d17aac0bfec6e > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306556 > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Commit-Queue: Clemens Backes <clemensb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78216} Bug: v8:12401 Change-Id: I53b574558305ac25fa8f38a843c98f653af201ba No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312488 Auto-Submit: Clemens Backes <clemensb@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78217}
-
Clemens Backes authored
Code objects are often small and do not use the full integer range of PC offsets and deoptimization indexes. Reducing the size of these fields to the required size per table reduces the overall size of safepoint tables by roughly 25%. R=jkummerow@chromium.org Bug: v8:12401 Change-Id: Ie6889a70782f5510436a1d05d31d17aac0bfec6e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306556Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/main@{#78216}
-
Thibaud Michaud authored
The stack memory will be accessed through a global list later, so the stack pointer should be accessible without the containing WasmContinuationObject. This also saves some unnecessary allocations and indirections already. R=ahaas@chromium.org Bug: v8:12191 Change-Id: Ic3d71ecadbb13b18f0440049527ba71d657589b4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312486 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#78215}
-
Leszek Swirski authored
Add a flag for controlling the maximum number of threads usable by the LazyCompileDispatcher. Change-Id: I87fc39d337a00cff0c3d152392630f48da050fff Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312482 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#78214}
-
Nico Hartmann authored
Bug: v8:11515 Change-Id: I9379187542499439debd293dd7c7d6d02e98accd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308709 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Thibaud Michaud authored
Set the JS limit at a 40KB offset from the actual limit, like on the native stack. This is an estimate of the maximum stack space needed for runtime calls. R=ahaas@chromium.org Bug: v8:12191 Change-Id: I709d5b25c5e47d2474cf4205ebcb8ee7fc8e794c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312485Reviewed-by:
-
Manos Koukoutos authored
Bug: v8:12463 Change-Id: I63ac0ab5aa3e5a3fc222c798c8127fef72db8567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312481Reviewed-by:
-
Thibaud Michaud authored
The call to SyncStackLimit is already inlined in the previous runtime call (WasmAllocateContinuation). R=ahaas@chromium.org Bug: v8:12191 Change-Id: Ie602f8317bc9ed5b5b5f9a0eb545a57602aeed42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312484Reviewed-by:
-
Leszek Swirski authored
This allows streamed sources to also trigger parallel compile tasks. The chunk vectors are shared via std::shared_ptr. Clone chunked streams are initialised with a null source, and are not allowed to fetch any more data. Similarly, the original stream is not allowed to fetch data if it has been cloned (since the vector is shared and would mutate if we added more data to it). This is ok for the purposes of cloning for parallel compile tasks, as we fully parse before cloning for the task. Change-Id: Ic268e4956e0894acb63111bf0aaf32eaad426066 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310917 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#78209}
-
Michael Lippautz authored
- Removes the unused Worklist implementation. All uses now refer to ::heap::base::Worklist. - Renames CppgcWorklistTest -> WorklistTest - Add test for Swap() Bug: v8:12426 Change-Id: I62c3472c030b853a846cf13ab48597ea1af8f700 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306507Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#78208}
-
Michael Achenbach authored
No-Try: true Bug: v8:12434 Change-Id: I62157f06efc8f472ea765278a2a65e3d67c1d973 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308891 Auto-Submit: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Reviewed-by:
Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#78207}
-
Hao Xu authored
Baseline compiler generates calls to builtin Bitwise_Baseline for bitwise bytecodes with Smi rhs. The builtin still performs type check for rhs even though it is known to be Smi. This CL implements new builtins for bitwise operations which does not do speculation for rhs. Bug: v8:12442 Change-Id: Ia6e1b25a74d00db8c39600b4f81f6e9aa5d59253 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310520Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Hao A Xu <hao.a.xu@intel.com> Cr-Commit-Position: refs/heads/main@{#78206}
-
Manos Koukoutos authored
Bug: v8:7748 Change-Id: I7884b548276372e5dfa130fbe39d29f3cca4f530 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310882Reviewed-by:
-
Igor Sheludko authored
... as a prerequisite for adding InstructionStream heap object. Bug: v8:11880 Change-Id: I22b4832cedd46bee4a4c5a0d7b5032eba10b2a7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310900Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Tamer Tas authored
R=machenbach@chromium.org,liviurau@chromium.org Bug: v8:11211,v8:12462 Change-Id: If13e9ac6eaa3edc6b99c77c9cf16f5441f5c33e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310898 Auto-Submit: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/main@{#78203}
-
Kim-Anh Tran authored
This CL makes sure to forward the information that we are pausing because of a debugger statement, and to encode it explicitly as an 'other' reason when reporting the pause to the front-end. Drive-by: refactoring the way break reasons are propagated by introducing a new enum for break reasons Bug: chromium:1229541, chromium:1133307 Change-Id: I9d2e8d8da54d96a231eff9d1f62b74507955b18f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306978Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Cr-Commit-Position: refs/heads/main@{#78202}
-
Manos Koukoutos authored
We optimize away type upcasts for nominal types in WasmFullDecoder. Upcasts trivially hold for nominal types, which is not the case for structural types. Note that we already optimize away trivially-failing checks (when types are unrelated) for both nominal and structural types. Bug: v8:7748 Change-Id: I720c9803cb8b4071aa4bae112ce06d587b7a68fa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306984 Commit-Queue: Manos Koukoutos <manoskouk@chromium.org> Reviewed-by:
-
Manos Koukoutos authored
--wasm-speculative-inlining makes no sense if --liftoff-only or --no-liftoff, since it needs type feedback from Liftoff and is appied by Turbofan. Therefore, it should be disabled in these cases. Specifically, --wasm-speculative-inlining implies --wasm-dynamic-tiering, which contradicts --liftoff-only. Bug: v8:12166 Change-Id: Idc5e0d7ceb7dbdf82ea6fd14ffc8386fe35a1257 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306554Reviewed-by:
-
Clemens Backes authored
{V8::Dispose} calls {FlagList::ResetAllFlags()}, which resets all flag values. Thus the values of FLAG_dump_counters and FLAG_dump_counters_nvp need to be read before disposing v8. Drive-by: Two unrelated code simplifications / unifications. R=mlippautz@chromium.org Bug: chromium:1275117 Change-Id: Ie2bbe0c844efaf3ed50a62533c5ec08b6b423379 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310881Reviewed-by: -
Junji Watanabe authored
This flag is not supported now. Bug: chromium:1271841 Change-Id: I6a80ebed79a03164f58f1757b8ebaca74a681441 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306786 Auto-Submit: Junji Watanabe <jwata@google.com> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
- 01 Dec, 2021 20 commits
-
-
Junliang Yan authored
Change-Id: I68f9e6e8edc7054bec7e838f0d3b007be196d240 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3312157Reviewed-by:
Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#78197}
-
Manos Koukoutos authored
This fixes operators in wasm Turbofan that were mixing up integer sizes and pointers with tagged pointers. Additional changes: - Remove unused (and non-compiling if V8_MAP_PACKING) GraphAssembler::StoreMap. - Factor out WasmGraphBuilder::IsNull. Change-Id: I9d99827e35507adc0af391bd39975d55371b98cf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306981Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
That code should be dead now that we compute the description in Blink (see crbug.com/1048143). Bug: chromium:1275591 Change-Id: I6e8c4dec27eb981807ab4eba75572635ee655a3b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310837 Auto-Submit: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Richard Stotz authored
This CL removes the CallRefData data structure and accesses a funcref's target and instance through the funcref. Bug: v8:7748 Change-Id: Ic46b127f7775052d5df13b03c447e3b15328ad74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306486 Commit-Queue: Richard Stotz <rstz@chromium.org> Reviewed-by:
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I30ab8540b698ea6e5e838e6aa27f8ec5efca414c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306570 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Victor Gomes authored
Moved DEFINE_UINT after the #ifdef block, so it is also defined for Mac arm64. This is a reland of 6aadf0e0 Original change's description: > [baseline] Add max threads flags for CSP > > Bug: v8:12054 > Change-Id: I49238fe673858b60c2a2a935ed1f45f465269216 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308707 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78187} Bug: v8:12054 Change-Id: Ica352b2f099fff875411c0e1915bcddb4ca48061 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310800Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#78192}
-
Clemens Backes authored
This fixes data races when lazily creating counters (and populating the {counter_map_}, and when concurrently adding samples to the counters. It also ensures that the Wasm engine is stopped (via {V8::Dispose}) before printing and deleting counters, as background threads might still try to update the counters otherwise. R=mlippautz@chromium.org CC=nikolaos@chromium.org Bug: v8:12453, chromium:1275117 Change-Id: Ie6beea6cc74eea52143d12f9921597da4a250f2a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308710Reviewed-by: -
Leszek Swirski authored
Change-Id: I67b62ae71700fab3755f83634fa571b1cea3af4e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308890 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Omer Katz authored
The new flags enum had kReduceMemory as the first value, which means it got the value 0 and thus was considered as never set. Bug: v8:12407, chromium:1274954 Change-Id: Ifcce2316c1dcd09a12ad52ef391f513b014aea1c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310609Reviewed-by:
-
Leszek Swirski authored
This reverts commit 6aadf0e0. Reason for revert: Maybe add arm64 mac to the CQ next time :) https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac%20-%20arm64%20-%20release%20builder/7729/overview Original change's description: > [baseline] Add max threads flags for CSP > > Bug: v8:12054 > Change-Id: I49238fe673858b60c2a2a935ed1f45f465269216 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308707 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Commit-Queue: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Cr-Commit-Position: refs/heads/main@{#78187} Bug: v8:12054 Change-Id: I1b53ea3eaaaa39cdb1b9a471aa716b5af7f5e3d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3310838 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#78188}
-
Victor Gomes authored
Bug: v8:12054 Change-Id: I49238fe673858b60c2a2a935ed1f45f465269216 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308707 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Jakob Gruber authored
When emitting code, character ranges must only specify ranges which the actual subject string (one- or two-byte) may contain. This was not always the case, specifically for ranges with `from <= kMaxUint8` and `to > kMaxUint8`. The reason this is so tricky: 1. not all parts of the pipeline know whether we are compiling for one- or two-byte subjects; 2. for case-insensitive regexps, an out-of-bounds CharacterRange may have an in-bounds case equivalent (e.g. /[Ÿ]/i also matches 'ÿ' == \u{ff}), which only gets added somewhere in the middle of the pipeline. Our current solution is to clamp immediately before code emission. We also keep the existing handling/dchecks of the 0x10ffff marker value which may occur in the two-byte subject case. Bug: v8:11069 Change-Id: Ic7b34a13a900ea2aa3df032daac9236bf5682a42 Fixed: chromium:1275096 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306569 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: -
Omer Katz authored
Enable the prefinalizers scope and add a top level AtomicSweep scope so that prefinalizers are accounted as part of sweeping. Change-Id: I9dade6a2367d30d20395de30c3db84922fee5a49 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306567Reviewed-by:
-
Tobias Tebbi authored
We sometimes use ReportError() inside of Torque parser actions. The resulting exception prevented the ParseResultIterator from being consumed completely, which in turn triggered a CHECK failure instead of the correct error message. Change-Id: Ie8dcdf67094e5ad5d68934e8a2921d5f52bd3092 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306973 Commit-Queue: Nico Hartmann <nicohartmann@chromium.org> Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Add suppose for compiling non-eager, non-top-level inner functions in parallel, using the compiler dispatcher. This behaviour can be enabled with --parallel-compile-tasks-for-lazy. There are a couple of consequences: * To support this we need support for off-thread ScopeInfo deserialization, so this adds that too. * The previous --parallel-compile-tasks flag is renamed to the more descriptive --parallel-compile-tasks-for-eager-toplevel. * Both parallel-compile-tasks flags are moved onto UnoptimizedCompileFlags so that they can be enabled/disabled on a per-compile basis (e.g. enabled for streaming, disabled for re-parsing). * asm.js compilations can now happen without an active Context (in the compiler dispatcher's idle finalization) so we can't get a ContextId for metric reporting; we'd need to somehow fix this if we wanted asm.js UKM but for now it's probably fine. * Took the opportunity to clean up some of the "can preparse" logic in the parser. Change-Id: I20b1ec6a6bacfe268808edc8d812b92370c5840d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3281924 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:Emanuel Ziegler <ecmziegler@chromium.org> Cr-Commit-Position: refs/heads/main@{#78183}
-
Milad Fa authored
c++17 is being enabled on some platforms: https://crrev.com/c/3306812 which causes gcc to emit the following warning: ``` error: null argument where non-null required (argument 2) memcpy(storage_ + kReturnCount, param_types.data(), ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ``` Unlike clang, gcc is not able to detect if memcpy is actually being executed or not when src is NULL: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=22179 Therefore need to disable this warning at this location. Change-Id: I44da9f698ef724e39bb9c7d4b235d1004d52f491 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308916Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#78182}
-
Clemens Backes authored
The {TierUpFunction} method is unused after https://crrev.com/c/3275570. R=jkummerow@chromium.org Bug: v8:12281 Change-Id: I81882a6f1907ff3f4504dea8e9e307cbd674e682 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306980Reviewed-by: -
Adam Klein authored
MSVC doesn't define __cplusplus appropriately, so use _MSVC_LANG instead. Bug: chromium:1274247 Change-Id: I40ef9f42f4e55b3410f89ff23c228f1b1201c4ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3308423 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Adam Klein <adamk@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Try blocks (whether catch or finally) will unconditionally create handler tables and start a new basic block for the exception handler. This can accidentally resurrect a dead block when the entire try block is dead (and hence can never enter the exception handler in the first place). Add a deadness check to BuildTryCatch/Finally to fix this. Bug: chromium:1273677 Change-Id: Icda9deb1459e47de5cb83e7b636299e24c3ebe77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306555 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#78179}
-
Anton Bikineev authored
Some performance sensitive paths in V8 (compilation/json parsing) or paths with high allocation/freeing throughput can suffer from not being able to reuse recently freed allocations. These paths can also significantly increase the working set and cause large number of page faults. For such paths (at least as an initial measure) we are planning to disable allocation quarantining. The CL provides a way for the embedder to hook in *Scan functions that disable/enable quarantining. It also disables *Scan for json parsing and compilation jobs. Bug: chromium:1249550 Change-Id: I0274f66010435f3d4d091fe70fabcd20f46dc0d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306389 Auto-Submit: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
