- 05 Jun, 2019 13 commits
-
-
Simon Zünd authored
R=tebbi@chromium.org Bug: v8:7793 Change-Id: Ibba7651f8bd6a8e06b7810a8190d210b4cd54be0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645324 Auto-Submit: Simon Zünd <szuend@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#62001}
-
Jakob Gruber authored
During regexp execution we usually do not expect any interrupts to exist. This optimization doubles Octane/RegExp scores with --regexp-interpret-all. Drive-by: Do the same for irregexp stack checks (only applicable when called through the runtime). Drive-by: Slightly more specific AllowHeapAllocation scopes. Bug: v8:7777, v8:9328, v8:9330 Change-Id: I502d54d49a1267dee4b8a086dc6c2dca318a2d97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645313 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#62000}
-
Maya Lekova authored
This reverts commit f2823886. Reason for revert: Causes TSAN timeouts in RestoreHeapLimit, see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26812 Original change's description: > [heap] Clean up Heap::ConfigureHeap > > This re-arranges the implementation of the function to make it more > consistent. The only functional change is replacement of RoundUp with > RoundDown, which makes more sense for the limits. > > Bug: v8:9306 > Change-Id: Id1d4bc6cc414e3618c3878de8cb87a9ed59711f5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643432 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61997} TBR=ulan@chromium.org,mlippautz@chromium.org,jgruber@chromium.org Change-Id: I635d60fdfb332cf62ab55eb32242937ebee2f6ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9306 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645323Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#61999}
-
Igor Sheludko authored
... as it uniquely idenifies object inside an Isolate. This also allows comparisons between full tagged values ([Maybe]Object) and potentially compressed tagged values ([Strong]TaggedValue). As a side effect with this change we should generate a bit less code. Bug: v8:7703 Change-Id: I822df24e03653fa73314e0a6f81f0fa7b5c61eba Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643433Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#61998}
-
Ulan Degenbaev authored
This re-arranges the implementation of the function to make it more consistent. The only functional change is replacement of RoundUp with RoundDown, which makes more sense for the limits. Bug: v8:9306 Change-Id: Id1d4bc6cc414e3618c3878de8cb87a9ed59711f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643432Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#61997}
-
Simon Zünd authored
This CL changes the way stack trace serialization appends numbers. Instead of converting plain int to Handle<String>, they are converted to char*. The reason is that appending a Handle<String> causes the IncrementalStringBuilder to shrink the current part and create two ConsString instances to concatenate the accumulator, the current part and the passed in Handle<String>. This CL improves stack trace serialization micro benchmarks by ~12%. Bug: v8:8742 Change-Id: I174667379084381245827cb979f91db3c59ce75e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643169 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Georg Schmid authored
R=tebbi@chromium.org Bug: chromium:964833 chromium:970120 Change-Id: I0fc179aa1e8fc5c13279342501f8639fce9ee7d7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645315Reviewed-by:
-
Nico Hartmann authored
Bug: v8:9213 Change-Id: I78e2e4b00c3dec92252adf3823138b14a7bc4a5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640202 Commit-Queue: Nico Hartmann <nicohartmann@google.com> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61994}
-
Thibaud Michaud authored
Compile import wrappers during module compilation by introducing import wrapper compilation units, the goal being to reduce instantiation time. For each wrapper, we assume the imported function is going to be a kJSFunctionArityMatchSloppy at instantiation time, which should be the most common case. If the function turns out to have a different kind the wrapper is going to be recompiled with the correct kind during instantiation. R=ahaas@chromium.org, clemensh@chromium.org CC=titzer@chromium.org Bug: v8:9231 Change-Id: Ieb050b09d1c19f2a5a3e59132a1864dadb06775d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1630685 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#61993}
-
Clemens Hammacher authored
This reverts commit 8c10501b. Reason for revert: Fails on all gc-stress bots: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22909 Original change's description: > Enable lazy feedback allocation > > Bug: v8:8394 > Change-Id: I29ffd38725bdcaa9dd11221045dba681eb0d567b > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643430 > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#61991} TBR=rmcilroy@chromium.org,mythria@chromium.org Change-Id: Ifa2867f5cbbf72cb4bb99f50f0d782ca0642c2f8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8394 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1645314Reviewed-by:
-
Mythri A authored
Bug: v8:8394 Change-Id: I29ffd38725bdcaa9dd11221045dba681eb0d567b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643430Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61991}
-
Georg Neis authored
Change-Id: Ibfff9d512dd94b9d086b5a39de6e6a6d089bb033 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643554Reviewed-by:
Mythri Alle <mythria@chromium.org> Commit-Queue: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#61990}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c66b31d..388c061 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/fd813d1..3344e16 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0183a1f..d2f31cc TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I575df20307181db0f8d1085d373c63ce69409a10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1644652Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#61989}
-
- 04 Jun, 2019 14 commits
-
-
Mathias Bynens authored
With bytecode flushing and lazy feedback allocation, we need to call %PrepareForOptimization before we call %OptimizeFunctionOnNextCall, ideally after declaring the function. Bug: v8:8801, v8:8394, v8:9183 Change-Id: I6bf119e726426df8527d97546b6ce806112c894d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643167 Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Maciej Goszczycki authored
Read-only heap sharing clears heap_ in read-only memory chunks because ReadOnlySpace is shared between multiple isolates. Bug: v8:7464 Change-Id: I821c94303ab3710c279e6c11a8ca8537aac0d0af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1642809 Commit-Queue: Maciej Goszczycki <goszczycki@google.com> Reviewed-by:
Dan Elphick <delphick@chromium.org> Reviewed-by:
-
Joey Gouly authored
On Windows, long is 32-bits, so the 'L' suffix shouldn't be used if a 64-bit value is needed. This caused a test failure in 'Int64MulWithImmediate'. Change-Id: I93c43a1f166aa0e5bcd53aaf7a860fffd006fd0b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627538 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Maciej Goszczycki authored
Bug: v8:7464 Change-Id: I09e5d66a2dc369d031691ef04cd8bb34bb40278e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1642808Reviewed-by:
-
Jakob Gruber authored
These were only used by test-log/EquivalenceOfLoggingAndTraversal, which itself has been marked as failing since 2013. This CL removes the test itself as well as the TEST natives kind. Bug: v8:7624,v8:2857 Change-Id: Iedf2b1c94e31ccd1ea885d72bf1fac5d33defa90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643467 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Avoid the linear lookup of function literal id when getting the shared function info TraceID, by optionally passing through a FunctionLiteral. Additionally, use the FunctionLiteralId helper when a FunctionLiteral is not available, since it can also fast-path in some cases. As a drive-by, allow using a ScriptIterator without an Isolate pointer (e.g. manually creating a handle) to allow calling FunctionLiteralId without an Isolate pointer. Bug: v8:9325 Change-Id: Ibfa053f300d6d5005485c67174a848264a5d1372 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643429 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Allow the embedder to decrement its allocated bytes count: - The decrement will be applied to the used bytes value. - The decrement is ignored for the total allocated bytes. Bug: chromium:948807 Change-Id: I609ccf81017b693e0db13b499cbf8967f5f8a2c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1631428 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Joey Gouly authored
This fixes the assembler tests on Windows arm64, that were previously crashing. Bug: v8:9235 Change-Id: I616e6eb00bb71d70195787f80f8b54a9ae33abe6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1634919 Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
-
Maya Lekova authored
The fix in https://chromium-review.googlesource.com/c/v8/v8/+/1627333 didn't seem to have worked, so disabling the tests again. Bug: chromium:963411, v8:9114, v8:9183, v8:9267 Change-Id: Id080c16b1fe4c99c8ef980a15bc91668dbfe5c13 NOTRY=true TBR=machenbach@chromium.org Change-Id: Id080c16b1fe4c99c8ef980a15bc91668dbfe5c13 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643428Reviewed-by:
-
Maciej Goszczycki authored
As it stands most of ReadOnlySpace class's method are unusable once it has been sealed, since all of its pages are read-only. Set owner_ to null to ensure nothing unintentionally uses it. This also helps with separating the ReadOnlySpace from the Heap class in the future as ReadOnlySpace might not inherit from Space. Bug: v8:7464 Change-Id: I3b24f20c644d6f5e23647bc1de4d256a20a0eb19 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637800Reviewed-by:
-
Georg Neis authored
It's very helpful to know when they die. Bug: v8:7790 Change-Id: I08a369da7eb19d46ecdc02b404b0085d6410ab4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643168Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#61978}
-
Georg Schmid authored
R=tebbi@chromium.org Bug: chromium:964833 Change-Id: I798f7c38eacaa16011ab7cc9ac4dea066078fbb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1643170Reviewed-by:
-
Gopesh Kumar Chaudhary authored
Regex test cases fails on AIX debug due to stack-overflow. R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com Bug: Change-Id: I217ad3d61fa8d7572cc0c7e25efa63065552f99a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1625836 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/a3b6390..c66b31d Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5b31e69..fd813d1 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c38806b..0183a1f TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I2d3652b0533a0ba4c0b22a58c1fd23dc367ae814 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640830Reviewed-by:
-
- 03 Jun, 2019 13 commits
-
-
Johannes Henkel authored
Change-Id: I05d69c8971352276c2d399f458f8f7ae6c2689c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1639575 Auto-Submit: Johannes Henkel <johannes@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#61974}
-
Johannes Henkel authored
serialize outgoing messages via cbor to json if needed. Change-Id: I6d0300ddc27e365b16671d19922f467e09adcc54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1636681Reviewed-by:
-
Simon Zünd authored
The extension moved to a separate Github repository found at: https://github.com/v8/vscode-torque The extension is best installed via the VSCode Marketplace: https://marketplace.visualstudio.com/items?itemName=v8-torque.vscode-torque R=tebbi@chromium.org Bug: v8:8880 Change-Id: I38e1bc7c912002b37d367beac10fb57c58763844 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640198 Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Bill Budge authored
- Changes functions that call OpenHandle multiple times to assign a local and use it the second time. Change-Id: Ibc7e881158dc6aec489e3f30690da8982014d52a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1636459 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#61971}
-
Seth Brenith authored
Implemented verifiers for the following classes: - ExternalString - FixedArrayBase - JSCollection - JSCollectionIterator - JSWeakCollection - Name - SeqString - Struct Removed the following class definitions from Torque, because they're just JSObject instances with particular starting maps, as discussed in https://crrev.com/c/v8/v8/+/1619146/6/src/builtins/base.tq#459 : - JSAccessorPropertyDescriptor - JSDataPropertyDescriptor - JSIteratorResult Following similar logic, removed the Torque definition of WasmExceptionPackage because it's just an error object that happens to have a couple of private-symbol properties. The following classes should not be defined in Torque because they're just a starting state for JSObject, but I'm leaving them for now because existing Torque code requires them: - JSArgumentsObjectWithLength - JSProxyRevocableResult Bug: v8:9311 Change-Id: I0336b6be7d02e48e4a8a0f660e24d2c2fa5f5e34 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637448 Commit-Queue: Seth Brenith <seth.brenith@microsoft.com> Reviewed-by:
-
Z Nguyen-Huu authored
Bug: v8:6664 Change-Id: Ie320264cfba8c33c90405bb009f584b8e2b3d8ce Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637660Reviewed-by:
-
Frank Tang authored
Bug: v8:9300 Change-Id: I8eee82f41e19858f1688c64e6bc6800e26db6050 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1638257 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#61968}
-
Maciej Goszczycki authored
Bug: v8:9183 Change-Id: I583915848435b6ad3f42c320b72b7bb1a4eb2444 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640207Reviewed-by:
-
Michael Achenbach authored
Bug: v8:9290 Change-Id: I0f1558231cdb71e3d84b123f9663be66f9101c6c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1637464Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61966}
-
Clemens Hammacher authored
The missing forward declaration made include header checks fail on gcc: https://crrev.com/c/1637464 R=ishell@chromium.org Bug: v8:9290, v8:7490, v8:9183 Change-Id: I7e513c04297982e403783e7ea7341b271c4fef72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640214Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 81abe8f7. Reason for revert: Fails several bots, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/26780 Original change's description: > [roheap] Enable shared ro-heap by default if ptr compression is disabled > > Shared read-only heap is currently incompatible with pointer compression. > Enable sharing only if pointer compression is disabled. > > Bug: v8:7464 > Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509 > Reviewed-by: Dan Elphick <delphick@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Maciej Goszczycki <goszczycki@google.com> > Cr-Commit-Position: refs/heads/master@{#61963} TBR=rmcilroy@chromium.org,delphick@chromium.org,goszczycki@google.com Change-Id: If450c8a7530763e69eaddb53583f890a467f4724 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7464 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640216Reviewed-by:
-
Maciej Goszczycki authored
Shared read-only heap is currently incompatible with pointer compression. Enable sharing only if pointer compression is disabled. Bug: v8:7464 Change-Id: I0866ac288a34eb92fc227e8beba57f4d72a69ef0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1635509Reviewed-by:
-
Santiago Aboy Solanes authored
Following up on https://chromium-review.googlesource.com/c/v8/v8/+/1637879, this CL removes the tests that used explicit Compress/Decompress functions in CSA Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: I063678a732545eb505fa752612242ceeb42be823 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1640206 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
