- 26 Oct, 2015 3 commits
-
-
yangguo authored
R=bmeurer@chromium.org Committed: https://crrev.com/15f36b2b1e166a511966a9991fddea94f890a755 Cr-Commit-Position: refs/heads/master@{#31566} Review URL: https://codereview.chromium.org/1423833003 Cr-Commit-Position: refs/heads/master@{#31576}
-
yangguo authored
Revert of Canonicalize handles for optimized compilation. (patchset #1 id:1 of https://codereview.chromium.org/1423833003/ ) Reason for revert: GC stress failure on ia32 optdebug: /tmp/runfswAKT/out/Debug/d8 --test --random-seed=-1536184370 --turbo --always-opt --nohard-abort --nodead-code-elimination --nofold-constants --enable-slow-asserts --debug-code --verify-heap --stack-size=46 /tmp/runfswAKT/test/mjsunit/mjsunit.js /tmp/runfswAKT/test/mjsunit/regress/regress-1132.js --gc-interval=500 --stress-compaction --concurrent-recompilation-queue-length=64 --concurrent-recompilation-delay=500 --concurrent-recompilation Run #1 Exit code: -6 Result: FAIL Expected outcomes: PASS Duration: 00:06:279 Stderr: # # Fatal error in ../../src/hashmap.h, line 248 # Check failed: base::bits::IsPowerOfTwo32(capacity_). # ==== C stack trace =============================== Original issue's description: > Canonicalize handles for optimized compilation. > > R=bmeurer@chromium.org > > Committed: https://crrev.com/15f36b2b1e166a511966a9991fddea94f890a755 > Cr-Commit-Position: refs/heads/master@{#31566} TBR=jochen@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1417013007 Cr-Commit-Position: refs/heads/master@{#31570}
-
yangguo authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1423833003 Cr-Commit-Position: refs/heads/master@{#31566}
-
- 20 Aug, 2015 1 commit
-
-
mstarzinger authored
R=bmeurer@chromium.org Review URL: https://codereview.chromium.org/1285183010 Cr-Commit-Position: refs/heads/master@{#30263}
-
- 15 Jul, 2015 3 commits
-
-
bmeurer authored
Bunch of cleanups to allow us to get rid of handles-inl.h at some point (in the not so far future); but more importantly to sanitize uses of handles and prepare for handle canonicalization support. R=yangguo@chromium.org Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 Cr-Commit-Position: refs/heads/master@{#28222} Committed: https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 Cr-Commit-Position: refs/heads/master@{#29666} Review URL: https://codereview.chromium.org/1128533002 Cr-Commit-Position: refs/heads/master@{#29675}
-
machenbach authored
Revert of [handles] Sanitize Handle and friends. (patchset #5 id:180001 of https://codereview.chromium.org/1128533002/) Reason for revert: [Sheriff] Still breaks mac asan: http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/2066 Original issue's description: > [handles] Sanitize Handle and friends. > > Bunch of cleanups to allow us to get rid of handles-inl.h at some > point (in the not so far future); but more importantly to sanitize uses > of handles and prepare for handle canonicalization support. > > R=yangguo@chromium.org > > Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 > Cr-Commit-Position: refs/heads/master@{#28222} > > Committed: https://crrev.com/d940c6d3bcc227b459cb4123d9a8332d9ed0d5f8 > Cr-Commit-Position: refs/heads/master@{#29666} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1235253007 Cr-Commit-Position: refs/heads/master@{#29669}
-
bmeurer authored
Bunch of cleanups to allow us to get rid of handles-inl.h at some point (in the not so far future); but more importantly to sanitize uses of handles and prepare for handle canonicalization support. R=yangguo@chromium.org Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 Cr-Commit-Position: refs/heads/master@{#28222} Review URL: https://codereview.chromium.org/1128533002 Cr-Commit-Position: refs/heads/master@{#29666}
-
- 22 Jun, 2015 1 commit
-
-
bmeurer authored
We resurrect the VectorSlotPair in order to be able to separate the feedback input for the compiler from the actual type feedback vector that is required to meet the IC requirements at runtime. This will allow us to for example use feedback from a different context or divide the type feedback vector into two separate vectors, without having to touch the compiler. It'll allow use to load the vector from the shared function info at runtime, while still consuming feedback in the compiler (i.e. we don't rely on the feedback vector node to be a heap constant). R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1198983002 Cr-Commit-Position: refs/heads/master@{#29185}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 05 May, 2015 2 commits
-
-
machenbach authored
Revert of [handles] Sanitize Handle and friends. (patchset #4 id:50001 of https://codereview.chromium.org/1128533002/) Reason for revert: [Sheriff] Breaks mac asan: http://build.chromium.org/p/client.v8/builders/V8%20Mac64%20ASAN/builds/1198 Original issue's description: > [handles] Sanitize Handle and friends. > > This almost allows us to get rid of handles-inl.h, once we fix the > cyclic dependencies (follow up CL). > > R=yangguo@chromium.org > > Committed: https://crrev.com/3283195d0408333cce552cf4087577e6f41054e5 > Cr-Commit-Position: refs/heads/master@{#28222} TBR=yangguo@chromium.org,bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1128543004 Cr-Commit-Position: refs/heads/master@{#28235}
-
bmeurer authored
This almost allows us to get rid of handles-inl.h, once we fix the cyclic dependencies (follow up CL). R=yangguo@chromium.org Review URL: https://codereview.chromium.org/1128533002 Cr-Commit-Position: refs/heads/master@{#28222}
-
- 04 Aug, 2014 1 commit
-
-
bmeurer@chromium.org authored
This way we don't clash with the ASSERT* macros defined by GoogleTest, and we are one step closer to being able to replace our homegrown base/ with base/ from Chrome. R=jochen@chromium.org, svenpanne@chromium.org Review URL: https://codereview.chromium.org/430503007 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22812 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 03 Jun, 2014 1 commit
-
-
jochen@chromium.org authored
- this avoids using relative include paths which are forbidden by the style guide - makes the code more readable since it's clear which header is meant - allows for starting to use checkdeps BUG=none R=jkummerow@chromium.org, danno@chromium.org LOG=n Review URL: https://codereview.chromium.org/304153016 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@21625 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 29 Apr, 2014 1 commit
-
-
bmeurer@chromium.org authored
R=svenpanne@chromium.org Review URL: https://codereview.chromium.org/259183002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@21035 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 16 Apr, 2014 3 commits
-
-
yangguo@chromium.org authored
R=jarin@chromium.org Review URL: https://codereview.chromium.org/239113009 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20807 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This reverts r20802 . TBR=jarin@chromium.org Review URL: https://codereview.chromium.org/239543010 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20804 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=mvstanton@chromium.org, ulan@chromium.org Review URL: https://codereview.chromium.org/237673014 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20802 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 15 Apr, 2014 1 commit
-
-
ishell@chromium.org authored
Function allocators, Heap::ReinitializeJSGlobalProxy() and Heap::ReinitializeJSReceiver() handlified. Factory::New<>() added. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/237093006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20762 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 14 Apr, 2014 2 commits
-
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/234913003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20730 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=jarin@chromium.org, ishell@chromium.org Review URL: https://codereview.chromium.org/235943006 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20705 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 11 Apr, 2014 6 commits
-
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/235083002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20689 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
This reverts r20682. TBR=dcarney@chromium.org Review URL: https://codereview.chromium.org/234893003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20685 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/233233004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20682 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/231883007 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20680 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
ulan@chromium.org authored
Maps in monomorphic Load, KeyedLoad, Store, KeyedStore, and CompareNil IC stubs are treated as weak references by the marking visitor. During generation of an IC stub with a weak map, the stub is appended to the dependent code array of the map. When the map dies, all stubs in its dependent code array are invalidated by setting embedded maps to undefined. BUG=v8:2073 LOG=Y TEST=cctest/test-heap/WeakMapInMonomorphic*IC R=mstarzinger@chromium.org, verwaest@chromium.org Review URL: https://codereview.chromium.org/188783003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20679 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
Deferred error formatting on GC was a failed experiment. It has been removed, except for this part. See r13371. R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/233163004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20672 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 10 Apr, 2014 1 commit
-
-
ishell@chromium.org authored
R=yangguo@chromium.org Review URL: https://codereview.chromium.org/231103002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20644 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 08 Apr, 2014 3 commits
-
-
yangguo@chromium.org authored
R=ulan@chromium.org Review URL: https://codereview.chromium.org/228093004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20572 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/227573002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20560 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/227593004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20559 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 04 Apr, 2014 2 commits
-
-
ishell@chromium.org authored
Callers of ElementsAccessor::AddElementsToFixedArray(), ElementsAccessor::HasElement() and ElementsAccessor::GetKeyForIndex() handlified. R=yangguo@chromium.org Review URL: https://codereview.chromium.org/225623004 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20513 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
yangguo@chromium.org authored
R=ishell@chromium.org Review URL: https://codereview.chromium.org/225283005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20509 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 31 Mar, 2014 4 commits
-
-
verwaest@chromium.org authored
BUG= R=hpayer@chromium.org Review URL: https://codereview.chromium.org/218663005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20358 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jochen@chromium.org authored
Reason for revert: crashes benchmarks/sunspider/string-fasta on ia32.debug This also reverts r20350 and r20352 > Fix LoadFieldByIndex to take mutable heap-numbers into account. > > BUG= > R=ishell@chromium.org > > Review URL: https://codereview.chromium.org/213213002 BUG=none LOG=n TBR=verwaest@chromium.org Revert "Use sarq on x64" This reverts commit e2a8ef9321345c6bc091054443bf2b9535ff6b1c. Revert "Don't | int and bool" This reverts commit c90d713d3a8ceba4fec41933a63beb6e50a3d7c0. Review URL: https://codereview.chromium.org/219393002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20354 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/219293002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20352 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
verwaest@chromium.org authored
BUG= R=ishell@chromium.org Review URL: https://codereview.chromium.org/213213002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20348 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 28 Mar, 2014 2 commits
-
-
yangguo@chromium.org authored
Runtime::GetObjectProperty: - handled string.charAt, element access and property access - now handlified GetProperty in handles.cc: - called to Runtime::GetObjectProperty - now removed Object::GetProperty (handlified version): - handled element access and property access - now changed to only do property access New: Object::GetPropertyOrElement: - handles element access and property access R=ishell@chromium.org Review URL: https://codereview.chromium.org/210953005 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20327 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
Reland r20308 (reverted by r20310). TBR=verwaest@chromium.org Review URL: https://codereview.chromium.org/216383003 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20321 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
- 27 Mar, 2014 2 commits
-
-
jarin@chromium.org authored
This reverts commit 4cf47a20b4846cf050ea4844433e9c57654da34e. BUG= Review URL: https://codereview.chromium.org/214893002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20310 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-
jarin@chromium.org authored
With this fix, we only create the enum cache for own property descriptors (originally we cached all descriptors in the map). The problem was that the size of all descriptors could be trimmed during GC triggered by allocating the storage for the cache, so we could have ended up with a wrong storage size. This is really Toon's fix, I have only created a small repro case. BUG= R=verwaest@chromium.org Review URL: https://codereview.chromium.org/212673011 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20308 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
-