- 15 Aug, 2019 4 commits
-
-
Adam Klein authored
This reverts commit f54f92dd. Reason for revert: CSA_ASSERTS failing while rolling into Chromium, see https://crbug.com/994103 for details. Original change's description: > [builtins] Port RegExpTest to Torque > > Bug: v8:8976 > Change-Id: Ia4dc120a31eb363599b47b22b749a3146a9c7c73 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1746083 > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63211} TBR=jgruber@chromium.org,tebbi@chromium.org,duongn@microsoft.com,szuend@chromium.org Change-Id: Id3e1fe4e323826d3a48db667b032f0fddd7cb064 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8976 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1756389Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#63217}
-
Santiago Aboy Solanes authored
This is a CL in a string of CLs that aims to TNodify CSA. In particular, there were some loads that were done in AnyTagged instead of TaggedPointer. TNode-ifying them brings improvement in pointer compression since we are able to decompress using the Pointer decompression. TNodified: * LoadJSFunctionPrototype * TryPrototypeChainLookup * OrdinaryHasInstance Also TNodified loads regarding: * FeedbackCell::kValueOffset * HeapObject::kMapOffset * JSFunction::kSharedFunctionInfoOffset * JSFunction::kFeedbackCellOffset * Map::kInstanceTypeOffset * Map::kInstanceDescriptorsOffset * Map::kPrototypeOffset Drive-by cleanup: StoreJSArrayLength and StoreElements were unused. Bug: v8:6949, v8:9396 Change-Id: I89697b5c02490906be1eee63cf3d9e60a1094d48 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1755844 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#63216}
-
Milad Farazmand authored
Previously we allowed for only one extra parameter on the stack, this CL makes it dynamic based on the kArgCount value. Change-Id: I18cd74d0cc0ecba6fb75dcee991a0e907d423d6a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1755411Reviewed-by:
Joran Siu <joransiu@ca.ibm.com> Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63215}
-
v8-ci-autoroll-builder authored
Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/a221f25..ace189a [spec] Terminology nits (#1053) (Andreas Rossberg) https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+/ace189a TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I0d06e838557560d07ca8d9ec2e8323d2d6658b99 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1755223Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#63214}
-
- 14 Aug, 2019 13 commits
-
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I81e48a99e34d7438c2b652a01d979bf8db4726ea Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1749666Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63213}
-
Ng Zhi An authored
Bug: v8:9528 Change-Id: Ib1e9505686b85fa426f3f66f7d6e1e63efc48014 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1710333Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#63212}
-
Z Nguyen-Huu authored
Bug: v8:8976 Change-Id: Ia4dc120a31eb363599b47b22b749a3146a9c7c73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1746083 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#63211}
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I4bf23d884f5d6b587db741e9d19ac4b6b1ece506 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1749663Reviewed-by:
-
Dan Elphick authored
Fixes DCHECK failure in DropStackFrameCacheCommon by returning early if the source_position_table is Exception. Bug: chromium:990582, v8:8510 Change-Id: I671f3e0cdc9f880dedf8ecd2fffb1083229dc6dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752856Reviewed-by:
-
Patrick Thier authored
This CL increases the maximum number of arguments for CallCFunction to 10 (was 9 previously). All simulators also support up to 10 arguments now for host-calls. Bug: v8:9621 Change-Id: Ib21cd39e965cdfcb0b04412261dc02e5fe106e47 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752852 Commit-Queue: Patrick Thier <pthier@google.com> Reviewed-by:
-
Michaël Zasso authored
This change makes the code compatible with both Python 2 and Python 3. Change-Id: I99d68af9c3163607c3a2fdbafac339a98b7471e4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751331 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63207}
-
Ross McIlroy authored
Otherwise there is a mismatch between eager parsing (where the reciever is marked as MaybeAssigned) and lazy parsing (where the receiver is deserialized and not marked MaybeAssigned) for arrow functions that have an inner scope that calls eval. BUG=chromium:989914 Change-Id: I8b8b78140858985a75a971b0e0a95bd61463457b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752851Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#63206}
-
Santiago Aboy Solanes authored
Moved code from the .cc file to the .h file, and added comments on important methods. There is still room for more cleanup / refactor, but it doesn't seem worth it right now. Bug: v8:9396 Change-Id: Id14d3ccaa853e0704732d468df504c379cd114b2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748735 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Michael Starzinger authored
The builtin in question was just tail-calling another existing builtin anyways. Call sites of the above builtin are rare and only appear in import wrappers, removing the unnecessary hop is more efficient. R=thibaudm@chromium.org Change-Id: I42286346119fc627f8b9ef23fb6e4b2da1da80de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752847Reviewed-by:
Thibaud Michaud <thibaudm@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63204}
-
Santiago Aboy Solanes authored
Consistent naming, moved methods, etc. There is a follow-up CL that moves code from this .cc to the private part of the class in the .h file. Bug: v8:9396 Change-Id: I9efac09baff7403bce1be9712c090d2ea70b60f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748734Reviewed-by:
-
Santiago Aboy Solanes authored
Since we can just use the lower bits, we can make the compressions no-ops. As a note, they still change the representation so that the machine graph verifier is happy. X64's version of: https://chromium-review.googlesource.com/c/v8/v8/+/1751722 Bug: v8:7703 Change-Id: I728eb8b6b3953f053a7042797f3c498d13e3c948 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751729Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b5e8d0f..1bf9025 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/1c632e3..942e493 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3c81495..979fa78 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I87deff115e8d5070c1b57393afe3bfa4bcd05c7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752433Reviewed-by:
-
- 13 Aug, 2019 23 commits
-
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: Ibef60086b49a43a6d027b8904fe905eccbd8b069 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1749662Reviewed-by:
-
Mike Stanton authored
We cherish the ability to create a (for example) JSFunctionRef by passing an object handle in phases of the compiler where we can't inspect the handle to verify the instance type. A slight change to constructor definitions of classes derived from ObjectRef allows us to police this typing effectively. Bug: v8:7790 Change-Id: I6ac8e4780d578e9c9cad80fdc87f399a92bc988d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751343 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Auto-Submit: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#63199}
-
Ng Zhi An authored
This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/1749712 with a fix in test-run-wasm-simd.cc to use base::Divide to work around C++ undefined behavior when the denominator is 0. Bug: v8:8460 Change-Id: Ia0a4ff621cccc6d9b7528717bf3fa7c79e42ba1a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745819 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#63198}
-
Darius Mercadier authored
PagedSpace::Available() is mostly used for counters. One may expect that it'd be constant time or bearly noticeable performance-wise, but its cost is linear in the number of freelists and number of pages in the freelists. Overall, d8 --prof showed that it has a important runtime cost, and prevents freelists from scaling. This CL makes this counter constant-time, and should improve performances, even using with our current FreeList strategy (FreeListLegacy). Bug: v8:9329 Bug: v8:9093 Change-Id: I7682c5debc78498fe46e8dbce70b2fbd540b0fd0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1746473 Commit-Queue: Darius Mercadier <dmercadier@google.com> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#63197}
-
Joey Gouly authored
After compression, the values should only be used for their lower 32-bits (W registers). This removes unnecessary 'ubfx' zero-extends. The size of the embedded builtins is reduced by 0.2%. This improves the ARES-6 by ~1.0%. Bug: v8:7703 Change-Id: Ib9bd771b51e85717f415a346b37428f8821bf278 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751722Reviewed-by:
Martyn Capewell <martyn.capewell@arm.com> Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#63196}
-
Patrick Thier authored
When GC triggered while an exception is pending, a read to memory that was no longer valid could happen while backtracking in the regexp interpreter (introduced with commit fb0df2c8). This CL prevents this dirty read, that could have been a security issue. Bug: chromium:992389, v8:9575 Change-Id: Ie1acd6faa16665e211666c6a8dcf2a9d74e0c886 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751342 Commit-Queue: Patrick Thier <pthier@google.com> Reviewed-by:
-
Milad Farazmand authored
Port c4d31fea Original Commit Message: Stack limits were additionally maintained in pseudo-smi roots. "Pseudo", because we stored the raw limit pointers there, just making sure their values looked like smis by masking the least significant bits. This mechanism is no longer needed now that we can access the stack limit external references as efficiently as the smi roots. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ida5c1fe10a494e9c6d665425bd464228978ecd1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752142Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#63194}
-
Milad Farazmand authored
Change-Id: If917f11f72d08e237fcb4ee43fabfc0c133dace6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1752143Reviewed-by:
-
Ross McIlroy authored
Previously we only used this flag if asm_wasm instantiation failed, but we should avoid trying asm_wasm again if we failed during the initial parse/compile, in case we have to recompile due to bytecode flushing. This also avoids issues if there is a tranisent reason we fail asm_wasm compilation (e.g., stack overflow) and later recompilations succeed and cause inconsistencies like in the linked bug. BUG=chromium:991133 Change-Id: Id156efa9d8625ce3db2058cb279ea23aeb66052f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751784Reviewed-by:
-
Santiago Aboy Solanes authored
We were going for 64 bits to go back to 32 bits. For example, TruncateInt64ToInt32(BitcastTaggedSignedToWord(ChangeCompressedToTagged(x))) when that doesn't modify the value at all. In order to keep the machine graph verifier happy two bitcast operations were introduced. As a drive-by nit cleanup, we were having two empty lines between some functions implementations in machine-operator-reducer.cc. Bug: v8:7703 Change-Id: Ifaa0d656010fe4f6f6f4581a2bb6633f060245b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1749383 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Ross McIlroy authored
When a RelocatingCharacterStream is Seeked, it's buffer_pos_ could be set a non-zero value. However, UpdateBufferPointers was assuming the position was zero to relocate the buffer_start_ and buffer_end_, which would lead to the stream becoming misaligned. Fix this and add a unittest and the clusterfuzz script which highlighted the issue. BUG=chromium:991133 Change-Id: I20dd510b3dcc5df6df058b7e06d2c8a838aef855 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751782Reviewed-by:
-
cjihrig authored
Update postmortem metadata constants for V8 7.4 in Node.js. Change-Id: I7d248b345e0326dafb776e144a6a22a381a05fc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1546049 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Michael Starzinger authored
This makes sure that the above predicate is independent of any global process-wide state. The state of enabled features is now passed in explicitly. R=thibaudm@chromium.org Change-Id: I5d44e2b0c0843d2e4f26aaf0d58d23afd5943726 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751348Reviewed-by:
-
Jakob Gruber authored
In generated code, we access fields inside IsolateData through the root-register. On some platforms it is significantly cheaper to access things that are close to the root-register value than things that are located far away. The motivation for this CL was a 5% difference in Octane/Mandreel scores between // Part of the stack check. cmpq rsp,[r13+0x9ea8] and cmpq rsp,[r13-0x30] // Mandreel score improved by 5%. This moves the StackGuard up to fix Mandreel. As a drive-by, also move two more fields up that are accessed by each CallCFunction. Tbr: yangguo@chromium.org Bug: v8:9534,chromium:993264 Change-Id: I5418b63d40274a138e285fa3c99b96e33a814fb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751345Reviewed-by:
-
Jakob Gruber authored
This reverts commit 47e077a2. Reason for revert: To avoid hard crashes on this CHECK until a proper fix has landed. Original change's description: > [deoptimizer] Check whether output frames fit into stack space > > Change-Id: I7af0fe843f73b702b03ffa50ecca19aabd7583b8 > Bug: chromium:983850 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1701858 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#62738} TBR=neis@chromium.org,sigurds@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:983850,chromium:987930,v8:9534 Change-Id: I1f1fe76c957e1f1cf2a117a5ddc7e62004497aeb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741665Reviewed-by:
-
Santiago Aboy Solanes authored
We were doing the SmiCheck in Compressed, but then using the Tagged one to go to Int32. Bug: v8:7703 Change-Id: Ib65084590eb611f9abea9383ee307d21959caa21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748698Reviewed-by:
-
Milad Farazmand authored
Port 5b2ab2f6 Original Commit Message: Now that all uses of LoadStackPointer have been removed, this CL cleans up related code: - Removed LoadStackPointer. - Removed ArchStackPointer. - Removed IA32StackCheck. - Removed X64StackCheck. - Removed StackCheckMatcher. All stack checks now follow a simple path without matchers or special register constraints: they load the limit and pass it to StackPointerGreaterThan, which is finally handled by code generation. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I68a66054dc1422e7fc0598ef4d112a031ba94cc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1750223Reviewed-by:
-
Jakob Gruber authored
Stack limits were additionally maintained in pseudo-smi roots. "Pseudo", because we stored the raw limit pointers there, just making sure their values looked like smis by masking the least significant bits. This mechanism is no longer needed now that we can access the stack limit external references as efficiently as the smi roots. Bug: v8:9534 Change-Id: I37e78851c97aebc1012ea0e95075e56366a40a73 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745339 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Mathias Bynens authored
Bug: v8:7834 Change-Id: I739ceb9668732e382cedca4d1f61a1ccc0339f35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1751344 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
Bug: chromium:982969, chromium:983267 Change-Id: I8700a21020bc63caf537ca9f70f200eebde23dee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1749902 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Georg Neis authored
R=mvstanton@chromium.org Bug: chromium:992684, v8:7790 Change-Id: Ia5e77873f4b96d9f6d9a1468a83a64206f1498ee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748692Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#63180}
-
Jakob Gruber authored
Previously these were called (real) stack limit on one end, (real) jslimit on the other. With this CL we consistently use jslimit everywhere. Tbr: tebbi@chromium.org Bug: v8:9534 Change-Id: I9f86ac113bb9682544c365d54f666c1312a073a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1748738 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f3d0ca5..b5e8d0f Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/30604c6..1c632e3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/1b4c7e9..3c81495 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/682a230..9a5af81 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3605577..a05d5ea TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: If39dec909344727bd2d2aa0f3ce7dfb64205f460 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1750585Reviewed-by:
-
