1. 31 Oct, 2018 1 commit
  2. 20 Oct, 2018 1 commit
  3. 27 Sep, 2018 1 commit
    • Clemens Hammacher's avatar
      [tracing] Fix data race · 0ba3de60
      Clemens Hammacher authored
      There is a data race if several background threads check for a tracing
      flag concurrently. Both will call {GetCategoryGroupEnabledInternal}.
      The first one not find the category in the {g_category_group_enabled}
      array, and hence will add it and call {UpdateCategoryGroupEnabledFlag}
      to initialize the flag. The second thread then finds the entry in the
      array and reads it without any synchronization, which is a data race.
      
      Since we do not really care about this race, we just use a
      {Relaxed_Load} to read the field. TSan is fine with that.
      
      R=yangguo@chromium.org
      CC=ofrobots@google.com
      
      Bug: v8:8221
      Change-Id: Ie09141e3d845956d3c487a463f00b7d6cd413513
      Reviewed-on: https://chromium-review.googlesource.com/1245424Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
      Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#56256}
      0ba3de60
  4. 20 Sep, 2018 1 commit
  5. 02 May, 2018 1 commit
  6. 02 Feb, 2018 1 commit
  7. 12 Jan, 2018 1 commit
  8. 19 Dec, 2017 1 commit
  9. 01 Dec, 2017 1 commit
  10. 18 Oct, 2017 1 commit
  11. 13 Oct, 2017 1 commit
  12. 03 Jul, 2017 1 commit
    • Jochen Eisinger's avatar
      Reland "Switch tracing to use v8::TracingController" · cc59f8b1
      Jochen Eisinger authored
      Original change's description:
      > Switch tracing to use v8::TracingController
      >
      > BUG=v8:6511
      > R=fmeawad@chromium.org
      >
      > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
      > Change-Id: I4961e4b61a9ddc98385ed97c3ffcbcaef2d9cba7
      > Reviewed-on: https://chromium-review.googlesource.com/543144
      > Commit-Queue: Jochen Eisinger <jochen@chromium.org>
      > Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
      > Cr-Commit-Position: refs/heads/master@{#46307}
      
      BUG=v8:6511
      TBR=fmeawad@chromium.org
      
      Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng;master.tryserver.v8:v8_linux64_tsan_rel
      Change-Id: Ide32b409248dfd466e7c0bae1d8ae61d6a955d98
      Reviewed-on: https://chromium-review.googlesource.com/558865
      Commit-Queue: Jochen Eisinger <jochen@chromium.org>
      Reviewed-by: 's avatarJochen Eisinger <jochen@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#46381}
      cc59f8b1
  13. 29 Jun, 2017 2 commits
  14. 30 May, 2017 1 commit
  15. 29 Mar, 2017 1 commit
  16. 12 Jan, 2017 1 commit
  17. 15 Dec, 2016 1 commit
  18. 07 Dec, 2016 1 commit
    • lpy's avatar
      [Tracing] Implement IC statistics in tracing. · 0a3c8fc3
      lpy authored
      This patch introduces:
      
      1. ICStats class to store ic statistics items produced by V8,
      2. A disabled by default tracing category v8.ic_stats,
      3. An trace event V8.ICStats that contains ic statistics items in args,
      
      We store ic statistics items in an array until the array is full to reduce
      the number of trace events.
      
      TBR=jkummerow@chromium.org,ishell@chromium.org
      
      Review-Url: https://codereview.chromium.org/2503183002
      Cr-Commit-Position: refs/heads/master@{#41559}
      0a3c8fc3
  19. 06 Dec, 2016 1 commit
  20. 09 Nov, 2016 1 commit
  21. 08 Nov, 2016 1 commit
    • lpy's avatar
      [Tracing] Use TracingCategoryObserver in gc statistics · 7d28301d
      lpy authored
      This patch is a follow-up patch to enable gc statistics to use
      TracingCategoryObserver.
      
      Previously we need to pass --track_gc_object_stats to v8 if we want to enable
      gc statistics in tracing. In this patch, we introducce an integer flag
      FLAG_gc_stats, and FLAG_track_gc_object_stats and FLAG_trace_gc_object_stats
      will set it to 0x01, tracing will set it to 0x10 when we start tracing and
      reset the bit when we stop tracing.
      
      BUG=v8:5590
      
      Review-Url: https://codereview.chromium.org/2459903003
      Cr-Commit-Position: refs/heads/master@{#40817}
      7d28301d
  22. 07 Nov, 2016 1 commit
  23. 05 Nov, 2016 1 commit
  24. 04 Nov, 2016 2 commits
  25. 03 Nov, 2016 3 commits
  26. 28 Oct, 2016 2 commits
    • lpy's avatar
      [Tracing] Implement TracingCategoryObserver. · 6df8096a
      lpy authored
      This patch implements TracingCategoryObserver to set global flag when a V8
      specific category is enabled. Previously, we set a global flag each time when we
      encounter a top level trace event, and use it as a global check. With this
      patch, we can set a group of flags when tracing is enabled; besides, we make
      V8 tracing feature use V8 flags instead of defining its own flag in a messy way.
      
      With this patch, whatever V8 flag we want to imply in tracing, we define another
      integer flag, and the original V8 flag will set it to 0x01 when passing by
      commandline, tracing will set it to 0x10 when we start tracing and reset the bit
      when we stop tracing.
      
      Review-Url: https://codereview.chromium.org/2436273002
      Cr-Commit-Position: refs/heads/master@{#40659}
      6df8096a
    • lpy's avatar
      [Tracing] Fix inaccurate timer calculation in runtime statistics. · 92d9a56a
      lpy authored
      Previously we reset runtime counters and dump them when we enter, exit top level
      trace events respectively. However, there is gap between two top level trace
      events and runtime counters may be activated, resetting the counters makes the
      accumulated time inaccurate, and we may end up with negative time due to the
      nature of how we accumulate time.
      
      This patch fixes this problem by only resetting counters when there's no
      counters active, and before dump counters, we traverse current active counters
      to calculate their time, and then restart their timer.
      
      BUG=chromium:658145
      
      Review-Url: https://codereview.chromium.org/2457523002
      Cr-Commit-Position: refs/heads/master@{#40653}
      92d9a56a
  27. 19 Oct, 2016 1 commit
  28. 12 Oct, 2016 1 commit
  29. 06 Oct, 2016 1 commit
  30. 27 Sep, 2016 2 commits
  31. 26 Sep, 2016 1 commit
  32. 22 Sep, 2016 1 commit
  33. 19 Sep, 2016 1 commit
  34. 08 Sep, 2016 1 commit