Commit 900d1982 authored by lpy's avatar lpy Committed by Commit bot

[Tracing] Remove AppendLongInteger in TracedValue.

JavaScript cannot represent integer larger than 2^53 - 1 from JSON, thus this
patch removes AppendLongInteger and convert long integer to string using
std::to_string.

TBR=cbruni@chromium.org

Review-Url: https://codereview.chromium.org/2557463003
Cr-Commit-Position: refs/heads/master@{#41533}
parent a9345a15
......@@ -280,8 +280,8 @@ void RuntimeCallCounter::Reset() {
void RuntimeCallCounter::Dump(v8::tracing::TracedValue* value) {
value->BeginArray(name_);
value->AppendLongInteger(count_);
value->AppendLongInteger(time_.InMicroseconds());
value->AppendDouble(count_);
value->AppendDouble(time_.InMicroseconds());
value->EndArray();
}
......
......@@ -121,12 +121,6 @@ void TracedValue::AppendInteger(int value) {
data_ += std::to_string(value);
}
void TracedValue::AppendLongInteger(int64_t value) {
DCHECK_CURRENT_CONTAINER_IS(kStackTypeArray);
WriteComma();
data_ += std::to_string(value);
}
void TracedValue::AppendDouble(double value) {
DCHECK_CURRENT_CONTAINER_IS(kStackTypeArray);
WriteComma();
......
......@@ -34,7 +34,6 @@ class TracedValue : public ConvertableToTraceFormat {
void BeginArray(const char* name);
void AppendInteger(int);
void AppendLongInteger(int64_t);
void AppendDouble(double);
void AppendBoolean(bool);
void AppendString(const std::string&);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment