1. 28 Apr, 2022 1 commit
    • Keith Smiley's avatar
      [bazel] Include handler-include-posix on m1 macs · 75325a32
      Keith Smiley authored
      Previously building `//:noicu/mksnapshot` on M1 macs produced this
      linker error:
      
      ```
      Undefined symbols for architecture arm64:
        "v8::internal::trap_handler::TryHandleSignal(int, __siginfo*, void*)", referenced from:
            v8::TryHandleWebAssemblyTrapPosix(int, __siginfo*, void*) in libv8_libshared_noicu.lo(api.o)
        "v8::internal::trap_handler::RegisterDefaultTrapHandler()", referenced from:
            v8::internal::trap_handler::EnableTrapHandler(bool) in libv8_libshared_noicu.lo(handler-outside.o)
      ld: symbol(s) not found for architecture arm64
      clang: error: linker command failed with exit code 1 (use -v to see invocation)
      ```
      
      Because this branch that enabled the trap handler:
      
      ```
      // Arm64 (non-simulator) on Mac.
       #elif V8_TARGET_ARCH_ARM64 && V8_HOST_ARCH_ARM64 && V8_OS_DARWIN
      ```
      
      Wasn't handled in the build, so the file was excluded.
      
      Change-Id: Ie2ed9d3aeab849b1479cad5d4f9ca48e6eb51bf4
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3589296
      Commit-Queue: Victor Gomes <victorgomes@chromium.org>
      Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#80246}
      75325a32
  2. 18 Mar, 2022 1 commit
  3. 16 Feb, 2022 1 commit
  4. 11 Jan, 2022 1 commit
  5. 10 Jan, 2022 3 commits
  6. 05 Jan, 2022 1 commit
  7. 04 Jan, 2022 1 commit
  8. 18 Nov, 2021 1 commit
  9. 15 Nov, 2021 1 commit
  10. 28 Oct, 2021 1 commit