- 03 Aug, 2015 1 commit
-
-
bbudge authored
Adds Int32x4, Bool32x4, Int16x8, Bool16x8, Int8x16, Bool8x16. Adds Simd128Value base heap object class. Changes heap/factory construction pattern to use arrays. Adds replaceLane functions to facilitate testing. NOPRESUBMIT=true (presubmit checks erroneously interpret array declaration in macro definition as variable size array.) LOG=Y BUG=v8:4124 Review URL: https://codereview.chromium.org/1250733005 Cr-Commit-Position: refs/heads/master@{#29974}
-
- 31 Jul, 2015 1 commit
-
-
bmeurer authored
This is the initial (big) step towards a more uniform implementation of the ToObject abstract operation (ES6 7.1.13), where we have a fallback implementation in JSReceiver::ToObject() and a fast (hydrogen) CodeStub to deal with the fast case (we should be able to do more cleanup on this in a followup CL). For natives we expose the abstract operation via a %_ToObject intrinsic, also exposed via a macro TO_OBJECT, that unifies the previous confusion with TO_OBJECT_INLINE, ToObject, TO_OBJECT, $toObject and %$toObject. Now the whole implementation of the abstract operation is context independent, meaning we don't need any magic in the builtins object nor the native context. R=mvstanton@chromium.org,yangguo@chromium.org Review URL: https://codereview.chromium.org/1266013006 Cr-Commit-Position: refs/heads/master@{#29953}
-
- 28 Jul, 2015 2 commits
-
-
chunyang.dai authored
port 5dff4bdf (r29886). original commit message: No need to pass the name explicitly to the stubs; the runtime can extract the name from the ScopeInfo (the extension of the ScriptContext) on-demand easily without any performance impact. BUG= Review URL: https://codereview.chromium.org/1259063004 Cr-Commit-Position: refs/heads/master@{#29892}
-
chunyang.dai authored
port cac64b9f (r29881) original commit message: We don't need the hole check and slow runtime mode for read-only properties this way. BUG= Review URL: https://codereview.chromium.org/1263473002 Cr-Commit-Position: refs/heads/master@{#29891}
-
- 27 Jul, 2015 2 commits
-
-
chunyang.dai authored
In CL 0fe2fbd1 the implementation of MathPow for all ports are unified and MathPow stub code is invoked. So we move the direct runtime function call from full-codegen to MathPow stub for X87 platform. BUG= Review URL: https://codereview.chromium.org/1258873002 Cr-Commit-Position: refs/heads/master@{#29865}
-
ishell authored
Review URL: https://codereview.chromium.org/1259853002 Cr-Commit-Position: refs/heads/master@{#29860}
-
- 24 Jul, 2015 4 commits
-
-
chunyang.dai authored
port d6ee366d (r29834). original commit message: This is the initial round of optimizations for the LoadGlobalViaContextStub and StoreGlobalViaContextStub, basically turning them into platform code stubs to avoid the Crankshaft overhead in the fast case, and making the runtime interface cheaper. BUG= Review URL: https://codereview.chromium.org/1258513003 Cr-Commit-Position: refs/heads/master@{#29839}
-
chunyang.dai authored
port bc8041dc (r29811). original commit message: Previous to this CL, ICs used a slightly different code idiom to get to C++ code from generated code than runtime intrinsics, using an IC_Utility class that in essence provided exactly the same functionality as Runtime::FunctionForId, but in its own quirky way. This CL unifies the two mechanisms, folding IC_Utility away by making all IC entry points in C++ code, e.g. IC miss handlers, full-fledged runtime intrinsics. This makes it possible to eliminate a bunch of ad-hoc declarations and adapters that the IC system had to needlessly re-invent. As a bonus and the original reason for this yak-shave: IC-related C++ runtime functions are now callable from TurboFan. BUG= Review URL: https://codereview.chromium.org/1252903002 Cr-Commit-Position: refs/heads/master@{#29837}
-
chunyang.dai authored
port 3334b830 (r20813). original commit message: HydrogenCodeStubs consume stack arguments via descriptor. All of this is controlled by the CallDescriptor. It's simply the case that if you specify less registers than the function arity calls for, the rest are assumed to be on the stack. Bailout handlers accept these constant stack arguments too. BUG= Review URL: https://codereview.chromium.org/1258553002 Cr-Commit-Position: refs/heads/master@{#29836}
-
chunyang.dai authored
port 1f295980 (r29787). original commit message: This fixes a recent regression where the register holding the original receiver was pushed onto the stack before the internal frame within the CallStubInRecordCallTarget helper was created. That in turn confused the stack walker when allocations in these stubs failed. BUG= Review URL: https://codereview.chromium.org/1247493004 Cr-Commit-Position: refs/heads/master@{#29828}
-
- 23 Jul, 2015 1 commit
-
-
mostynb authored
Review URL: https://codereview.chromium.org/1251593009 Cr-Commit-Position: refs/heads/master@{#29825}
-
- 16 Jul, 2015 3 commits
-
-
bbudge authored
This CL exposes the constructor function, defines type related information, and implements value type semantics. It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc LOG=Y BUG=v8:4124 Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 Cr-Commit-Position: refs/heads/master@{#29689} Review URL: https://codereview.chromium.org/1219943002 Cr-Commit-Position: refs/heads/master@{#29712}
-
hablich authored
Revert of Expose SIMD.Float32x4 type to Javascript. (patchset #14 id:450001 of https://codereview.chromium.org/1219943002/) Reason for revert: Seems to brake the latest roll into Chromium: http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/59796/steps/compile%20%28with%20patch%29/logs/stdio Original issue's description: > Expose SIMD.Float32x4 type to Javascript. > This CL exposes the constructor function, defines type related > information, and implements value type semantics. > It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. > > TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc > > LOG=Y > BUG=v8:4124 > > Committed: https://crrev.com/e5ed3bee99807c502fa7d7a367ec401e16d3f773 > Cr-Commit-Position: refs/heads/master@{#29689} TBR=rossberg@chromium.org,littledan@chromium.org,martyn.capewell@arm.com,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Review URL: https://codereview.chromium.org/1241533004 Cr-Commit-Position: refs/heads/master@{#29701}
-
chunyang.dai authored
original commit message: This changes the calling convention of the CallConstructStub to take the original constructor (i.e. new.target in JS-speak) in a register instead of magically via the operand stack. For optimizing compilers the operand stack doesn't exist, hence cannot be peeked into. BUG= Review URL: https://codereview.chromium.org/1235273003 Cr-Commit-Position: refs/heads/master@{#29695}
-
- 15 Jul, 2015 2 commits
-
-
bbudge authored
This CL exposes the constructor function, defines type related information, and implements value type semantics. It also refactors test/mjsunit/samevalue.js to test SameValue and SameValueZero. TEST=test/mjsunit/harmony/simd.js, test/cctest/test-simd.cc LOG=Y BUG=v8:4124 Review URL: https://codereview.chromium.org/1219943002 Cr-Commit-Position: refs/heads/master@{#29689}
-
machenbach authored
Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c Reland after https://codereview.chromium.org/1241643002/ TBR=jochen@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1237793003 Cr-Commit-Position: refs/heads/master@{#29673}
-
- 13 Jul, 2015 2 commits
-
-
https://codereview.chromium.org/1232583002/machenbach authored
Reason for revert: [Sheriff] Looks like another clang option got deprecated: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20ASAN%20mipsel%20-%20debug%20builder/builds/326 Original issue's description: > Update V8 DEPS. > > Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c > > Original CL: https://codereview.chromium.org/1232043002/ > > BUG= > > Committed: https://crrev.com/6211e1660492f653d30ddd1336bce6f9083ede94 > Cr-Commit-Position: refs/heads/master@{#29598} TBR=jochen@chromium.org,akos.palfi@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1232803003 Cr-Commit-Position: refs/heads/master@{#29600}
-
machenbach authored
Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c Original CL: https://codereview.chromium.org/1232043002/ BUG= Review URL: https://codereview.chromium.org/1232583002 Cr-Commit-Position: refs/heads/master@{#29598}
-
- 02 Jul, 2015 2 commits
-
-
verwaest authored
BUG=v8:4137 LOG=n Review URL: https://codereview.chromium.org/1221713003 Cr-Commit-Position: refs/heads/master@{#29447}
-
chunyang.dai authored
port 7015fd20 (r29402) original commit message: Up until now the context register was listed explicitly in each stub's CallInterfaceDescriptor. This was problematic, because it was listed first in the list of register parameters--which is fine for Crankshaft, which is more or less built to handle the context as the first parameter-- but not ideal for TurboFan, which adds the context at the end of all function parameters. Now the context register is no longer in the register list and can be handled appropriately by both compilers. Specifically, this allows the FunctionType specified for each CallInterfaceDescriptor to exactly match the parameter register list. BUG= Review URL: https://codereview.chromium.org/1216543004 Cr-Commit-Position: refs/heads/master@{#29433}
-
- 01 Jul, 2015 2 commits
-
-
chunyang.dai authored
port c1a4f747 (r29281). original commit message: The idea is that TurboFan can use this information for more intelligent inlining. BUG= Review URL: https://codereview.chromium.org/1213723005 Cr-Commit-Position: refs/heads/master@{#29409}
-
chunyang.dai authored
port 8196c28a (r29238). original commit message: JSConstructStub for subclass constructors instead locates new.target in a known location on the stack. BUG= Review URL: https://codereview.chromium.org/1207613003 Cr-Commit-Position: refs/heads/master@{#29398}
-
- 30 Jun, 2015 1 commit
-
-
conradw authored
Revert "Revert relanded strong property access CL" Regression issues should be solved. Initial patchset is the original, subsequent patchsets are the fixing modifications. This reverts commit 4ac7be56. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1199983002 Cr-Commit-Position: refs/heads/master@{#29384}
-
- 19 Jun, 2015 1 commit
-
-
conradw authored
Reason: Regressions in various benchmarks. Revert "Revert of Revert of [strong] Implement strong mode restrictions on property access (patchset #1 id:1 of https://codereview.chromium.org/1189153002/)" This reverts commit 41405c04. Revert "X87: Revert of Revert of [strong] Implement strong mode restrictions on property access." This reverts commit 48de5f4d. Revert "Fix overlapping KeyedLoadIC bitfield." This reverts commit 4e6c956a. Revert "MIPS64: Fix 'Revert of Revert of [strong] Implement strong mode restrictions on property access'." This reverts commit 74f97b0d. BUG= Review URL: https://codereview.chromium.org/1199493002 Cr-Commit-Position: refs/heads/master@{#29166}
-
- 18 Jun, 2015 3 commits
-
-
conradw authored
Revert of Revert of [strong] Implement strong mode restrictions on property access (patchset #1 id:1 of https://codereview.chromium.org/1189153002/) Reason for revert: Issue was ultimately caused/fixed by https://codereview.chromium.org/1194673002/ Original issue's description: > Revert of [strong] Implement strong mode restrictions on property access (patchset #23 id:460001 of https://codereview.chromium.org/1168093002/) > > Reason for revert: > Speculative revert, maybe breaks GC-stress > > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/808 > > Original issue's description: > > [strong] Implement strong mode restrictions on property access > > > > Implements the strong mode proposal's restrictions on property access. > > > > To be fully explored in a followup: proxies, interceptors, access checks, load from super > > > > BUG=v8:3956 > > LOG=N > > > > Committed: https://crrev.com/85dbfb9a389e7b21bd2a63862202ee97fc5d7982 > > Cr-Commit-Position: refs/heads/master@{#29109} > > TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:3956 > > Committed: https://crrev.com/407657b706711fd5f8d417841e24b284886f3776 > Cr-Commit-Position: refs/heads/master@{#29115} TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1185343005 Cr-Commit-Position: refs/heads/master@{#29122}
-
conradw authored
Revert of [strong] Implement strong mode restrictions on property access (patchset #23 id:460001 of https://codereview.chromium.org/1168093002/) Reason for revert: Speculative revert, maybe breaks GC-stress http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/808 Original issue's description: > [strong] Implement strong mode restrictions on property access > > Implements the strong mode proposal's restrictions on property access. > > To be fully explored in a followup: proxies, interceptors, access checks, load from super > > BUG=v8:3956 > LOG=N > > Committed: https://crrev.com/85dbfb9a389e7b21bd2a63862202ee97fc5d7982 > Cr-Commit-Position: refs/heads/master@{#29109} TBR=rossberg@chromium.org,mvstanton@chromium.org,mstarzinger@chromium.org,verwaest@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:3956 Review URL: https://codereview.chromium.org/1189153002 Cr-Commit-Position: refs/heads/master@{#29115}
-
conradw authored
Implements the strong mode proposal's restrictions on property access. To be fully explored in a followup: proxies, interceptors, access checks, load from super BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1168093002 Cr-Commit-Position: refs/heads/master@{#29109}
-
- 08 Jun, 2015 1 commit
-
-
conradw authored
Boolean "is_strong" parameters have begun to proliferate across areas where strong mode semantics are different. This CL repurposes the existing ObjectStrength enum as a replacement for them. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1144183004 Cr-Commit-Position: refs/heads/master@{#28839}
-
- 02 Jun, 2015 1 commit
-
-
conradw authored
Copied, with permission, from https://codereview.chromium.org/1151853003/ Initial patch set is an unmodified copy, rebased on top of related fixes from https://codereview.chromium.org/1158933002/ Subsequent patch sets contain fixes for remaining bugs in the CL. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1152093003 Cr-Commit-Position: refs/heads/master@{#28760}
-
- 01 Jun, 2015 1 commit
-
-
erikcorry authored
When compiling on a laptop I like to concatenate the small test files. This makes a big difference to compile times. These changes make that easier. R=ulan@chromium.org BUG= Review URL: https://codereview.chromium.org/1163803002 Cr-Commit-Position: refs/heads/master@{#28742}
-
- 25 May, 2015 1 commit
-
-
chunyang.dai authored
port a86384f1 (r28597). original commit message: Also introduce new interface descriptors for the trampoline and full versions of those stubs. Currently, the stubs aren't functional. BUG= Review URL: https://codereview.chromium.org/1148963003 Cr-Commit-Position: refs/heads/master@{#28605}
-
- 21 May, 2015 1 commit
-
-
chunyang.dai authored
port 09aaf003 (r28516). original commit message: Also removed ornamentation like "VectorRaw" from stub names. BUG= Review URL: https://codereview.chromium.org/1152473003 Cr-Commit-Position: refs/heads/master@{#28532}
-
- 19 May, 2015 1 commit
-
-
chunyang.dai authored
X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. port 323ced9e (r28422). original commit message: BUG= Review URL: https://codereview.chromium.org/1142713007 Cr-Commit-Position: refs/heads/master@{#28467}
-
- 12 May, 2015 1 commit
-
-
conradw authored
Implements the strong mode proposal's restrictions on implicit conversions for the binary >, >=, <, and <= operators. BUG=v8:3956 LOG=N Review URL: https://codereview.chromium.org/1130283002 Cr-Commit-Position: refs/heads/master@{#28370}
-
- 07 May, 2015 1 commit
-
-
chunyang.dai authored
port 7798548a (r28260) original commit message: typeof was implemented as a runtime function. Calling it in optimized code with a non-constant input becomes burdensome. BUG= Review URL: https://codereview.chromium.org/1124263005 Cr-Commit-Position: refs/heads/master@{#28279}
-
- 06 May, 2015 1 commit
-
-
chunyang.dai authored
port cf53fed9 (r28242). original commit message: ArgumentsAdaptorStub for derived constructor (the one that needs new.target) works in this way: - If the constructor is invoked via the Construct stub, we know that actual arguments always include new.target. ``arguments`` object however should not include a new.target, therefore we remove it. We achieve this by decrementing the argument count. - If the constructor is invoked as a call, we do not care for a correct ``arguments`` array since the constructor will immediately throw on entrance. The bug is that the call could actually pass 0 actual arguments, but I decrement unconditionally :(. The fix is to detect this case and avoid decrementing. ``arguments`` is bogus, but it is ok as constructor throws. Long-term we should just remove mucking about with arguments for new.target and just get it from the stack. BUG= Review URL: https://codereview.chromium.org/1124063002 Cr-Commit-Position: refs/heads/master@{#28246}
-
- 05 May, 2015 1 commit
-
-
arv authored
When comparing a symbol to istself using <, <=, > or >= we need to throw a TypeError. This is correctly handled in the runtime function so if we are comparing a symbol fall back to use the runtime. BUG=v8:4073 LOG=Y R=rossberg@chromium.org Review URL: https://codereview.chromium.org/1125783002 Cr-Commit-Position: refs/heads/master@{#28226}
-
- 04 May, 2015 1 commit
-
-
jarin authored
BUG=v8:3985 LOG=n R=mstarzinger@chromium.org Review URL: https://codereview.chromium.org/1122083002 Cr-Commit-Position: refs/heads/master@{#28206}
-
- 13 Apr, 2015 1 commit
-
-
chunyang.dai authored
port 4bd9bdbb (r27751) original commit message: BUG= Review URL: https://codereview.chromium.org/1051323003 Cr-Commit-Position: refs/heads/master@{#27778}
-
- 09 Apr, 2015 1 commit
-
-
chunyang.dai authored
port 6a222b8f (r27630) original commit message: Code cleanup in GenerateRecordCallTarget BUG= Review URL: https://codereview.chromium.org/1074683003 Cr-Commit-Position: refs/heads/master@{#27694}
-