Skip to content

V
V8
Commit c63e50ed authored by machenbach's avatar machenbach Committed by Commit bot
Browse files
Options

Reland Update V8 DEPS. 

Rolling v8/tools/clang to 58128abd44c22255def1163d30bc9bb2cc85e15c

Reland after https://codereview.chromium.org/1241643002/

TBR=jochen@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/1237793003

Cr-Commit-Position: refs/heads/master@{#29673}
parent fc9c5275
Hide whitespace changes
Inline Side-by-side
Showing with 32 additions and 39 deletions
DEPS
View file @ c63e50ed
......@@ -18,7 +18,7 @@ deps = {
"v8/testing/gmock":
Var("git_url") + "/external/googlemock.git" + "@" + "29763965ab52f24565299976b936d1265cb6a271", # from svn revision 501
"v8/tools/clang":
Var("git_url") + "/chromium/src/tools/clang.git" + "@" + "73ec8804ed395b0886d6edf82a9f33583f4a7902",
Var("git_url") + "/chromium/src/tools/clang.git" + "@" + "0de8f3bb6af64e13876273c601704795d5e00faf",
}
deps_os = {
......
src/arm/code-stubs-arm.cc
View file @ c63e50ed
......@@ -3014,10 +3014,9 @@ void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {
// Fast case of Heap::LookupSingleCharacterStringFromCode.
STATIC_ASSERT(kSmiTag == 0);
STATIC_ASSERT(kSmiShiftSize == 0);
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));
__ tst(code_,
Operand(kSmiTagMask |
((~String::kMaxOneByteCharCode) << kSmiTagSize)));
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCodeU + 1));
__ tst(code_, Operand(kSmiTagMask |
((~String::kMaxOneByteCharCodeU) << kSmiTagSize)));
__ b(ne, &slow_case_);
__ LoadRoot(result_, Heap::kSingleCharacterStringCacheRootIndex);
......
src/ia32/code-stubs-ia32.cc
View file @ c63e50ed
......@@ -3026,10 +3026,9 @@ void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {
// Fast case of Heap::LookupSingleCharacterStringFromCode.
STATIC_ASSERT(kSmiTag == 0);
STATIC_ASSERT(kSmiShiftSize == 0);
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));
__ test(code_,
Immediate(kSmiTagMask |
((~String::kMaxOneByteCharCode) << kSmiTagSize)));
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCodeU + 1));
__ test(code_, Immediate(kSmiTagMask |
((~String::kMaxOneByteCharCodeU) << kSmiTagSize)));
__ j(not_zero, &slow_case_);
Factory* factory = masm->isolate()->factory();
......
src/mips/code-stubs-mips.cc
View file @ c63e50ed
......@@ -3161,11 +3161,9 @@ void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {
STATIC_ASSERT(kSmiTag == 0);
STATIC_ASSERT(kSmiShiftSize == 0);
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));
__ And(t0,
code_,
Operand(kSmiTagMask |
((~String::kMaxOneByteCharCode) << kSmiTagSize)));
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCodeU + 1));
__ And(t0, code_, Operand(kSmiTagMask |
((~String::kMaxOneByteCharCodeU) << kSmiTagSize)));
__ Branch(&slow_case_, ne, t0, Operand(zero_reg));
__ LoadRoot(result_, Heap::kSingleCharacterStringCacheRootIndex);
......
src/mips64/code-stubs-mips64.cc
View file @ c63e50ed
......@@ -3198,11 +3198,9 @@ void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {
DCHECK(!a4.is(code_));
STATIC_ASSERT(kSmiTag == 0);
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));
__ And(a4,
code_,
Operand(kSmiTagMask |
((~String::kMaxOneByteCharCode) << kSmiTagSize)));
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCodeU + 1));
__ And(a4, code_, Operand(kSmiTagMask |
((~String::kMaxOneByteCharCodeU) << kSmiTagSize)));
__ Branch(&slow_case_, ne, a4, Operand(zero_reg));
......
src/x87/code-stubs-x87.cc
View file @ c63e50ed
......@@ -2716,10 +2716,9 @@ void StringCharFromCodeGenerator::GenerateFast(MacroAssembler* masm) {
// Fast case of Heap::LookupSingleCharacterStringFromCode.
STATIC_ASSERT(kSmiTag == 0);
STATIC_ASSERT(kSmiShiftSize == 0);
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCode + 1));
__ test(code_,
Immediate(kSmiTagMask |
((~String::kMaxOneByteCharCode) << kSmiTagSize)));
DCHECK(base::bits::IsPowerOfTwo32(String::kMaxOneByteCharCodeU + 1));
__ test(code_, Immediate(kSmiTagMask |
((~String::kMaxOneByteCharCodeU) << kSmiTagSize)));
__ j(not_zero, &slow_case_);
Factory* factory = masm->isolate()->factory();
......
test/cctest/test-disasm-mips.cc
View file @ c63e50ed
......@@ -98,7 +98,7 @@ if (failure) { \
byte *progcounter = &buffer[pc_offset]; \
char str_with_address[100]; \
snprintf(str_with_address, sizeof(str_with_address), "%s -> %p", \
compare_string, progcounter + 4 + (offset << 2)); \
compare_string, progcounter + 4 + (offset * 4)); \
assm.asm_; \
if (!DisassembleAndCompare(progcounter, str_with_address)) failure = true; \
}
......@@ -110,7 +110,7 @@ if (failure) { \
byte *progcounter = &buffer[pc_offset]; \
char str_with_address[100]; \
snprintf(str_with_address, sizeof(str_with_address), "%s -> %p", \
compare_string, progcounter + (offset << 2)); \
compare_string, progcounter + (offset * 4)); \
assm.asm_; \
if (!DisassembleAndCompare(progcounter, str_with_address)) failure = true; \
}
......@@ -422,45 +422,45 @@ TEST(Type0) {
"60857fff bnec a0, a1, 32767", 32767);
}
COMPARE_PC_REL_COMPACT(bne(a0, a1, -32768),
"14858000 bne a0, a1, -32768", -32768);
COMPARE_PC_REL_COMPACT(bne(a0, a1, 65535U),
"14858000 bne a0, a1, 65535U", 65535U);
COMPARE_PC_REL_COMPACT(bne(a0, a1, -1), "1485ffff bne a0, a1, -1",
-1);
COMPARE_PC_REL_COMPACT(bne(a0, a1, 1), "14850001 bne a0, a1, 1", 1);
COMPARE_PC_REL_COMPACT(bne(a0, a1, 32767),
"14857fff bne a0, a1, 32767", 32767);
COMPARE_PC_REL_COMPACT(beq(a0, a1, -32768),
"10858000 beq a0, a1, -32768", -32768);
COMPARE_PC_REL_COMPACT(beq(a0, a1, 65535U),
"10858000 beq a0, a1, 65535U", 65535U);
COMPARE_PC_REL_COMPACT(beq(a0, a1, -1), "1085ffff beq a0, a1, -1",
-1);
COMPARE_PC_REL_COMPACT(beq(a0, a1, 1), "10850001 beq a0, a1, 1", 1);
COMPARE_PC_REL_COMPACT(beq(a0, a1, 32767),
"10857fff beq a0, a1, 32767", 32767);
COMPARE_PC_REL_COMPACT(bltz(a0, -32768), "04808000 bltz a0, -32768",
-32768);
COMPARE_PC_REL_COMPACT(bltz(a0, 65535U), "04808000 bltz a0, 65535U",
65535U);
COMPARE_PC_REL_COMPACT(bltz(a0, -1), "0480ffff bltz a0, -1", -1);
COMPARE_PC_REL_COMPACT(bltz(a0, 1), "04800001 bltz a0, 1", 1);
COMPARE_PC_REL_COMPACT(bltz(a0, 32767), "04807fff bltz a0, 32767",
32767);
COMPARE_PC_REL_COMPACT(bgez(a0, -32768), "04818000 bgez a0, -32768",
-32768);
COMPARE_PC_REL_COMPACT(bgez(a0, 65535U), "04818000 bgez a0, 65535U",
65535U);
COMPARE_PC_REL_COMPACT(bgez(a0, -1), "0481ffff bgez a0, -1", -1);
COMPARE_PC_REL_COMPACT(bgez(a0, 1), "04810001 bgez a0, 1", 1);
COMPARE_PC_REL_COMPACT(bgez(a0, 32767), "04817fff bgez a0, 32767",
32767);
COMPARE_PC_REL_COMPACT(blez(a0, -32768), "18808000 blez a0, -32768",
-32768);
COMPARE_PC_REL_COMPACT(blez(a0, 65535U), "18808000 blez a0, 65535U",
65535U);
COMPARE_PC_REL_COMPACT(blez(a0, -1), "1880ffff blez a0, -1", -1);
COMPARE_PC_REL_COMPACT(blez(a0, 1), "18800001 blez a0, 1", 1);
COMPARE_PC_REL_COMPACT(blez(a0, 32767), "18807fff blez a0, 32767",
32767);
COMPARE_PC_REL_COMPACT(bgtz(a0, -32768), "1c808000 bgtz a0, -32768",
-32768);
COMPARE_PC_REL_COMPACT(bgtz(a0, 65535U), "1c808000 bgtz a0, 65535U",
65535U);
COMPARE_PC_REL_COMPACT(bgtz(a0, -1), "1c80ffff bgtz a0, -1", -1);
COMPARE_PC_REL_COMPACT(bgtz(a0, 1), "1c800001 bgtz a0, 1", 1);
COMPARE_PC_REL_COMPACT(bgtz(a0, 32767), "1c807fff bgtz a0, 32767",
......
test/cctest/test-disasm-mips64.cc
View file @ c63e50ed
......@@ -98,7 +98,7 @@ if (failure) { \
byte *progcounter = &buffer[pc_offset]; \
char str_with_address[100]; \
snprintf(str_with_address, sizeof(str_with_address), "%s -> %p", \
compare_string, progcounter + 4 + (offset << 2)); \
compare_string, progcounter + 4 + (offset * 4)); \
assm.asm_; \
if (!DisassembleAndCompare(progcounter, str_with_address)) failure = true; \
}
......@@ -110,7 +110,7 @@ if (failure) { \
byte *progcounter = &buffer[pc_offset]; \
char str_with_address[100]; \
snprintf(str_with_address, sizeof(str_with_address), "%s -> %p", \
compare_string, progcounter + (offset << 2)); \
compare_string, progcounter + (offset * 4)); \
assm.asm_; \
if (!DisassembleAndCompare(progcounter, str_with_address)) failure = true; \
}
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment