- 07 Sep, 2018 25 commits
-
-
Stephan Herhut authored
Add a test that runs multiple workers that concurrently try to advance along a random sequence of numbers, using AtomicCompareExchange to update the shared current position. Change-Id: Ie073bbdce6fd6766ef1f73f996dd592b90b8b3c2 Reviewed-on: https://chromium-review.googlesource.com/1198769 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55722}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: If6017a85683efcc847dab8034fdd82ac51106317 Reviewed-on: https://chromium-review.googlesource.com/1213182Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55721}
-
Benedikt Meurer authored
This reverts commit 0aac3884. Reason for revert: Various performance regressions (Blink and JSTests). Original change's description: > [turbofan] Be more consistent about Smi comparisons. > > This changes SimplifiedLowering to be more consistent when chosing Smi > representation as input for Number comparisons. We already had some > isolated logic for doing (speculative) Number comparisons on Smis, but > only in the case where that decision was based on type feedback, not on > information already present in the graph. > > Bug: v8:7703 > Change-Id: I25370ade630917675a6ac79b5ae6a8afd253dfc7 > Reviewed-on: https://chromium-review.googlesource.com/1196422 > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55518} TBR=jarin@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703, chromium:881758, chromium:881759, chromium:881760 Change-Id: I4af9c0b0ad37dea17ceabeb721c92a7cc978987a Reviewed-on: https://chromium-review.googlesource.com/1213185Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55720}
-
Benedikt Meurer authored
Make the TurboFan Typer infer proper types for calls to the known Symbol.prototype.toString() and Symbol.prototype.valueOf() builtins. Bug: v8:8015 Change-Id: Ia133bd8f2cfcabaf984820a953b357d1747d6892 Reviewed-on: https://chromium-review.googlesource.com/1213203 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#55719}
-
Ross McIlroy authored
Splits PreParsedScopeDataBuilder out of ProducedPreParserScopeData to make the split between building PreParsedScopeData and using already build PreParserScopeData more explicit. BUG=v8:8041 Change-Id: Iab42cab84c247152c14ac39f3136f985753160ec Reviewed-on: https://chromium-review.googlesource.com/1202104 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#55718}
-
jgruber authored
The first: we allocated within the argument list of a function call on a handlified receiver. The allocation may trigger GC which leaves us with a stale receiver reference. The second: in generated code we triggered further allocations while an uninitialized fixed array was live. Bug: v8:8145 Change-Id: If59cab6274277534b2ff6463daa5863b8feae22c Reviewed-on: https://chromium-review.googlesource.com/1213162Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#55717}
-
Ulan Degenbaev authored
This is needed to implement a new metric that measures health of Web Page Replay archives. Bug: chromium:880432 Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I59aed22e4671e491fc3a30d04fbdce1643404b32 Reviewed-on: https://chromium-review.googlesource.com/1204570 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55716}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I4062fea76f0db405e38f5f5b7d8b78409ff57357 Reviewed-on: https://chromium-review.googlesource.com/1209787 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#55715}
-
Florian Sattler authored
Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I6bf929bea03a59b40f205482b7604f44e61bc6f8 Reviewed-on: https://chromium-review.googlesource.com/1209846 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
String find has a faster overload for char, hence, we should pass a char instead of a string where possible. Fixing clang-tidy warning. Bug: v8:8015 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I49611d84bfb195992b6e2de538a726a8654b7b71 Reviewed-on: https://chromium-review.googlesource.com/1209348 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Florian Sattler authored
In these cases the std::function state does not change, hence, it can be a const ref. Fixing clang-tidy warning. Bug: v8:8015 Change-Id: I221b0c3e18c5c1f54d35d671445d2e947cf64c02 Reviewed-on: https://chromium-review.googlesource.com/1209822 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
-
Ross McIlroy authored
Adds support for zone allocated (off-heap) ConsumedPreParsingScopeData to enable worker-thread access to PreParsingScopeData during parallel IIFE compile tasks. In order to avoid code-duplication, a templated BaseConsumedPreParsingScopeData is added which implements the logic for decoding the bytestream into scope data. Two implementations of this base class are instantiated for each of the underlying serialized scope date: - ZoneConsumedPreParsedScopeData for exposing ZonePreParsedScopeData - OnHeapConsumedPreParsedScopeData for exposing on-heap PreParsedScopeData The interface for each of these classes is the ConsumedPreParsingScopeData, which exposes the methods required by the parser to deserialize the required data. As a side-cleanup, moved Ucs2CharLength and Utf8LengthHelper implementations to cc file so that we don't get a linker error if one of them are unused by the cc file including the header. BUG=v8:8041 Change-Id: Id502312d32fe4a9ddb6f5d2d9d3e3a9d30b9b27d Reviewed-on: https://chromium-review.googlesource.com/1199462 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Benedikt Meurer authored
Previously all internal accesses to the String::length field in TurboFan would use the StringLength operator, whereas explicit `string.length` accesses from user JavaScript code would use LoadField operators instead. This inconsistency led to redundant loads of the String::length, for example in case of code like ```js subject.substring(1, subject.length - 1) ``` where the `subject.substring` call introduces a StringLength(subject) node, and the `subject.length` introduces a LoadField[length](subject) node. Consistently using StringLength operator everywhere enables optimizations in TurboFan that had been blocked before here (besides avoiding the redundant load operations). Bug: v8:8015 Change-Id: I21c82bc418105b9933a9e60dde11c7b222dfcf4f Reviewed-on: https://chromium-review.googlesource.com/1212942 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Ross McIlroy authored
Also removes the --no-recompile-concurrent from the callstats.py script. BUG=v8:7790 Change-Id: I7e652dd273fd12565e086fe579bdf5974a876d9c Reviewed-on: https://chromium-review.googlesource.com/1202402Reviewed-by:
-
Florian Sattler authored
We don't need to copy the std::function because we don't modify it's state. Bug: v8:8015 Change-Id: I5320f78683fb7c1cca44b73e54312b3cc07b28cd Reviewed-on: https://chromium-review.googlesource.com/1209782Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55708}
-
Dan Elphick authored
Move everything defined in the v8::internal namespace from include/v8.h into a separate header that can be included by globals.h/checks.h instead of the whole v8.h. Also moves V8_EXPORT into v8config.h (so it can be use in the new v8-internal.h). Bug: v8:8015 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I22cdc2728d91a94b309a3d030ed06c0f8a06c723 Reviewed-on: https://chromium-review.googlesource.com/1210102Reviewed-by:
-
Benedikt Meurer authored
The CheckBounds operator was missing from the re-typing phase during representation selection, meaning that even if better type information was available on the inputs (i.e. due to taking feedback), this new type information was not propagated through CheckBounds properly. Bug: v8:8015 Change-Id: I503555e041c9fa2b9b27a28d223202d17b27a92e Reviewed-on: https://chromium-review.googlesource.com/1212963Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55706}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: chromium:866862 Change-Id: Ifcce9fced4fb96d0ec36335802549f146f0af751 Reviewed-on: https://chromium-review.googlesource.com/1209345 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#55705}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I4e4892f49de69b8c6c3347de024708997825cb44 Reviewed-on: https://chromium-review.googlesource.com/1209848Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Florian Sattler <sattlerf@google.com> Cr-Commit-Position: refs/heads/master@{#55704}
-
Igor Sheludko authored
The provided page allocator will serve all the memory requests done by the virtual memory object. This is a necessary cleanup before introducing BoundedPageAllocator. Bug: v8:8096 Change-Id: I95477d67e5f532013322a991db3ee1a1f2e821e6 Reviewed-on: https://chromium-review.googlesource.com/1210122Reviewed-by:
-
Clemens Hammacher authored
Since https://crrev.com/c/1112003, the memory size is stored as size_t instead of uint32_t in order to support 4GB memories. This CL fixes Liftoff to load and handle that field as ptrsized field instead of 32 bit integer. Drive-by: Fix wrong machine type on Phi in TF wasm compiler. R=titzer@chromium.org Bug: v8:8130 Change-Id: I40a92a2c24f6311e05b5e2608a0902674a2ce411 Reviewed-on: https://chromium-review.googlesource.com/1206008 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55702}
-
Michael Achenbach authored
This is a reland of 8ac91f6c Skips failing tests on gc stress and fixes predictable testing. Original change's description: > [test] Increase coverage of d8_default test suites > > NOTRY=true > > Bug: v8:7285,v8:8140 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 > Reviewed-on: https://chromium-review.googlesource.com/1208496 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55682} Bug: v8:7285, v8:8140, v8:8141 Change-Id: Ia7a437b874d5c8712f6def30382404e527145610 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux_optional_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg Reviewed-on: https://chromium-review.googlesource.com/1209762Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: Id459da19e009b2203b12ba04d185dc857e4913c1 Reviewed-on: https://chromium-review.googlesource.com/1209786Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Simon Zünd authored
The functionality of "FillFixedArrayWithSmiZero" got merged into "AllocateZeroedFixedArray", making these calls superfluous. R=jgruber@chromium.org Bug: v8:8015 Change-Id: I5453ea4b16a1446717517fe1676d611d987ad0a3 Reviewed-on: https://chromium-review.googlesource.com/1212842Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ebaffbc..6533d05 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0f5a0b4..dd2c588 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/d8cf40c..a90cbf3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3aa6139..e9dadb9 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2a894bf58f4c42036bbfa48b738479229a082426 Reviewed-on: https://chromium-review.googlesource.com/1212523 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55698}
-
- 06 Sep, 2018 15 commits
-
-
Igor Sheludko authored
... broken in https://chromium-review.googlesource.com/c/v8/v8/+/1209343 Change-Id: If2d630276530dc8d85de7d17e561f703937f4988 Reviewed-on: https://chromium-review.googlesource.com/1210922Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55697}
-
Bill Budge authored
- Removes workarounds in test-run-native_calls for ARM and adds ARM 32-bit aliasing-aware register allocation. - Uses wasm::LinkageAllocator instead of custom allocator to avoid duplication of this logic. - Fixes a problem in wasm::LinkageAllocator with high 16 VFP regs, and makes member variable naming consistent. Bug: v8:8015 Change-Id: Ie8bb8bad06bebce2cef3da0f6ad5c59d5f3b3b36 Reviewed-on: https://chromium-review.googlesource.com/1199907Reviewed-by:
-
Clemens Hammacher authored
These methods were deprecated in 7.0, now we can remove them. R=adamk@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I60badb378a055152bdd27aed67d11ddf74fce174 Reviewed-on: https://chromium-review.googlesource.com/1209283Reviewed-by:
-
Michael Lippautz authored
Previously explicit calls to external memory adjustment could yield in lowering the limit below the initial default limit. The consequence is repeated useless garbage collections when e.g. passing around ArrayBuffers. Bug: chromium:880036 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I429f5adcd9ae523e5ac7621cf7976686b0dec71b Reviewed-on: https://chromium-review.googlesource.com/1209784Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I6b1283f893944ca45ff7816d51e0c7fb26c8a8e1 Reviewed-on: https://chromium-review.googlesource.com/1209785Reviewed-by:
-
Igor Sheludko authored
This CL adds CheckRange() which will be used in DCHECKs in BoundedPageAllocator and renames "min_region_size" to "page_size" for better readability. Bug: v8:8096 Change-Id: I62cf7a92e50d0a11d462a9fbc34ddc5eda5456e1 Reviewed-on: https://chromium-review.googlesource.com/1209284Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55692}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: Ice0c5994ff5695c06be307c3e37d90daf14c643c Reviewed-on: https://chromium-review.googlesource.com/1209763 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55691}
-
Igor Sheludko authored
... like AllocatePage[s](), FreePages() and SetPermissions(). This CL also changes base::PageAllocator to cache AllocatePageSize and CommitPageSize values returned by the OS. This is a necessary cleanup before introducing BoundedPageAllocator. Bug: v8:8096 Change-Id: Ifb7cdd2caa6a1b029ce0fca6545c61df9d281be2 Reviewed-on: https://chromium-review.googlesource.com/1209343Reviewed-by:
-
Clemens Hammacher authored
If a web worker terminates while a wasm finisher task is scheduled, we try to cancel that task even though the platform already deleted it. This results in UBSan failures, ASan failures or crashes. This CL fixes this by deregistering the foreground task when it is deleted before being executed. A layout test for this will be added to chromium in https://crrev.com/c/1209602. R=ahaas@chromium.org Bug: chromium:875579 Change-Id: Icae43a9dcc6dc16c872851961894bf8bc0872de8 Reviewed-on: https://chromium-review.googlesource.com/1209344 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: I681dbe1bc115f284994d9ecdb0d2061aed1dbb5e Reviewed-on: https://chromium-review.googlesource.com/1208514Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: Id3c2075e3c0a8f9b81a9c6b5f0578b6ecfa58001 Reviewed-on: https://chromium-review.googlesource.com/1205834Reviewed-by:
-
Simon Zünd authored
Also changes occurrences of 'length' with kLengthString. R=mvstanton@chromium.org Bug: v8:8015 Change-Id: Ida205a7d69939d7d3473e1ab8e82d0cdba4c8668 Reviewed-on: https://chromium-review.googlesource.com/1209302Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I7f63989a897857c2258ec2bee59aed6100bc689e Reviewed-on: https://chromium-review.googlesource.com/1209346Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Change-Id: I59a373d838678ec8659a3014e5e3184e5c2d5c12 Reviewed-on: https://chromium-review.googlesource.com/1209462Reviewed-by:
-
Michael Achenbach authored
This reverts commit 8ac91f6c. Reason for revert: Some actual failures on Mac and debugger: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/2914 Failing message tests need to be skipped for predictable testing: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20predictable/18967 Original change's description: > [test] Increase coverage of d8_default test suites > > NOTRY=true > > Bug: v8:7285,v8:8140 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 > Reviewed-on: https://chromium-review.googlesource.com/1208496 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55682} TBR=rmcilroy@chromium.org,machenbach@chromium.org,sergiyb@chromium.org Change-Id: I701abe28317028acbf65769674f15517020d3496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7285, v8:8140 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1209347Reviewed-by:
-
