• Benedikt Meurer's avatar
    [turbofan] Consistently use the StringLength operator. · 60d3f89d
    Benedikt Meurer authored
    Previously all internal accesses to the String::length field in TurboFan
    would use the StringLength operator, whereas explicit `string.length`
    accesses from user JavaScript code would use LoadField operators instead.
    This inconsistency led to redundant loads of the String::length, for
    example in case of code like
    
    ```js
    subject.substring(1, subject.length - 1)
    ```
    
    where the `subject.substring` call introduces a StringLength(subject)
    node, and the `subject.length` introduces a LoadField[length](subject)
    node.
    
    Consistently using StringLength operator everywhere enables
    optimizations in TurboFan that had been blocked before here (besides
    avoiding the redundant load operations).
    
    Bug: v8:8015
    Change-Id: I21c82bc418105b9933a9e60dde11c7b222dfcf4f
    Reviewed-on: https://chromium-review.googlesource.com/1212942
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55710}
    60d3f89d
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...