- 08 Jan, 2019 1 commit
-
-
Frank Tang authored
Fix intl402/*/ignore-invalid-unicode-ext-values intl/*/check-* Bug: v8:7481 Change-Id: I5c9d7e19c010953ff9503a2e0981fa148278a451 Reviewed-on: https://chromium-review.googlesource.com/c/1396739 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58606}
-
- 03 Jan, 2019 1 commit
-
-
Frank Tang authored
This reverts commit 8d094249. Reason for revert: Cause Memory regression TBR=gsathya@chromium.org Original change's description: > [Intl] Validate u extension type > > Fix intl402/*/ignore-invalid-unicode-ext-values > Add tests for other valid/invalid -u- ext values. > > Bug: v8:7481 > Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 > Reviewed-on: https://chromium-review.googlesource.com/c/1351307 > Commit-Queue: Frank Tang <ftang@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58173} TBR=cira@chromium.org,jshin@chromium.org,gsathya@chromium.org,ftang@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7481 Change-Id: Idabf2183684f264271ebe2b8c0ca10ae8e30d811 Reviewed-on: https://chromium-review.googlesource.com/c/1393499Reviewed-by: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#58506}
-
- 12 Dec, 2018 1 commit
-
-
Frank Tang authored
Fix intl402/*/ignore-invalid-unicode-ext-values Add tests for other valid/invalid -u- ext values. Bug: v8:7481 Change-Id: I429effd071bb03599a1e767bb2a9e9918a91b850 Reviewed-on: https://chromium-review.googlesource.com/c/1351307 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#58173}
-
- 08 Nov, 2018 1 commit
-
-
Frank Tang authored
Requires ICU 63 or above be used when building v8 1. Remove unneeded #include of icu header files 2. Remove code inside "#if U_ICU_VERSION_MAJOR_NUM < x" block where x is 63 or smaller. Bug: v8:8401 v8:5751 Change-Id: I908b0d7d174df53d4296580fe7150417322b0b21 Reviewed-on: https://chromium-review.googlesource.com/c/1314112Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57341}
-
- 01 Nov, 2018 1 commit
-
-
Frank Tang authored
Add a templates: Intl::GetStringOptionTo<> to simplify the reading of string from options. Add GetCaseFirst and GetHourCycle into Intl for later reuse by different Intl objects Move some enum shared by Intl object into Intl:: Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If9ed1889a594f7c0ee6669b4679dda9169e4a771 Reviewed-on: https://chromium-review.googlesource.com/c/1297772Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57201}
-
- 24 Oct, 2018 3 commits
-
-
Frank Tang authored
Remove ICUService and decentralize GetAvailableLocales to each class. Refactor part of the Intl::GetAvailableLocales into Intl::BuildLocaleSet as helper function. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ic82d919cbf7ec840a7df3b0fa040561534c105a1 Reviewed-on: https://chromium-review.googlesource.com/c/1295934 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56923}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9653b862f58f25e35b5443fb5d47d69c36792768 Reviewed-on: https://chromium-review.googlesource.com/c/1295929 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56921}
-
Frank Tang authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I5a482014fa482c62b014506df45846496d909a63 Reviewed-on: https://chromium-review.googlesource.com/c/1295933Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#56917}
-
- 22 Oct, 2018 1 commit
-
-
Frank Tang authored
Fold methods from intl.* to objects/intl-objects.* Move Isolate* to the first parameter for some method Move ICUSerice type under Intl Hide ICUTimeZoneCache under a CreateTimeZoneCache factory method. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie6f6a1ceee789333a077c1965de8e11d8c15c175 Reviewed-on: https://chromium-review.googlesource.com/c/1293109 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56873}
-
- 16 Oct, 2018 1 commit
-
-
Sathya Gunasekaran authored
- Add a new Intl::ResolveLocale method and uses it in all the intl objects. - Fix CanonicalizeLocaleList to call out to HasProperty as per spec. - Add calls to CanonicalizeLocaleList where it was previously missing. - Change CanonicalizeLocaleListJS calls to CanonicalizeLocaleList now that we have migrated ResolveLocale. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I4249d2045c1556f18d570b00f7c92cbc3fa52077 Reviewed-on: https://chromium-review.googlesource.com/c/1270255Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Frank Tang <ftang@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#56660}
-
- 04 Oct, 2018 1 commit
-
-
Frank Tang authored
Make Initialize functions name consistent for Intl.* Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: If4736007fc8f048a087469acc5d968e6ece289ce Reviewed-on: https://chromium-review.googlesource.com/c/1261644Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#56390}
-
- 17 Sep, 2018 1 commit
-
-
Michael Hablich authored
This reverts commit 1a225459. Reason for revert: Makes GC stress unhappy: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20gc%20stress/18325 and blocks the roll Original change's description: > Implement ResolveLocale in C++. > > Bug: v8:8065, v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 > Reviewed-on: https://chromium-review.googlesource.com/1211402 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55925} TBR=bstell@chromium.org,gsathya@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:8065, v8:5751 Change-Id: I4d71adb31ffd5ab0d2ae42c0255d0a05edbaad29 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1226646Reviewed-by: Michael Hablich <hablich@chromium.org> Commit-Queue: Michael Hablich <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#55932}
-
- 15 Sep, 2018 1 commit
-
-
Brian Stell authored
Bug: v8:8065, v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Id9dc16455d63b7c436126c21758d64fae0ec8de9 Reviewed-on: https://chromium-review.googlesource.com/1211402Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55925}
-
- 13 Sep, 2018 1 commit
-
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7c8aab3f0420e5a7e64aa78c642320bec4142d03 Reviewed-on: https://chromium-review.googlesource.com/1208653Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55842}
-
- 07 Aug, 2018 1 commit
-
-
Jakob Kummerow authored
This CL also contains some drive-by cleanup of related code. Bug: v8:5751, v8:7987 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I6144d16c1d85922efc1dc419cce8a2eba2a60056 Reviewed-on: https://chromium-review.googlesource.com/1161545Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#54952}
-
- 06 Aug, 2018 1 commit
-
-
Sathya Gunasekaran authored
Previously, Intl.PluralRules was mostly implemented in JavaScript. This patch moves most of the constructor and parts of other methods to C++. The size of the Intl.PluralRules object is reduced by not storing MinimumIntegerDigits, MinimumFractionDigits, MaximumFractionDigits, MinimumSignificantDigits, MaximumSignificantDigits. Instead these are looked up from icu::DecimalFormat as required. Another optimziation is that we don't create the result of resolvedOptions when the Intl.PluralRules object is constructed, but instead defer until this method is called. In the future, we may want to cache the result. This patch also cleans up several error handling paths that shouldn't happen with ICU and instead just crashes should it ever happen. Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I84c5aa6c25c35fe2d336693dee1b36bf3dcd4a79 Reviewed-on: https://chromium-review.googlesource.com/1158701 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Jungshik Shin <jshin@chromium.org> Reviewed-by: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#54917}
-