Commit 42f17e7d authored by Frank Tang's avatar Frank Tang Committed by Commit Bot

[Intl] Make Initialize functions name consistent

Make Initialize functions name consistent for Intl.*

Bug: v8:5751
Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
Change-Id: If4736007fc8f048a087469acc5d968e6ece289ce
Reviewed-on: https://chromium-review.googlesource.com/c/1261644Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
Commit-Queue: Frank Tang <ftang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56390}
parent e3f40ad2
...@@ -529,8 +529,8 @@ BUILTIN(ListFormatConstructor) { ...@@ -529,8 +529,8 @@ BUILTIN(ListFormatConstructor) {
Handle<Object> options = args.atOrUndefined(isolate, 2); Handle<Object> options = args.atOrUndefined(isolate, 2);
// 3. Return InitializeListFormat(listFormat, locales, options). // 3. Return InitializeListFormat(listFormat, locales, options).
RETURN_RESULT_OR_FAILURE(isolate, JSListFormat::InitializeListFormat( RETURN_RESULT_OR_FAILURE(
isolate, format, locales, options)); isolate, JSListFormat::Initialize(isolate, format, locales, options));
} }
BUILTIN(ListFormatPrototypeResolvedOptions) { BUILTIN(ListFormatPrototypeResolvedOptions) {
...@@ -582,8 +582,8 @@ MaybeHandle<JSLocale> CreateLocale(Isolate* isolate, ...@@ -582,8 +582,8 @@ MaybeHandle<JSLocale> CreateLocale(Isolate* isolate,
Object::ToObject(isolate, options), JSLocale); Object::ToObject(isolate, options), JSLocale);
} }
return JSLocale::InitializeLocale(isolate, Handle<JSLocale>::cast(result), return JSLocale::Initialize(isolate, Handle<JSLocale>::cast(result),
locale_string, options_object); locale_string, options_object);
} }
} // namespace } // namespace
...@@ -784,9 +784,8 @@ BUILTIN(RelativeTimeFormatConstructor) { ...@@ -784,9 +784,8 @@ BUILTIN(RelativeTimeFormatConstructor) {
// 3. Return ? InitializeRelativeTimeFormat(relativeTimeFormat, locales, // 3. Return ? InitializeRelativeTimeFormat(relativeTimeFormat, locales,
// options). // options).
RETURN_RESULT_OR_FAILURE(isolate, RETURN_RESULT_OR_FAILURE(isolate, JSRelativeTimeFormat::Initialize(
JSRelativeTimeFormat::InitializeRelativeTimeFormat( isolate, format, locales, options));
isolate, format, locales, options));
} }
BUILTIN(RelativeTimeFormatPrototypeResolvedOptions) { BUILTIN(RelativeTimeFormatPrototypeResolvedOptions) {
...@@ -854,8 +853,8 @@ BUILTIN(PluralRulesConstructor) { ...@@ -854,8 +853,8 @@ BUILTIN(PluralRulesConstructor) {
// 3. Return ? InitializePluralRules(pluralRules, locales, options). // 3. Return ? InitializePluralRules(pluralRules, locales, options).
RETURN_RESULT_OR_FAILURE( RETURN_RESULT_OR_FAILURE(
isolate, JSPluralRules::InitializePluralRules(isolate, plural_rules, isolate,
locales, options)); JSPluralRules::Initialize(isolate, plural_rules, locales, options));
} }
BUILTIN(PluralRulesPrototypeResolvedOptions) { BUILTIN(PluralRulesPrototypeResolvedOptions) {
...@@ -921,8 +920,8 @@ BUILTIN(CollatorConstructor) { ...@@ -921,8 +920,8 @@ BUILTIN(CollatorConstructor) {
Handle<JSCollator> collator = Handle<JSCollator>::cast(collator_obj); Handle<JSCollator> collator = Handle<JSCollator>::cast(collator_obj);
// 6. Return ? InitializeCollator(collator, locales, options). // 6. Return ? InitializeCollator(collator, locales, options).
RETURN_RESULT_OR_FAILURE(isolate, JSCollator::InitializeCollator( RETURN_RESULT_OR_FAILURE(
isolate, collator, locales, options)); isolate, JSCollator::Initialize(isolate, collator, locales, options));
} }
BUILTIN(CollatorPrototypeResolvedOptions) { BUILTIN(CollatorPrototypeResolvedOptions) {
...@@ -1019,9 +1018,9 @@ BUILTIN(V8BreakIteratorConstructor) { ...@@ -1019,9 +1018,9 @@ BUILTIN(V8BreakIteratorConstructor) {
Handle<JSV8BreakIterator> break_iterator = Handle<JSV8BreakIterator> break_iterator =
Handle<JSV8BreakIterator>::cast(break_iterator_obj); Handle<JSV8BreakIterator>::cast(break_iterator_obj);
RETURN_RESULT_OR_FAILURE(isolate, RETURN_RESULT_OR_FAILURE(
JSV8BreakIterator::InitializeV8BreakIterator( isolate,
isolate, break_iterator, locales, options)); JSV8BreakIterator::Initialize(isolate, break_iterator, locales, options));
} }
BUILTIN(V8BreakIteratorPrototypeResolvedOptions) { BUILTIN(V8BreakIteratorPrototypeResolvedOptions) {
......
...@@ -1939,7 +1939,7 @@ void JSNumberFormat::JSNumberFormatVerify(Isolate* isolate) { ...@@ -1939,7 +1939,7 @@ void JSNumberFormat::JSNumberFormatVerify(Isolate* isolate) {
CHECK(IsJSNumberFormat()); CHECK(IsJSNumberFormat());
JSObjectVerify(isolate); JSObjectVerify(isolate);
VerifyObjectField(isolate, kLocaleOffset); VerifyObjectField(isolate, kLocaleOffset);
VerifyObjectField(isolate, kIcuNumberFormatOffset); VerifyObjectField(isolate, kICUNumberFormatOffset);
VerifyObjectField(isolate, kBoundFormatOffset); VerifyObjectField(isolate, kBoundFormatOffset);
VerifyObjectField(isolate, kFlagsOffset); VerifyObjectField(isolate, kFlagsOffset);
} }
......
...@@ -24,7 +24,7 @@ JSV8BreakIterator::Type JSV8BreakIterator::getType(const char* str) { ...@@ -24,7 +24,7 @@ JSV8BreakIterator::Type JSV8BreakIterator::getType(const char* str) {
UNREACHABLE(); UNREACHABLE();
} }
MaybeHandle<JSV8BreakIterator> JSV8BreakIterator::InitializeV8BreakIterator( MaybeHandle<JSV8BreakIterator> JSV8BreakIterator::Initialize(
Isolate* isolate, Handle<JSV8BreakIterator> break_iterator_holder, Isolate* isolate, Handle<JSV8BreakIterator> break_iterator_holder,
Handle<Object> locales, Handle<Object> options_obj) { Handle<Object> locales, Handle<Object> options_obj) {
Factory* factory = isolate->factory(); Factory* factory = isolate->factory();
......
...@@ -25,11 +25,9 @@ namespace internal { ...@@ -25,11 +25,9 @@ namespace internal {
class JSV8BreakIterator : public JSObject { class JSV8BreakIterator : public JSObject {
public: public:
V8_WARN_UNUSED_RESULT static MaybeHandle<JSV8BreakIterator> V8_WARN_UNUSED_RESULT static MaybeHandle<JSV8BreakIterator> Initialize(
InitializeV8BreakIterator(Isolate* isolate, Isolate* isolate, Handle<JSV8BreakIterator> break_iterator_holder,
Handle<JSV8BreakIterator> break_iterator_holder, Handle<Object> input_locales, Handle<Object> input_options);
Handle<Object> input_locales,
Handle<Object> input_options);
static Handle<JSObject> ResolvedOptions( static Handle<JSObject> ResolvedOptions(
Isolate* isolate, Handle<JSV8BreakIterator> break_iterator); Isolate* isolate, Handle<JSV8BreakIterator> break_iterator);
......
...@@ -217,9 +217,10 @@ void SetCaseFirstOption(icu::Collator* icu_collator, const char* value) { ...@@ -217,9 +217,10 @@ void SetCaseFirstOption(icu::Collator* icu_collator, const char* value) {
} // anonymous namespace } // anonymous namespace
// static // static
MaybeHandle<JSCollator> JSCollator::InitializeCollator( MaybeHandle<JSCollator> JSCollator::Initialize(Isolate* isolate,
Isolate* isolate, Handle<JSCollator> collator, Handle<Object> locales, Handle<JSCollator> collator,
Handle<Object> options_obj) { Handle<Object> locales,
Handle<Object> options_obj) {
// 1. Let requestedLocales be ? CanonicalizeLocaleList(locales). // 1. Let requestedLocales be ? CanonicalizeLocaleList(locales).
Handle<JSObject> requested_locales; Handle<JSObject> requested_locales;
ASSIGN_RETURN_ON_EXCEPTION(isolate, requested_locales, ASSIGN_RETURN_ON_EXCEPTION(isolate, requested_locales,
......
...@@ -28,7 +28,7 @@ namespace internal { ...@@ -28,7 +28,7 @@ namespace internal {
class JSCollator : public JSObject { class JSCollator : public JSObject {
public: public:
// ecma402/#sec-initializecollator // ecma402/#sec-initializecollator
V8_WARN_UNUSED_RESULT static MaybeHandle<JSCollator> InitializeCollator( V8_WARN_UNUSED_RESULT static MaybeHandle<JSCollator> Initialize(
Isolate* isolate, Handle<JSCollator> collator, Handle<Object> locales, Isolate* isolate, Handle<JSCollator> collator, Handle<Object> locales,
Handle<Object> options); Handle<Object> options);
......
...@@ -119,7 +119,7 @@ JSListFormat::Type get_type(const char* str) { ...@@ -119,7 +119,7 @@ JSListFormat::Type get_type(const char* str) {
UNREACHABLE(); UNREACHABLE();
} }
MaybeHandle<JSListFormat> JSListFormat::InitializeListFormat( MaybeHandle<JSListFormat> JSListFormat::Initialize(
Isolate* isolate, Handle<JSListFormat> list_format_holder, Isolate* isolate, Handle<JSListFormat> list_format_holder,
Handle<Object> input_locales, Handle<Object> input_options) { Handle<Object> input_locales, Handle<Object> input_options) {
Factory* factory = isolate->factory(); Factory* factory = isolate->factory();
......
...@@ -29,7 +29,7 @@ class JSListFormat : public JSObject { ...@@ -29,7 +29,7 @@ class JSListFormat : public JSObject {
public: public:
// Initializes relative time format object with properties derived from input // Initializes relative time format object with properties derived from input
// locales and options. // locales and options.
static MaybeHandle<JSListFormat> InitializeListFormat( static MaybeHandle<JSListFormat> Initialize(
Isolate* isolate, Handle<JSListFormat> list_format_holder, Isolate* isolate, Handle<JSListFormat> list_format_holder,
Handle<Object> locales, Handle<Object> options); Handle<Object> locales, Handle<Object> options);
......
...@@ -163,10 +163,10 @@ bool PopulateLocaleWithUnicodeTags(Isolate* isolate, const char* icu_locale, ...@@ -163,10 +163,10 @@ bool PopulateLocaleWithUnicodeTags(Isolate* isolate, const char* icu_locale,
} }
} // namespace } // namespace
MaybeHandle<JSLocale> JSLocale::InitializeLocale(Isolate* isolate, MaybeHandle<JSLocale> JSLocale::Initialize(Isolate* isolate,
Handle<JSLocale> locale_holder, Handle<JSLocale> locale_holder,
Handle<String> locale, Handle<String> locale,
Handle<JSReceiver> options) { Handle<JSReceiver> options) {
static const char* const kMethod = "Intl.Locale"; static const char* const kMethod = "Intl.Locale";
v8::Isolate* v8_isolate = reinterpret_cast<v8::Isolate*>(isolate); v8::Isolate* v8_isolate = reinterpret_cast<v8::Isolate*>(isolate);
UErrorCode status = U_ZERO_ERROR; UErrorCode status = U_ZERO_ERROR;
......
...@@ -25,10 +25,10 @@ class JSLocale : public JSObject { ...@@ -25,10 +25,10 @@ class JSLocale : public JSObject {
public: public:
// Initializes locale object with properties derived from input locale string // Initializes locale object with properties derived from input locale string
// and options. // and options.
static MaybeHandle<JSLocale> InitializeLocale(Isolate* isolate, static MaybeHandle<JSLocale> Initialize(Isolate* isolate,
Handle<JSLocale> locale_holder, Handle<JSLocale> locale_holder,
Handle<String> locale, Handle<String> locale,
Handle<JSReceiver> options); Handle<JSReceiver> options);
static Handle<String> Maximize(Isolate* isolate, String* locale); static Handle<String> Maximize(Isolate* isolate, String* locale);
static Handle<String> Minimize(Isolate* isolate, String* locale); static Handle<String> Minimize(Isolate* isolate, String* locale);
......
...@@ -20,7 +20,7 @@ namespace internal { ...@@ -20,7 +20,7 @@ namespace internal {
ACCESSORS(JSNumberFormat, locale, String, kLocaleOffset) ACCESSORS(JSNumberFormat, locale, String, kLocaleOffset)
ACCESSORS(JSNumberFormat, icu_number_format, Managed<icu::NumberFormat>, ACCESSORS(JSNumberFormat, icu_number_format, Managed<icu::NumberFormat>,
kIcuNumberFormatOffset) kICUNumberFormatOffset)
ACCESSORS(JSNumberFormat, bound_format, Object, kBoundFormatOffset) ACCESSORS(JSNumberFormat, bound_format, Object, kBoundFormatOffset)
SMI_ACCESSORS(JSNumberFormat, flags, kFlagsOffset) SMI_ACCESSORS(JSNumberFormat, flags, kFlagsOffset)
......
...@@ -80,7 +80,7 @@ class JSNumberFormat : public JSObject { ...@@ -80,7 +80,7 @@ class JSNumberFormat : public JSObject {
// Layout description. // Layout description.
#define JS_NUMBER_FORMAT_FIELDS(V) \ #define JS_NUMBER_FORMAT_FIELDS(V) \
V(kLocaleOffset, kPointerSize) \ V(kLocaleOffset, kPointerSize) \
V(kIcuNumberFormatOffset, kPointerSize) \ V(kICUNumberFormatOffset, kPointerSize) \
V(kBoundFormatOffset, kPointerSize) \ V(kBoundFormatOffset, kPointerSize) \
V(kFlagsOffset, kPointerSize) \ V(kFlagsOffset, kPointerSize) \
/* Total size. */ \ /* Total size. */ \
......
...@@ -85,7 +85,7 @@ void InitializeICUPluralRules( ...@@ -85,7 +85,7 @@ void InitializeICUPluralRules(
} // namespace } // namespace
// static // static
MaybeHandle<JSPluralRules> JSPluralRules::InitializePluralRules( MaybeHandle<JSPluralRules> JSPluralRules::Initialize(
Isolate* isolate, Handle<JSPluralRules> plural_rules, Isolate* isolate, Handle<JSPluralRules> plural_rules,
Handle<Object> locales, Handle<Object> options_obj) { Handle<Object> locales, Handle<Object> options_obj) {
// 1. Let requestedLocales be ? CanonicalizeLocaleList(locales). // 1. Let requestedLocales be ? CanonicalizeLocaleList(locales).
......
...@@ -27,7 +27,7 @@ namespace internal { ...@@ -27,7 +27,7 @@ namespace internal {
class JSPluralRules : public JSObject { class JSPluralRules : public JSObject {
public: public:
V8_WARN_UNUSED_RESULT static MaybeHandle<JSPluralRules> InitializePluralRules( V8_WARN_UNUSED_RESULT static MaybeHandle<JSPluralRules> Initialize(
Isolate* isolate, Handle<JSPluralRules> plural_rules, Isolate* isolate, Handle<JSPluralRules> plural_rules,
Handle<Object> locales, Handle<Object> options); Handle<Object> locales, Handle<Object> options);
......
...@@ -54,8 +54,7 @@ JSRelativeTimeFormat::Numeric JSRelativeTimeFormat::getNumeric( ...@@ -54,8 +54,7 @@ JSRelativeTimeFormat::Numeric JSRelativeTimeFormat::getNumeric(
UNREACHABLE(); UNREACHABLE();
} }
MaybeHandle<JSRelativeTimeFormat> MaybeHandle<JSRelativeTimeFormat> JSRelativeTimeFormat::Initialize(
JSRelativeTimeFormat::InitializeRelativeTimeFormat(
Isolate* isolate, Handle<JSRelativeTimeFormat> relative_time_format_holder, Isolate* isolate, Handle<JSRelativeTimeFormat> relative_time_format_holder,
Handle<Object> input_locales, Handle<Object> input_options) { Handle<Object> input_locales, Handle<Object> input_options) {
Factory* factory = isolate->factory(); Factory* factory = isolate->factory();
......
...@@ -29,8 +29,7 @@ class JSRelativeTimeFormat : public JSObject { ...@@ -29,8 +29,7 @@ class JSRelativeTimeFormat : public JSObject {
public: public:
// Initializes relative time format object with properties derived from input // Initializes relative time format object with properties derived from input
// locales and options. // locales and options.
V8_WARN_UNUSED_RESULT static MaybeHandle<JSRelativeTimeFormat> V8_WARN_UNUSED_RESULT static MaybeHandle<JSRelativeTimeFormat> Initialize(
InitializeRelativeTimeFormat(
Isolate* isolate, Isolate* isolate,
Handle<JSRelativeTimeFormat> relative_time_format_holder, Handle<JSRelativeTimeFormat> relative_time_format_holder,
Handle<Object> locales, Handle<Object> options); Handle<Object> locales, Handle<Object> options);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment