- 09 May, 2016 9 commits
-
-
mstarzinger authored
The flag in question used to fall-back to Crankshaft whenever an OSR request couldn't be handled by TurboFan. By now OSR in TurboFan is sufficiently stabilized that one single --use-osr flag should do it. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/1960043002 Cr-Commit-Position: refs/heads/master@{#36102}
-
ishell authored
BUG=chromium:610207 LOG=N Review-Url: https://codereview.chromium.org/1958043002 Cr-Commit-Position: refs/heads/master@{#36101}
-
titzer authored
R=ahaas@chromium.org,clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/1962553002 Cr-Commit-Position: refs/heads/master@{#36100}
-
zhengxing.li authored
The CL #35926 (https://codereview.chromium.org/1804003002) exposed two hidden bugs in x87 code generation when Ignition was enabled. This CL fixed those bugs. BUG= Review-Url: https://codereview.chromium.org/1960993002 Cr-Commit-Position: refs/heads/master@{#36099}
-
mythria authored
mjsunit/es6/mirror-collections fails with ignition because dead registers may hold references to objects. This prevents GC from collecting otherwise dead objects. Dead registers are not cleared because the cost of clearing them outweighs its benefits. Hence, modifying this test to work around this problem. BUG=v8:4280,v8:4853 LOG=N Review-Url: https://codereview.chromium.org/1945223002 Cr-Commit-Position: refs/heads/master@{#36098}
-
nikolaos authored
RuntimeCallTimers were not properly stopped and this made a DCHECK in the Debug version fail. R=cbruni@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/1955943002 Cr-Commit-Position: refs/heads/master@{#36097}
-
hablich authored
Revert of Add GN targets for samples (patchset #1 id:1 of https://codereview.chromium.org/1955723003/ ) Reason for revert: Blocks roll: https://codereview.chromium.org/1956223002/ Original issue's description: > Add GN targets for samples > > BUG=chromium:609107 > R=machenbach@chromium.org > LOG=n > > Committed: https://crrev.com/19a8e09cc0bafa5071c52243234bfc8512210065 > Cr-Commit-Position: refs/heads/master@{#36072} TBR=machenbach@chromium.org,jochen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:609107 LOG=n Review-Url: https://codereview.chromium.org/1955353002 Cr-Commit-Position: refs/heads/master@{#36096}
-
ulan authored
Handles of this type are automatically reset by the garbage collector when their objects are not longer reachable. The motivation is to reduce pause time of external.weak_global_handles phase of the garbage collector by not maintaing the list of pending callbacks and not calling the callbacks. Local testing on discourse page of the v8.inifinite_scroll benchmark shows 7x improvement for this GC phase. Before: external.weak_global_handles len: 21 min: 0.0 max: 4.5 avg: 0.757142857143 After: external.weak_global_handles len: 21 min: 0.0 max: 0.5 avg: 0.109523809524 A follow-up patch will enable the new phantom handles in Chromium. BUG=chromium:608333 LOG=NO Review-Url: https://codereview.chromium.org/1950963002 Cr-Commit-Position: refs/heads/master@{#36095}
-
zhengxing.li authored
X87: Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ). port 3b7ff999 (r36066) original commit message: Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} BUG= Review-Url: https://codereview.chromium.org/1958863003 Cr-Commit-Position: refs/heads/master@{#36094}
-
- 08 May, 2016 1 commit
-
-
v8-autoroll authored
Rolling v8/build to e3d87b142123f2da73c94c276ee915c099afe909 Rolling v8/tools/clang to 15dd77e3ea10e43596ec6ac07b73431135915b30 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1961713002 Cr-Commit-Position: refs/heads/master@{#36093}
-
- 07 May, 2016 2 commits
-
-
v8-autoroll authored
Rolling v8/build to b81f2a05b5aa7f5b6cf843380eb276897b1ef626 Rolling v8/tools/clang to afdc842603935f994788bf2388e1155528448b2a TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/1961653002 Cr-Commit-Position: refs/heads/master@{#36092}
-
jwolfe authored
Add comments explaining how to iterate over an OrderedHashTable. Use the correct strategy for iteration in Set::AsArray(). Add a DCHECK bounds check in OrderedHashTable::KeyAt(). BUG=v8:4946 LOG=y Review-Url: https://codereview.chromium.org/1952093002 Cr-Commit-Position: refs/heads/master@{#36091}
-
- 06 May, 2016 28 commits
-
-
akos.palfi authored
Port c2de9611 Fixes an infinite loop on MIPS64 big-endian. BUG= Review-Url: https://codereview.chromium.org/1959463003 Cr-Commit-Position: refs/heads/master@{#36090}
-
adamk authored
No bugs found, but the additional coverage of arrows as default param initializers in a generator param list seems good to have. R=littledan@chromium.org Review-Url: https://codereview.chromium.org/1949293002 Cr-Commit-Position: refs/heads/master@{#36089}
-
lpy authored
Currently we have Time and TimeTicks sharing some methods. This patch creates TimeBase, and makes Time and TimeTicks inherits from it, so that time related classes won't have to implement common methods and it's easier to introduce new time related classes. BUG=v8:4990 LOG=n Review-Url: https://codereview.chromium.org/1952843002 Cr-Commit-Position: refs/heads/master@{#36088}
-
jkummerow authored
This ports https://codereview.chromium.org/1323293005 to V8. I'm not aware of any evidence that such crashes are currently happening, but it's probably good to ship this workaround anyway. BUG=chromium:517681 LOG=n Review-Url: https://codereview.chromium.org/1959643002 Cr-Commit-Position: refs/heads/master@{#36087}
-
titzer authored
R=clemensh@chromium.org BUG= Review-Url: https://codereview.chromium.org/1956703002 Cr-Commit-Position: refs/heads/master@{#36086}
-
alph authored
Review-Url: https://codereview.chromium.org/1952753003 Cr-Commit-Position: refs/heads/master@{#36085}
-
jochen authored
They're always in sloppy mode, so always do the conversion BUG=chromium:609134 R=bmeurer@chromium.org,verwaest@chromium.org LOG=n Review-Url: https://codereview.chromium.org/1960663002 Cr-Commit-Position: refs/heads/master@{#36084}
-
rmcilroy authored
Some tests which fail with '--ignition --turbo --turbo-from-bytecode' pass with just '--ignition'. Unskip these tests. Also group other tests with related bugs. BUG=v8:4680 LOG=N Review-Url: https://codereview.chromium.org/1944413002 Cr-Commit-Position: refs/heads/master@{#36083}
-
mbrandy authored
R=titzer@chromium.org, ahaas@chromium.org, michael_dawson@ca.ibm.com BUG= Review-Url: https://codereview.chromium.org/1948053002 Cr-Commit-Position: refs/heads/master@{#36082}
-
akos.palfi authored
MIPS: Add new relocation type WASM_MEMORY_SIZE_REFERENCE, use relocatable pointers to update wasm memory size references in generated code. Port 117a56b7 BUG= Review-Url: https://codereview.chromium.org/1959653002 Cr-Commit-Position: refs/heads/master@{#36081}
-
cbruni authored
callstats.html in combination with callstats.py can be used to get an in-depth view on where we spend time in v8. Furthermore, with callstats.html we can compare different versions of v8/chrome and see where and how performnce evolved. Drive-by-fix: add missing copyrights header to ic-explorer.html and format ic-explorer.html BUG= Review-Url: https://codereview.chromium.org/1947413004 Cr-Commit-Position: refs/heads/master@{#36080}
-
ulan authored
This removes: - PersistentBase::SetWeak that takes WeakCallbackData. The embedders should use the version that takes WeakCallbackInfo. - PersistentBase::SetPhantom. The embedders should SetWeak that takes WeakCallbackInfo. Functions in DefaultPersistentValueMapTraits are changed to accept WeakCallbackInfo instead of WeakCallbackData. BUG=chromium:609808 LOG=NO Review-Url: https://codereview.chromium.org/1953263002 Cr-Commit-Position: refs/heads/master@{#36079}
-
jochen authored
We just deleted a persistent the line before, so make sure the context is cleared up before disposing the isolate R=ulan@chromium.org BUG= Review-Url: https://codereview.chromium.org/1953253003 Cr-Commit-Position: refs/heads/master@{#36078}
-
ulan authored
BUG=chromium:609808 LOG=NO Review-Url: https://codereview.chromium.org/1954033002 Cr-Commit-Position: refs/heads/master@{#36077}
-
mattloring authored
Hydrogen logs are ambiguous if multiple functions share the same name. This change adds file names to this output. Functions are now named <file_name>:<function_name> to reduce this ambiguity. R=ofrobots@google.com BUG= Review-Url: https://codereview.chromium.org/1913973004 Cr-Commit-Position: refs/heads/master@{#36076}
-
ishell authored
Deoptimizer is now able to reconstruct topmost accessor and constructor frames. BUG=chromium:608278, v8:4698 LOG=N TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1936043002 Cr-Commit-Position: refs/heads/master@{#36075}
-
ulan authored
BUG=chromium:609808 LOG=NO Review-Url: https://codereview.chromium.org/1949393006 Cr-Commit-Position: refs/heads/master@{#36074}
-
cbruni authored
- Cleanup CL to remove unused parameters in elements.cc. Additionally use fields from the KeyAccumulator wherever possible. - Make method names in KeyAccumulator more consistent BUG= Review-Url: https://codereview.chromium.org/1944703002 Cr-Commit-Position: refs/heads/master@{#36073}
-
jochen authored
BUG=chromium:609107 R=machenbach@chromium.org LOG=n Review-Url: https://codereview.chromium.org/1955723003 Cr-Commit-Position: refs/heads/master@{#36072}
-
jkummerow authored
Because not initializing fields can be, you know, dangerous. Review-Url: https://codereview.chromium.org/1952703002 Cr-Commit-Position: refs/heads/master@{#36071}
-
nikolaos authored
R=cbruni@chromium.org BUG= LOG=N Review-Url: https://codereview.chromium.org/1922873004 Cr-Commit-Position: refs/heads/master@{#36070}
-
mstarzinger authored
R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1945363002 Cr-Commit-Position: refs/heads/master@{#36069}
-
mstarzinger authored
This moves all the machinery for tracing inlined function that is specific to Crankshaft into the appropriate component. Only the old side-channel via a list of InlinedFunctionInfo structs remained within the CompilationInfo for now. In the long run we will reconstruct that information from the deoptimization data on the code objects. R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/1944323002 Cr-Commit-Position: refs/heads/master@{#36068}
-
clemensh authored
This changes different locations to extract the reference to the wasm object and the function index from the stack trace, and make it available through all the APIs which process stack traces. The javascript CallSite object now has the new methods isWasm(), getWasmObject() and getWasmFunctionIndex(); the byte offset is available via getPosition(). Function names of wasm frames should be fully functional with this commit, position information works reliably for calls, but not for traps like unreachable or out-of-bounds accesses. R=titzer@chromium.org, yangguo@chromium.org Review-Url: https://codereview.chromium.org/1909353002 Cr-Commit-Position: refs/heads/master@{#36067}
-
titzer authored
Revert of [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. (patchset #2 id:20001 of https://codereview.chromium.org/1948453002/ ) Reason for revert: Breaks WASM; please also add tests when relanding. Original issue's description: > [turbofan] Take the immediate size in account when narrowing ia32/x64 word comparison operators. > > Before this patch, we would emit a cmp or test with a memory operand only if both of the operands in the IR were loads. Now if either of them is a load and the other one is an immediate, we can use a memory operand if the load representation machine size is wide enough to represent the latter. > > Committed: https://crrev.com/a0543313dbd46b0c2e72c91ee3488a7dc6db73e4 > Cr-Commit-Position: refs/heads/master@{#36009} TBR=bmeurer@chromium.org,jfb@chromium.org,epertoso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Review-Url: https://codereview.chromium.org/1959603002 Cr-Commit-Position: refs/heads/master@{#36066}
-
machenbach authored
BUG=v8:4280 LOG=N NOTRY=true TBR=rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/1956663002 Cr-Commit-Position: refs/heads/master@{#36065}
-
machenbach authored
BUG=v8:4995 LOG=n NOTRY=true TBR=thakis@chromium.org, titzer@chromium.org Review-Url: https://codereview.chromium.org/1955013002 Cr-Commit-Position: refs/heads/master@{#36064}
-
bmeurer authored
This operator was initially designed to handle arbitrary effect merging for effect relaxation, but we don't do that (at least currently). So no need to keep the dead operator around. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/1954983002 Cr-Commit-Position: refs/heads/master@{#36063}
-