- 17 Jan, 2018 23 commits
-
-
Clemens Hammacher authored
For memory tracing, output a 'T' for Turbofan code and an 'L' for Liftoff code. To do this, the WasmCodeWrapper now has some dispatch functions which work for both on-the-heap and off-the-heap code. We can probably refactor more code by having this mechanism. Since the output of --wasm-trace-memory differs now between Turbofan and Liftoff, the message test is split in two. R=titzer@chromium.org CC=mstarzinger@chromium.org Bug: v8:6600 Change-Id: Ic5fd18c631f5c8aaad19d639df75b18098895b5a Reviewed-on: https://chromium-review.googlesource.com/868214Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50655}
-
Ulan Degenbaev authored
This is a workaround for false positive race reported by TSAN. Bug: v8:7315 Change-Id: I55712010dc5386a58b5ef7d48043e474f4b89bb9 Reviewed-on: https://chromium-review.googlesource.com/869672Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#50654}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I54f908609fadd88bb23bf9fc566d1e2f3ff5e18e Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/870353 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#50653}
-
Clemens Hammacher authored
This adds support for tracing memory operations in code compiled with Liftoff. This is the first runtime call we emit from Liftoff code, so part of this code can be reused for other runtime calls. Drive-by: Reuse outer compilation zone (avoid one Zone allocation). Bug: v8:6600, v8:7210 Change-Id: I8b22088d0685338d533d328cb371384210e0ed22 Reviewed-on: https://chromium-review.googlesource.com/864663Reviewed-by:
-
peterwmwong authored
Bug: v8:7239 Change-Id: I25d2926a974bdb99a45fe4df79c6a62a363f67cf Reviewed-on: https://chromium-review.googlesource.com/867237Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#50651}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I1a355bdfe3f873091a7d7c32a937a533a7d8b3d4 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/867053 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I14c7e0a140bfe828ee8199606db36cab12be14ff Reviewed-on: https://chromium-review.googlesource.com/868135 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: v8:7266 Change-Id: I4a8b8a799d08834675522e9c1dde9ff90f9fc14e Reviewed-on: https://chromium-review.googlesource.com/870034Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50648}
-
Michal Majewski authored
Bug: v8:6917 Change-Id: I0ee15a41b6028bdbf8448f066b0bc47a049ca587 Reviewed-on: https://chromium-review.googlesource.com/868154Reviewed-by:
-
Michal Majewski authored
Bug: v8:6917 Change-Id: If9c097548a5879d693174c73e9952db7b25ef2e7 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/868437Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
-
Dan Elphick authored
Assembler::PopAndReturn expects an Integral type so convert argc from a SMI if necessary. On 64-bit architectures, convert 64-bit immediate pop values into 32-bit values. This is safe since the conversion checks that nothing was truncated. Also change CodeStubArguments unit tests to use PopAndReturn rather than Return. Change-Id: I91b47d2e81dc0504d185ad59752d638b1c3135a7 Reviewed-on: https://chromium-review.googlesource.com/867052Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#50645}
-
Clemens Hammacher authored
The method {SpillAllRegisters} should really just spill registers, and not also constants. Also, since more code is inlined into that method now, we can optimize it to update register use counters only once in the end, since no used register should be left after executing this method. R=titzer@chromium.org Bug: v8:6600, chromium:802244 Change-Id: I737a1a87f8e912151062224952c4f5dffd43f802 Reviewed-on: https://chromium-review.googlesource.com/868022Reviewed-by: -
Andreas Haas authored
This is the implementation of crrev.com/c/866721 for ia32. Drive-by change: Clean up the slot index calculation. At the moment the slot index is encoded in the opcode. This, however, sets an upper limit the slot index which is lower than what we want to have (i.e. < 512). With this change we pass the slot index as an immediate operand, which does not impose limits on the value it contains. R=titzer@chromium.org Change-Id: I40adf8c6e62de28f8428492db6c5297252c1e2d1 Reviewed-on: https://chromium-review.googlesource.com/864642Reviewed-by:
-
Michal Majewski authored
Since test processors create tests dynamically we cannot simply count how many tests will be run. Instead we count only base tests that we've loaded, before creating variants. Bug: v8:6917 Change-Id: Ibc5b9a73f6afad423572afa575f477ca661a99d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_fyi_rel_ng Reviewed-on: https://chromium-review.googlesource.com/868290 Commit-Queue: Michał Majewski <majeski@google.com> Reviewed-by:
-
Ali Ijaz Sheikh authored
Incremental marking job and concurrent marking tasks may be triggered during heap tear down. The task scheduler may already be torn down at this point. Avoid scheduling new tasks if tasks are disabled. Bug: v8:7238 Change-Id: I3869a20dc8b4f38b26754872448952a9aadb6bd9 Reviewed-on: https://chromium-review.googlesource.com/868825Reviewed-by:
-
Marja Hölttä authored
They were in the wrong order in PreParser, which caused problem for "function arguments() { ... }". BUG=chromium:801772 Change-Id: Ia04c8c8c0a5d641fd1db0746dc3312c83ebcaf24 Reviewed-on: https://chromium-review.googlesource.com/865900Reviewed-by:Adam Klein <adamk@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#50640}
-
Benedikt Meurer authored
These operations don't need to access per-native context data and cannot throw exceptions. Bug: v8:5268, v8:5269 Change-Id: Id7fdbee2b39f96717de83b3cef5ab789424f8338 Reviewed-on: https://chromium-review.googlesource.com/779142 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Yang Guo authored
Bug: v8:6105 Change-Id: Idfc10bdab9c69d2d5f751197e3df068406bd521a Reviewed-on: https://chromium-review.googlesource.com/868131 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Qingyan Li authored
There maybe one more ScriptContext in script_context_table if mksnapshot executed with embeded script. R=yangguo@chromium.org Bug: v8:7304 Change-Id: I6f431f76d4beae61a519c3acc3b856d1f7479740 Reviewed-on: https://chromium-review.googlesource.com/866630Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50637}
-
Benedikt Meurer authored
This adds a new simplified operator NumberToString, which just lowers to a call to the NumberToString builtin, and hooks that up to the typed lowering (addressing a long-standing TODO). Drive-by-fix: Also remove the %NumberToString runtime entry, and just always use the %NumberToStringSkipCache entry from CSA, since we only go there if the cache lookup already failed. Bug: v8:5267, v8:7109 Change-Id: I5ca698c98679653813088a404f1fd38903a73c0e Reviewed-on: https://chromium-review.googlesource.com/779099 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#50636}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/cd91c99..b3a78cd Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/7854862..b4826a5 Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/f3d25bc..c8ca296 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I0f5539c41e801702608498b2b1ef943bd3653cc6 Reviewed-on: https://chromium-review.googlesource.com/869392Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50635}
-
jing.bao authored
Also refine SSES128Not Change-Id: Ifb34055ed673e1a0f5842e99b10547b834b0d9d6 Reviewed-on: https://chromium-review.googlesource.com/867520Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
-
Adam Klein authored
Change-Id: I1e386dd23e8e485c670cd31a09ceffe6a75e26c8 Reviewed-on: https://chromium-review.googlesource.com/869115Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50633}
-
- 16 Jan, 2018 17 commits
-
-
Karl Schimpf authored
Adds I32UConvertF32, I32SConvertF64, and I32UConvertF64 instructions. Refactors code to use templates where appropriate, and to use previously committed template function is_inbounds() when appropriate in tests. Bug: v8:7226 Change-Id: I2701e5fd0b21cefa1f285677f20616cfde29ab0d Reviewed-on: https://chromium-review.googlesource.com/862609 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by:
-
Adam Klein authored
Bug: v8:7269, v8:7276, v8:7291, v8:7297, v8:7298 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I20770e049171db158973fab7bc58eb819fe2371c Reviewed-on: https://chromium-review.googlesource.com/865797Reviewed-by:
-
Mostyn Bramley-Moore authored
Bug: chromium:798964 Change-Id: If88093cc1f1c1793be570f37604a03d427821821 Reviewed-on: https://chromium-review.googlesource.com/868159Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: v8:7266 Change-Id: I3e0d95d7c59577941e1154e21949b2714f56f652 Reviewed-on: https://chromium-review.googlesource.com/868292Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50629}
-
Junliang Yan authored
R=titzer@chromium.org, mstarzinger@chromium.org, joransiu@ca.ibm.com, jbarboza@ca.ibm.com Bug: Change-Id: Ie7424ed26464574470ce5ae4184092cf46920da9 Reviewed-on: https://chromium-review.googlesource.com/867550Reviewed-by:
-
Ben L. Titzer authored
The WebAssembly JS API specification [1] covers the JS-visible side-effects of executing a grow_memory operation and states that a successful grow operation should always detach any prior array buffer. [1] https://github.com/WebAssembly/spec/blob/master/document/js-api/index.bs R=mstarzinger@chromium.org,gdeepti@chromium.org Bug: Change-Id: Ib9232e01209ba546c0bba1c9408c92da60ff6d92 Reviewed-on: https://chromium-review.googlesource.com/860011Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50627}
-
Michael Starzinger authored
R=clemensh@chromium.org Change-Id: I49ca12fc882dd19eb26b60ed64a36b023a836702 Reviewed-on: https://chromium-review.googlesource.com/868294Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#50626}
-
Michael Achenbach authored
This is a reland of 96f55796 Original change's description: > [test] Add test runner system tests for flaky tests > > This uses a temporary file in the mocked d8 script to let d8 flip > between FAIL and PASS on rerun. > > This adds a separate test root with dedicated test suite for testing > flakes to no interfere with existing status file configs. > > NOTRY=true > > Bug: v8:6917 > Change-Id: Id43753650195fb74cceb2a3ee9014100cabad546 > Reviewed-on: https://chromium-review.googlesource.com/867917 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50621} TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6917 Change-Id: I4e7bca272dfd8778fbb8d012fcd6fd8406158e43 Reviewed-on: https://chromium-review.googlesource.com/868433Reviewed-by:
-
Michael Achenbach authored
This reverts commit 96f55796. Reason for revert: breaks CI presubmit: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20presubmit/builds/22115 Original change's description: > [test] Add test runner system tests for flaky tests > > This uses a temporary file in the mocked d8 script to let d8 flip > between FAIL and PASS on rerun. > > This adds a separate test root with dedicated test suite for testing > flakes to no interfere with existing status file configs. > > NOTRY=true > > Bug: v8:6917 > Change-Id: Id43753650195fb74cceb2a3ee9014100cabad546 > Reviewed-on: https://chromium-review.googlesource.com/867917 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50621} TBR=machenbach@chromium.org,sergiyb@chromium.org,majeski@google.com Change-Id: I103bf8f0e926a3f56921f14bdd7e875ce839ea71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6917 Reviewed-on: https://chromium-review.googlesource.com/868530Reviewed-by:
-
Clemens Hammacher authored
Both tables are always updated together and are always accessed together. Thus merge them, reducing code complexity, but also code space and overhead for accessing them during runtime. Instead of two weak global handles, we only need one, which also means one less load for each indirect call. Merging them also improves cache locality, since signature and code address are not stored next to each other in memory, so they will very likely end up in the same cache line. R=titzer@chromium.org Change-Id: I862df7de93a98aa602a3895796610c2c520d6f21 Reviewed-on: https://chromium-review.googlesource.com/866868 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Allows reading GC object stats data from an unpacked Chrome trace file. No-try: true Bug: v8:7266 Change-Id: I1b851a5b9c5937bd80ae08129d3daee8b4397500 Reviewed-on: https://chromium-review.googlesource.com/868211Reviewed-by:
-
Michael Achenbach authored
This uses a temporary file in the mocked d8 script to let d8 flip between FAIL and PASS on rerun. This adds a separate test root with dedicated test suite for testing flakes to no interfere with existing status file configs. NOTRY=true Bug: v8:6917 Change-Id: Id43753650195fb74cceb2a3ee9014100cabad546 Reviewed-on: https://chromium-review.googlesource.com/867917 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Mike Stanton authored
We don't currently inline array builtins if we detect any side effects between the load of the receiver map and the call to the builtin. The introduction of a map check allows us to be more permissive. Bug: v8:7250 Change-Id: I6b3f9243f6506eff45c0d727c47a7e8cb8765640 Reviewed-on: https://chromium-review.googlesource.com/849005 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Qingyan Li authored
R=yangguo@chromium.org Bug: v8:7305, v8:5536 Change-Id: I4750cf392dd60880e75e187a9091f62f9292ffe2 Reviewed-on: https://chromium-review.googlesource.com/866631Reviewed-by:
-
Qingyan Li authored
R=yangguo@chromium.org Bug: v8:7306 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I40037ebb66a856b52454c50d17b4c8a51aab7a84 Reviewed-on: https://chromium-review.googlesource.com/866215 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Choongwoo Han authored
If there is no constructor or species updates on Array or TypedArrays, then skip lookups of constructor and species so that we can create a new typed array quickly. This path makes TA.p.slice() 2x faster in fast cases. Bug: chromium:800356, v8:7161 Change-Id: Ied8c90e23ca6708f4a3cec077c1fd733e4a6609e Reviewed-on: https://chromium-review.googlesource.com/859397Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:6105 Change-Id: I15fe26c8546e024794c165affd17ce104ecae4a1 Reviewed-on: https://chromium-review.googlesource.com/867870Reviewed-by:
-
