• Dan Elphick's avatar
    [CSA] Fix CSArguments::PopAndReturn for SMIs · 7fc10cb9
    Dan Elphick authored
    Assembler::PopAndReturn expects an Integral type so convert argc from a
    SMI if necessary.
    
    On 64-bit architectures, convert 64-bit immediate pop values into
    32-bit values. This is safe since the conversion checks that nothing
    was truncated.
    
    Also change CodeStubArguments unit tests to use PopAndReturn rather
    than Return.
    
    Change-Id: I91b47d2e81dc0504d185ad59752d638b1c3135a7
    Reviewed-on: https://chromium-review.googlesource.com/867052Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50645}
    7fc10cb9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...