- 05 Jul, 2021 3 commits
-
-
Clemens Backes authored
This is a three-state field now: kTrapHandler, kExplicitBoundsChecks, kNoBoundsChecks. It is set once based on the flags (--wasm-bounds-checks and --wasm-enforce-bounds-checks) and depending on whether the signal handler for wasm trap handling was installed. All compilation then only uses the field value, and does not need to check any flags any more. R=ahaas@chromium.org Bug: v8:11926 Change-Id: I2c0eb5ecb742ee65d1c10e4dceff7204119dab7c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996191 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#75558}
-
Georg Neis authored
A frame state's outer frame state input can be kDeadValue. A DCHECK did not take that into account. In release builds there was no issue because we branch on the opcode anyways. While fixing this bug, I'm strengthening the FrameState class such that a FrameState node must have a kFrameState operator. I'm also - changing the result type of outer_frame_state() from FrameState to Node* since it may in fact not be a kFrameState; - removing has_outer_frame_state() because I find it unintuitive to have outer_frame_state() return non-NULL even when has_outer_frame_state() would return true. Bug: chromium:1224758 Change-Id: I8ebed75c62e31f7eef71e2941fd18869d8a56af3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001356Reviewed-by: Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75553}
-
Santiago Aboy Solanes authored
Mark: * InternalizedString * String * Symbol * Name Bug: v8:7790 Change-Id: I17463d51ffe8a50711f5b4916c9beb369bac7f38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982480 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75551}
-
- 02 Jul, 2021 7 commits
-
-
Junliang Yan authored
Drive-by: cleanup codegen Change-Id: I343d56c32e81d0c5d40ed53e153c8170441df3e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3003085Reviewed-by: Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/master@{#75540}
-
Ross McIlroy authored
BUG=chromium:1225561 Change-Id: Ia81127e489b6e790d20f73f7a4a047b6808eb81d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001177 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75536}
-
Ross McIlroy authored
Moves back to the same approach as TurboFan of keeping the graph unscheduled during effect control linearization and later backend phases and only scheduling the graph immediately before instruction selection. This gives better code generation, though at a small cost of more background optimization time. BUG=v8:9684 Change-Id: I4fb32b5d332e977ca480ac9cceff955750ddd320 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999091 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75535}
-
Jakob Gruber authored
This is a reland of d3cacbbb Changes: Skipped the test in the 'stress' variant instead. Original change's description: > Reland: ScopeInfo, SharedFunctionInfo never-ever serialized > > This relands squashed CLs: > > 59b9aaf7 > 8f84d0bb > > The revert was at crrev.com/c/2996198. > > Changed: Fixed a test in which bytecode flushing caused a behavioral > change between serialized- and unserialized SFI Refs. The serialized > SFI ref kept bytecode alive while unserialized SFIs allow flushing. > The test was fixed by adding a %PrepareFunctionForOptimization > annotation. > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7790, v8:11939 > Change-Id: I170f8085bd7454a2a5f2bb03c8824e2862857827 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999089 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75504} Bug: v8:7790, v8:11939 Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg_ng Change-Id: I10c3fce3a1e5007b4dadfead2baf1f4434d8880b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2998590 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75531}
-
Milad Fa authored
MemOperand is declared as: ```` MemOperand(Register rx, Register rb, Disp offset = 0); ``` Change-Id: I56b89dec8f206081f08c674fc160b6bc2347877b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001173Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75530}
-
Georg Neis authored
Replace a ZoneUnorderedMap with a ZoneMap in order to avoid non-deterministic iteration order resulting in non-deterministic IR and non-deterministic allocations during code assembly later. The map in question is very small in practice so there should be no performance regression. Bug: v8:11894 Change-Id: Ic961102b45b3df28dafdece0cfb54ff5ef940d56 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3001348Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75529}
-
Milad Fa authored
On PPC we don't have the `ties to even` FP roundings enabled, therefore their equivalent Simd op will never get emitted. Once support is added, the flag needs to be set under `SupportedMachineOperatorFlags` within the instruction selector. Setting this flag affects both the scalar and Simd variants of this op. Change-Id: I7d486def103045d2dee7cb691927feb19c3e5ef4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996747Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75528}
-
- 01 Jul, 2021 7 commits
-
-
Ng Zhi An authored
Small refactoring to use an existing ElementSizeInPointers (which has the same implementation). LinkageLocation::GetSize is now not called anywhere else, so remove it. The instruction selector can then call LinkageLocation::GetSizeInPointers instead of calculating it. Bug: v8:11879 Change-Id: I6f717db1c4047e7847f00cf2bf96c6ec8ea52bda Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997924Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#75520}
-
Maya Lekova authored
This reverts commit d3cacbbb. Reason for revert: Breaks gc stress again - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/34248/overview Original change's description: > Reland: ScopeInfo, SharedFunctionInfo never-ever serialized > > This relands squashed CLs: > > 59b9aaf7 > 8f84d0bb > > The revert was at crrev.com/c/2996198. > > Changed: Fixed a test in which bytecode flushing caused a behavioral > change between serialized- and unserialized SFI Refs. The serialized > SFI ref kept bytecode alive while unserialized SFIs allow flushing. > The test was fixed by adding a %PrepareFunctionForOptimization > annotation. > > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: v8:7790, v8:11939 > Change-Id: I170f8085bd7454a2a5f2bb03c8824e2862857827 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999089 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Auto-Submit: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75504} Bug: v8:7790, v8:11939 Change-Id: Icf8858fda38e4ce28080dc254beb7a42444e9784 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999868 Auto-Submit: Maya Lekova <mslekova@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#75507}
-
Maya Lekova authored
This CL improves setting the javascript_execution_assert on the isolate from generated code by adding a single wrapper function around the fast call creation, along with its setup and teardown. It's a follow-up for https://chromium-review.googlesource.com/c/v8/v8/+/2982998/ Bug: chromium:1218898 Change-Id: I0dc45520aa2a9b60ce03076a495e3f68c05945c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999086Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#75506}
-
Mythri A authored
It is possible that we fallback to GenericLowering for minimorphic property accesses. So handle MinimorphicPropertyAccess in ShouldUseMegamorphicLoadBuiltin. Bug: chromium:1223733 Change-Id: Ia1ba8c8786be91dda841d4138cffe81185c066b0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997104 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75505}
-
Jakob Gruber authored
This relands squashed CLs: 59b9aaf7 8f84d0bb The revert was at crrev.com/c/2996198. Changed: Fixed a test in which bytecode flushing caused a behavioral change between serialized- and unserialized SFI Refs. The serialized SFI ref kept bytecode alive while unserialized SFIs allow flushing. The test was fixed by adding a %PrepareFunctionForOptimization annotation. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790, v8:11939 Change-Id: I170f8085bd7454a2a5f2bb03c8824e2862857827 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999089 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75504}
-
Jakob Gruber authored
Bug: v8:7790, chromium:1225300 Change-Id: I36ae331db0abb072ebc597b4682c3983a00d8a1d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2999084 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75497}
-
Peter Kasting authored
There are still a few cases remaining that seem more controversial; I'll upload those separately. Bug: chromium:1066980 Change-Id: Iabbaf23f9bbe97781857c0c589f2b3db685dfdc2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994804 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#75494}
-
- 30 Jun, 2021 16 commits
-
-
Ng Zhi An authored
Grouping a couple of small, non-functional fixes: - add a comment to GetStackParameterDelta - small typo fixes to a couple of places I saw while reading related code Bug: v8:11879 Change-Id: I8566c9778fd6268b08ea3aefbdaa84ef894bcd35 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2997922Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#75490}
-
Jakob Gruber authored
No longer needed now that the predicate is fixed. Bug: v8:7790,v8:11779 Change-Id: If585c3692aed77659b53f670182129988ba93130 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996193 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#75486}
-
Clemens Backes authored
Those flags are old, not commonly used, and redundant. People usually rely on external tools to disassembly wasm functions or modules. Also, the name is misleading as Wasm is not an AST (any more). R=ahaas@chromium.org Bug: v8:11879 Change-Id: I0f90d142ae4c7c6b7ee6013ea033951aad6bf133 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996194Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75474}
-
Jakob Gruber authored
This reverts: 59b9aaf7 8f84d0bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7790 Change-Id: Ieaca12cad2edcab85517cb4cffb58abb1be50674 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996198 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#75470}
-
Jakob Gruber authored
.. and make JSGlobalObjectRef bg-serialized. GetPropertyCell was implemented as: LookupIterator it(holder, isolate, name, LookupIterator::OWN); it.TryLookupCachedProperty(); if (it.state() == LookupIterator::DATA) it.GetPropertyCell(); Due to concurrency requirements, we essentially have to reimplement this entire path for use in a concurrent setting: - Reads in some cases have to use relaxed or acquire semantics. - The IsPendingAllocation predicate must be called on some objects before reading into them. - Repeated reads of the same field must be avoided due to the possibility of concurrent modifications. This CL introduces two new methods: ConcurrentLookupIterator::TryGetPropertyCell implements the outer lookup logic, including the repeated lookup for accessors / cached property names. GlobalDictionary::TryFindPropertyCellForConcurrentLookupIterator is a slightly modified HashTable::FindEntry which follows the above rules. Bug: v8:7790 Change-Id: Ic9a52da766afdfedce8efcbda92876845a17eed9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959616Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75467}
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: Ie46c575a9f438f25e7db7c1758beaf7bf0e8b39f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992885 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75466}
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: I54eea2deaaa4823b13f8f66e13a1851f951c63c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991241 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75464}
-
Jakob Gruber authored
Bug: v8:7790 Change-Id: If558b6db7feed50bd0325a814bcab9e98ebd9493 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991239 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75463}
-
Santiago Aboy Solanes authored
This reverts commit 5fefa970. Reason for revert: They are used via CodeT https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20external%20code%20space%20-%20debug%20-%20builder/124/overview Original change's description: > [compiler] Remove unused CodeDataContainerRef/Data classes > > Bug: v8:7790 > Change-Id: I072823ea40b0bd64aaf4a14882603cef29edcf22 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992722 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75456} Bug: v8:7790 Change-Id: I2c7f65c8a772de9967ce5b3aa78d1f46c9c99866 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2996188Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75462}
-
Ross McIlroy authored
Adds support for a seperate dynamic map checks trampoline that takes the feedback vector as an argument rather than reading it from the stack frame, to enable it to work for inlined functions. Plumbs the logic through the compiler to select between these trampolines based on the framestate. BUG=v8:9684,chromium:1224367 Change-Id: Ibc7facdc78930aedec4a102693a926f64f6de7e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992724 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75461}
-
Santiago Aboy Solanes authored
When failing to construct a Ref, it helps debugging knowing which class is the one we failed to create. Bug: v8:7790 Change-Id: I22388920633fe2155c7b4fa712c5dead25a2f2d6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992726Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75460}
-
Jakob Gruber authored
... but keep/make subclass-specific methods do direct reads. Bug: v8:7790 Change-Id: Ia4b9d207ce75cf28f6f0f33027ab05e27db49ce9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959621Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75457}
-
Santiago Aboy Solanes authored
Bug: v8:7790 Change-Id: I072823ea40b0bd64aaf4a14882603cef29edcf22 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992722Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#75456}
-
Jakob Gruber authored
Call it NativeContextRef::GlobalIsDetached and implement it on top of Refs such that it can benefit from direct reads. Drive-by: inline a JSNativeContextSpecialization::ReduceGlobalAccess overload into its only callsite. Bug: v8:7790 Change-Id: I1c6891e0fc65a476b0c4587f3fde2c6461b302a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2959614Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75454}
-
Clemens Backes authored
There currently is no way to enforce explicit bounds checks if the embedder installed the signal handler for wasm trap handling (queried via {trap_handler::IsTrapHandlerEnabled()}). This CL adds a respective flag and makes all compilation emit explicit bounds checks if it is disabled. R=ahaas@chromium.org Bug: v8:11926 Change-Id: Ie19faab1766d3105f3c22cb4470c0f15398f1d09 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989129Reviewed-by: Andreas Haas <ahaas@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#75453}
-
Jakob Gruber authored
.. now that all JSObjectRef methods can run in concurrent settings. Also change a few subtypes to bg-serialized: - JSArray - JSGlobalProxy - JSTypedArray Bug: v8:7790 Change-Id: I406b0a8eacb4e5bd2c3a24eb106b29df2cf55421 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2966377Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#75452}
-
- 29 Jun, 2021 2 commits
-
-
Milad Fa authored
Flags are also updated under `instruction-selector` to include these operations. Not having them was causing their Simd versions to remain unused as well. V8 was just interpreting them at runtime. Change-Id: I42677f7412859ad4759b70ba16667ec9d90505af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994803Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Fa <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/master@{#75444}
-
Peter Kasting authored
This is a reland of edab8730 It was speculatively reverted but the issue turned out to just be slow tests. Original change's description: > Fix -Wimplicit-int-float-conversions. > > Bug: chromium:989932 > Change-Id: Ief917b023cb079f5ff87dc8963d74f225d074d7a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989096 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75413} Bug: chromium:989932 Change-Id: Iec8ac8ee32705c6a699a2df2f292ffe07cde99f7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2994802Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#75443}
-
- 28 Jun, 2021 5 commits
-
-
Ng Zhi An authored
Bug: v8:11879 Change-Id: I7badcbe81485f9e325c75f406560983b78be949a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989101Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/master@{#75423}
-
Thibaud Michaud authored
PopulateReferenceMaps caches an iterator for the reference maps list, which allows skipping many iterations when the live ranges are mostly sorted. When they are not sorted however, the complexity increases significantly since we have to iterate from the beginning of the reference maps list for each live range. We observed a real-world wasm GC function where this phase takes up 90% of the compilation time because of this, which drops to below 2% when the ranges are sorted first. R=sigurds@chromium.org CC=jkummerow@chromium.org Change-Id: I829c909c06e5a1daee0f8d10c156d0a382af9ed0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2985339 Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#75420}
-
Francis McCabe authored
This reverts commit edab8730. Reason for revert: appears to be causing additional TSAN flakes: see https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN%20-%20stress-incremental-marking/3772 Original change's description: > Fix -Wimplicit-int-float-conversions. > > Bug: chromium:989932 > Change-Id: Ief917b023cb079f5ff87dc8963d74f225d074d7a > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2989096 > Reviewed-by: Bill Budge <bbudge@chromium.org> > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > Auto-Submit: Peter Kasting <pkasting@chromium.org> > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#75413} Bug: chromium:989932 Change-Id: I43d16b151f3c2d7bd68d0007af18a06de65da442 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2991342 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#75419}
-
Daan de Graaf authored
Bug: v8:11546 Change-Id: I40bc4b5e3c813edba4a194b086b63e19d1231e29 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2956729 Commit-Queue: Daan de Graaf <daagra@google.com> Reviewed-by: Zhi An Ng <zhin@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#75416}
-
Maya Lekova authored
This CL implements setting the javascript_execution_assert on the isolate from generated code, so we don't need to create an expensive class in the embedder callback. Bug: chromium:1218898 Change-Id: Ia05b49281ab4c1cc3ac34caf2dfadb79feb86e84 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2982998 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#75414}
-