- 09 Nov, 2018 3 commits
-
-
Jaroslav Sevcik authored
Change-Id: Ia1f47083689abb7d37c91098465a107a71f4dbea Reviewed-on: https://chromium-review.googlesource.com/c/1225757 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57375}
-
Tom Tan authored
Same as Windows x64, Windows ARM64 doesn't prefix assembly label with _. Bug: chromium:893460 Change-Id: I1b19a4e7ea16da3fe8bd1873509fffe3d067613a Reviewed-on: https://chromium-review.googlesource.com/c/1298376 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:893593 Change-Id: I5efafa57c8206982c4e5e4fa7442a3a05fb3c474 Reviewed-on: https://chromium-review.googlesource.com/c/1328641Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57373}
-
- 08 Nov, 2018 35 commits
-
-
Frank Tang authored
Split the case of 'ar-SA' into test/intl/regress-8432.js Bug: v8:8432, v8:8413 Change-Id: I6a0e3040b132be6620649c7b7aa5fdd2e0f07053 Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng_triggered Reviewed-on: https://chromium-review.googlesource.com/c/1324574Reviewed-by:
Jungshik Shin <jshin@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#57372}
-
Sergiy Byelozyorov authored
This is useful to see exact command used to communicate with buildbucket and debug any triggering issues. R=machenbach@chromium.org Change-Id: I1630485ed128f757364d9c1f62b7f1d663db2ece Reviewed-on: https://chromium-review.googlesource.com/c/1325371Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57371}
-
Yutaka Hirano authored
We are migrating streams implementation from JavaScript (v8Extra) to C++. One of missing features is an ability to set promise.[[PromiseIsHandled]] to true, used for example in https://streams.spec.whatwg.org/#rs-pipe-through. This CL introduces the feature. Bug: chromium:894357, chromium:888154, chromium:902633 Change-Id: If6487b29a74a212761e6d2ef04ef3ca0e6957dce Reviewed-on: https://chromium-review.googlesource.com/c/1322296Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#57370}
-
Jakob Kummerow authored
Behavior in Release mode was correct; Debug mode triggered a DCHECK failure that indicated an inefficiency: when a requested truncation would be a no-op, we should return the original BigInt, rather than creating a copy. In the special case of -2^(n-1), i.e. the smallest negative n-bit integer, getting truncated to n bits, with n being a multiple of kDigitBits, this shortcut was not taken. Bug: v8:8426 Change-Id: I8e4595d9ac0dbef81aae06688f9a9636bd2d9cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1325029Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#57369}
-
Caitlin Potter authored
Change the macros added in bf84766a to only do the hard work if FLAG_unbox_double_fields is unset (otherwise, they will attempt to dereference raw float64s, which is bad!) Also adds a write barrier in CopyPropertyArrayValues for each store if it's possible that a MutableHeapNumber is cloned. BUG=chromium:901301, chromium:902965, chromium:903070, v8:7611 R=cbruni@chromium.org, jkummerow@chromium.org, ishell@chromium.org Change-Id: I224d3c4e7b0a887684bff68985b4d97021ba4cfb Reviewed-on: https://chromium-review.googlesource.com/c/1323911 Commit-Queue: Caitlin Potter <caitp@igalia.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57368}
-
Frank Tang authored
Bug: v8:7871 Change-Id: I287f4a365b5e1443652131e97bcd149f9e6fd623 Reviewed-on: https://chromium-review.googlesource.com/c/1324491Reviewed-by:
-
Michael Starzinger authored
R=clemensh@chromium.org BUG=v8:8238 Change-Id: I03454ced41da35be9d389d843026ed5c0f7131fe Reviewed-on: https://chromium-review.googlesource.com/c/1326465 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57366}
-
Igor Sheludko authored
The rounding error occured in VirtualMemory class when the provided page allocator had bigger allocation page size than the commit page size and the VirtualMemory was requested to reserve an area of a size aligned only to commit page size. Bug: v8:8096 Change-Id: Ifb9b7fe5797881408d1bb9e95073991a42b62e80 Reviewed-on: https://chromium-review.googlesource.com/c/1327041Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#57365}
-
Toon Verwaest authored
- Mark arrow functions the uncommon assignment case - arrow formal parameter productions are ignored by default already - avoid duplicate is_destructuring_assignment branch - immediately pass expected productions into Accumulate Change-Id: Ifaeece53a1d6b99999ea298518702e82bc20db73 Reviewed-on: https://chromium-review.googlesource.com/c/1326941 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
It's too easy to implicitly cast it to bool, as we did in several tests. Also, move TryAbortResult out of CancelableTaskManager to avoid too much typing when referencing one of the enum values. R=mstarzinger@chromium.org Bug: v8:8238 Change-Id: Ia3fa8597428876217bc86f9b8b31c21ae4846fa1 Reviewed-on: https://chromium-review.googlesource.com/c/1326027 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#57363}
-
Toon Verwaest authored
This allows the main ExpressionCoverGrammar parsing to be a little tighter. Change-Id: I45e3d1a9a647a98ffe1ad9969cb1ffbe47f67f1c Reviewed-on: https://chromium-review.googlesource.com/c/1326468 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Toon Verwaest authored
We only use arrow_formal_parameters_error to find that the parentheses aren't nested. E.g., (()) isn't valid. We can immediately classify those errors if ) (matching either "(" or "async(") isn't followed by =>. The individual parameters are verified by making sure that they are valid binding patterns with valid initializers. Change-Id: I5f86d9896a4fa42d1ae436ced8bf2d4bd2b02c82 Reviewed-on: https://chromium-review.googlesource.com/c/1326023Reviewed-by: -
Yang Guo authored
We used to assume that we know the remaining entries returned by the iterator based on the current index. However, that is not accurate, since entries skipped by the current index could be deleted. In the new approach, we allocate conservatively and shrink the result. R=neis@chromium.org Bug: v8:8433 Change-Id: I38a3004dc3af292daabb454bb76f38d65ef437e8 Reviewed-on: https://chromium-review.googlesource.com/c/1325966 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Yang Guo authored
The lifetime of this list is fairly simple to reason about. There is no need to allocate it into the zone. R=leszeks@chromium.org Change-Id: I9c918f7e5fddc24c943206aa82be859f27acc2fe Reviewed-on: https://chromium-review.googlesource.com/c/1325610 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57359}
-
Leszek Swirski authored
Bug: chromium:902610 Change-Id: I4675e3089a09ee75aa81ba2958f30a17621a537e Reviewed-on: https://chromium-review.googlesource.com/c/1326029Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57358}
-
Toon Verwaest authored
Since we use a ScopedPtrList to track cover grammar expressions we don't know the position of the commas anymore. The position of the commas was used to demark the initializer, which is needed to figure out whether we need hole checks for variable references. (Typically only references within the initializer need hole checks for the initialized variable.) Since we didn't have the comma position, we simply used the position of the first expression as the position of any subsequent comma, which would make it seem as if the initializer body wasn't in the initializer. Now instead we simply use the position of the subsequent parameter as the end of the initializer, which is close enough. Bug: chromium:902810 Change-Id: I8d2bc7a2dc9f59db16ce56ccef01e263a18a3b7a Reviewed-on: https://chromium-review.googlesource.com/c/1326022Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/test/test262/data: https://chromium.googlesource.com/external/github.com/tc39/test262/+log/d9d9839..0475c12 TBR=adamk@chromium.org,gsathya@chromium.org Change-Id: I3d996306614cbf80a24c9dfc4f320ad551fd0b84 Reviewed-on: https://chromium-review.googlesource.com/c/1326365Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57356}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I5192891c85da12638e036b605713264d0e59aedc Reviewed-on: https://chromium-review.googlesource.com/c/1324490 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Currently, in debug mode the snippets check the result of decompression equals to the full value stored in the field. Bug: v8:7703 Change-Id: I0caa7fdaa7d346612084706ed96a4330fcb0c236 Reviewed-on: https://chromium-review.googlesource.com/c/1319575 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#57354}
-
Sigurd Schneider authored
Increase width of resizers and clean up CSS. Drive-by: Add hot recompile watch command. Run npm run-script watch and rollup will recompile on file changes. Notry: true Bug: v8:7327 Change-Id: If24e18049ff565a7584b5cca9c64431e4ac03f77 Reviewed-on: https://chromium-review.googlesource.com/c/1320852Reviewed-by:
-
Clemens Hammacher authored
Introduce a typedef to avoid repeating the function definition multiple times. R=ahaas@chromium.org Change-Id: I9d8a2a9b663f86ce0f6e21edf6d4a6d5ae450efc Reviewed-on: https://chromium-review.googlesource.com/c/1325963Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57352}
-
George Wort authored
Change-Id: I7079a0460fcb8f9b818c97125ab11f6168c3a28d Reviewed-on: https://chromium-review.googlesource.com/c/1323731 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Leszek Swirski authored
The Ignition statement list visitor will skip the rest of the statements in the list if it hits a jump statement (like a return or break), as the rest of the code in the list can be considered dead. return; dead_call(); // skipped However, since this is at an AST node level, it does not take into account condition shortcutting: if(2.2) return; dead_call(); // not skipped There is also a second dead code elimination in Ignition compilation, at the bytecode array writer level, where a bytecodes are not emitted if an "exit" bytecode (Return, Jump, or a few others) has been written, until the next basic block starts (i.e. a Bind). This can cause an issue with statements that resurrect the bytecode array writer part-way through their visit. An example is try-catch statements, which save the context to a register, and then Bind to start the try region. For the case: if (2.2) return; try { // try statement not skipped ... } the bytecode writer is called with OutputReturn() // exit bytecode seen OutputMove(<context>, r1) // not emitted Bind(&try_begin) // starts new basic block // try body So, the try is emitted, but without saving the context to a register. This means that the liveness analysis sees the read of that register (as the output liveness of throwing bytecodes), but does not have a write to the register, which means that the liveness escapes. This patch fixes this by using the bytecode array writer dead-code elimination (i.e. "exit bytecode seen") to inform the statement list visitor, so that in this example the try statement is not visited at all. Bug: chromium:902395 Change-Id: Ieb8e46a4318df3edbac0ae17235e0ce8fba12ee3 Reviewed-on: https://chromium-review.googlesource.com/c/1322951Reviewed-by:Mythri Alle <mythria@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57350}
-
Jaroslav Sevcik authored
As opposed to the register. For subtle reasons, this fixes a deoptimizer bug with handling return values in lazy deopt. Since the return values can now only overwrite the accumulator, there is no danger of overwriting a captured object that might be later used (since there is no "later"). Bug: chromium:902608 Change-Id: I3a7a10bb1c7a6f4303a01d60f80680afcb7bc942 Reviewed-on: https://chromium-review.googlesource.com/c/1325901Reviewed-by:
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: chromium:901329 Change-Id: Id9bc01e7e49c90ac3b5bca88abba53a38a1b0d80 Reviewed-on: https://chromium-review.googlesource.com/c/1326021Reviewed-by:
-
Marja Hölttä authored
See https://github.com/tc39/proposal-weakrefs/issues/37 Drive-by: fix error messages. BUG=v8:8179 Change-Id: I8608d09ec5a58c8b62eea4580be9415f6bb41586 Reviewed-on: https://chromium-review.googlesource.com/c/1319758 Commit-Queue: Marja Hölttä <marja@chromium.org> Reviewed-by:
-
Ivica Bogosavljevic authored
Fix 4001f86a Change-Id: I8392c1c6c279b51c64d1052992d836939c84ec55 Reviewed-on: https://chromium-review.googlesource.com/c/1325377Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57346}
-
Georg Neis authored
Also brokerize a few things along the way. Bug: v8:7790 Change-Id: I40d8175fd1c86901af3d128f0d0a1e29e56723d9 Reviewed-on: https://chromium-review.googlesource.com/c/1319751Reviewed-by:
-
Jaroslav Sevcik authored
This is a hacky approach to make constant field tracking somewhat friendly to class boilerplates - if the class boilerplate has an on-descriptor-data field, we change the field to be an on-instance-const-field and store it on the instance. Bug: v8:8361 Change-Id: I5152041363bcd26568669fee93c91ff362ba8de9 Reviewed-on: https://chromium-review.googlesource.com/c/1319869 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Georg Neis authored
Installation of the PrototypePropertyDependency, as well as GC, can invalidate dependencies. Bug: chromium:902552 Change-Id: Iabcce026c7475c722d19ac0b80758b22d9fbcfda Reviewed-on: https://chromium-review.googlesource.com/c/1322450Reviewed-by:
-
Jakob Gruber authored
This fixes an issue introduced in https://crrev.com/c/1301483. The JSArray allocation could trigger GC and thus elements must be fully initialized. Bug: v8:8429,chromium:890599 Change-Id: I7bfa1728c1dde7fc880063e095413163b13be2d5 Reviewed-on: https://chromium-review.googlesource.com/c/1322955Reviewed-by:
-
Frank Tang authored
Requires ICU 63 or above be used when building v8 1. Remove unneeded #include of icu header files 2. Remove code inside "#if U_ICU_VERSION_MAJOR_NUM < x" block where x is 63 or smaller. Bug: v8:8401 v8:5751 Change-Id: I908b0d7d174df53d4296580fe7150417322b0b21 Reviewed-on: https://chromium-review.googlesource.com/c/1314112Reviewed-by:
-
Yang Guo authored
Previously, we finalize all compile jobs at once. This keeps the zone memory in every compile job alive until the end. This contributes to a high peak memory when many functions are compiled eagerly, for example when producing cache data for the ServiceWorker cache. Memory tracked by the AccountingAllocator in bytes, prior to this change in the test case: peak memory after init: 8192 peak memory after lazy compile: 41200 peak memory after lazy compile: 41200 peak memory after eager compile: 164256 With this change, if we are compiling on the main thread, we finalize every compile job as soon as it is done and dispose the compile job and its zone memory. After this change: peak memory after init: 8192 peak memory after lazy compile: 41200 peak memory after lazy compile: 41200 peak memory after eager compile: 41376 R=leszeks@chromium.org, rmcilroy@chromium.org Bug: chromium:901329 Change-Id: Iae0c89396c89692c4ecdeec3970d3c62031d2bce Reviewed-on: https://chromium-review.googlesource.com/c/1322949 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9f8abf9..cae006c Rolling v8/test/wasm-js/data: https://chromium.googlesource.com/external/github.com/WebAssembly/spec/+log/a56cf2e..5aaea96 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2e722b0..1a1b38d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6d6e0a8..75fa855 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/29de0c2..ac40df8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ifcd163c5757f69ea900548da5e315c07a76e1cb8 Reviewed-on: https://chromium-review.googlesource.com/c/1325372Reviewed-by:
-
Sergiy Byelozyorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:902428 Change-Id: If261edaa4d5ebd2a8635cdc76870c8e4ac4194dd Reviewed-on: https://chromium-review.googlesource.com/c/1325609Reviewed-by:
-
- 07 Nov, 2018 2 commits
-
-
Adam Klein authored
Bug: v8:8413 Change-Id: I8dffebd92b3d2ce85deb31b48cbefb1dd2390481 Reviewed-on: https://chromium-review.googlesource.com/c/1325049Reviewed-by:
Frank Tang <ftang@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#57337}
-
Sergiy Byelozyorov authored
R=machenbach@chromium.org Bug: chromium:902428 Change-Id: Id9a727d83c2a69e4ffd20e761c274cba2c75404a Reviewed-on: https://chromium-review.googlesource.com/c/1320889Reviewed-by:
-
