• Toon Verwaest's avatar
    [parser] Fix cover-grammar initializer positions · 5bf9e470
    Toon Verwaest authored
    Since we use a ScopedPtrList to track cover grammar expressions we don't know
    the position of the commas anymore. The position of the commas was used to
    demark the initializer, which is needed to figure out whether we need hole
    checks for variable references. (Typically only references within the
    initializer need hole checks for the initialized variable.) Since we didn't
    have the comma position, we simply used the position of the first expression as
    the position of any subsequent comma, which would make it seem as if the
    initializer body wasn't in the initializer. Now instead we simply use the
    position of the subsequent parameter as the end of the initializer, which is
    close enough.
    
    Bug: chromium:902810
    Change-Id: I8d2bc7a2dc9f59db16ce56ccef01e263a18a3b7a
    Reviewed-on: https://chromium-review.googlesource.com/c/1326022Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57357}
    5bf9e470
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...