1. 04 Apr, 2019 1 commit
  2. 13 Feb, 2019 1 commit
  3. 07 Feb, 2019 1 commit
  4. 09 Jan, 2019 1 commit
  5. 03 Jan, 2019 1 commit
  6. 17 Dec, 2018 1 commit
  7. 12 Dec, 2018 1 commit
  8. 08 Dec, 2018 1 commit
  9. 22 Nov, 2018 1 commit
  10. 24 Oct, 2018 1 commit
  11. 04 Oct, 2018 1 commit
  12. 04 Sep, 2018 1 commit
  13. 29 Aug, 2018 1 commit
    • Ujjwal Sharma's avatar
      [Intl] Add a CreateBoundFunction helper function · 3ed9f606
      Ujjwal Sharma authored
      Add a C++ helper function called "CreateBoundFunction" as a static
      function to the Intl class, and change all existing builtins involving
      the creation of a bound function to use it instead.
      
      Also remove the redundant ContextSlot enums on all Intl objects in favor
      of a single BoundFunctionContextSlot enum in the Intl class.
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Ibd541f5e79828cd1e2cd573a0e23fc93b348a8ad
      Reviewed-on: https://chromium-review.googlesource.com/1194817
      Commit-Queue: Ujjwal Sharma <usharma1998@gmail.com>
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55508}
      3ed9f606
  14. 27 Aug, 2018 1 commit
    • Sathya Gunasekaran's avatar
      [Intl] Correctly pass usage option to Collator · 59c03fef
      Sathya Gunasekaran authored
      The spec specifies that search and standard can not be valid values
      for the collation extension keyword. Instead users are expected to use
      the options bag to set the correct usage options.
      
      But, ICU expects the usage option to be set through the collation
      extension value.
      
      In this patch, we set the usage option using the collation extension
      value in ICU. For resolvedOptions, we filter out this extension value
      using ICU to be spec compatible.
      
      Previously, we stored the usage option on the JSCollator instance. But
      this patch changes the logic to just look it up from the icu::Collator
      when required. This saves one word of memory.
      
      This fails a test262 that was incorrectly fixed. A follow on patch
      will fix the test262 test.
      
      Bug: v8:5751
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: I8c66c6286287e686f4cd152fa1301f9d51c38654
      Reviewed-on: https://chromium-review.googlesource.com/1180488Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#55437}
      59c03fef
  15. 14 Aug, 2018 1 commit
  16. 08 Aug, 2018 1 commit
    • Sathya Gunasekaran's avatar
      [Intl] Optimize Intl.Collator · 363fe1eb
      Sathya Gunasekaran authored
      This patch ports most of the Intl.Collator from JS to C++.
      
      The Intl.Collator object no longer stores all the resolved
      values. Instead these are looked up on demand as part of
      Intl.Collator.prototype.resolvedOptions(), saving several words. In
      the future, we can cache the result of the resolvedOptions as well.
      
      In this patch, we use ICU to do parsing of the unicode extension in
      the bcp47 language tag instead of using a custom extension parser.
      
      This patch also fixes several spec compliance bugs as well.
      
      Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
      Change-Id: Iaaa7be4a628404da1bd83d882e04a2c6de70ebd9
      Bug: v8:5751, v8:7480
      Reviewed-on: https://chromium-review.googlesource.com/1165084
      Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org>
      Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
      Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
      Cr-Commit-Position: refs/heads/master@{#54965}
      363fe1eb