- 30 Sep, 2019 15 commits
-
-
Ana Pesko authored
This reverts commit cfb60d43. Reason for revert: Several bots timing out, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/24717 Original change's description: > [regexp] Eagerly tier-up for very long strings > > For very long subject strings, the regexp interpreter is currently much slower > than the native machine code execution. This CL implements eager tier-up to the > compiler to avoid the performance penalty for subject strings of length greater > than 1000. > > Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e > Bug: v8:9566 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ana Pesko <anapesko@google.com> > Cr-Commit-Position: refs/heads/master@{#64046} TBR=yangguo@chromium.org,petermarshall@chromium.org,anapesko@google.com TBR=yangguo@chromium.org Change-Id: Id8dd362617988c8c5efa87ae157ee91c96cb1fdf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832163Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#64047}
-
Ana Peško authored
For very long subject strings, the regexp interpreter is currently much slower than the native machine code execution. This CL implements eager tier-up to the compiler to avoid the performance penalty for subject strings of length greater than 1000. Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ana Pesko <anapesko@google.com> Cr-Commit-Position: refs/heads/master@{#64046}
-
Milad Farazmand authored
Port 1e4bb087 Original Commit Message: x64 code path is different and we can't do this optimization. R=solanes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I173d7339706a9c09d3e6519d1cee36fa15692aca Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829171 Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#64045}
-
Milad Farazmand authored
Port 559a0034 Original Commit Message: We didn't think this affected arm but it turns out it does. This is a port of https://chromium-review.googlesource.com/c/v8/v8/+/1688049 R=petermarshall@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id081736420a20216cef5c5f483acd987785c4d97 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829899Reviewed-by:
-
Dominik Inführ authored
This reverts commit 70e07cdb. Reason for revert: Clusterfuzz found issue in chromium:1009019 Original change's description: > [heap] Insert directly into RememberedSet and remove StoreBuffer > > This CL removes the StoreBuffer and inserts slots into the > RememberedSet directly from within the RecordWrite builtin. Only calls > into C code when either the SlotSet-array or the bucket is not > allocated. This avoids filling the store buffer up with duplicates or > due to a write-heavy workload and then blocking the main thread on > store buffer processing. > > Change-Id: I05b0b0938d822cdf0e8ef086ad4527d3229c05b2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1815241 > Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64002} TBR=ulan@chromium.org,jkummerow@chromium.org,dinfuehr@chromium.org Change-Id: I6f4cc1641965c83b05f3b3830b0f526b362beb49 Bug: chromium:1009019, chromium:1009196 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829259Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/master@{#64043}
-
Ana Peško authored
This CL changes the eager tier-up for global replaces slightly to include a previously unaccounted for path by moving the logic into the caller so that it includes this path as well. Change-Id: Ifc265ddb1183b8bb3ea75ca5d6c83d66e55e2837 Bug: v8:9566 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829276 Commit-Queue: Ana Pesko <anapesko@google.com> Reviewed-by:
-
Dan Elphick authored
This is a short-term fix to prevent any merging of feedback slots for dynamic globals, while we work on a longer term solution to make it consistent between eager and lazy compilation. Bug: chromium:1008414, v8:8510 Change-Id: I4a5977046f53454d6f8a6ea2f41046abdf73418f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829270 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#64041}
-
Ingvar Stepanyan authored
Adds ability to pause JavaScript debugger from d8 by defining a global function `handleInspectorMessage` which should block waiting for a new inspector message, and `send` it afterwards. Additionally, adds a simple helper script that, when invoked via `websocketd` as per instructions, can be used for debugging `d8` using Chrome DevTools (inspecting script sources, pausing, stepping over, etc.). Change-Id: Iee75fb4e3f2ccc8c8552c804fefaefb233d6b089 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829221Reviewed-by:
-
Igor Sheludko authored
... in disabled state. It will be enabled in a follow-up CL. Bug: v8:9706 Change-Id: I43b482a4fd1bf9af0c6ba535b453e72463bee0f8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826731Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Clemens Backes [né Hammacher] <clemensb@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#64039}
-
Michael Achenbach authored
NOTRY=true Change-Id: Icb4c3a1a544331baab5d6637daa12bea87044715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829268 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
David Carlier authored
/proc/sys/auxv might not be accessible, instead getting these from the user's stack. Change-Id: I2dcf696734e2b4dc1da27a991930b9e0d4228d51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730990 Commit-Queue: Clemens Backes [né Hammacher] <clemensb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Change-Id: Ie96e645851beb26e9a777379ad68f1c173acd80d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829266Reviewed-by:
-
Georg Neis authored
This fixes a bug in the optimization concerning detached or re-attached global proxies. Bug: v8:7790 Change-Id: Ifd30b88361914430bb373d4b64a76e33ccde37e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1809361Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64035}
-
Liviu Rau authored
When a DEPS file changes we need to verify at presubmit all other files sitting in the same dir as the DEPS file (& below recursively). Bug: v8:9692 Change-Id: I7ae3b4cec5ab3bf970f0d04afe54e8f40138b819 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1803644Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Liviu Rau <liviurau@chromium.org> Cr-Commit-Position: refs/heads/master@{#64034}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f3828ad..0a96846 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/3905857..0081c0f TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie01ce3e4e5d8ab3d508b941087358800d631d4de Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1831178Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64033}
-
- 29 Sep, 2019 1 commit
-
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b321a92..f3828ad TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I1c7470e130052795b0dd137724f741bffc017b42 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829512Reviewed-by:
-
- 28 Sep, 2019 2 commits
-
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/15152b5..5f4659d Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/2b82936..3905857 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I6293d1e076c663cf2ebc850ea33f4025145f2e38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829508Reviewed-by:
-
Yu Yin authored
port dcf3b663 https://crrev.com/c/1825222 port 7675b95f https://crrev.com/c/1826724 [mips][wasm-simd] Implement f32x4.sqrt. port 36f2ec1f https://crrev.com/c/1808045 Change-Id: Ib714d56f2b0062d5013364eeea30294cf0b92cd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826588Reviewed-by:
Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Zhi An Ng <zhin@chromium.org> Commit-Queue: Yu Yin <xwafish@gmail.com> Cr-Commit-Position: refs/heads/master@{#64030}
-
- 27 Sep, 2019 17 commits
-
-
Santiago Aboy Solanes authored
If we SmiTag using the same register we will save a mov instruction. Bug: v8:9771 Change-Id: Iadfa332e76115688eac6c3ec5262ca751ec02405 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826735Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64029}
-
Frank Tang authored
Address special case condiction for U+017F. Bug: v8:9356 Change-Id: Id24e5e2c999b198bf0f696aea8c98f223508c051 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827683 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Frank Tang authored
Add logic stated in Bug: v8:9731 Change-Id: I0b3468bbad11a178f36d682febd0e44214646de8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828279 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Port 842f1ca0 Original Commit Message: Port dcf3b663 R=miladfar@ca.ibm.com, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Ib5ff44751b466e650c09239e387206ba8c7757d4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829158Reviewed-by:
-
Santiago Aboy Solanes authored
Combining the load with the SmiUntag let's us have better instruction selection opportunities against not doing it. Bug: v8:9771 Change-Id: I6b6391398413ee1bc808c71d48474e9336c09f2b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826734 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
-
Peter Marshall authored
We didn't think this affected arm but it turns out it does. This is a port of https://chromium-review.googlesource.com/c/v8/v8/+/1688049 Bug: v8:9057 Change-Id: I671737107e589673fc32c5fa1760d887d1bcc240 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826665Reviewed-by:
-
Mythri A authored
This is a reland of cfb10028 with a fix for failures in lite mode. Original change's description: > [compiler] Cache OSR optimized code > > With lazy feedback allocation, for functions that get OSRed we may > not have feedback for the initial part of the functions since feedback > vectors might be allocated after the function started executing. Hence > we would not be able to optimize the function on the next call. This > means we may have to OSR twice before we actually optimize function. > This cl introduces OSR cache, so we could reuse the optimized code. One > side effect of this cl is that the OSRed code won't be function context > specialized anymore. > > Bug: chromium:987523 > Change-Id: Ic1e2abca85ccfa0a66a0fa83f7247392cc1e7cb2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796329 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64014} Bug: chromium:987523 Change-Id: I9c782242b07b24d15247533ab4ee044334b429ff TBR: rmcilroy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826898 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64023}
-
Santiago Aboy Solanes authored
x64 code path is different and we can't do this optimization. Bug: v8:9771 Change-Id: I1639e53b4397873e70895ec2919ac2769b0bbc72 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826728Reviewed-by:
-
Santiago Aboy Solanes authored
The current version of SmiTag and SmiUntag was checking if the registers were the same, copying them if not and then untagging. We can avoid a branch and a check by having two versions of SmiTag and SmiUntag. Change-Id: Id89213e073cefc9f8e46fcf0e79d0c1d349342ae Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826730Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#64021}
-
Milad Farazmand authored
Port 36f2ec1f R=zhin@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I4c93e533bfc999010d7c1f5ada37d0e0d7813ac3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827513Reviewed-by:
-
Dominik Inführ authored
insert_remembered_set_function used Heap::RecordSlotFromCode as name, while the actual function is Heap::InsertIntoRememberedSetFromCode. Change-Id: Idbdc389bf7267dd2be47986249fba33349cd44f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828918Reviewed-by:
-
Benedikt Meurer authored
This new optional parameter controls whether "Runtime.evaluate" ignores break points and previous "Debugger.pause" calls while evaluating the expression. This will be used for live expressions, which should never interfere with debugging. Bug: chromium:1001216 Change-Id: Ie37f6616a4a1cae40399b79255ab92fb254d91b5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826664 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Michael Achenbach authored
Also remove or adapt all mentioning of buildbot. The flag was removed on the infra side here: https://crrev.com/c/1827557 Change-Id: I8a6be80faa65f99cd42a084c804fc5bfae7f02c2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826722Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64017}
-
Mike Stanton authored
Almost everywhere, we use the ProcessedFeedback abstraction to query feedback in the compiler. The remaining exception is in handling RegExp, Object and Array literals. By bringing this in line with other feedback queries, we no longer need to serialize all feedback vector slots (possibly wasteful of memory), and offer a uniform way to pick up feedback everywhere. Bug: v8:7790, v8:9396 Change-Id: Ice42587595fe30bebfbd7835d2b2e9e49601c92e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807358 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit cfb10028. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20lite/6483 Original change's description: > [compiler] Cache OSR optimized code > > With lazy feedback allocation, for functions that get OSRed we may > not have feedback for the initial part of the functions since feedback > vectors might be allocated after the function started executing. Hence > we would not be able to optimize the function on the next call. This > means we may have to OSR twice before we actually optimize function. > This cl introduces OSR cache, so we could reuse the optimized code. One > side effect of this cl is that the OSRed code won't be function context > specialized anymore. > > Bug: chromium:987523 > Change-Id: Ic1e2abca85ccfa0a66a0fa83f7247392cc1e7cb2 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796329 > Commit-Queue: Mythri Alle <mythria@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Georg Neis <neis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64014} TBR=rmcilroy@chromium.org,neis@chromium.org,mythria@chromium.org Change-Id: Ib3692e7570bed5d3e88ca8a0247b185d70497a04 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:987523 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826668Reviewed-by:
-
Mythri A authored
With lazy feedback allocation, for functions that get OSRed we may not have feedback for the initial part of the functions since feedback vectors might be allocated after the function started executing. Hence we would not be able to optimize the function on the next call. This means we may have to OSR twice before we actually optimize function. This cl introduces OSR cache, so we could reuse the optimized code. One side effect of this cl is that the OSRed code won't be function context specialized anymore. Bug: chromium:987523 Change-Id: Ic1e2abca85ccfa0a66a0fa83f7247392cc1e7cb2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1796329 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/7f88e8b..b321a92 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/6bb5733..15152b5 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/7211cf6..2b82936 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/d0c91c0..925d2e5 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I118391ac0b07c9709bef3be3f48c71d2538c682f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828557Reviewed-by:
-
- 26 Sep, 2019 5 commits
-
-
Milad Farazmand authored
Port dcf3b663 R=solanes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I92b18a10581e0d1b7977db6be8ed455ec621d537 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827738Reviewed-by:
-
Ng Zhi An authored
Bug: v8:8460 Change-Id: I02f5ac42ab101dd8e12e14f253a625212db13a21 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808045 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#64011}
-
Ng Zhi An authored
Bug: v8:9728 Change-Id: Icb8c1cfce481ba8a9c4b3447cd2de43920d6f528 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807552Reviewed-by:
-
Milad Farazmand authored
Port 7675b95f Original Commit Message: The x64 version was already doing it. R=solanes@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I4dbe1959736e73910567fb74381c4505c790ba14 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827739Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Reviewed-by:
-
Santiago Aboy Solanes authored
There is some code common to both wide and extra wide that we are able to hoist up since they do not affect the flags after testing to see which version to use. Bug: v8:9771 Change-Id: Idb5ce4bd0dfcb5b38d9bc6e4257f763de3bf3567 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826725Reviewed-by:
-
