Commits · 3a9817546964194d826ac9e16166cd14db5eb39e · Linshizhi / V8

24 Feb, 2015 17 commits

Use mutex/condition variables to synchronize threads · 3a981754

jochen authored Feb 24, 2015

Instead of semaphore and atomics

BUG=v8:3608
R=yangguo@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/950323002

Cr-Commit-Position: refs/heads/master@{#26823}

3a981754

Invalidate property cells for non-existent properties properly. · 675f7d2d

dslomov authored Feb 24, 2015

R=verwaest@chromium.org
BUG=v8:3914
LOG=N

Review URL: https://codereview.chromium.org/945403008

Cr-Commit-Position: refs/heads/master@{#26822}

675f7d2d

Switch to new branching model in auto-push script. · 42dcc6f4

machenbach authored Feb 24, 2015

BUG=chromium:391261
LOG=n
TBR=tandrii@chromium.org
NOTRY=true

TEST=./script_test.py

Review URL: https://codereview.chromium.org/955613003

Cr-Commit-Position: refs/heads/master@{#26821}

42dcc6f4

[strong] Deprecate ellisions · 943dc631

rossberg authored Feb 24, 2015

R=marja@chromium.org
BUG=

Review URL: https://codereview.chromium.org/950303002

Cr-Commit-Position: refs/heads/master@{#26820}

943dc631

[turbofan] optimize moves into merges · 95df1bc2

dcarney authored Feb 24, 2015

BUG=

Review URL: https://codereview.chromium.org/755323011

Cr-Commit-Position: refs/heads/master@{#26819}

95df1bc2

Fix bogus assertion in Debug::PrepareStep. · c42b0e82

yangguo authored Feb 24, 2015

R=svenpanne@chromium.org
BUG=chromium:461042
LOG=N

Review URL: https://codereview.chromium.org/948313002

Cr-Commit-Position: refs/heads/master@{#26818}

c42b0e82

[turbofan] Strength reduction for inline comparisons. · dcf193f1

bmeurer authored Feb 24, 2015

Perform strength reduction on machine operators with inline comparisons:

  CMP & 1 => CMP
  1 & CMP => CMP
  CMP << 31 >> 31 => CMP

Also strength reduce the following constructs:

  x + (0 - y) => x - y
  (0 - y) + x => x - y

R=dcarney@chromium.org

Review URL: https://codereview.chromium.org/951903003

Cr-Commit-Position: refs/heads/master@{#26817}

dcf193f1

Make sure exception handlers are deferred. · b33f552f

mstarzinger authored Feb 24, 2015

R=bmeurer@chromium.org
TEST=unittests/SchedulerTest.CallException

Review URL: https://codereview.chromium.org/944903002

Cr-Commit-Position: refs/heads/master@{#26816}

b33f552f

Remove reinvented wheel for partial snapshot cache. · abf122cc

yangguo authored Feb 24, 2015

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/946073003

Cr-Commit-Position: refs/heads/master@{#26815}

abf122cc

[turbofan] only use two gaps · 43c7345b

dcarney authored Feb 24, 2015

BUG=

Review URL: https://codereview.chromium.org/948033002

Cr-Commit-Position: refs/heads/master@{#26814}

43c7345b

Drop Intrusive*TransitionIterators, use recursion instead. · 32bac2df

jkummerow authored Feb 24, 2015

We already use recursion to iterate over transition trees elsewhere, so this should be safe wrt. call stack height.

Review URL: https://codereview.chromium.org/942523003

Cr-Commit-Position: refs/heads/master@{#26813}

32bac2df

Get rid of recursive locks for job based recompilation · 2f7c1926

jochen authored Feb 24, 2015

For flushing the input queue, use the input queue lock. Introduce an
explicit refcount to make sure we don't delete the thread object before
all jobs are finished.

BUG=v8:3608
R=yangguo@chromium.org
LOG=n

Review URL: https://codereview.chromium.org/948863002

Cr-Commit-Position: refs/heads/master@{#26812}

2f7c1926

NewError no longer returns a MaybeObject. · c5d55550

yangguo authored Feb 24, 2015

We no longer expect NewError to return an empty handle to signal termination
exception, since TryCall simply requests a new terminate exception interrupt.

BUG=chromium:403509
LOG=N

Review URL: https://codereview.chromium.org/952483002

Cr-Commit-Position: refs/heads/master@{#26811}

c5d55550

Reland "Correctly propagate terminate exception in TryCall." · dafd7301

yangguo authored Feb 24, 2015

BUG=v8:3892
LOG=Y

Review URL: https://codereview.chromium.org/953463002

Cr-Commit-Position: refs/heads/master@{#26810}

dafd7301

[turbofan] encode instruction operand as uint64_t · 92ccbefe

dcarney authored Feb 24, 2015

R=bmeurer@chromium.org

BUG=

Review URL: https://codereview.chromium.org/947153002

Cr-Commit-Position: refs/heads/master@{#26809}

92ccbefe

[turbofan] Initial version of branch cloning. · 0882d3ff

bmeurer authored Feb 24, 2015

This implements a special case of block cloning to recognize constructs like

 if (a ? b : c) { ... }

that happen to be generated by Emscripten quite often.

Review URL: https://codereview.chromium.org/947963002

Cr-Commit-Position: refs/heads/master@{#26808}

0882d3ff

Revert extra commit · 59275668

Erik Arvidsson authored Feb 24, 2015

"for-of should throw if result object is not an object"

The CQ committed the CL twice

This reverts commit ab2591ed.

BUG=None
TBR=adamk

Review URL: https://codereview.chromium.org/951133002

Cr-Commit-Position: refs/heads/master@{#26807}

59275668

23 Feb, 2015 18 commits

for-of should throw if result object is not an object · ab2591ed

arv authored Feb 23, 2015

This is done using desugaring. Before this we had:

  result = iterator.next()

with this we instead do:

  !%_IsSpecObject(result = iterator.next()) &&
      %ThrowIteratorResultNotAnObject(result)

BUG=v8:3916
LOG=N

Review URL: https://codereview.chromium.org/929733003

Cr-Commit-Position: refs/heads/master@{#26806}

ab2591ed

for-of should throw if result object is not an object · 87f77d6a

arv authored Feb 23, 2015

This is done using desugaring. Before this we had:

  result = iterator.next()

with this we instead do:

  !%_IsSpecObject(result = iterator.next()) &&
      %ThrowIteratorResultNotAnObject(result)

BUG=v8:3916
LOG=N

Review URL: https://codereview.chromium.org/929733003

Cr-Commit-Position: refs/heads/master@{#26805}

87f77d6a

Update GN build files with the cpu_arch -> current_cpu change. · f8abac93

dpranke authored Feb 23, 2015

R=machenbach@chromium.org, jochen@chromium.org
BUG=crbug.com/344767
LOG=Y

Review URL: https://codereview.chromium.org/946023002

Cr-Commit-Position: refs/heads/master@{#26804}

f8abac93

ES6 collections: Fix order of constructor logic · 36e72aed

arv authored Feb 23, 2015

The adder should be gotten before the iterator.

Motivation: Once this is done we should be able to use a for-of loop
instead which leads to cleaner code and correct behavior once the
for-of loop correctly supports abrupt completion.

BUG=None
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/949933002

Cr-Commit-Position: refs/heads/master@{#26803}

36e72aed

Prototype objects never share their map, and hence cannot be in deprecated state. · 74c0cdbf
verwaest authored Feb 23, 2015
```
Review URL: https://codereview.chromium.org/955433002

Cr-Commit-Position: refs/heads/master@{#26802}
```
74c0cdbf

Promise.all and race should work with iterables · 3a8e496f

arv authored Feb 23, 2015

BUG=v8:3705
LOG=N
R=rossberg@chromium.org

Review URL: https://codereview.chromium.org/948843004

Cr-Commit-Position: refs/heads/master@{#26801}

3a8e496f

Merge LookupResult into PropertyAccessInfo · ca623fae

verwaest authored Feb 23, 2015

BUG=

Review URL: https://codereview.chromium.org/939623004

Cr-Commit-Position: refs/heads/master@{#26800}

ca623fae

Revert "The expected key is a valid identifier, which is already free of \\, <0x20, "." · 460187b5

verwaest authored Feb 23, 2015

The optimization is invalid as indicated by the test.

BUG=
TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/950873003

Cr-Commit-Position: refs/heads/master@{#26799}

460187b5

Bump up version for 4.3 candidate. · 46c7d681

machenbach authored Feb 23, 2015

NOTRY=true
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/948003002

Cr-Commit-Position: refs/heads/master@{#26798}

46c7d681

MIPS: [turbofan] Fix several int vs size_t issues. · 585e50c3

balazs.kilvady authored Feb 23, 2015

Port 9c1407da

BUG=

Review URL: https://codereview.chromium.org/948843002

Cr-Commit-Position: refs/heads/master@{#26797}

585e50c3

emit premonomorphic ics for loads/stores in optimized code · 7361dce4

dcarney authored Feb 23, 2015

R=verwaest@chromium.org

BUG=

Review URL: https://codereview.chromium.org/892383003

Cr-Commit-Position: refs/heads/master@{#26796}

7361dce4

More tests added to cctest/tests/test-migrations.cc. · 4349b186

ishell authored Feb 23, 2015

This also includes a regression test for crbug/459512.

BUG=chromium:459512
LOG=N

Review URL: https://codereview.chromium.org/947103002

Cr-Commit-Position: refs/heads/master@{#26795}

4349b186

disable some harmony scoping tests · 102ddf35

dcarney authored Feb 23, 2015

R=verwaest@chromium.org

BUG=v8:3914
LOG=N

Review URL: https://codereview.chromium.org/914333002

Cr-Commit-Position: refs/heads/master@{#26794}

102ddf35

MIPS64: Implement optimization utilizing signaling NaN for holes in double arrays. · c1f8f727
dusan.milosavljevic authored Feb 23, 2015
```
TEST=
BUG=

Review URL: https://codereview.chromium.org/945823002

Cr-Commit-Position: refs/heads/master@{#26793}
```
c1f8f727

Revert of Correctly propagate terminate exception in TryCall. (patchset #2... · 035b144b

machenbach authored Feb 23, 2015

Revert of Correctly propagate terminate exception in TryCall. (patchset #2 id:20001 of https://codereview.chromium.org/928193002/)

Reason for revert:
See crbug.com/460412 and crbug.com/460356. Reverting on master in order to roll from master again soon.

Original issue's description:
> Correctly propagate terminate exception in TryCall.
>
> BUG=v8:3892
> LOG=Y
>
> Committed: https://crrev.com/a49b55b78844557b65a98e7a77dd26078157ed7f
> Cr-Commit-Position: refs/heads/master@{#26685}

TBR=ishell@chromium.org,yangguo@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:3892

Review URL: https://codereview.chromium.org/946973004

Cr-Commit-Position: refs/heads/master@{#26792}

035b144b

Revert of [x64] Improve instruction selection for TruncateInt64ToInt32.... · 61ac4613

bmeurer authored Feb 23, 2015

Revert of [x64] Improve instruction selection for TruncateInt64ToInt32. (patchset #1 id:1 of https://codereview.chromium.org/936323004/)

Reason for revert:
Breaks SQLite

Original issue's description:
> [x64] Improve instruction selection for TruncateInt64ToInt32.
>
> R=svenpanne@chromium.org
>
> Committed: https://crrev.com/64a2717529e2197f3a789adabf86ca36f5eb764c
> Cr-Commit-Position: refs/heads/master@{#26739}

TBR=svenpanne@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/928723003

Cr-Commit-Position: refs/heads/master@{#26791}

61ac4613

[linux] Use _GLIBCXX_DEBUG in Debug builds by default for better checking. · b9513848

bmeurer authored Feb 23, 2015

The _GLIBCXX_DEBUG macro is now set by default for Linux Debug builds
and can be disabled using the disable_glibcxx_debug=1 setting
(compatible with Chrome).  This will help us catch problems earlier.

BUG=v8:3638
LOG=n

Review URL: https://codereview.chromium.org/946283003

Cr-Commit-Position: refs/heads/master@{#26790}

b9513848

[turbofan] Fix several int vs size_t issues. · 9c1407da

bmeurer authored Feb 23, 2015

R=svenpanne@chromium.org

Review URL: https://codereview.chromium.org/946553002

Cr-Commit-Position: refs/heads/master@{#26789}

9c1407da

20 Feb, 2015 5 commits

Replace is_reference_error bool argument with ParseErrorType enum · 82368b17

adamk authored Feb 20, 2015

This avoids accidental coercion-to-bool when calling ReportMessage()
in the parser (e.g., from pointer types), and as a bonus makes callsites
easier to read.

Review URL: https://codereview.chromium.org/939303002

Cr-Commit-Position: refs/heads/master@{#26788}

82368b17

Fix issue with -0 in Maps · 925364f5

arv authored Feb 20, 2015

Because we generated a different hash code for 0 and -0 we ended up
not even getting to the SameValueZero check.

BUG=v8:3906
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/947443005

Cr-Commit-Position: refs/heads/master@{#26787}

925364f5

ES6: Fix GetIterator · fa1523ea

arv authored Feb 20, 2015

After further spec reading it turns out that we should not do ToObject
on the iterable.

BUG=None
LOG=N
R=adamk

Review URL: https://codereview.chromium.org/941313003

Cr-Commit-Position: refs/heads/master@{#26786}

fa1523ea

MIPS: Fix label position types in binding code. · 39f58c24

balazs.kilvady authored Feb 20, 2015

Also some target_at and target_at_put uniformed on mips and mips64.

BUG=

Review URL: https://codereview.chromium.org/942123002

Cr-Commit-Position: refs/heads/master@{#26785}

39f58c24

Change bit pattern of hole nan to reflect different sNan encoding on mips HW. · 4e946e3e
dusan.milosavljevic authored Feb 20, 2015
```
TEST=
BUG=

Review URL: https://codereview.chromium.org/945813002

Cr-Commit-Position: refs/heads/master@{#26784}
```
4e946e3e