- 05 May, 2020 1 commit
-
-
Liviu Rau authored
Slow tests are now collected in a heap with a fixed size. When the maximum size is reached we evict the fastest test after adding a new test to the heap. Bug: v8:10168 Change-Id: If3298df85d6e924451f55fe9350e293169cc849d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2106205 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#67572}
-
- 19 Feb, 2020 1 commit
-
-
Michael Achenbach authored
The extra checks done with --testing-d8-test-runner might not hold when using NumFuzz. This refactors the test runner and allows passing implementation specific flags. The --testing-d8-test-runner flag is now only passed in the standard-runner not in the numfuzz implementation. Bug: v8:10220 Change-Id: I83cac57a948c98c34f2d84f41d719e0434e25ee7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2064217 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#66341}
-
- 21 Jan, 2020 1 commit
-
-
Liviu Rau authored
Bug: v8:9641 Change-Id: Ia85d14677e8eb7d2d14ff7eb150a1b0b279642f4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1998078 Commit-Queue: Liviu Rau <liviurau@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#65892}
-
- 16 Jan, 2020 1 commit
-
-
Michael Achenbach authored
When an overall timeout is reached, swarming sends a SIGTERM to terminate the test runner. The test runner has a signal handler on the main process to terminate all workers gracefully. Additionally, every worker process installs a signal handler for terminating ongoing tests wrapped by command.Command. Also, command.Command is used on the main process to list tests for cctest and gtest executables, which led to overriding the test runner's main signal handler. This CL disables using signal handlers in commands by default and only explicitly enables it in safe source locations. Bug: v8:8292 Change-Id: Ifceadaff75bdd2b77e761498bccbe00b6a3e265c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2002528Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#65815}
-
- 22 Oct, 2019 2 commits
-
-
Simon Zünd authored
Embedded builtins are now unconditionally enabled, which removes the need to differentiate between enabled/disabled embedded builtins. This Cl removes the 'embedded_builtins' variant and related *.status entries. R=machenbach@chromium.org Bug: v8:8519 Change-Id: I55d0dd54735b7cc437832af6fa2836fd6c14a317 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864936 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64464}
-
Simon Zünd authored
This CL removes the 'v8_enable_embedded_builtins' GN argument and sets the 'V8_EMBEDDED_BUILTIN' define unconditionally. Removing the now obsolete 'define' and corresponding C++ code will be done in a separate CL. R=machenbach@chromium.org Bug: v8:8519 Change-Id: Ibaa3e958121931c0ce14baf48ad401fab87c5337 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864929 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64456}
-
- 16 Oct, 2019 1 commit
-
-
Simon Zünd authored
This is a reland of 1c56974f This is a plain reland of the original CL. The original CL was speculatively reverted, but ended up not being the cause for bot failures. Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Bug: v8:8531 Change-Id: Id75a802279238138f7aefec62e0b6425a5acc08d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1864649Reviewed-by: Simon Zünd <szuend@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#64305}
-
- 15 Oct, 2019 2 commits
-
-
Clemens Backes authored
This reverts commit 1c56974f. Reason for revert: Causes several bots to timeout, e.g. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20debug/27945 Original change's description: > Unconditionally enable snapshot builds and remove 'v8_use_snapshot' > > This CL removes 'v8_use_snapshot' and the usages of the implied > V8_USE_SNAPSHOT define. One test runner unittest was updated to use the > "asan" variant instead of the now obsolete "no_snap" variant. > > Related chromium CL: https://crrev.com/c/1796325. > > Bug: v8:8531 > Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 > Commit-Queue: Simon Zünd <szuend@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64290} TBR=thakis@chromium.org,machenbach@chromium.org,mstarzinger@chromium.org,jgruber@chromium.org,tmrts@chromium.org,szuend@chromium.org Change-Id: I4024d818877e534b9f7908a2d14f33dca35b5924 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8531 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1862572Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64293}
-
Simon Zünd authored
This CL removes 'v8_use_snapshot' and the usages of the implied V8_USE_SNAPSHOT define. One test runner unittest was updated to use the "asan" variant instead of the now obsolete "no_snap" variant. Related chromium CL: https://crrev.com/c/1796325. Bug: v8:8531 Change-Id: I5da7c9f8e9110fe7bc0f4e4f821bcb7f7d98f927 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1784282 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Nico Weber <thakis@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#64290}
-
- 11 Jul, 2019 1 commit
-
-
Mythri A authored
With lazy feedback allocation and bytecode flushing we need to call %PrepareFunctionForOptimize before we call %OptimizeFunctionOnNextCall/ %OptimizeOsr. This cl: 1. Adds an additional state in pending optimized table to check if the optimization was triggered manually. 2. Changes the compilation pipeline to delete the entry from pending optimized table only if the optimization was triggered through %OptimizeFunctionOnNextCall / %OptimizeOsr. 3. Adds a check to enforce %PrepareFunctionForOptimize was called. 4. Adds a new run-time flag to only check in the d8 test runner. We don't want this check enabled in other cases like clusterfuzz that doesn't ensure %PrepareFunctionForOptimize is called. Bug: v8:8394, v8:8801, v8:9183 Change-Id: I9ae2b2da812e313c746b6df0b2da864c2ed5de51 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1664810 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#62653}
-
- 09 May, 2019 1 commit
-
-
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:880724 Change-Id: I2b8ede244fa09868eef384b967223a3788ddd2a1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581180 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61370}
-
- 07 May, 2019 1 commit
-
-
Michael Achenbach authored
Bug: v8:9145 Change-Id: Idb1a838666ea21cb260a141929fd80b400913836 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1596731Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61262}
-
- 04 May, 2019 1 commit
-
-
Sergiy Belozorov authored
Overall, total test runtime that was wasted due to timeouts is 3420 seconds in the last 2 weeks. Even with 4 retries, assuming all of them time out, needed additional capacity is under 2 hours per week. Based on this analysis, I think it's safe to land this CL. Note that this is not intended as a long-term solution of the timeout problem, but rather a temporary solution to prevent ongoing errors. Proper investigation and correct long-term solution are still needed and tracked in the bug. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: Id16e6b784fa85bb9e28ed8c6b267b583636e2dc1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1593342Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#61224}
-
- 29 Apr, 2019 1 commit
-
-
Sergiy Belozorov authored
This is needed to allow deriving timeout and near_timeout runnables on the recipe side and drop corresponding fields in the output. We also remove some unused code that was removed in previous refactoring CLs. R=tmrts@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Ib7cec9baceff994fb9b32be09ba4a4079ebff2c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1588417 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#61095}
-
- 26 Apr, 2019 2 commits
-
-
Sergiy Belozorov authored
This also makes processing immediate, i.e. outputs are parsed into results as soon as test run is finished, which will allow us to implement logic that checks whether we have enough runs based on already-accumulated results. Since we process each output immediately, we do not need Measurement class any longer and its ConsumeOutput is now integrated directly into TraceConfig. Similarly AccumulateResults is replaced with RunnableConfig.ProcessOutput as we do not accumulate results any longer. R=machenbach@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:880724 Change-Id: I0fc4846024c43258c10ba8d568312aa4746d746f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1584325 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61048}
-
Sergiy Belozorov authored
This is part of the refactoring needed to implement a feature that allows re-running benchmarks until needed confidence is reached. R=machenbach@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:880724 Change-Id: I45f584a3503ecf567f4c2661a302a74fc5e516af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581605 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61037}
-
- 24 Apr, 2019 1 commit
-
-
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I9852ccc573eda6b1bab7a7db295f7fd6e7410581 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570010 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60967}
-
- 23 Apr, 2019 3 commits
-
-
Sergiy Belozorov authored
This is dead code as no benchmarks seem to be using it and removing this additional logic will reduce maintenance cost for the perf infrastructure. R=machenbach@chromium.org, tmrts@chromium.org No-Try: true No-Tree-Checks: true Change-Id: I952af069d4d18d63624510b4c461fa1891703db9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570008 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60947}
-
Sergiy Belozorov authored
This is part of the refactoring to allow exporting more information about test execution to the recipes and upload this information to ChromePerf. This fixes running secondary even after primary run fails, which will allow us to differentiate between test and infra failures as latter ones will also affect refbuilds and re-runs without patch. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I29ce49d2f8c5e73158f1d41a73c51f2b35929f36 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570006 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60946}
-
Sergiy Belozorov authored
This is part of the refactoring to allow exporting more information about test execution to the recipes and upload this information to ChromePerf. R=machenbach@chromium.org,tmrts@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:841700 Change-Id: Iab400e8922231d8eac91a6fa22ce8f45053f7ac6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1569442Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60944}
-
- 12 Apr, 2019 1 commit
-
-
Sergiy Belozorov authored
- Remove all relative imports from mock and os - Fix mocking in a few tests to prevent cross-test side-effects - Add run_perf_test.py to v8_presubmit.py - The vpython config was not added since root .vpython already includes coverage and mock libraries - Convert all double-quoted strings to single-quoted (PS8->PS9) R=sergiyb@chromium.org Bug: chromium:123456 Change-Id: I7b3a08dc5d950b0f51cc7a5eb3a012ea953ca824 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564206 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60810}
-
- 11 Apr, 2019 1 commit
-
-
Michael Achenbach authored
This will allow to distinguish between the standard runner and the num fuzzer on the infra side when generating flako command lines. The value could be inferred, but it'd be more confusing. Bug: v8:8971 Change-Id: I78f5104135d1c7fd7d98bceb4b17897e79421455 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1564050 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60769}
-
- 05 Apr, 2019 1 commit
-
-
Michael Achenbach authored
For standard test failures, the variant name is enough to deduce the full command line of the test. This is used to create the flako command line on the infra side. Test failures from numfuzz have additional variant_flags, calculated by the fuzzer, which don't match a variant name. Exposing those in the test results will enable printing a proper flako command line on infra side for numfuzz cases. Bug: v8:8971 Change-Id: Ie47d42a0b34037da458b474f2a9ab38f1a5d238a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1554689Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60656}
-
- 03 Apr, 2019 1 commit
-
-
Clemens Hammacher authored
Reading --verify_predictable makes me sad, whereas --verify-predictable makes me happy. This CL introduces more happiness. R=machenbach@chromium.org Bug: v8:8834 Change-Id: Id51a75f32e6d5a2f87aed81e058a8b6dff189758 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1550399Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60599}
-
- 27 Feb, 2019 1 commit
-
-
Michael Achenbach authored
Also enable test runner to differentiate between clang and gcc. Bug: v8:8919 Change-Id: Icdcae0aba3644a1b1b9ddc6c037eabde27d717f7 Reviewed-on: https://chromium-review.googlesource.com/c/1491634Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59906}
-
- 19 Feb, 2019 1 commit
-
-
Vadim Gorbachev (bmsdave) authored
There are now less that 400 days until the end of life of Python 2(aka _legacy_ Python) https://pythonclock.org/ . The code compatibility check for python2 and python3 used the following tools: futurize, flake8 You can see the reports here: https://travis-ci.com/bmsdave/v8/builds This CL was uploaded by git cl split. Bug: v8:8594 Change-Id: I661c52a70527e8ddde841fee6d4dcba282b4a938 Reviewed-on: https://chromium-review.googlesource.com/c/1470123 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#59675}
-
- 12 Feb, 2019 3 commits
-
-
Tamer Tas authored
Using test generators meant that we had to remove the progress indicator since the total number of tests weren't known before-hand. This CL implements a progress indicator using test number estimations. cctest and unittests progress indicator is accurate, however estimating means the progress will terminate over 100% in big test suites and sometimes under 100%. R=machenbach@chromium.org CC=sergiyb@chromium.org,yangguo@chromium.org Bug: v8:8769 Change-Id: I40ca5b40f9b1223376d33707f0945900ea98cea3 Reviewed-on: https://chromium-review.googlesource.com/c/1460471 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59538}
-
Tamer Tas authored
Testrunner test-suite doesn't have automated tests for the Fuzzer. A significant change for the testrunner may break the fuzzers. We don't have a way to catch even the syntax errors for the fuzzer before landing CLs. This CL creates a rudimentary test-suite that runs the fuzzer without any tests to see if APIs still work as intended. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: v8:8763 Change-Id: Ib4519ca093de2af5279964edd164cee04aae77a8 Reviewed-on: https://chromium-review.googlesource.com/c/1466301Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59535}
-
Tamer Tas authored
Testrunner runs variants of a test sequentially without taking sharding into account. A slow test with slow variants slows down the whole test run no matter the sharding configuration. This CL implements a test hashing algorithm and variant sharding for test variants. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I15f8c547fa2f361fb6c53bf8d5df055d3df38d3e Reviewed-on: https://chromium-review.googlesource.com/c/1458016 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59530}
-
- 07 Feb, 2019 1 commit
-
-
Tamer Tas authored
The test name alone isn't informative alone. This CL prints the variant name during the progress reporting. tested by running test262 with all variants R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8728 Change-Id: I3d7d1fc6eacef3712d87404c7276fd5523bb445a Reviewed-on: https://chromium-review.googlesource.com/c/1458156 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59437}
-
- 06 Feb, 2019 1 commit
-
-
Tamer Tas authored
This is a reland of 81eec150 Original change's description: > Reland "[test] refactor testsuite configuration" > > This is a reland of 7f92ad0a > > Original change's description: > > [test] refactor testsuite configuration > > > > Every testsuite configuration consist of at least 30% code duplication. > > > > The code age ranges from 10 years old to 5 years old. Implementing anything that > > touches the testsuite code becomes a technical fight to the death. > > > > This CL removes all the duplication by refactoring the common functionality. > > > > This CL contains structural changes without any logical changes % small bug > > fixes. > > > > R=machenbach@chromium.org > > CC=yangguo@chromium.org,sergiyb@chromium.org > > > > Bug: v8:8174, v8:8769 > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59361} > > Bug: v8:8174, v8:8769 > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 > Reviewed-on: https://chromium-review.googlesource.com/c/1454485 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59369} Bug: v8:8174, v8:8790 Change-Id: I38ab9d37bca76057441a970f26e2102e4387a857 Reviewed-on: https://chromium-review.googlesource.com/c/1454724 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59387}
-
- 05 Feb, 2019 4 commits
-
-
Tamer Tas authored
This reverts commit 81eec150. Reason for revert: windows mozilla test failures Original change's description: > Reland "[test] refactor testsuite configuration" > > This is a reland of 7f92ad0a > > Original change's description: > > [test] refactor testsuite configuration > > > > Every testsuite configuration consist of at least 30% code duplication. > > > > The code age ranges from 10 years old to 5 years old. Implementing anything that > > touches the testsuite code becomes a technical fight to the death. > > > > This CL removes all the duplication by refactoring the common functionality. > > > > This CL contains structural changes without any logical changes % small bug > > fixes. > > > > R=machenbach@chromium.org > > CC=yangguo@chromium.org,sergiyb@chromium.org > > > > Bug: v8:8174, v8:8769 > > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59361} > > Bug: v8:8174, v8:8769 > Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 > Reviewed-on: https://chromium-review.googlesource.com/c/1454485 > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59369} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org Change-Id: I8f5650b5f46be299c004e2fa8b708fa2c17a4dc2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454607Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59370}
-
Tamer Tas authored
This is a reland of 7f92ad0a Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} Bug: v8:8174, v8:8769 Change-Id: I8e7078cfb875ceb3777e57084e6f8dfac09693e7 Reviewed-on: https://chromium-review.googlesource.com/c/1454485Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59369}
-
Tamer Tas authored
This reverts commit 7f92ad0a. Reason for revert: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Win32/19148 Original change's description: > [test] refactor testsuite configuration > > Every testsuite configuration consist of at least 30% code duplication. > > The code age ranges from 10 years old to 5 years old. Implementing anything that > touches the testsuite code becomes a technical fight to the death. > > This CL removes all the duplication by refactoring the common functionality. > > This CL contains structural changes without any logical changes % small bug > fixes. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8174, v8:8769 > Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1445881 > Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59361} TBR=machenbach@chromium.org,sergiyb@chromium.org,tmrts@chromium.org,v8-reviews@chromium.org Change-Id: I473f0d4c6b9c0239923b8c03699dbc38b7f85030 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8174, v8:8769 Reviewed-on: https://chromium-review.googlesource.com/c/1454599 Commit-Queue: Tamer Tas <tmrts@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59362}
-
Tamer Tas authored
Every testsuite configuration consist of at least 30% code duplication. The code age ranges from 10 years old to 5 years old. Implementing anything that touches the testsuite code becomes a technical fight to the death. This CL removes all the duplication by refactoring the common functionality. This CL contains structural changes without any logical changes % small bug fixes. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174, v8:8769 Change-Id: Iee299569caa7abdc0307ecf606136669034a28a2 Reviewed-on: https://chromium-review.googlesource.com/c/1445881 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59361}
-
- 01 Feb, 2019 3 commits
-
-
Tamer Tas authored
This is a reland of 101fd4dd Original change's description: > [testrunner] catch unforeseen exceptions > > Testrunner doesn't catch exceptions except TestRunnererror, KeyboardInterrupt. > > Unforeseen exceptions should fail the CI step. > > This CL returns an error exit code for uncaught exceptions. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8731 > Change-Id: I7fb20dad4a3eea29f1dfa87ef91d45381ee08692 > Reviewed-on: https://chromium-review.googlesource.com/c/1434034 > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59278} Bug: v8:8731 No-Try: true No-Tree-Checks: true Change-Id: Ic580b334697ecebec923e76ff4a3e09fdf24dc8c Reviewed-on: https://chromium-review.googlesource.com/c/1449632Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#59283}
-
Tamer Tas authored
This reverts commit 101fd4dd. Reason for revert: Uncaught exception in the recipe API https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux/29928 Original change's description: > [testrunner] catch unforeseen exceptions > > Testrunner doesn't catch exceptions except TestRunnererror, KeyboardInterrupt. > > Unforeseen exceptions should fail the CI step. > > This CL returns an error exit code for uncaught exceptions. > > R=machenbach@chromium.org > CC=yangguo@chromium.org,sergiyb@chromium.org > > Bug: v8:8731 > Change-Id: I7fb20dad4a3eea29f1dfa87ef91d45381ee08692 > Reviewed-on: https://chromium-review.googlesource.com/c/1434034 > Commit-Queue: Tamer Tas <tmrts@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59278} TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ia2b661c1a71d1799693383bc942a9a1d47668b24 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8731 Reviewed-on: https://chromium-review.googlesource.com/c/1449692Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#59282}
-
Tamer Tas authored
Testrunner doesn't catch exceptions except TestRunnererror, KeyboardInterrupt. Unforeseen exceptions should fail the CI step. This CL returns an error exit code for uncaught exceptions. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8731 Change-Id: I7fb20dad4a3eea29f1dfa87ef91d45381ee08692 Reviewed-on: https://chromium-review.googlesource.com/c/1434034 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#59278}
-
- 21 Jan, 2019 2 commits
-
-
Tamer Tas authored
With and without infra_staging flag testrunner behaves the same for old features. This CL removes duplicate tests testing the same behavior. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org No-Try: true Bug: v8:8174 Change-Id: Icf7bea15b2343b90697016d050fa0d918a99997d Reviewed-on: https://chromium-review.googlesource.com/c/1424859Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#58951}
-
Tamer Tas authored
Moving to a lazy test loading approach makes counting the total number of tests non-trivial. For CI runs, we output the total number of tests after the run. For users, progress indicator signals the status of the run. R=machenbach@chromium.org CC=yangguo@chromium.org,sergiyb@chromium.org Bug: v8:8174 Change-Id: I0731964515aac60a3629acee6c7243433a2b4e04 Reviewed-on: https://chromium-review.googlesource.com/c/1420677 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#58944}
-