- 25 Apr, 2019 9 commits
-
-
peterwmwong authored
It shipped in Chrome 73. Bug: v8:6890 Change-Id: Idd8c98cf05a0d6e8fa58c5b0a34d079631f68b1b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582879Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#61005}
-
Simon Zünd authored
TypedArray#sort has a fast-path when the user does not provide a comparison function. This fast-path utilizes std::sort which operates directly on the raw data. Per spec, std::sort requires the "less than" operation to be anti-symmetric and transitive. When sorting SharedArrayBuffers (SAB) that are concurrently modified during sorting, the "less than" operator stops being consistent as the underlying data is constantly modified. This breaks some invariants in std::sort resulting in infinite loops or straight out segfaults. This CL fixes this by copying the data before sorting SABs and writing the sorted result back. Note: The added regression test is tailored for ASAN bots as a normal build would need too many iterations to consistently crash. R=neis@chromium.org, petermarshall@chromium.org Bug: v8:9161 Change-Id: Ic089928652f75865bfdb11e7453806faa6ecb988 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581641Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#61004}
-
Simon Zünd authored
This CL refactors and extends the infrastructure around sending diagnostic notifications. This enables publishing lint errors as warnings after a compilation run. R=sigurds@chromium.org, tebbi@chromium.org Bug: v8:8880 Change-Id: Ia64d2d490c1449021c92f5dc45eb7f8dab21e60a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582405 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#61003}
-
Michael Achenbach authored
Bug: chromium:775123 Change-Id: I970bdbb9759f765257167531110a16cb4257af10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581607 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#61002}
-
Michael Achenbach authored
NOTRY=true TBR=sergiyb@chromium.org Bug: v8:9058 Change-Id: I61a3f28565e703304315ef5758c7d1796ec4cb1e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582406Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#61001}
-
Jakob Gruber authored
When the snapshot blob is not aligned properly, loading it can cause a crash on platforms such as arm. This was exposed by a SIGBUS/BUS_ADRALN crash on arm when accessing the blob_data symbol (declared as a byte array) through a reinterpret cast to uintptr_t in an internal snapshot build. Thanks to florian.dold@gmail.com for the initial patch. Bug: v8:9171 Change-Id: I99b071dec3733416f2f01b58a770e30d8f2dcdf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582402 Commit-Queue: Dan Elphick <delphick@chromium.org> Auto-Submit: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#61000}
-
Jakob Gruber authored
This reverts commit 7a2651cb. Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Android%20Arm64%20-%20N5X/4126 Original change's description: > [arm64] Cleanup TODO around handling of x18 > > Use `padreg` instead of x18 to maintain alignment in the CPURegList. > > Also clean up some comments and tidy up RequiredStackSizeForCallerSaved > and PushCallerSaved. > > Change-Id: I80a780e5649e69a1746c43f37c2d1d875120c7a0 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581609 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> > Cr-Commit-Position: refs/heads/master@{#60987} TBR=jgruber@chromium.org,martyn.capewell@arm.com,joey.gouly@arm.com Change-Id: Id95ac26142717f6503d284d20ca03b9de33a9122 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582403Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/ebb658a..63246bb Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5160e91..8ab7b3e Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/429d9b4..ab7b8fe Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0d82718..bdc80cb TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Id0b0c5d63e8330487e01e1f4e479f125516bc560 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582836Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60998}
-
Kevin Gibbons authored
Bug: v8:9160 Change-Id: If3f624c1ccf1ed397daa3e30b3a7ec2a73b7c9b7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578279Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Kevin Gibbons <bakkot@gmail.com> Cr-Commit-Position: refs/heads/master@{#60997}
-
- 24 Apr, 2019 31 commits
-
-
Sathya Gunasekaran authored
Make sure to adapt the formal parameters for the Promise.allSettled method. Bug: v8:7834 Change-Id: I255fc695f5ac0d62ed18f5aad78665feb38c241a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1580239 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Reviewed-by:
-
Z Duong Nguyen-Huu authored
Also, fix CSA generator for call runtime with return type of object. Spec: https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-get-p-receiver Bug: v8:6664 Change-Id: I61ce1fa72a498520dd811f034e182f060f115330 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1573042 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Cr-Commit-Position: refs/heads/master@{#60995}
-
Sathya Gunasekaran authored
This reverts commit 98bbe37e. Reason for revert: breaks gc_stress bot https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22113 Original change's description: > Remove always-true --harmony-object-from-entries runtime flag > > It shipped in Chrome 73. > > Bug: v8:8021 > Change-Id: I82875829ff081ce055a0184170b15c65efca1c38 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581647 > Commit-Queue: Mathias Bynens <mathias@chromium.org> > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Auto-Submit: Mathias Bynens <mathias@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60992} TBR=gsathya@chromium.org,mathias@chromium.org Change-Id: I812d62a7e8b70a8646e606da5f0f8812fac330c7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8021 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582882 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#60994}
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: I4d4d9b65a346384b8f6c6dc2cfe0c1ce88116e18 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1574503 Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Reviewed-by:
-
Mathias Bynens authored
It shipped in Chrome 73. Bug: v8:8021 Change-Id: I82875829ff081ce055a0184170b15c65efca1c38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581647 Commit-Queue: Mathias Bynens <mathias@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Auto-Submit: Mathias Bynens <mathias@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This reverts commit 81dd67db. Reason for revert: Breaks gc-stress: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/22111 Original change's description: > Improve test coverage for non-extensible holey array in optimized code > > Bug: v8:6831 > Change-Id: Icb4b504771e623b3c9503c6daffd7b771fbef3a6 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575036 > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#60990} TBR=verwaest@chromium.org,duongn@microsoft.com Change-Id: I0a581c1e47d9883a2727000843ad4e9ede2e411d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:6831 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581648Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60991}
-
Z Duong Nguyen-Huu authored
Bug: v8:6831 Change-Id: Icb4b504771e623b3c9503c6daffd7b771fbef3a6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1575036Reviewed-by:
-
Ross McIlroy authored
This is a reland of d6121fd1 Original change's description: > [Interpreter] Ensure Test*Handler don't allocate a frame for fast-path. > > Avoids allocating a frame for the fast-path in TestEqual, TestEqualStrict and > TestLess/GreaterThan bytecode handlers. Also changes how feedback is tracked > to try and avoid needing to keep feedback to "combine" with if it's unecessary > which reduces the liveranges of the registers holding this data. > > This reduces the time needed for a tight loop in Ignition (e.g., > while (i < 1000000000) ++i;) from 12.8s to 10.8s. > > BUG=v8:9133 > > Change-Id: I686b9da89541d15d233635db3276de3dad2fa282 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570020 > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60906} TBR=jgruber@chromium.org Bug: v8:9133 Change-Id: Ie9940d029d412986e6713438630565a98fe3c51c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1582401Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#60989}
-
Hannes Payer authored
Bug: v8:9093 Change-Id: I6d71e8ebd34e2495312b01facbb896e0d5ae8a8a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581645 Auto-Submit: Hannes Payer <hpayer@chromium.org> Commit-Queue: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#60988}
-
Joey Gouly authored
Use `padreg` instead of x18 to maintain alignment in the CPURegList. Also clean up some comments and tidy up RequiredStackSizeForCallerSaved and PushCallerSaved. Change-Id: I80a780e5649e69a1746c43f37c2d1d875120c7a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581609Reviewed-by:
-
Tobias Tebbi authored
The order of the typeswitch branches causes repeated Smi-checks. This CL fixes this by putting the Number case first. However, the generated code is still worse due to repeated Map and InstanceType loads. This will be fixed by a future load elimination for Torque/CSA. Bug: chromium:955976 Change-Id: I0f59ef795878f65b3cb11246626738bc33f8aff5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581644 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
-
Mathias Bynens authored
It shipped in Chrome 72. Bug: v8:7782 Change-Id: I9ddee4370dd65821020dd7292d9e9b9850d060df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581603Reviewed-by:
-
Tobias Tebbi authored
Add suport for large object space allocations in Turbofan and use it from CSA when young large objects are enabled. This maintains the Turbofan invariant that the generation is statically predictable. In principle, this enables write barrier elimination for large objects allocated from Torque/CSA. But it doesn't seem to trigger much yet, probably we have to improve the MemoryOptimizer. Bug: v8:7793 Change-Id: I7ea7d0cb549573db65fafe5df5edf67e0ce90893 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1565905Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#60984}
-
Simon Zünd authored
This CL changes lint errors to not be printed directly to stderr. Instead, they are collected in a list that gets surfaced via the TorqueCompilerResult. This is done so they can be presented to language server clients. This change also removes the "abort_on_lint_errors" option. API users can now decide for themselves what to do, depending on the presence of lint errors in the returned list. R=sigurds@chromium.org, tebbi@chromium.org Bug: v8:8880 Change-Id: I44601010491aafcf4c8609fd8c115219317506a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581608Reviewed-by:
-
Igor Sheludko authored
... and make the checks stricter. Bug: chromium:954852 Change-Id: Ib28246d275b0cadff00012f02f8aca4c4c235cc5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581599 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#60982}
-
Jakob Gruber authored
When collecting JS block coverage, we track block execution counts on so-called CoverageInfo objects. Generated bytecode and native code contains inlined snippets of code to increment the appropriate counters. These used to be implemented as calls to the IncBlockCounter runtime function. Each call incurred the entire CEntry overhead. This CL reduces that overhead by moving logic over into a new IncBlockCounter TFS builtin. The builtin is called directly from bytecode, and lowered to the same builtin call for optimized code. Drive-by: Tweak CoverageInfo layout to generate faster code. Tbr: jarin@chromium.org Bug: v8:9149, v8:6000 Change-Id: I2d7cb0db649edf7c56b5ef5a4683d27b1c34605c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1571420Reviewed-by:
-
Sergiy Belozorov authored
The --run-count-multiplier flag was used to run an experiment and is not needed anymore. It will be superceeded by another parameter that will run benchmarks as many times as needed until needed confidence is achieved. R=machenbach@chromium.org No-Try: true No-Tree-Checks: true Bug: chromium:880724 Change-Id: Iedd3d0f900a838f97cfa3339f582f6d02cce3e93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578504 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
peterwmwong authored
Bug: v8:8976 Change-Id: Idc896770fd0f448c37d8d83b7970e3f8e16f5f2e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1572682 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Reviewed-by:
-
Jaroslav Sevcik authored
This fixes the bounds check for the 'in' operator to handle the negative index case properly (by using the same machinery as the potentially out-of-bounds loads/stores use). Bug: chromium:952586 Change-Id: I2225acae8be7dcedbcde745e8ef202e789085041 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581179Reviewed-by:
-
Michael Starzinger authored
This extends the existing test coverage of interactions between the exception handling and the reference type proposal. Now "any-func" and "except-ref" can both be encoded as an exception value. Missing switch cases have been added. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-anyref[-interpreter] BUG=v8:8091,v8:7581 Change-Id: Ie2e9819fe66b4daab623390f27bb19007131f619 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581600Reviewed-by:
-
Ross McIlroy authored
On Arm/64 the last return address is stored in a link register instead of being pushed to the top-of-stack like on x64/ia32. Extend the support in the tick sampler to check for samples in a frameless bytecode handler with support for checking the link register if it exists instead of top-of-stack. In addition, make the x64/ia32 check more robust by ensuring we only apply the change if the pc is a bytecode handler and the top frame isn't a bytecode handler (stub) frame. BUG=v8:9162 Change-Id: I89d2e80ea8a0b84ff6a265d0e0e73f9fdd1daca8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578464Reviewed-by:
-
Clemens Hammacher authored
Use the existing {ArrayVector} method for this, which reads nicer. In some places, I replaced a stack-allocated array by {EmbeddedVector} to avoid the {ArrayVector} call. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: I5560c07f2775338fefd11acf67a540e003428e74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578899Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#60975}
-
Clemens Hammacher authored
This is one step towards removing the {StrLength} helper and using {size_t} consistently instead. R=mstarzinger@chromium.org Bug: v8:8834 Change-Id: Ibcdfd579531a259d490c39a8e8c96d469a5a4aac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578901 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: -
Sigurd Schneider authored
This reverts commit fa6ec3cb. Reason for revert: v8:9169, v8:9170 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux/31457 https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64/31417 https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/19919 Original change's description: > [cpu-profiler] Split out debug mode for CPU profiler naming > > Adds a new flag to CpuProfiler to control whether or not "debug" names > (potentially inferred from scope) are used for captured frames > associated with a SharedFunctionInfo instance. > > Bug: v8:9135 > Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60972} TBR=ulan@chromium.org,alph@chromium.org,yangguo@chromium.org,petermarshall@chromium.org,acomminos@fb.com Change-Id: I573194b5affd31fd0748b9ef3c45052e8ab420f5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9135 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1581639Reviewed-by:
-
Andrew Comminos authored
Adds a new flag to CpuProfiler to control whether or not "debug" names (potentially inferred from scope) are used for captured frames associated with a SharedFunctionInfo instance. Bug: v8:9135 Change-Id: I104f3246431dc6336de4e4688c0d98c86e0bb776 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1566169Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Removes APIs: - MarkIndependent - IsIndependent - MarkActive - RegisterExternalReference All weak persistent handles are now treated as independent. Users of traced handles should already use v8::EmbedderHeapTracer. This reverts commit 49954eb5. Bug: chromium:923361 Change-Id: I0b9fcd678964331f926f6b725f70eb64268ca33f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578462 Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
The current logic sometimes skips the request for a code logging stack guard request, even though no such request is pending. This happens if the previous stack guard already executed, but a foreground task is still pending. This CL fixes this by re-requesting a stack guard interrupt when the first code is added to the vector of outstanding code to be logged. Plus minor drive-by fix. R=mstarzinger@chromium.org Bug: v8:9163 Change-Id: I4937f3983f15e7122141b04ddb1432cd1f78828b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578461 Auto-Submit: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Michael Starzinger authored
R=titzer@chromium.org TEST=mjsunit/regress/regress-9165 BUG=v8:9165 Change-Id: If6d7d56bf164a85675590e69bf9857c11fc1b218 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578463Reviewed-by:
Ben Titzer <titzer@chromium.org> Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#60969}
-
Santiago Aboy Solanes authored
... for * in ("", "Tagged", "Signed"). Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:7703 Change-Id: I6891fea9596058e7290df7a6b6775dd8a184ea2f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1578500Reviewed-by: -
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:841700 Change-Id: I9852ccc573eda6b1bab7a7db295f7fd6e7410581 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1570010 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
This is an attempt to work around a potential toolchain bug. Disassembly of FlushICache: 00000000 <_ZN2v88internal11CpuFeatures11FlushICacheEPvj>: 0:·b5c0 ··push··{r6, r7, lr} 2:·af01 ··add·r7, sp, #4 4:·2702 ··movs··r7, #2 6:·4401 ··add·r1, r0 8:·f2c0 070f ··movt··r7, #15 c:·2200 ··movs··r2, #0 e:·df00 ··svc·0 10:·bdc0 ··pop·{r6, r7, pc} Bug: chromium:952759 Change-Id: I6a618607f58c394c364b2ebd9f11684871a8beee Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1579542 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
