- 03 Oct, 2019 3 commits
-
-
Pierre Langlois authored
When comparing with zero, we can generate a CBZ instruction instead of a CMP+B. If we teach TurboAssembler::JumpIfEqual() to do it then we can do it in code generated for binary switches. Change-Id: I39a045ed666fd6569bf9c9f6be28c4efbeeb01a9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1836254Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#64094}
-
Sathya Gunasekaran authored
Bug: v8:9552 Change-Id: If13a3ff1baa259cb0f51858c0d3c28bfef943499 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822038 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#64093}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/5de2214..12bec71 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/16236fc..bb31bb3 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/5eac9d3..336a2b1 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/925d2e5..22ecf17 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: Ie28ab13a9238ca48e801c1df532110da52d3b9aa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835747Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#64092}
-
- 02 Oct, 2019 16 commits
-
-
Irina Yatsenko authored
Change-Id: I63cf6cd9b22ea02846ec40eba214acb21304d418 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832637 Commit-Queue: Irina Yatsenko <irinayat@microsoft.com> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#64091}
-
Francis McCabe authored
This reverts commit b271ea3c. Reason for revert: breaks arm build: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm64%20-%20sim%20-%20debug/17575 Original change's description: > [ptr-compr] Disable double fields unboxing > > Double field unboxing optimization is incompatible with pointer compression so > we land this CL before enabling pointer compression in order to separate memory > and performance regressions caused by disabled double field unboxing from > pointer compression change. > > Bug: v8:9799 > Change-Id: Ic8118356496a3f351344215b409f9722de6c9355 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835546 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64089} TBR=ishell@chromium.org,verwaest@chromium.org Change-Id: Ief07d8d4b3c4a6f1439656f31b8d34ec99bf9747 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:9799 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834769Reviewed-by:
Francis McCabe <fgm@chromium.org> Commit-Queue: Francis McCabe <fgm@chromium.org> Cr-Commit-Position: refs/heads/master@{#64090}
-
Igor Sheludko authored
Double field unboxing optimization is incompatible with pointer compression so we land this CL before enabling pointer compression in order to separate memory and performance regressions caused by disabled double field unboxing from pointer compression change. Bug: v8:9799 Change-Id: Ic8118356496a3f351344215b409f9722de6c9355 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835546 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Ng Zhi An authored
We already use PACKED_OP_LIST to generate AVX instructions, this change reuses the same list to generate the SSE equivalents, by introducting a helper assembler instruction, ps, as the actual implementation (similar to out vps is used as the implementation for AVX packed singled-precision floats). Change-Id: I7dd72c2be75eb3ff5badf6d668780604cae8c684 Bug: v8:9396 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834621 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#64088}
-
Igor Sheludko authored
... which fail when double fields unboxing is disabled. Bug: v8:9799 Change-Id: I77f11046d5a50c37c113aa8d9c5b8ca1148a746b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835549Reviewed-by:
-
Ingvar Stepanyan authored
If script is not disassembled, still use the same script URL format for consistency. In particular, use an absolute `wasm://wasm/` prefix, like disassembled fake scripts do, instead of just a script name which appears to be a relative URL to devtools. Change-Id: Ib7632f9f3587ca4961eb4f0b884482b3a1a6e1f0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833685Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Ingvar Stepanyan <rreverser@google.com> Cr-Commit-Position: refs/heads/master@{#64086}
-
Mythri A authored
Premonomorphic state was only used for store globals to handle contextual store on a global object [1]. We now handle these differently and we move to fast handlers even without going through premonomorphic state after this cl: https://chromium-review.googlesource.com/c/v8/v8/+/1807356. Also, with lazy feedback this would be a relatively uncommon case anyway. So, we no longer need premonomorphic state. This cl removes this state entirely. [1]: https://bugs.chromium.org/p/v8/issues/detail?id=8712 Bug: v8:8394 Change-Id: I71fb918b82b0c321a9705e32c8fc44e9ec223b38 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833690Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
The creator of the allocator retains ownership and is responsible for its eventual destruction. Change-Id: Iaf1b24bee7153b3b1a75df99974adff42c6a197f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835545 Auto-Submit: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#64084}
-
Michael Lippautz authored
Fix corner case where we would try to read a property when having a pending or scheduled exception. Re-add tests. Bug: chromium:1006640 Change-Id: I2fc84ee0f6145db2d200a8b9abf57fdc4b12a5a3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835531Reviewed-by:
-
Mythri A authored
This is a reland of 9efe315e after marking box2d slow. Original change's description: > Mark functions for optimization only on bytecode budget interrupts > > We used to mark functions for optimization on any interrupt. This sometimes > causes functions to OSR when not needed. The implementation was such because > we didn't have a different runtime function to distinguish bytecode budget > interrupts from other interrupts. For lazy feedback allocation we added a > new runtime function for bytecode budget interrupts so it makes it easier > to actually mark functions only when needed. > > This also includes a fix to reduce the stack limits for interrupts when > entering a scope that allows interrupts from a postponed interrupt scope. > > Bug: chromium:993061 > Change-Id: Iaf7b4dccb7a503e5b6bfcbb993bc7482aa593955 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829218 > Reviewed-by: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Commit-Queue: Mythri Alle <mythria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64048} Bug: chromium:993061 Change-Id: I24dae03357d6c368e4173db3f071e8ab09e9d6dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832173Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Georg Neis authored
... in order to print more information when it's disabled. Bug: v8:7790 Change-Id: I58a5dacbbe9551814e62b157885c83001924a59b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1835534 Auto-Submit: Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#64081}
-
Jakob Gruber authored
The natives blob is deprecated and will be removed in the next release. This commit does two things, 1. it disables the v8_extra_library_files gn argument which will make building natives_blob.bin through gn impossible; 2. it marks API functions associated with the natives blob as V8_DEPRECATE_SOON. Embedders should remove any uses of SetNativesDataBlob and replace all calls to InitializeExternalStartupData(const char*, const char*) with the new function InitializeExternalStartupDataFromFile(const char*) Step 2 is to mark API functions as V8_DEPRECATED. Step 3, in the next V8 release, is to remove these functions and all other natives support in V8. Bug: v8:7624 Change-Id: I745e96c60204a9b94d9240be65dd59bb9bdd0699 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1824944 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Jakob Kummerow authored
GC stress flags (--gc-interval, --random-gc-interval) could trigger unexpected fake allocation failures while trying to fill up a page. An AlwaysAllocateScope suppresses that. Drive-by fix: allocation requests with exactly kMaxRegularHeapObjectSize can take the fast path. Bug: v8:9700 Change-Id: I7fa35e56848e74f12d3606da453e1ae7254c268b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834121Reviewed-by:
-
Clemens Backes authored
We need to register the unwind info for each code space (it was just done for the first one). Otherwise we fail when freeing the native module, where we try to unregister the unwind info again for each code space. This CL moves the call to {RegisterNonABICompliantCodeRange} from {NewNativeModule} to {AddCodeSpace}, so it happens whenever a new code space is added. R=jgruber@chromium.org CC=paolosev@microsoft.com Bug: chromium:1008597, v8:9477, v8:9795 Change-Id: I20121b2a2fde4d37432dd7e13b19cdf99129e6a4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832178 Commit-Queue: Clemens Backes <clemensb@chromium.org> Reviewed-by:Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#64078}
-
Michael Lippautz authored
Bug: chromium:1006640 Change-Id: I0f38ed9c44b6a2a6cfd52fdd9e177768f57beb11 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833692 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/69e3270..5de2214 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/5f4659d..16236fc Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/a19d353..5eac9d3 TBR=machenbach@chromium.org,tmrts@chromium.org Change-Id: I45412c50e72c4899b4e88046a9e2565f07cdad5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833873Reviewed-by:
-
- 01 Oct, 2019 21 commits
-
-
Igor Sheludko authored
... by flipping the flag. Bug: v8:9706 Change-Id: Ie0e70a243a5a6a703cdaa27c1ed55a78d9904bbe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826732 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Jaime Bernardo authored
Explicitly #include<string> in v8.h, since std::string is referenced in it. In the C++ STL shipped with Visual Studio 2019, none of the headers included in v8.h ends up including the C++ string header, which caused a compile error. Bug: v8:9793 Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#64074}
-
Ng Zhi An authored
Bug: v8:9728 Change-Id: Ic15d793e6408af1ea2e1f7f71b9130300d359a95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1808417Reviewed-by:
-
Ross McIlroy authored
TurboProp will not reschedule after effect-control linearization, so the graph-assembler will be used to modify the schedule as new nodes are added. To enable this, ensure we use the graph assembler for all node creation from effect-control linearization onwards. BUG=v8:9684 Change-Id: I2be3f5d2a3f2cbee44c72bb397e9bd1d9ac7de05 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832166 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#64072}
-
Ng Zhi An authored
Change-Id: I5dcc3f708ca05a0d3b504cb4d7a89693ca0717b4 Bug: v8:9396 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1819521Reviewed-by:
-
Frank Tang authored
* Throws RangeError only when the calendar and numberingSystem is ill-formed. * Set the calendar and numberingSystem to the locale only if the values are valid. * Fix the order of GetOption of "localeMatcher". * Add more unit tests. See https://github.com/tc39/ecma402/pull/175 for details. Bug: v8:9786, v8:9787, v8:9788 Change-Id: Ic0f918ad7d9afb0b7c8df39caa0f44ef07ca10c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1830345 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#64070}
-
Frank Tang authored
Bug: v8:9155 Change-Id: I54c65ee28171064f596fc305bb718613640f251a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832636Reviewed-by:
-
Joshua Litt authored
Removes the static protector values from isolate now that they are no longer needed. This is the final cl in the migration effort. Bug: v8:9463 Change-Id: I2127ef6c8a0cdaf0ccf28aed12539335ef985704 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1827455Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
-
Igor Sheludko authored
Bug: v8:9706 Change-Id: I5779e2fbaec5741cc9b8d44f7f3f721400e70b28 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832174 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Dan Elphick authored
Pushes the optimised code path to after the main interpreter path, so the straightline path is just normal interpretation. Bug: v8:9771 Change-Id: I2f48ff290efcd85a5e30cf823027919560f8a56a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829220Reviewed-by:
-
Peter Marshall authored
This was missed when changing Object to hold a ptr field instead of abusing the this pointer. This was printing the stack address of the particular Object rather than the location of the printed code object on the heap. Change-Id: I5c884464419debcbc70b73fe8bdfa8107f2bdb71 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1833681 Auto-Submit: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Jakob Gruber authored
This is a reland of 66129430 Fixed: Unaligned reads, unspecified evaluation order. Original change's description: > [regexp] Bytecode peephole optimization > > Bytecodes used by the regular expression interpreter often occur in > specific sequences. The number of dispatches in the interpreter can be > reduced if those sequences are combined into a single bytecode. > > This CL adds a peephole optimization pass for regexp bytecodes. > This pass checks the generated bytecode for pre-defined sequences that > can be merged into a single bytecode. > > With the currently implemented bytecode sequences a speedup of 1.12x on > regex-dna and octane-regexp is achieved. > > Bug: v8:9330 > Change-Id: I827f93273a5848e5963c7e3329daeb898995d151 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1813743 > Commit-Queue: Patrick Thier <pthier@google.com> > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#63992} Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux_gcc_rel Bug: v8:9330,chromium:1008502,chromium:1008631 Change-Id: Ib9fc395b6809aa1debdb54d9fba5b7f09a235e5b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1828917Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Ana Peško authored
This is a reland of cfb60d43 Original change's description: > [regexp] Eagerly tier-up for very long strings > > For very long subject strings, the regexp interpreter is currently much slower > than the native machine code execution. This CL implements eager tier-up to the > compiler to avoid the performance penalty for subject strings of length greater > than 1000. > > Change-Id: I244ccbd60255e0f3bedc493b1cc3d25cdd42133e > Bug: v8:9566 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829273 > Reviewed-by: Peter Marshall <petermarshall@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Ana Pesko <anapesko@google.com> > Cr-Commit-Position: refs/heads/master@{#64046} Bug: v8:9566 Change-Id: I81a10728c64ce3b35258c31eb8178e458d3de205 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832167Reviewed-by:
-
Georg Neis authored
This is an experiment to see the memory/performance impact. Bug: v8:9775 Change-Id: I2ae61ae8bb5c6c1c55436e96c4b2d8201cbf4739 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832177Reviewed-by:
-
chrome://traceMike Stanton authored
Bug: chromium:1005195 Change-Id: I41b8526d1394d82b06bab975dc0cc18c080dfd60 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829271 Commit-Queue: Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Change-Id: I822f3961b2ec5ef8fb7ca4765cb7c9fd38514223 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832171 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
-
Leszek Swirski authored
Avoid emitting deprecation checks for these fields. Bug: v8:9606 Change-Id: Id3e317a8c36728b3c7b063743ef9d36aa1209176 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832170 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
David Carlier authored
Change-Id: I4d4c6e8a6371102ae7b2ece7cbbc068cdd8c6799 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832165Reviewed-by:
Clemens Backes <clemensb@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64058}
-
Dan Elphick authored
Moves CodeStubAssembler::BranchIfPrototypesHaveNoElements to AccessorAssembler and TNodifies it on the way. Bug: v8:9396 Change-Id: Ie5d8ad5abc3dbdb688c0cbee4610cd441ba1a9b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1826736 Auto-Submit: Dan Elphick <delphick@chromium.org> Reviewed-by:
Mythri Alle <mythria@chromium.org> Reviewed-by:
-
Andreas Haas authored
Apparently this is necessary. R=ulan@chromium.org Bug: v8:9396 Change-Id: Ia7c439308fb7edbb901f595aeb9fbf9389858daa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1832161Reviewed-by:
-
Michael Achenbach authored
It was confusing to silently run test262 only in the default variant with a switch on the infra side. We'll remove that switch in a follow up and explicitly configure the testing variant for test262 in builders.pyl. Bug: v8:9791 Change-Id: I0da351ff981c833704f51a415225aff24df1664a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829269Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64055}
-
