- 22 Apr, 2022 19 commits
-
-
jameslahm authored
... /objects/concurrent-js-array-unittest. Bug: v8:12781 Change-Id: Ie23432df7ffa785f96684060f5f2df3716713fd6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600549Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80115}
-
Michael Achenbach authored
Using this flag has led to several duplicate issues. We need to stop using the flag for a while until the issues are investigated. Potentially these are all false positives. No-Try: true Bug: chromium:1317880 Change-Id: I09f4e1c642befc3a8f5b88c2eb003931dc112826 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602508 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Auto-Submit: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Marja Hölttä <marja@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#80114}
-
Milad Fa authored
Result of `and` is stored in cr0. Change-Id: I113ff7ceb9412d2f1f8ffdd58397123603b5818a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600550Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80113}
-
jameslahm authored
This CL extends GetIterator to check whether the result of calling @@iterator is JSReceiver and throw SymbolIteratorInvalid if it's not JSReceiver. GetIterator bytecode involves 3 steps now: - method = GetMethod(obj, @@iterator) - iterator = Call(method, obj) - if(!IsJSReceiver(iterator)) throw SymbolIteratorInvalid [Added] New Builtin: CallIteratorWithFeedbackLazyDeoptContinuation, which is used when lazy deopt is triggered by call @@iterator. Related spec: https://tc39.es/ecma262/#sec-getiterator. Related doc: https://docs.google.com/document/d/1s67HC2f-4zxA_s1Bmm7dfwMFv_KDUfMiWIKkNSeQNKw/edit#heading=h.kdzv8mq4g4ks. Bug: v8:9489 Change-Id: I17952c0f3e24e1e600ee1348809fb188c2c70f8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3563447Reviewed-by: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80112}
-
Milad Fa authored
There is currently a bug in docker where fstat may not return the correct device id and as a result a check under `OS::RemapPages, stat_buf.st_dev != enclosing_region.dev` fails, details on the bug: https://github.com/moby/moby/issues/43512 Platform specific page sizes are also defined for kMaxPageSize to fix compilation errors. Change-Id: I026609329aa6432eda4f1880a0f586c0c2162461 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3601211Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Junliang Yan <junyan@redhat.com> Commit-Queue: Milad Farazmand <mfarazma@redhat.com> Cr-Commit-Position: refs/heads/main@{#80111}
-
Tobias Tebbi authored
This reverts commit 267b962d. Reason for revert: Flake turned out to not be reproducible: https://ci.chromium.org/ui/p/v8/builders/try.triggered/v8_flako/b8816185753319345009/overview Original change's description: > Revert "[base/platform] Simplify fast TLS on macOS" > > This reverts commit 9cdee4f4. > > Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/38658/overview > > Original change's description: > > [base/platform] Simplify fast TLS on macOS > > > > Since the TLS offset is constant across all supported OS releases, we > > no longer need to adjust it, nor to read it at runtime. This also aligns > > the code in V8 with what is done in Chromium. > > > > Change-Id: I0f3c54da39a776406083c897de888f06c61852b8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599481 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Benoit Lize <lizeb@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#80106} > > Change-Id: Ie6371c2ad12ed6f63be51b819083a7c0c4e22751 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602502 > Auto-Submit: Tobias Tebbi <tebbi@chromium.org> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> > Commit-Queue: Tobias Tebbi <tebbi@chromium.org> > Owners-Override: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80108} Change-Id: I6c50a568751a3892b82fe2dce6fe940fce293b3d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602503 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80110}
-
Victor Gomes authored
Fixes https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20-%20gcov%20coverage/29098/overview and https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20gcc%20-%20debug%20builder/1389/overview Bug: v8:7700 Change-Id: I90717b9644b75cef28656893d37aa57e5f03e2fe Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599478 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80109}
-
Tobias Tebbi authored
This reverts commit 9cdee4f4. Reason for revert: https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Mac64%20-%20debug/38658/overview Original change's description: > [base/platform] Simplify fast TLS on macOS > > Since the TLS offset is constant across all supported OS releases, we > no longer need to adjust it, nor to read it at runtime. This also aligns > the code in V8 with what is done in Chromium. > > Change-Id: I0f3c54da39a776406083c897de888f06c61852b8 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599481 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Benoit Lize <lizeb@chromium.org> > Cr-Commit-Position: refs/heads/main@{#80106} Change-Id: Ie6371c2ad12ed6f63be51b819083a7c0c4e22751 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602502 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80108}
-
Tobias Tebbi authored
This reverts commit 6e6c1bf6. Reason for revert: breaks Chromium roll: https://ci.chromium.org/ui/p/chromium/builders/try/linux-lacros-rel/515150/overview Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/28bea73..7ee892a > > Rolling v8/buildtools/linux64: git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce..git_revision:0d6d1310d005cb9bace909cb8352e83113c6fc51 > > Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/2760db4..36c1580 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/960c656..43f0426 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/89ccf4a..5e49eda > > Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a0906c7..563043f > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4dd2e32..ea2f00c > > R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com > > Change-Id: I6295d2ca2cc0f8a738a3ade212da52d74d203c67 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600836 > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/main@{#80097} Change-Id: I4cd78dddbb477773ea80f16c4bfa0e0ecabff7e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3598888 Auto-Submit: Tobias Tebbi <tebbi@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Owners-Override: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80107}
-
Benoît Lizé authored
Since the TLS offset is constant across all supported OS releases, we no longer need to adjust it, nor to read it at runtime. This also aligns the code in V8 with what is done in Chromium. Change-Id: I0f3c54da39a776406083c897de888f06c61852b8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599481Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Benoit Lize <lizeb@chromium.org> Cr-Commit-Position: refs/heads/main@{#80106}
-
Victor Gomes authored
Bazel bot is red due to ICU problem. https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20bazel%20-%20builder Temporarily compiling V8 without ICU until the problem is solved. Change-Id: I98b9ce9ca445d100896c43ae24d5fa73463cdfbc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3598884 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80105}
-
jameslahm authored
... /objects/concurrent-feedback-vector-unittest. Bug: v8:12781 Change-Id: Ib294adbf57d77fd6fff2801b35fd53cffd0d46c3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600509Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80104}
-
Lu Yahan authored
should using scratch register to hold intermediate result. Change-Id: I08e2236fd0a491398ffaa15c4fd9ae3d0e9ef535 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596441Reviewed-by: ji qiu <qiuji@iscas.ac.cn> Commit-Queue: Yahan Lu <yahan@iscas.ac.cn> Auto-Submit: Yahan Lu <yahan@iscas.ac.cn> Cr-Commit-Position: refs/heads/main@{#80103}
-
Liu Yu authored
Port commit 4ae5a813 Change-Id: I194b424996d9f2427272fdd0510b6a464c4e07d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3602233 Auto-Submit: Yu Liu <liuyu@loongson.cn> Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80102}
-
jameslahm authored
... /objects/concurrent-string-unittest. - Add AsciiToTwoByteString to convert ascii string to two byte string. Bug: v8:12781 Change-Id: Icc2f745846fa10ec940085eab0ef022d7c277e0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600552Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80101}
-
Liu Yu authored
Port f8fddd6b v8: 12161 Change-Id: Ied27490a457ff1e4fcc9e80057c5d39c4c5c08cc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3601876Reviewed-by: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Yu Liu <liuyu@loongson.cn> Auto-Submit: Yu Liu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#80100}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I61246df3a13f8beb91979591455b3d63357ed220 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599477 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80099}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/d2858cb..e5b846b Cherrypick PR 2060 to fix DateIntervalFormat (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/e5b846b Enable WASM cross-compilation by using current_cpu correctly (Harry Terkelsen) https://chromium.googlesource.com/chromium/deps/icu/+/f43d565 Remove obsoleted android_(small|extra) build script (Frank Tang) https://chromium.googlesource.com/chromium/deps/icu/+/0a50280 R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,ftang@chromium.org Change-Id: I5b19727b85316c56e7b19d6b73c4206642de56af Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600838 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80098}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/28bea73..7ee892a Rolling v8/buildtools/linux64: git_revision:1cdd270be9803dbfcdd0343f6104ad4dc30c38ce..git_revision:0d6d1310d005cb9bace909cb8352e83113c6fc51 Rolling v8/third_party/android_platform: https://chromium.googlesource.com/chromium/src/third_party/android_platform/+log/2760db4..36c1580 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/960c656..43f0426 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/89ccf4a..5e49eda Rolling v8/third_party/zlib: https://chromium.googlesource.com/chromium/src/third_party/zlib/+log/a0906c7..563043f Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/4dd2e32..ea2f00c R=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I6295d2ca2cc0f8a738a3ade212da52d74d203c67 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600836 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#80097}
-
- 21 Apr, 2022 21 commits
-
-
Frank Tang authored
Spec Text: https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.offset https://tc39.es/proposal-temporal/#sec-get-temporal.zoneddatetime.prototype.offsetnanoseconds Bug: v8:11544 Change-Id: Ia88d96b038117a8e528ff9d0cdb9a07fb7cbcda5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3385606Reviewed-by: Shu-yu Guo <syg@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/main@{#80096}
-
Camillo Bruni authored
Change-Id: I1ad5d4796168115fe2dc88d073a663c87cab73cb No-try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596171Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/main@{#80095}
-
Joyee Cheung authored
Normally, taking a heap snapshot in the near heap limit would result in a full GC, then the overhead of the promotions would cause another invocation of the heap limit callback and it can raise the limit in the second call to avoid an OOM, so we test that the callback can indeed raise the limit this way in this case. When there is only one generation, however, there would not be the overhead of promotions so the callback may not be triggered again during the generation of the heap snapshot. In that case we only need to check that the callback is called and it can perform GC-triggering operations jsut fine there. Bug: v8:12815 Change-Id: If244417624b56bc068aed480fb3391d26c19005a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600357Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Joyee Cheung <joyee@igalia.com> Cr-Commit-Position: refs/heads/main@{#80094}
-
Junliang Yan authored
Bug: v8:12161 Change-Id: I65029217e99dd2c59af295b2f02c697415151a59 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3600376Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80093}
-
Tobias Tebbi authored
Bug: v8:12822 Change-Id: Idc8225640e132d175d2c06b530d77fcda7362b55 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599486 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/main@{#80092}
-
jameslahm authored
... unittests/objects/concurrent-descriptor-array-unittest. Bug: v8:12781 Change-Id: Iad4e99e256745d2874e6b03c2fe1c91b5599ab30 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596443Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80091}
-
Andreas Haas authored
Change-Id: I4ffcf9792501928e9e59d702c5855b288470cff4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599485Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#80090}
-
Leszek Swirski authored
In the simplest way possible. Bug: v8:7700 Change-Id: I155aaf85192b75c89617820d6f127a2ae04c7d9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599484 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80089}
-
Leszek Swirski authored
Additionally, pass the JSFunctionRef directly for inlined functions' compilation units. Bug: v8:7700 Change-Id: Ibdc738c8a9790f8ac45e6a0fd55facdf638562f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599480 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80088}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: I5155fc665f1214dda390fc6d1476ecf1f137166e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599483 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80087}
-
jameslahm authored
... /utils/bit-vector-unittest. Bug: v8:12781 Change-Id: I26b9c2b8a911b513d65d54476b78a0bbac7aa78f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596445Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80086}
-
Michael Lippautz authored
This reverts commit 2d394aca. Concurrrent marking for v8::TracedReference requires a single bit in global handles to be written concurrently. While no other bits require concurrent access, initialization still needs to properly publish the the bitfield. Publishing generally allows all bits to be read on any thread which is already used for some. The CL introduces acq/rel semantics on the actual object pointer for publishing the state. Bug: chromium:1315498, v8:12600 Change-Id: Ic50c7c0b647b8b609bcd899f6c9f73bee80303da Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596125Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80085}
-
jameslahm authored
... /compiler/compiler-unittest. - Add PrintExtension for adding print function. - Add WithPrintExtensionMixin to register PrintExtension. - Add StreamerThread to run a ScriptStreamingTask in a separate thread. Bug: v8:12781 Change-Id: I9d3324f3a8dcf00b5b121db6007c9a3cb2972313 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596442Reviewed-by: Leszek Swirski <leszeks@chromium.org> Commit-Queue: 王澳 <wangao.james@bytedance.com> Cr-Commit-Position: refs/heads/main@{#80084}
-
Leszek Swirski authored
Fixes the iteration after emitting an unconditional deopt to kill all Jumps along the way, not just ones preceeding a merge point. This fixes several issues: a) That Jump may be to a not yet created merge point, in which case we were getting a nullptr deref. b) Not-yet created merge points would not be detected as merge points, so we'd skip over them and miss killing the control node before them. c) We weren't reducing predecessor counts, so even after fixing the nullptr deref above, merge states created later would have the wrong predecessor count. Now, we check bytecode targets (including fallthrough for non-returning bytecodes) on for every bytecode, and skip over both not-yet created merges, and loop merges that have no predecessors other than the loop jump itself. As part of this, the dead predecessor merging is changed; instead of setting the predecessor to nullptr, we drop the predecessor count by one, and trim any Phis' input counts. Bug: v8:7700 Change-Id: I904c82df7c5dd44d7637e07f6750b35e7e219284 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599470Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#80083}
-
Michael Lippautz authored
When moving forward and optimizing internals, these APIs cannot be trusted anymore as their semantics are tangled to the current implementation. Bug: v8:12819 Change-Id: I0e3370724307a420ee42fed8070b55542be9400d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599475 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#80082}
-
Junliang Yan authored
Change-Id: I1ceb1038c91e43299f4f4b35da684566ecbbef7f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3596911Reviewed-by: Milad Farazmand <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#80081}
-
Victor Gomes authored
Adds LogFunctionCompilation as a static member of Compiler. Calls the log function after installing the code on the main thread. Bug: v8:12054, v8:12818 Cq-Include-Trybots: luci.v8.try:v8_linux64_tsan_rel_ng Change-Id: I664b2c890292a207720efe311b7c55757c7c6470 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599472Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80080}
-
Omer Katz authored
Bug: chromium:1316121, v8:12612 Change-Id: I5b32211f01a97a6aaee52f0285d62a516381f43c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3592954Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80079}
-
Michael Lippautz authored
Removes V8-internal support for resurrecting finalizers in the garbage collector. The APIs have already been removed in http://crrev.com/c/3596174 Bug: v8:12672 Change-Id: Ia507e74659b61a2c8c08281d7f395aee51e3fe17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3584115Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#80078}
-
Leszek Swirski authored
Add a --maglev-inlining flag, and add some half-baked support for inlining functions when there is call feedback. When the flag is enabled and there is call feedback, we create a nested MaglevGraphBuilder for the current graph, and pause building the graph of the outer function. We manually set up its prologue to set up its frame with the arguments pass into the call, build the body with the nested graph builder. This inner builder knows that it is building an inlined function, and all Return bytecodes will instead emit a Jump to a single merge block at the end of the function, where execution of the outer function can resume. These inner function basic blocks are wired into the outer graph with new JumpToInline and JumpFromInline control nodes. The idea is that subsequent passes will know what the inline function is, and will use these to manage the function stack (particularly for codegen and especially deopts). Bug: v8:7700 Change-Id: I4e9b153f8cf4d06c56e7be6365e7a18b86a773c0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3585958 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Jakob Linke <jgruber@chromium.org> Cr-Commit-Position: refs/heads/main@{#80077}
-
Leszek Swirski authored
Bug: v8:7700 Change-Id: Ieecdd66e7e540ad27aaa05cf13f270e42377b15e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3599471 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Auto-Submit: Leszek Swirski <leszeks@chromium.org> Reviewed-by: Victor Gomes <victorgomes@chromium.org> Commit-Queue: Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#80076}
-