- 06 Nov, 2017 18 commits
-
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: Ibdb00bee4dc563663ef2151b489600a2b100f146 Reviewed-on: https://chromium-review.googlesource.com/739601 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#49143}
-
Peter Marshall authored
The maximum length of the chars in bytes was hardcoded and was not updated with the increase in string length on 64-bit platforms. The other platforms don't do this debug check so they don't need updating. Bug: chromium:779407 Change-Id: I94fd946f9e67b39075c1f7eed14a20e9db126a72 Reviewed-on: https://chromium-review.googlesource.com/753584Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49142}
-
Clemens Hammacher authored
The function receives imports and memory, but always calls SyncInstantiate with null handles. This CL fixes this by passing on the received values. R=ahaas@chromium.org Change-Id: I1ddb617b3d4847db341d97737043cc667f879734 Reviewed-on: https://chromium-review.googlesource.com/753727Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49141}
-
Michael Achenbach authored
This ports: https://chromium-review.googlesource.com/c/chromium/src/+/732997 NOTRY=true Bug: chromium:781724 Change-Id: Ib57e94bfa66f7898c10b14ce0c07a12b0c3d25b8 Reviewed-on: https://chromium-review.googlesource.com/753725 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49140}
-
Michael Achenbach authored
This reverts commit 2769a7c4. Reason for revert: https://build.chromium.org/p/client.v8.ports/builders/V8%20Arm/builds/5195 Original change's description: > [wasm] Test binary operations for more inputs > > Instead of hard-coding one or two inputs per binary operation, use all > inputs provided by FOR_INT32_INPUTS. > > R=ahaas@chromium.org > > Change-Id: I534227f93068f52d69ea0ff0fcf686a9af034bad > Reviewed-on: https://chromium-review.googlesource.com/753484 > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Reviewed-by: Andreas Haas <ahaas@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49136} TBR=ahaas@chromium.org,clemensh@chromium.org Change-Id: I40a6822679956d872b21d5c01e548d5c49a4250f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/753731Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49139}
-
Clemens Hammacher authored
This is a reland of 7d231e57, fixed to avoid instantiating CountLeadingZeros for bits==0. Original change's description: > [bits] Consolidate Count{Leading,Trailing}Zeros > > Instead of having one method for 32 bit integers and one for 64 bit, > plus a templatized version to choose from those two, just implement one > version which handles unsigned integers of any size. Also, make them > constexpr. > The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in > order to keep the amount of code changes small. Also, sometimes it > improves readability by stating exactly the size of the argument, > especially for leading zeros (where zero-extending would add more > leading zeros). > > CountLeadingZeros now uses a binary search inspired implementation > as proposed in Hacker's Delight. It's more than 20% faster on x64 if > the builtins are disabled. > CountTrailingZeros falls back to CountPopulation instead of counting in > a naive loop. This is ~50% faster. > > R=mstarzinger@chromium.org > > Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e > Reviewed-on: https://chromium-review.googlesource.com/741231 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49106} Change-Id: Icdff2510ec66d1c96a1912cef29d77d8550994ee Reviewed-on: https://chromium-review.googlesource.com/753903Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49138}
-
Clemens Hammacher authored
If the destination register of a binop is the same register as the right hand side, we would first move the left hand side into that register (overwriting the value of the rhs), and then use the rhs. This CL fixes this issue and adds a regression test. R=ahaas@chromium.org Bug: v8:6600, v8:7033 Change-Id: Ief90b5bcffc65823037bc57fb00741b2448e6375 Reviewed-on: https://chromium-review.googlesource.com/753462 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49137}
-
Clemens Hammacher authored
Instead of hard-coding one or two inputs per binary operation, use all inputs provided by FOR_INT32_INPUTS. R=ahaas@chromium.org Change-Id: I534227f93068f52d69ea0ff0fcf686a9af034bad Reviewed-on: https://chromium-review.googlesource.com/753484 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#49136}
-
Franziska Hinkelmann authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I9df5beca6444a42aa35c624760265a3cc02182b6 Reviewed-on: https://chromium-review.googlesource.com/753450Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#49135}
-
Clemens Hammacher authored
Fix a stack overflow in the wasm_compile_fuzzer by limiting the recursion depth to 64. At this depth, we always just generate a constant expression. R=eholk@chromium.org, ahaas@chromium.org Bug: chromium:747348 Change-Id: I236c1e07b8cb2b6c9181c549e850eca34fac6ec6 Reviewed-on: https://chromium-review.googlesource.com/753329Reviewed-by: Eric Holk <eholk@chromium.org> Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49134}
-
Igor Sheludko authored
This CL ensures that elements kind transitions don't cause silent mutable-to-constant field migrations when the following options are enabled: --track_constant_fields --modify_map_inplace. Bug: v8:5495, v8:6980 Change-Id: Ie28daab84f91d424110e71504b025a2e465bfe16 Reviewed-on: https://chromium-review.googlesource.com/753087 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#49133}
-
Georg Neis authored
R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I765790d8b163aff6725900f19e95a914c75a0fe9 Reviewed-on: https://chromium-review.googlesource.com/752521 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#49132}
-
Georg Neis authored
We must throw a SyntaxError only when failing to convert a string. In the other cases we must throw a TypeError. R=jkummerow@chromium.org Bug: v8:6791 Change-Id: I802d8b6830b341f87e46e7de198af74ba95b8658 Reviewed-on: https://chromium-review.googlesource.com/752803Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49131}
-
Georg Neis authored
This reverts commit e83ee945. Reason for revert: Check failure in regress-v8-6940.js Original change's description: > RegExp: Add the ability to switch flags on and off within the regexp. > > This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/752522 > which was itself a reupload of > https://chromium-review.googlesource.com/c/v8/v8/+/571746 where reviews took > place. > > R=yangguo@chromium.org > > Bug: > Change-Id: Ia4dbdd6e9a362e272753ff10dc66b7f72d81ee20 > Reviewed-on: https://chromium-review.googlesource.com/753596 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Erik Corry <erikcorry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49129} TBR=yangguo@chromium.org,erikcorry@chromium.org Change-Id: I5ee94c47606101d06010c9e6b4b78ca51566b60a No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/754682Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49130}
-
Erik authored
This is a reland of https://chromium-review.googlesource.com/c/v8/v8/+/752522 which was itself a reupload of https://chromium-review.googlesource.com/c/v8/v8/+/571746 where reviews took place. R=yangguo@chromium.org Bug: Change-Id: Ia4dbdd6e9a362e272753ff10dc66b7f72d81ee20 Reviewed-on: https://chromium-review.googlesource.com/753596Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Erik Corry <erikcorry@chromium.org> Cr-Commit-Position: refs/heads/master@{#49129}
-
Yang Guo authored
TBR=mstarzinger@chromium.org Change-Id: I13447a31518226d0d86365b0c41d40ac2f688275 Reviewed-on: https://chromium-review.googlesource.com/722702 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#49128}
-
Alexey Kozyatinskiy authored
It is preparation step for step-into-worker. There are few changes: - added breakOnAsyncCall flag for Debugger.stepInto. When flag is set and async task is scheduled before step-into finished, we pause execution with additional Debugger.paused event. This event contains additional scheduledAsyncTaskId field. - added Debugger.pauseOnAsyncTask. This method will pause execution as soon as given async task is started. This mechanism is replacement for Debugger.scheduleStepIntoAsync which can not be used between multiple targets. As result we can split async task scheduling in one target and requesting break for this async task running in another target. R=pfeldman@chromium.org Bug: chromium:778796 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel Change-Id: I77be0c880d91253d333c54a23a4c084e7b8549e9 Reviewed-on: https://chromium-review.googlesource.com/750071Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49127}
-
Deepti Gandluri authored
Implement I32Atomic BinOps, and enable tests to run in the interpreter. Bug=v8:6532 Change-Id: Ida78d2911cb6973fe053283a9937e7af04e6df01 Reviewed-on: https://chromium-review.googlesource.com/724928 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49126}
-
- 04 Nov, 2017 5 commits
-
-
Michael Achenbach authored
Change-Id: I80378f4ea38e1251715614158716a2b1f7bc91b5 Reviewed-on: https://chromium-review.googlesource.com/753594Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49125}
-
Benedikt Meurer authored
The condition for bounds check generation was not in sync with the condition that was used for the actual access, which lead to invalid memory accesses when the array protector was invalid. Tbr: tebbi@chromium.org Bug: chromium:781506, chromium:781494, chromium:781457, chromium:781285, chromium:781381, chromium:781380, v8:6936, v8:7014, v8:7027 Change-Id: Ia5b2ad02940292572ed9b37abd3f9ffaa6d7a26b Reviewed-on: https://chromium-review.googlesource.com/753590Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49124}
-
Michael Achenbach authored
This reverts commit 7d231e57. Reason for revert: Breaks revert for win-clang: https://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/342755 Original change's description: > [bits] Consolidate Count{Leading,Trailing}Zeros > > Instead of having one method for 32 bit integers and one for 64 bit, > plus a templatized version to choose from those two, just implement one > version which handles unsigned integers of any size. Also, make them > constexpr. > The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in > order to keep the amount of code changes small. Also, sometimes it > improves readability by stating exactly the size of the argument, > especially for leading zeros (where zero-extending would add more > leading zeros). > > CountLeadingZeros now uses a binary search inspired implementation > as proposed in Hacker's Delight. It's more than 20% faster on x64 if > the builtins are disabled. > CountTrailingZeros falls back to CountPopulation instead of counting in > a naive loop. This is ~50% faster. > > R=mstarzinger@chromium.org > > Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e > Reviewed-on: https://chromium-review.googlesource.com/741231 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Clemens Hammacher <clemensh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49106} TBR=mstarzinger@chromium.org,clemensh@chromium.org Change-Id: Iceeb35bf9c7539a1013c9bdbc47118008611bef2 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/753463Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49123}
-
Alexey Kozyatinskiy authored
DebugBreak bytecode fetches current return value from debugger prior dispatching original handler. So we can change its value on break. R=leszeks@chromium.org,rmcilroy@chromium.org Bug: chromium:656150 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I82d0bc82ff49923a748c0084d252d0fd214a2db8 Reviewed-on: https://chromium-review.googlesource.com/731679Reviewed-by: Pavel Feldman <pfeldman@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49122}
-
Daniel Bevenius authored
I believe the paths to the V8 include headers are incorrect. The paths to other sources seem to be relative to the parent directory. When building Node.js I get the following warning on Windows: Warning: Missing input files: deps\v8\src\..\..\include\v8-inspector-protocol.h deps\v8\src\..\..\include\v8-inspector.h This commit updates the two include paths. Bug: Change-Id: I51a057abba61e294e7811ba69db03e283b0bdc3f Reviewed-on: https://chromium-review.googlesource.com/743981Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49121}
-
- 03 Nov, 2017 17 commits
-
-
Ross McIlroy authored
This reverts commit c60934e9. Reason for revert: breaks nosnap build Original change's description: > [Ast] Teach Ast Printer to print raw literal values. > > Converts the ast prettyprinter to printing literals from the raw values > rather than internalized on-heap strings. This enables ast printing before > internalizing, and means we can avoid use of the isolate in the interpreter's > off-thread phase. > > Also removes --print-builtin-ast and relies on just --print-ast to print > everything. > > Finally, converts FunctionLiteral's debug_name function to return a > char[] which is created from the raw name literal where it exists, rather > than relying on the value having been internalized. > > BUG=v8:5203 > > Change-Id: I0e358d6acc9ae4516ed49e7a763e208fea5fcf66 > Reviewed-on: https://chromium-review.googlesource.com/749261 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49119} TBR=rmcilroy@chromium.org,adamk@chromium.org Change-Id: Ic9d511f5107666a2f6a2bf59d8e93643c32d4d2b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5203 Reviewed-on: https://chromium-review.googlesource.com/753627Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49120}
-
Ross McIlroy authored
Converts the ast prettyprinter to printing literals from the raw values rather than internalized on-heap strings. This enables ast printing before internalizing, and means we can avoid use of the isolate in the interpreter's off-thread phase. Also removes --print-builtin-ast and relies on just --print-ast to print everything. Finally, converts FunctionLiteral's debug_name function to return a char[] which is created from the raw name literal where it exists, rather than relying on the value having been internalized. BUG=v8:5203 Change-Id: I0e358d6acc9ae4516ed49e7a763e208fea5fcf66 Reviewed-on: https://chromium-review.googlesource.com/749261 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#49119}
-
Ross McIlroy authored
Bug: Change-Id: I9648c10c81a976b179fb58e8192366ee49f57db4 Reviewed-on: https://chromium-review.googlesource.com/741720Reviewed-by: Mythri Alle <mythria@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#49118}
-
Karl Schimpf authored
The code was updating the UMA stats for V8.WasmFunctionSizeBytes when the WASM function was decoded. Unfortunately, decoding of functions is no longer done as a separate step. Rather, it is done as part of the compilation step. This CL moves the UMA updates to the compilation step. Bug: v8:7032 Change-Id: I4679036035540fabd43855c1ba5ba66ffee6762a Reviewed-on: https://chromium-review.googlesource.com/754023 Commit-Queue: Karl Schimpf <kschimpf@chromium.org> Reviewed-by: Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49117}
-
Benedikt Meurer authored
This reverts commit fd5b067f. Reason for revert: Tanks Babylon by around 40% Original change's description: > Disable --string-slices. > > This is an experiment to quantify the impact of SlicedStrings on both > performance and memory usage. The intention is to get Canary coverage > for the experiment and then decide how to proceed. > > Bug: v8:7025 > Change-Id: Ied548cd9e2fab127c1ad2aea3e60b2615d3de663 > Reviewed-on: https://chromium-review.googlesource.com/750082 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49070} TBR=yangguo@chromium.org,bmeurer@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7025 Change-Id: I95dc36e632ecb5ddcddda8f6f58528439d5c102b Reviewed-on: https://chromium-review.googlesource.com/753621Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#49116}
-
Sathya Gunasekaran authored
This patch evaluates computed properties in the order of declaration during class definition time. This patch creates a synthetic variable to store the result of evaluating a computed property and then looks this up in the initializer function. Bug: v8:5367 Change-Id: I4182c6a01196d2538991818142890f6afb0e532b Reviewed-on: https://chromium-review.googlesource.com/752567Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#49115}
-
Bill Budge authored
- Sanitize Windows page size / alignment code. - Reorder some methods to match header file. - Rename AllocateAlignment to AllocatePageSize to be consistent with CommitPageSize. - Eliminate OS::Allocate overload with is_executable argument. - Eliminate base::OS::AllocateGuarded - it's not implemented. Bug: chromium:756050 Change-Id: I046bb019cddde0c0063d617adc2c94a23989d9d1 Reviewed-on: https://chromium-review.googlesource.com/742684 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by: Bill Budge <bbudge@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#49114}
-
Jakob Gruber authored
V8 provides non-standard Error API through: Error.captureStackTrace Error.prepareStackTrace Error.stackTraceLimit Let's add use counters to gauge how wide-spread these are used. This is the V8 side of required changes. The Chromium-side CL: https://crrev.com/c/753446 Bug: v8:6975 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I917cd6344a01670799f6cbf88a4bfff8e8d0d6ad Reviewed-on: https://chromium-review.googlesource.com/753443Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49113}
-
Michael Achenbach authored
This reverts commit c61f9171. Reason for revert: (Speculative) Seems to block the roll: https://chromium-review.googlesource.com/c/chromium/src/+/753602 Also failures on webkit win unittests and gpu tests: https://build.chromium.org/p/client.v8.fyi/builders/Win%20Release%20%28NVIDIA%29/builds/3382 https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Win/builds/11512 Original change's description: > [compiler] Add background compilation mode. > > Adds support for compiling top-level code on a background thread behind a flag. > When the flag is enabled, any background-parsing-task will perform compilation > as well as parsing. > > BUG=v8:5203 > > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: I88ab05c97cd6aea8d6be26e27d8da327f2c9c3a8 > Reviewed-on: https://chromium-review.googlesource.com/741716 > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Reviewed-by: Marja Hölttä <marja@chromium.org> > Cr-Commit-Position: refs/heads/master@{#49103} TBR=rmcilroy@chromium.org,marja@chromium.org,mstarzinger@chromium.org Change-Id: I49b0b0ee61fb79766a9a928b43d51d0eeb793d39 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5203 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/753302Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#49112}
-
Peter Marshall authored
more. Bug: v8:6333, v8:6921 Change-Id: I442190988f2c853560b28efa54e04ff73f9d94ca Reviewed-on: https://chromium-review.googlesource.com/718343 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#49111}
-
Camillo Bruni authored
Change-Id: I456b3456351860e3e5e7e9dcb800d42d543a7c47 Reviewed-on: https://chromium-review.googlesource.com/753681 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#49110}
-
Georg Neis authored
The {NUMBER} regexp only allowed one, leading to occasional test failures such as: https://build.chromium.org/p/client.v8/builders/V8%20Mac%20-%20debug/builds/17156 Bug: Change-Id: I25a08b80640d9af19ba70c61c846163685f1cb82 Reviewed-on: https://chromium-review.googlesource.com/753322Reviewed-by: Franziska Hinkelmann <franzih@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#49109}
-
Predrag Rudic authored
Bug: Change-Id: If922715b071276613fd27b6cc7f5326fdc9a37db Reviewed-on: https://chromium-review.googlesource.com/753091 Commit-Queue: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Reviewed-by: Ivica Bogosavljevic <ivica.bogosavljevic@imgtec.com> Cr-Commit-Position: refs/heads/master@{#49108}
-
Junliang Yan authored
Port c1925690 Original Commit Message: We expect no GC between the call to UnwindAndFindHandler and the call to that handler. We can precalculate the handler entrypoint and then let the CEntryStub just load and call that address. The main motivation for this change is the wasm on the native heap work, and making the CEntryStub able to work with non- Code* values. R=mtrofin@chromium.org, mstarzinger@chromium.org, bradnelson@chromium.org, titzer@chromium.org, joransiu@ca.ibm.com, bjaideep@ca.ibm.com, michael_dawson@ca.ibm.com Change-Id: I139fddabef9f601b46dac9011db3ab8e01e3346d Reviewed-on: https://chromium-review.googlesource.com/752483Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Mircea Trofin <mtrofin@chromium.org> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#49107}
-
Clemens Hammacher authored
Instead of having one method for 32 bit integers and one for 64 bit, plus a templatized version to choose from those two, just implement one version which handles unsigned integers of any size. Also, make them constexpr. The Count{Leading,Trailing}Zeros{32,64} methods are kept for now in order to keep the amount of code changes small. Also, sometimes it improves readability by stating exactly the size of the argument, especially for leading zeros (where zero-extending would add more leading zeros). CountLeadingZeros now uses a binary search inspired implementation as proposed in Hacker's Delight. It's more than 20% faster on x64 if the builtins are disabled. CountTrailingZeros falls back to CountPopulation instead of counting in a naive loop. This is ~50% faster. R=mstarzinger@chromium.org Change-Id: I1d8bf1d7295b930724163248150444bd17fbb34e Reviewed-on: https://chromium-review.googlesource.com/741231Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49106}
-
Camillo Bruni authored
Drive-by-fix: increase coverage in object literals test. Change-Id: Iccfdf35b29229f63b3e8c1d961bee56ee03da688 Reviewed-on: https://chromium-review.googlesource.com/751661Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#49105}
-
Clemens Hammacher authored
If an error is thrown in a setTimeout callback, exit d8 with an error code. This will allow us to test asynchronous failures better, see linked bug. R=yangguo@chromium.org CC=mathias@chromium.org Bug: v8:6981 Change-Id: Ifad152e6039f12dc4ceaac0bdc4b87f709898087 Reviewed-on: https://chromium-review.googlesource.com/738372Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#49104}
-