• Ross McIlroy's avatar
    Revert "[Ast] Teach Ast Printer to print raw literal values." · 5dc02ef2
    Ross McIlroy authored
    This reverts commit c60934e9.
    
    Reason for revert: breaks nosnap build
    
    
    Original change's description:
    > [Ast] Teach Ast Printer to print raw literal values.
    > 
    > Converts the ast prettyprinter to printing literals from the raw values
    > rather than internalized on-heap strings. This enables ast printing before
    > internalizing, and means we can avoid use of the isolate in the interpreter's
    > off-thread phase.
    > 
    > Also removes --print-builtin-ast and relies on just --print-ast to print
    > everything.
    > 
    > Finally, converts FunctionLiteral's debug_name function to return a
    > char[] which is created from the raw name literal where it exists, rather
    > than relying on the value having been internalized.
    > 
    > BUG=v8:5203
    > 
    > Change-Id: I0e358d6acc9ae4516ed49e7a763e208fea5fcf66
    > Reviewed-on: https://chromium-review.googlesource.com/749261
    > Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    > Reviewed-by: Adam Klein <adamk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#49119}
    
    TBR=rmcilroy@chromium.org,adamk@chromium.org
    
    Change-Id: Ic9d511f5107666a2f6a2bf59d8e93643c32d4d2b
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:5203
    Reviewed-on: https://chromium-review.googlesource.com/753627Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49120}
    5dc02ef2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...