- 18 Mar, 2019 2 commits
-
-
Pierre Langlois authored
Bug: v8:7327 Change-Id: I2a140cf79d3be83a34401f5e4a8033fd9d89568b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526011 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60306}
-
Sigurd Schneider authored
Change-Id: I8fee653d2e331c2e796115b4cb88a2138e456177 Bug: v8:7327 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528730Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Auto-Submit: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#60305}
-
- 28 Feb, 2019 2 commits
-
-
Sigurd Schneider authored
after previous change, which moved icons to .png format and to subdirectory img/. Bug: v8:7327 Notry: true Change-Id: Iebbbe175cc65ed1f2e505084344a2b55864732e7 Reviewed-on: https://chromium-review.googlesource.com/c/1494009 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#59940}
-
Sigurd Schneider authored
Change-Id: I19abd54f3c7825a99cbebd370092259cf8c21945 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1494007Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59939}
-
- 15 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I9cdea29db2b409d773a16e3d6c29ef4325257162 Reviewed-on: https://chromium-review.googlesource.com/c/1409437 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58815}
-
Sigurd Schneider authored
This allows to reset the layout to the the inital layout of the graph, which only contains the control nodes. Change-Id: I7ab9fb1615057df99983369cd0fcdd42a68e1924 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409436 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58814}
-
Sigurd Schneider authored
This enables per-phase toolbox items, which makes the toolbar easier to understand and use. Change-Id: I1b44d28595c118f0ba55dd64eea54415b51b93aa Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409435Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58813}
-
- 14 Jan, 2019 8 commits
-
-
Sigurd Schneider authored
The URL must not have a leading slash, and the file needs to be included in the deployment script. TBR=neis@chromium.org Change-Id: Idd3fc25c052cb720d4956f630a8ddca7e5d36a1a Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1409432Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58799}
-
Sigurd Schneider authored
This is a first step towards support for opening more than one turbolizer json file at once. Change-Id: Id51ce47c59492ba63de03eceb0163fa1701ea500 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407057 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58790}
-
Sigurd Schneider authored
..as mentioned in the info tab. Change-Id: I9ddbe1ad7eb3242ad7839650aecc7305a902fb0d Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407056 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58789}
-
Sigurd Schneider authored
..instead of wrongly keeping the location from the previous view if the selection became empty after attaching it. Change-Id: I606010ad86034c2ec06e00c82143a22ca2d88274 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1407055 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58788}
-
Sigurd Schneider authored
..and display them in the extended node title (on hover). Notry: true Bug: v8:7327 Change-Id: Ic9cd6207269686edb42ecf1bee8f7ef7b6caa035 Reviewed-on: https://chromium-review.googlesource.com/c/1407054 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58783}
-
Sigurd Schneider authored
Drive-by: Make label of checkboxes in disassembly view clickable. Notry: true Bug: v8:7327 Change-Id: I29478c5cb2bd4152df7943f9dfbba487f3b8bddb Reviewed-on: https://chromium-review.googlesource.com/c/1407053 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58782}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I440578b6b790f7f5f4cb41147572f32459fb59e5 Reviewed-on: https://chromium-review.googlesource.com/c/1407052 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58781}
-
Sigurd Schneider authored
Notry: true Bug: v8:7327 Change-Id: I2592d921905ad361f09ff6d99c0b0d64617543c4 Reviewed-on: https://chromium-review.googlesource.com/c/1407051 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58780}
-
- 12 Jan, 2019 3 commits
-
-
Sigurd Schneider authored
- 'let' instead of 'var', and prefer 'const' - Prefer for-of over indexed interation - Variable names should be 'camel-case' or all-caps snake-case. - Only one variable declaration per line Change-Id: I645dd2333d6d9a993f24c29121f5f156249f1b71 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405320 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58761}
-
Sigurd Schneider authored
Change-Id: I8e147bcb5d1e0b8e16874f0593a8ce4338dfc201 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1405319 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58760}
-
Sigurd Schneider authored
- Ban T[] array syntax - Format arrow function arguments consistently Bug: v8:7327 Notry: true Change-Id: I072a352ec9009948392a6bb5dd4381d4993af7be Reviewed-on: https://chromium-review.googlesource.com/c/1405317 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58759}
-
- 09 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Change-Id: Iffd68156515948254e4ce38021c511596acc5788 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1400849 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58681}
-
- 08 Jan, 2019 1 commit
-
-
Sigurd Schneider authored
Graph width is now managed by the Graph instead of the GraphView, which simplifies some interfaces. Change-Id: If78bc9a469cc8369bc75695a6612627103036bc8 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1398227Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58618}
-
- 07 Jan, 2019 8 commits
-
-
Sigurd Schneider authored
This CL removes the graph between phase changes. This prevents incorrect path layouting after changing from a phase where a path is displayed that is not a correct path in the phase we change to. Change-Id: Iad80f49efc8d8c71600ad51432981c3a206ef9cb Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1397710Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58592}
-
Sigurd Schneider authored
This CL simplifies the keydown handling code and fixes several issues: - Input to the search box was not reliably working, because the SVG keydown handler was attached to the window and its repeat-key detection was supressing key events. - Selecting the input of a node via keys 1-9 did not select the input, but always enabled the corresponding input node. 1-9 now select the input node, and CTRL+1 through CTRL+9 can be used to toggle the input edge. Bug: v8:7327 Notry: true Change-Id: Ifedc8b703f6552e101ad00fee2f3c50f29b325b5 Reviewed-on: https://chromium-review.googlesource.com/c/1397666 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58579}
-
Sigurd Schneider authored
This improves readability and encapsulation of the code. Change-Id: Ifbca8441941a1776797937c973a064153818c859 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396423 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58578}
-
Sigurd Schneider authored
This CL enables noImplicitReturns and noImplicitThis warnings in TypeScript, another step on the road to stricter types. Drive-by: Fix bug in search function. Change-Id: Iafb528b5f0e7ccc8774bc218fd0dcdb206a0de31 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396422 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58576}
-
Sigurd Schneider authored
Turbolizer only remembered the expansion state of the panes, but not their widths. This CL remembers the relative widths, and restores them upon reload. This is also useful when the size of the Turbolizer window changes. Change-Id: I0fd81c1266bfbddded86da16e2241420cdf73f4e Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396421 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58575}
-
Sigurd Schneider authored
Drive-by: Fix z-index (stacking) issue with hovers and pane resize bars. Change-Id: Ibd028a666681face1ccd6ec36b388f1ef25b1393 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396420 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58573}
-
Sigurd Schneider authored
This is a step towards removing all instances of implicit any types from turbolizer. This CL also replaces var with const/let. This improves readability and warnings. Change-Id: I67c2974df209f857e67dfdbb743ce695ce861982 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396419 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58572}
-
Sigurd Schneider authored
Refactor NodeLabel from GNode, which saves memory and is a step towards decoupling the node layout from the graph structure. Change-Id: I095a2f7a7ab28067161deffbc37952ae15410e0a Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396418 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58571}
-
- 06 Jan, 2019 1 commit
-
-
Mathias Bynens authored
This patch ensures each HTML page has a DOCTYPE (to trigger standards mode as opposed to quirks mode), a <meta charset="utf-8">, and a <title>. Additionally, it removes redundant attribute/value pairs such as `type="text/javascript"` on <script> elements or `type="text/css"` on <style> or <link rel="stylesheet"> elements. [1] Finally, it removes the optional solidus for self-closing HTML elements. [2] [1] https://mathiasbynens.be/notes/html5-levels#type-attributes [2] https://mathiasbynens.be/notes/html5-levels#solidus Change-Id: I66d2700be120dc8fd52bdf38f9d34749f55e1e7f Reviewed-on: https://chromium-review.googlesource.com/c/1396084Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#58561}
-
- 04 Jan, 2019 6 commits
-
-
Sigurd Schneider authored
This CL adds more TypeScript types and inserts some instanceof checks to ensure typing. The CL also selects es2018 as target and loads es6/es2018 libs for TypeScript types. This ensures that RegExp groups matching results are properly typed. Notry: true Bug: v8:7327 Change-Id: I1a59a1047188a49579c975149b336cc232c05eef Reviewed-on: https://chromium-review.googlesource.com/c/1396095Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58553}
-
Sigurd Schneider authored
...and fix all related issues. Change-Id: I3bd37ae038b9ea7c4305600958c1ae20e67e0f1f Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396092Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58552}
-
Sigurd Schneider authored
This CL updates TypeScript, rollup and d3 to newer versions. Drive-bys: - Remove unused source file lang-disassembly. - Fix typing problem with FileReader callback The rollup version update also ensures that watch mode works again: npm run-script watch Change-Id: If852bc4287760017c185fbcb6dd9d2e36db36a04 Notry: true Bug: v8:7327 Reviewed-on: https://chromium-review.googlesource.com/c/1396091 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58551}
-
Sigurd Schneider authored
- Move helper functions to utils - Use let/const instead of var - Fix display bug when schedule view was initially selected Bug: v8:7327 Notry: true Change-Id: I7caf3dd17b725a4553d035293716f452b9999ed8 Reviewed-on: https://chromium-review.googlesource.com/c/1396088 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58550}
-
Sigurd Schneider authored
This CL splits out a Graph class from the GraphView, which improves maintainability and is a first step towards preserving node positions during phase view changes. This CL also removes duplication of node storage on the graph and provides a generator function instead. The only storage for nodes in the graph is now the {nodeMap}. Bug: v8:7327 Notry: true Change-Id: I1659ecfe46f62a12d2fb3c40ccd6f4936f081b53 Reviewed-on: https://chromium-review.googlesource.com/c/1396087 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58549}
-
Sigurd Schneider authored
This removes duplicate storage of edges in the graph view, thereby reducing memory overhead. Bug: v8:7327 Notry: true Change-Id: I70df4bc102add8c89bc5145f01c0555b3e0a73d7 Reviewed-on: https://chromium-review.googlesource.com/c/1396085 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58548}
-
- 21 Dec, 2018 3 commits
-
-
Sigurd Schneider authored
This CL makes both absolute address and opcode literal (byte sequence of the instruction) display optional, which improves readability. Additionally, jump offsets are parsed and can now once again be clicked. TBR=neis@chromium.org Bug: v8:7327 Notry: true Change-Id: I709f44540b32f6d4afabdd1e5eb27e932208e7fc Reviewed-on: https://chromium-review.googlesource.com/c/1388540 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58444}
-
Sigurd Schneider authored
Disassembly selections now work even if no origin node is associated with the disassembly code range that the user selects. TBR=neis@chromium.org Bug: v8:7327 Change-Id: Ib5bfcaded66deb65314fde7d3cb9ed2c3c4f6fe9 Notry: true Reviewed-on: https://chromium-review.googlesource.com/c/1387492Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58423}
-
Sigurd Schneider authored
Bug: v8:7327 Notry: true Change-Id: Ia1c2164269d3d656b951d46debe42a811a6d9c89 Reviewed-on: https://chromium-review.googlesource.com/c/1386494Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58421}
-
- 20 Dec, 2018 1 commit
-
-
Sigurd Schneider authored
This is work towards making instructions in the sequence view selectable. For now, they are clickable and will select the corresponding instructions in the disassembly view. Bug: v8:7327 Notry: true Change-Id: I8850efeec7f94487bd80c11a7ad250a959062393 Reviewed-on: https://chromium-review.googlesource.com/c/1386112 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#58397}
-
- 19 Dec, 2018 1 commit
-
-
Sigurd Schneider authored
This CL improves load times by up to 6x. This is achieved by not setting event handlers per-line, but setting one event handler on the container. Unfortunately, load times are dominated by the graph view, which needs to be addressed in another CL. Bug: v8:7327 Notry: true Change-Id: Ie9a999f4150617fd763b770fcacca6096f457880 Reviewed-on: https://chromium-review.googlesource.com/c/1384312Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#58370}
-