- 12 Oct, 2015 18 commits
-
-
mbrandy authored
R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1390953004 Cr-Commit-Position: refs/heads/master@{#31221}
-
mtrofin authored
For live ranges with many use positions, such as those encountered in some unity asm.js code, this change significantly reduces compile time (e.g. benchmarks/Compile/slow_nbody1.js: from ~6s to 2s). The improvement is solely due to regressions (fixed by this CL) due to splintering. This CL does not fully address compile time problems for large functions in Turbofan, but constitutes a step in the right direction. Review URL: https://codereview.chromium.org/1386253004 Cr-Commit-Position: refs/heads/master@{#31220}
-
hpayer authored
Revert of [heap] Decrease large object limit for regular heap objects. (patchset #3 id:40001 of https://codereview.chromium.org/1392823003/ ) Reason for revert: broken tests Original issue's description: > [heap] Decrease large object limit for regular heap objects. > > Committed: https://crrev.com/e887d42342b3449f64fb6078f84f6c55bae3978d > Cr-Commit-Position: refs/heads/master@{#31217} TBR=mlippautz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1402823002 Cr-Commit-Position: refs/heads/master@{#31219}
-
adamk authored
BUG=v8:4482 LOG=n Review URL: https://codereview.chromium.org/1397513004 Cr-Commit-Position: refs/heads/master@{#31218}
-
hpayer authored
Review URL: https://codereview.chromium.org/1392823003 Cr-Commit-Position: refs/heads/master@{#31217}
-
mvstanton authored
The data structure that holds the optimized code is becoming essential for additional functionality, too. R=mstarzinger@chromium.org BUG= Review URL: https://codereview.chromium.org/1399033002 Cr-Commit-Position: refs/heads/master@{#31216}
-
mstarzinger authored
R=mvstanton@chromium.org Review URL: https://codereview.chromium.org/1399623004 Cr-Commit-Position: refs/heads/master@{#31215}
-
mstarzinger authored
The revert of the original change in question did not recover regressions, which allows us to reland this cleanup after all. This reverts commit 871529b4. R=hpayer@chromium.org Review URL: https://codereview.chromium.org/1393773004 Cr-Commit-Position: refs/heads/master@{#31214}
-
mbrandy authored
Port 2d4aeaad Original commit message: The stack manipulation was expensive. Two virtual registers are better. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Review URL: https://codereview.chromium.org/1390343004 Cr-Commit-Position: refs/heads/master@{#31213}
-
machenbach authored
Revert of Don't compile functions in a context the caller doesn't have access to (patchset #1 id:1 of https://codereview.chromium.org/1393713006/ ) Reason for revert: [Sheriff] Breaks layout tests. Please add needsmanualrebaseline upstream first if intended. E.g.: http://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/2263 (one of them is a timeout that only happens with this commit) Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead, just return undefined. > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > Based on https://codereview.chromium.org/294073002 but taking access > check callbacks into account > > BUG=chromium:541703 > R=verwaest@chromium.org > LOG=y > > Committed: https://crrev.com/9a5e2f512c4aa90563eb575605c2a8c2a92ac9f4 > Cr-Commit-Position: refs/heads/master@{#31208} TBR=verwaest@chromium.org,jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:541703 Review URL: https://codereview.chromium.org/1395583004 Cr-Commit-Position: refs/heads/master@{#31212}
-
littledan authored
Previously, name conflicts between var and let declarations were only made into exceptions if they were visible at parse-time. This patch adds runtime checks so that sloppy-mode direct eval can't introduce conflicting var declarations. The change is implemented by traversing the scope chain when a direct eval introduces a var declaration to look for conflicting let declarations, up to the function boundary. BUG=v8:4454 R=adamk LOG=Y Review URL: https://codereview.chromium.org/1382513003 Cr-Commit-Position: refs/heads/master@{#31211}
-
mythria authored
-Bitwise Or -Bitwise Xor -Bitwise And Adds the above bytecodes, support to BytecodeGenerator and BytecodeArrayBuilder to enable it's use, it's implementation and tests. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1386133002 Cr-Commit-Position: refs/heads/master@{#31210}
-
neis authored
R=rossberg BUG= Review URL: https://codereview.chromium.org/1403683003 Cr-Commit-Position: refs/heads/master@{#31209}
-
jochen authored
Instead, just return undefined. A side effect of this is that it's no longer possible to compile functions in a detached context. Based on https://codereview.chromium.org/294073002 but taking access check callbacks into account BUG=chromium:541703 R=verwaest@chromium.org LOG=y Review URL: https://codereview.chromium.org/1393713006 Cr-Commit-Position: refs/heads/master@{#31208}
-
machenbach authored
BUG=chromium:535160 LOG=n NOTRY=true Review URL: https://codereview.chromium.org/1395343002 Cr-Commit-Position: refs/heads/master@{#31207}
-
littledan authored
Revert of Stage --harmony_sloppy_function (patchset #2 id:20001 of https://codereview.chromium.org/1393423002/ ) Reason for revert: This still breaks Inbox. Original issue's description: > Stage --harmony_sloppy_function > > This patch turns on ES2015-style function hoisting semantics in > staging. --harmony_sloppy_function was previously staged, leading > to a number of bugs being filed and the staging being reversed; > important bugs have been fixed, so it is time to try again. > > R=adamk > LOG=Y > BUG=v8:4285 > > Committed: https://crrev.com/333e27fd99f8187c97e62b9538529900f0a30668 > Cr-Commit-Position: refs/heads/master@{#31190} TBR=adamk@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4285 Review URL: https://codereview.chromium.org/1402763003 Cr-Commit-Position: refs/heads/master@{#31206}
-
mythria authored
Adds support for following operators -Shift left -Shift right -Shift right logical Adds the above bytecodes, support to BytecodeGenerator and BytecodeArrayBuilder to enable it's use, it's implementation and tests. BUG=v8:4280 LOG=N Review URL: https://codereview.chromium.org/1392913002 Cr-Commit-Position: refs/heads/master@{#31205}
-
mvstanton authored
The stack manipulation was expensive. Two virtual registers are better. BUG= Review URL: https://codereview.chromium.org/1376933006 Cr-Commit-Position: refs/heads/master@{#31204}
-
- 11 Oct, 2015 1 commit
-
-
ahaas authored
Give the SupportedMachineOperatorFlags to GraphAndBuilders to allow the use of optional operators in tests. BUG= Review URL: https://codereview.chromium.org/1398023002 Cr-Commit-Position: refs/heads/master@{#31203}
-
- 09 Oct, 2015 14 commits
-
-
adamk authored
Review URL: https://codereview.chromium.org/1386383003 Cr-Commit-Position: refs/heads/master@{#31202}
-
adamk authored
Scope has no subclasses, so "protected" should just be "private". And there is no ParserFactory class, so making it a friend doesn't buy us anything. Review URL: https://codereview.chromium.org/1393303005 Cr-Commit-Position: refs/heads/master@{#31201}
-
karl authored
Now emits `Array buffer allocation failed` instead of `Invalid array buffer length`. Review URL: https://codereview.chromium.org/1393263003 Cr-Commit-Position: refs/heads/master@{#31200}
-
paul.lind authored
BUG= Review URL: https://codereview.chromium.org/1397003002 Cr-Commit-Position: refs/heads/master@{#31199}
-
ofrobots authored
Revert of improve perf_basic_prof filename reporting (patchset #4 id:60001 of https://codereview.chromium.org/1396843004/ ) Reason for revert: The test-case has issues on windows. http://build.chromium.org/p/client.v8/builders/V8%20Win32%20-%20debug%20-%203/builds/5011/steps/Check/logs/stdio Original issue's description: > improve perf_basic_prof filename reporting > > Re-implement https://codereview.chromium.org/1388543002 after fixing the issue > with SNPrintF crashing on windows when a zero-length buffer is passed in. > > R=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org > BUG=chromium:539892 > LOG=N > > Committed: https://crrev.com/701ba0b255f9c34f4b8c43584ef1e35040474e7d > Cr-Commit-Position: refs/heads/master@{#31197} TBR=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:539892 Review URL: https://codereview.chromium.org/1400813003 Cr-Commit-Position: refs/heads/master@{#31198}
-
ofrobots authored
Re-implement https://codereview.chromium.org/1388543002 after fixing the issue with SNPrintF crashing on windows when a zero-length buffer is passed in. R=jkummerow@chromium.org,yangguo@chromium.org,yurys@chromium.org BUG=chromium:539892 LOG=N Review URL: https://codereview.chromium.org/1396843004 Cr-Commit-Position: refs/heads/master@{#31197}
-
jochen authored
This will allow for probing access from any context to any receiver in a future CL. BUG=none R=jkummerow@chromium.org,verwaest@chromium.org LOG=n Review URL: https://codereview.chromium.org/1398093002 Cr-Commit-Position: refs/heads/master@{#31196}
-
jochen authored
Makes debugging failures a bit easier BUG=none R=ulan@chromium.org LOG=n Review URL: https://codereview.chromium.org/1398703007 Cr-Commit-Position: refs/heads/master@{#31195}
-
karl authored
Fixes clang on windows warning: ..\..\v8\src\base\platform\platform-win32.cc(836,1) : error: function declared 'noreturn' should not return [-Werror,-Winvalid-noreturn] CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_clang_rel,win_clang_x64_rel Review URL: https://codereview.chromium.org/1390193003 Cr-Commit-Position: refs/heads/master@{#31194}
-
jarin authored
The test had an effect phi with one effect input connected to a loop with two control inputs. Also, the Terminate node was used by the effect phi. Review URL: https://codereview.chromium.org/1398763002 Cr-Commit-Position: refs/heads/master@{#31193}
-
cbruni authored
strict mode. LOG=N BUG=chromium:423739 Review URL: https://codereview.chromium.org/1381083004 Cr-Commit-Position: refs/heads/master@{#31192}
-
Michael Achenbach authored
Cr-Commit-Position: refs/heads/master@{#31191}
-
littledan authored
This patch turns on ES2015-style function hoisting semantics in staging. --harmony_sloppy_function was previously staged, leading to a number of bugs being filed and the staging being reversed; important bugs have been fixed, so it is time to try again. R=adamk LOG=Y BUG=v8:4285 Review URL: https://codereview.chromium.org/1393423002 Cr-Commit-Position: refs/heads/master@{#31190}
-
caitpotter88 authored
Make the end position of a regexp literal the first character following the regexp. This matches the behaviour of number literals and string literals, as well as single-character tokens. This change corrects the lazy-parsing of arrow functions with concise bodies, whose last token is a regular expression literal. BUG=v8:4474 LOG=N R=wingo@igalia.com, adamk@chromium.org, rossberg@chromium.org Review URL: https://codereview.chromium.org/1389313003 Cr-Commit-Position: refs/heads/master@{#31189}
-
- 08 Oct, 2015 7 commits
-
-
bradnelson authored
Not all register codes are safe for use on all architectures. Using RegisterConfiguration when picking a calling convention in test-multiple-return. BUG=None TEST=test-multiple-return R=titzer@chromium.org LOG=N Review URL: https://codereview.chromium.org/1401453002 Cr-Commit-Position: refs/heads/master@{#31188}
-
littledan authored
Revert of Use simple/fast macro version of MinMax in JS (patchset #2 id:20001 of https://codereview.chromium.org/1390023003/ ) Reason for revert: This contains bugs, as found by mstarzinger. Reverting until we can find a clean fix (maybe it should be an inline function instead of a macro). Original issue's description: > Use simple/fast macro version of MinMax in JS > > Use the simple macro version of {Min, Max} where possible to > improve performance > > Follow-up to CR: https://codereview.chromium.org/1331993004 > > BUG= > > Committed: https://crrev.com/27c96c26212a10bb7f19f7bf3ff793b31bbad354 > Cr-Commit-Position: refs/heads/master@{#31162} TBR=jkummerow@chromium.org,mstarzinger@chromium.org,karl@skomski.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1394303003 Cr-Commit-Position: refs/heads/master@{#31187}
-
akos.palfi authored
BUG= Review URL: https://codereview.chromium.org/1393903003 Cr-Commit-Position: refs/heads/master@{#31186}
-
karl authored
Without that, it has a few false positives about out-of-bounds array accesses. Also makes the clang static-analyzer happy. Original code review from Sven Panne: https://codereview.chromium.org/790723002/ CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_arm_dbg,v8_linux_arm64_dbg,v8_mac64_dbg,v8_win_compile_dbg,v8_linux_gcc_rel Review URL: https://codereview.chromium.org/1393023003 Cr-Commit-Position: refs/heads/master@{#31185}
-
bradnelson authored
This will allow exploration of possibilities like passing around buffer base and length. BUG=None TEST=test-multiple-return LOG=N R=mtrofin@chromium.org,titzer@chromium.org Review URL: https://codereview.chromium.org/1391333003 Cr-Commit-Position: refs/heads/master@{#31184}
-
mlippautz authored
R=ulan@chromium.org BUG=chromium:524425 LOG=N Review URL: https://codereview.chromium.org/1394863002 Cr-Commit-Position: refs/heads/master@{#31183}
-
machenbach authored
BUG= Review URL: https://codereview.chromium.org/1396803002 Cr-Commit-Position: refs/heads/master@{#31182}
-