- 10 Nov, 2021 2 commits
-
-
Ng Zhi An authored
F64x2ExtractLane and F64x2ReplaceLane were missing the IA32 prefix that is used by all the other instruction codes. Bug: v8:12244 Change-Id: Ib99cd9b62161a13305ad01d6e7e0aa82046dd25a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3255662Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77808}
-
Ng Zhi An authored
4 instructions, int32x4.trunc_f32x4_{s,u}, int32x4.trunc_f64x2_{s,u}_zero. ia32 port of a7b208739d2dabe11ca4e792085aed3455e879d5. Bug: v8:12284 Change-Id: Ia94ff572b63f9fd8e3bfe2dd8e5fa41212f84a76 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3255661Reviewed-by:
-
- 09 Nov, 2021 27 commits
-
-
Dominik Inführ authored
This flag is now enabled by default for quite some time in production. In addition that flag was already defined readonly and couldn't be disabled, so let's remove this flag for good. Bug: v8:10064 Change-Id: I0e71eee9d25960a96324d56c8f0191fe678dc6e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268907 Commit-Queue: Dominik Inführ <dinfuehr@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#77806}
-
Seth Brenith authored
The GC already treats some embedded object pointers in Code as weak, based on Code::IsWeakObject. If one of those embedded objects ends up unmarked during a full mark-collect GC, then the Code is marked for lazy deoptimization and the embedded objects are cleared. However, many of those same objects are often held strongly by the deoptimization literal array for the Code, which causes memory leaks. This change updates the deoptimization literals array to store those objects weakly. Any Code currently executing on the stack might need those deoptimization literals in order to deoptimize, so the deoptimization literal array is marked strongly in that case. Design document: https://docs.google.com/document/d/1gFRBYCeqz9Mysx8CVYQkldBbk3AZLo8UX0DMLZV_7qw/edit?usp=sharing Bug: v8:4578 Change-Id: I02e86683c59371e9f88ecf523750c9c6afebdb39 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160299Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I1ec0d96b645afa9bbda670918ce57be3698f50ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3265684 Commit-Queue: Zhi An Ng <zhin@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/main@{#77804}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I7f5067c9a329ac27bb4ec72d97a7509028ae648a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269176Reviewed-by:
Nico Hartmann <nicohartmann@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77803}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/f7f53e9..0a9d641 Rolling v8/buildtools/third_party/libc++abi/trunk: https://chromium.googlesource.com/external/github.com/llvm/llvm-project/libcxxabi/+log/4c6e099..bc060a2 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/e5067b0..462705b Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/6500963..266129c Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/a736941..fe0d17a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/af96b7b..92efe5e TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com Change-Id: I4a5d7a8bc8725b4eab5ca35837c1c702e6cd76d3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269624Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/main@{#77802}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I794fff2dee42d16c5e75457cc905fd5ac68919cb Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269173Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I2aaa01215276cbfdf269b2e60dc2482d0aebc0dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269174Reviewed-by:
Maya Lekova <mslekova@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77800}
-
Seth Brenith authored
As Nico pointed out in [1], it is a little strange that the pair of annotations "@export @customCppClass" behaves similarly to the keyword "extern": both indicate that the class is defined in a C++ file and Torque generates only a base class template for it. In this change, I explore a possible alternative which might be more consistent. Removed annotations: - @customCppClass, which required @export, instructed Torque to only generate a base class template instead of a full class. - @customMap, which also required @export, instructed Torque to not emit code for setting up a unique Map instance for the class. Added annotations: - @generateUniqueMap, which requires extern, instructs Torque to emit code for setting up a unique Map instance for the class. - @generateFactoryFunction, which requires extern, instructs Torque to emit a function for creating a class instance. Subtracting two annotations and adding two others still leaves us with way too many annotations, but the usage of "extern" becomes more consistent and I think that the new opt-in annotations might be easier to understand. [1] https://docs.google.com/document/d/1q_gZLnXd4bGnCx3IUfbln46K3bSs9UHBGasy9McQtHI/edit Bug: v8:7793 Change-Id: Ic9e147a095bc492d6645001b9275357386e8adcf Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266008Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I05775d6a9f7d0188573017ac588d6af504930b91 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269175Reviewed-by:
-
Joyee Cheung authored
In assignments the lhs should be evaluated first and shouldn't be re-evaluated when the value of the rhs is available. Fix it by saving the receiver and the key registers into AssignmentLhsData before building the assignment and use them later, instead of visiting the AST again to retrieve the receiver. In addition, now that we save the receiver register, use it to perform the brand check even when we know for sure that it's going to fail later because it's a write to a private method or accessing the accessor in the wrong way (v8:11364), so that the brand check error always appears first if it is present, as specified in https://tc39.es/proposal-private-methods/#sec-privatefieldget Drive-by: unify the brand check error messages, and replace "Object" with "Receiver" in the messages for clarity. The instance private brand check now throws "Receiver must be an instance of class <name>" and the static private brand check now throws "Receiver must be class <name>". Also always set the expression position to the property load position, because the brand check failure comes from the load operation. Bug: v8:12352, v8:11364 Change-Id: I61a8979b2e02b561dd5b2b35f9e0b6691fe07599 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266964 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
Marja Hölttä <marja@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/main@{#77797}
-
Al Muthanna Athamina authored
We want to skip the readability/check rule on the bigint directory while keeping the rest of the linting. Bug: v8:12024 Change-Id: I56f84554af9aa44d4436249916269b5441d4fbaa Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264221Reviewed-by:
Jakob Kummerow <jkummerow@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Almothana Athamneh <almuthanna@chromium.org> Cr-Commit-Position: refs/heads/main@{#77796}
-
Camillo Bruni authored
In the future we will allow arbitrary objects as host-defined options. To prepare the embedders for the upcoming changes we migrate the API to use v8::Data where possible. Internally we still use i::FixedArray with primitive values until the migration to context-stored host-defined options is completed. Note: This CL also introduces a temporary cast and inheritance between Data and PrimitiveArray which will be removed again. Bug: chromium:1244145 Change-Id: I852d0d827708d32b6f3a6d03457234a006e2fd77 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264285 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Victor Gomes <victorgomes@chromium.org> Cr-Commit-Position: refs/heads/main@{#77795}
-
Marja Hölttä authored
In order to construct the optimal source code combination for functions (and especially the positions inside the optimal source code for each function), we need to know all functions upfront. Rewrite the d8-based snapshotter so that it discovers all objects first (+ assigns ids), then does the actual snapshotting. Bug: v8:11525 Change-Id: I4f4e5589575ee9738e8a83aa6cda2c8164803b4c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268915Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/main@{#77794}
-
Jakob Gruber authored
Change-Id: Id51910177ce1124b025af2ec36ab6d7c6b06937d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268741 Auto-Submit: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Adds support for aborting compaction when finalizing with stack: - never_compact_with_stack: All pages are aborted; - never_compact_code_space_with_stack: Only code space pages are aborted; This flags allow simulating a worst case where a stack cannot be considered precise, or evacuation candiate is refered to from a stack slot that V8 has no info for. Bug: v8:12251 Change-Id: Ice24ac87a985b8ecf7b5cbb5c106ad4a3ae1944b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3173682 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Dominik Inführ <dinfuehr@chromium.org> Cr-Commit-Position: refs/heads/main@{#77792}
-
Victor Gomes authored
No-Try: true Change-Id: Icdcd22ba16670e3e56f5610141d708c2ca2a165e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268914 Auto-Submit: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL fixes a memory leak where we would not properly pop all Promises from the Isolate-wide Promise stack. This can happen under the following conditions: - `await`ing a Promise in an async function - Debugger is active - AsyncEventDelegate is not set. In the case above, the promise of the surrounding async function is pushed onto the global Promise stack, but not poped before the await. This CL fixes that. R=bmeurer@chromium.org Fixed: chromium:1225905 Change-Id: If03f6bfda48b8cb14bc6a68815fd702632edc68d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268464Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Victor Gomes authored
This reverts commit 04899013. Reason for revert: Main CL got reverted: https://chromium-review.googlesource.com/c/v8/v8/+/3268910 Original change's description: > [bazel] Adds encoded-c-signature.{cc,h} > > Introduced by: > https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > > No-Try: true > Bug: chromium:1052746 > Change-Id: I1dd0028fd05999ec7b4128bb9250f7fa663dfe41 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264292 > Auto-Submit: Victor Gomes <victorgomes@chromium.org> > Reviewed-by: Maya Lekova <mslekova@chromium.org> > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77753} Bug: chromium:1052746 Change-Id: Ib5ebcf4f02abfd8f270269079d132abf10ab9645 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268740Reviewed-by:
-
Maya Lekova authored
This reverts commit b9ddcbc8. Reason for revert: Hits unreachable on MSAN, see https://bugs.chromium.org/p/chromium/issues/detail?id=1267854 Original change's description: > [fastcall] Enable float support on arm64 simulator > > This CL adds support for handling calls to C functions with arbitrary > signatures on the arm64 simulator. It adds infrastructure for > encoding the signature data from CallDescriptor and FunctionInfo > classes into a compact representation, stored in the simulator and > called EncodedCSignature. > > Design doc: > https://docs.google.com/document/d/1ZxOF3GSyNmtU0C0YJvrsydPJj35W_tTJZymeXwfDxoI/edit > > This CL is a follow up on the native support added in > https://chromium-review.googlesource.com/c/v8/v8/+/3182232 > and is partially based on the previous attempt: > https://chromium-review.googlesource.com/c/v8/v8/+/2343072 > > Bug: chromium:1052746 > Change-Id: I0991b47bd644b2fc2244c5eb923b085261f04765 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3060486 > Commit-Queue: Maya Lekova <mslekova@chromium.org> > Reviewed-by: Camillo Bruni <cbruni@chromium.org> > Reviewed-by: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77744} Bug: chromium:1052746, chromium:1267854, chromium:1267841 Change-Id: If3d5aaab6b5f4309ce90add614d674aaa86b43c7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268910 Commit-Queue: Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Al Muthanna Athamina authored
Bug: v8:12185 Change-Id: If5f07f6f7aa2d63d09bcf069fce57b124cbc9c76 No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263974 Auto-Submit: Almothana Athamneh <almuthanna@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Victor Gomes authored
This is a reland of ef62cd06 Original change's description: > [heap] Remove executable_memory_ from release code > > The map is only used to check invariants. > > Bug: v8:12054 > Change-Id: I7d067cca801c9b6104efb22a26cf27f1f62920c5 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268286 > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org> > Commit-Queue: Victor Gomes <victorgomes@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77766} Bug: v8:12054 Change-Id: I2a699d1db4c1ed5a2881a1ccd9dd3b36b20ea8e5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268303 Commit-Queue: Victor Gomes <victorgomes@chromium.org> Reviewed-by:
-
Leszek Swirski authored
This reverts commit 3a46c81c. Reason for revert: Breaking roll (or rather, oh no, cast_shell is broken, need to fix that before relanding): https://ci.chromium.org/ui/p/chromium/builders/try/cast_shell_linux/1053410/overview Original change's description: > [flags] Add a sanity check for unchanged jitless flags > > V8 flags in general should not change in a process after the > first Isolate has been initialized. --jitless and related flags > especially sensitive to this, so we introduce a dedicated check > just for them. > > Bug: chromium:1262676, v8:9019, v8:12366 > Change-Id: I239726889d236a3785c1fdc076fa21d1b8983c92 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3260508 > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#77759} Bug: chromium:1262676, v8:9019, v8:12366 Change-Id: Ie47d183bfd68633c3d30a13a038219051c38eba0 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268734 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Owners-Override: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#77785}
-
Liu Yu authored
Besides, port commit 9711289d to mips and loong64, and fix an error with the usage of BlockTrampolinePoolFor. Change-Id: Ifee64f8471e1d2db8945768370a30ab06210420c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269369Reviewed-by:
Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Commit-Queue: Zhao Jiazhong <zhaojiazhong-hf@loongson.cn> Auto-Submit: Liu yu <liuyu@loongson.cn> Cr-Commit-Position: refs/heads/main@{#77784}
-
v8-ci-autoroll-builder authored
Rolling v8/third_party/google_benchmark/src: https://chromium.googlesource.com/external/github.com/google/benchmark/+log/329fb06..431abd1 Fix warning with MacOS (#1276) (Bensuperpc) https://chromium.googlesource.com/external/github.com/google/benchmark/+/431abd1 Fixed typo in doc: s/marcro/macro (#1274) (Vy Nguyen) https://chromium.googlesource.com/external/github.com/google/benchmark/+/4b99670 TBR=v8-waterfall-sheriff@grotations.appspotmail.com,mtv-sf-v8-sheriff@grotations.appspotmail.com,mlippautz@chromium.org Change-Id: Ia2b2029241092d1821264f18cc514d14231bb114 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3269626Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I5b908f056222c57e796fb76e86ceea9a77cde77f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3265066Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I7de616f87dcec7ebaa51af10390c2685650633d0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266004Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77781}
-
Ng Zhi An authored
Relaxed f32x4 and f64x2 min and max. These instructions only guarantee results when the inputs are non nans, and when the inputs are not 0s of opposite signs. Drive-by rename of instruction codes to be Minps/Maxps/Minpd/Maxpd since they map down exactly to a single instruction. ia32 port of c3f346b7. Bug: v8:12284 Change-Id: If64da551524ea8c304e1fa8f9cf4acbd54abfe5c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251708Reviewed-by:
-
- 08 Nov, 2021 11 commits
-
-
Ng Zhi An authored
4 instructions, i8x16, i16x8, i32x4, i64x2 relaxed lane select. These instructions only guarantee results when the entire lane is set or unset, so vpblendvb will give correct results for all of them. Same instruction selector code as x64. Bug: v8:12284 Change-Id: Icd0bc8c5125cd2780141117830d6cb6e6babbb74 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3251701Reviewed-by:
-
Junliang Yan authored
Change-Id: Ib13761e9336e67cc2fc218c3a6e9193330fdfd45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268937Reviewed-by:
Milad Fa <mfarazma@redhat.com> Commit-Queue: Junliang Yan <junyan@redhat.com> Cr-Commit-Position: refs/heads/main@{#77778}
-
Ng Zhi An authored
vmovups requires AVX, even though we have FMA3 scope, that only enables FMA3 and not AVX. We can't enable AVX when FMA3 is supported (inside of Assembler::Assembler) because we will hit some DCHECKS in SSE instructions that check that AVX is not enabled. Reported in https://chromium-review.googlesource.com/c/v8/v8/+/3131370/5#message-8a19a8c68a205f1efa208917df89a2082bae2276 Bug: v8:11659 Change-Id: Iece17c6550d4a6cbfca0c7f9c0ca042b52600d8e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3252249Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I801821448459bf2b74c99b36f6882d59bb24a273 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264645Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I68aeaf1f30a03295ef76bb07037e809ed91f6977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3266009Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Ia999105ffd616c07d4e062e0ddf3a35419d645e6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264644Reviewed-by:
-
Camillo Bruni authored
Bug: v8:12195 Change-Id: I815594cf7636c1830a6f025159fe0950fe925744 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3268196 Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Explicit write barriers for internal fields are deprecated as they are automatically emitted by V8. Depends on: https://crrev.com/c/3263924 Bug: v8:12356 Change-Id: I171ba5b42a6570ce52e2e2ea1b7c1029d5a8a3a7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3263888Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: Ic84020ea7e54c50dc8f773eb655078582bb33fa7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264361Reviewed-by:
Shu-yu Guo <syg@chromium.org> Commit-Queue: Zhi An Ng <zhin@chromium.org> Cr-Commit-Position: refs/heads/main@{#77771}
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: If92311b47a6019cb9f7b96a7dcd313a658d426ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3265067Reviewed-by:
-
Ng Zhi An authored
Bug: v8:12244,v8:12245 Change-Id: I4bc0378a7d4ad3033485f98e446daa7ff2e83e0a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264646Reviewed-by:
-
