Commit 933f41e1 authored by Ng Zhi An's avatar Ng Zhi An Committed by V8 LUCI CQ

[compiler][objects] Fix -Wshadow warnings

Bug: v8:12244,v8:12245
Change-Id: Ia999105ffd616c07d4e062e0ddf3a35419d645e6
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3264644Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
Commit-Queue: Zhi An Ng <zhin@chromium.org>
Cr-Commit-Position: refs/heads/main@{#77774}
parent c896fd4f
......@@ -1469,7 +1469,7 @@ ObjectData* JSHeapBroker::TryGetOrCreateData(Handle<Object> object,
#define CREATE_DATA(Name) \
if (object->Is##Name()) { \
RefsMap::Entry* entry = refs_->LookupOrInsert(object.address()); \
entry = refs_->LookupOrInsert(object.address()); \
object_data = zone()->New<ref_traits<Name>::data_type>( \
this, &entry->value, Handle<Name>::cast(object), \
ObjectDataKindFor(ref_traits<Name>::ref_serialization_kind)); \
......
......@@ -101,11 +101,11 @@ LookupIterator::LookupIterator(Isolate* isolate, Handle<Object> receiver,
// is not a typed array, then this means "array index", otherwise we need to
// ensure the full generality so that typed arrays are handled correctly.
if (!check_prototype_chain() && !lookup_start_object->IsJSTypedArray()) {
uint32_t index;
DCHECK(!name_->AsArrayIndex(&index));
uint32_t array_index;
DCHECK(!name_->AsArrayIndex(&array_index));
} else {
size_t index;
DCHECK(!name_->AsIntegerIndex(&index));
size_t integer_index;
DCHECK(!name_->AsIntegerIndex(&integer_index));
}
#endif // DEBUG
Start<false>();
......
......@@ -4198,7 +4198,7 @@ TEST(HeapSnapshotDeleteDuringTakeSnapshot) {
WeakData* data =
new WeakData{heap_profiler->TakeHeapSnapshot(), &gc_calls, &handle};
v8::HandleScope scope(env->GetIsolate());
v8::HandleScope inner_scope(env->GetIsolate());
handle.Reset(env->GetIsolate(), v8::Object::New(env->GetIsolate()));
handle.SetWeak(
data,
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment