1. 12 Feb, 2021 1 commit
    • Milad Fa's avatar
      PPC/s390: [debug] Fix extra arguments when restarting frame · 02c80dbf
      Milad Fa authored
      Port 94b294b3
      
      Original Commit Message:
      
          Before the removal of the arguments adaptor frame, we could set {actual arguments count} = {formal parameter count} before restarting a live frame to avoid re-entering in the adaptor frame trampoline.
          This does not work anymore, since we now need the correct value of the {actual argument count} to be pushed in the callee frame to be used in its epilogue.
      
          This CL calls InvokeCall with the correct argument count and the kDontAdaptArgumentsSentinel to skip arguments adaptation.
      
      R=victorgomes@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
      BUG=
      LOG=N
      
      Change-Id: Idc7f712d1860192dc0306366ca77230ed8ad3455
      Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2693046Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
      Commit-Queue: Milad Fa <mfarazma@redhat.com>
      Cr-Commit-Position: refs/heads/master@{#72716}
      02c80dbf
  2. 21 Dec, 2020 1 commit
  3. 11 Dec, 2020 1 commit
  4. 04 Dec, 2020 1 commit
  5. 31 Mar, 2020 1 commit
  6. 31 Oct, 2019 1 commit
  7. 30 Oct, 2019 2 commits
  8. 25 Oct, 2019 1 commit
  9. 28 May, 2019 1 commit
  10. 24 May, 2019 1 commit
  11. 22 May, 2019 1 commit
  12. 21 May, 2019 1 commit
  13. 14 Jan, 2019 1 commit
  14. 31 May, 2018 1 commit
    • Junliang Yan's avatar
      PPC/s390: [sfi] Compress function arg counts to 16 bit · 035dbdd9
      Junliang Yan authored
      Port 53d4dfc3
      
      Original Commit Message:
      
          Compress the parameter count (and function length) stored in
          SharedFunctionInfo to a uint16_t. This limits us to 2^16 - 1 parameters
          per function, minus one for the "don't adapt arguments" sentinel value,
          which is one fewer than Code::kMaxArguments was already. Anyway, 65534
          arguments should be enough for anyone!
      
          This drops SFI size by 4 bytes.
      
      R=leszeks@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=
      LOG=N
      
      Change-Id: I23db04fd41ad577949cd8d45bab82c77019d9350
      Reviewed-on: https://chromium-review.googlesource.com/1081450Reviewed-by: 's avatarJoran Siu <joransiu@ca.ibm.com>
      Commit-Queue: Junliang Yan <jyan@ca.ibm.com>
      Cr-Commit-Position: refs/heads/master@{#53464}
      035dbdd9
  15. 12 Apr, 2018 1 commit
  16. 20 Oct, 2017 1 commit
  17. 13 Oct, 2017 1 commit
  18. 16 Aug, 2017 1 commit
  19. 03 Aug, 2017 1 commit
  20. 19 Jul, 2017 1 commit
  21. 27 Jan, 2017 1 commit
    • bjaideep's avatar
      PPC/s390: [liveedit] reimplement frame restarting. · 9515f7ed
      bjaideep authored
      Port 3f47c63d
      
      Original Commit Message:
      
          Previously, when restarting a frame, we would rewrite all frames
          between the debugger activation and the frame to restart to squash
          them, and replace the return address with that of a builtin to
          leave that rewritten frame, and restart the function by calling it.
      
          We now simply remember the frame to drop to, and upon returning
          from the debugger, we check whether to drop the frame, load the
          new FP, and restart the function.
      
      R=yangguo@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
      BUG=v8:5587
      LOG=N
      
      Review-Url: https://codereview.chromium.org/2663453004
      Cr-Commit-Position: refs/heads/master@{#42748}
      9515f7ed
  22. 12 Jan, 2017 1 commit
  23. 06 Sep, 2016 1 commit
    • marja's avatar
      Include only stuff you need, part 8: Fix debug.h -> liveedit.h. · 51a3ffd9
      marja authored
      Rebuilding (after touching certain files) is crazy slow because
      includes are out of control.
      
      The (last remaining) offending include path is: ast.h <- liveedit.h <-
      debug.h <- src/x64/assembler-whatever-port-inl.h <-
      src/macro-assembler.h <- everything possible
      
      With this CL, the rebuild steps needed when touching ast-value-factory.h
      drops from 365 to 181.
      
      BUG=v8:5294
      TBR=bmeurer@chromium.org
      
      Review-Url: https://codereview.chromium.org/2316443002
      Cr-Commit-Position: refs/heads/master@{#39195}
      51a3ffd9
  24. 09 Jun, 2016 1 commit
    • ishell's avatar
      [ic] [stubs] Remove InlineCacheState field from the code flags. · 9dc62d27
      ishell authored
      There are no ICs left that store their state in this field: vector based
      ICs use feedback vector and the rest three (BinaryOpIC, CompareIC and
      ToBooleanIC) reconstruct their state from the ExtraICState field.
      
      This CL also removes unused InlineCacheState::DEBUG_STUB which was used
      mostly in Code::is_debug_stub(). The latter now checks if the code is one
      of the debug builtins instead.
      
      BUG=chromium:618701
      LOG=Y
      
      Review-Url: https://codereview.chromium.org/2052763003
      Cr-Commit-Position: refs/heads/master@{#36871}
      9dc62d27
  25. 30 May, 2016 1 commit
  26. 30 Mar, 2016 1 commit
    • mythria's avatar
      [Interpreter] Adds support to fetch return value on break at return. · b82720df
      mythria authored
      Debugger fetches the return value of a function when we break at return.
      Interpreter holds the return value in accumulator. This is not stored in a
      specified location on stack and hence it is not possible to look it up from
      stack similar to full-codegen or optimized frames. This cl adds support to
      store the value of accumulator on debug breaks. The value of accumulator is
      passed to the runtime function and is then stored in thread local data.
      
      Also changes full-codegen implementation to match that of ignition.
      The return value from full-codegen is also stored in thread local data.
      The return value is fetched directly thread local data instead of
      finding it by iterating over frames.
      
      BUG=v8:4280, v8:4690
      LOG=N
      
      Review URL: https://codereview.chromium.org/1842683002
      
      Cr-Commit-Position: refs/heads/master@{#35127}
      b82720df
  27. 24 Mar, 2016 2 commits
    • machenbach's avatar
      Revert of [Interpreter] Adds support to fetch return value on break at return.... · 25d2b247
      machenbach authored
      Revert of [Interpreter] Adds support to fetch return value on break at return. (patchset #9 id:160001 of https://codereview.chromium.org/1818873003/ )
      
      Reason for revert:
      [Sheriff] Seems to break nosnap debug:
      https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6019
      
      Original issue's description:
      > [Interpreter] Adds support to fetch return value on break at return.
      >
      > Debugger fetches the return value of a function when we break at return.
      > Interpreter holds the return value in accumulator. This is not stored in a
      > specified location on stack and hence it is not possible to look it up from
      > stack similar to full-codegen or optimized frames. This cl adds support to
      > store the value of accumulator on debug breaks. The value of accumulator is
      > passed to the runtime function and is then stored in thread local data.
      >
      > Also changes full-codegen implementation to match that of ignition.
      > The return value from full-codegen is also stored in thread local data.
      > The return value is fetched directly thread local data instead of
      > finding it by iterating over frames.
      >
      > BUG=v8:4280, v8:4690
      > LOG=N
      >
      > Committed: https://crrev.com/fb65527b75754bcf3b173f16f5d0b04a1c6d9b99
      > Cr-Commit-Position: refs/heads/master@{#35060}
      
      TBR=rmcilroy@chromium.org,yangguo@chromium.org,weiliang.lin@intel.com,balazs.kilvady@imgtec.com,jyan@ca.ibm.com,mythria@chromium.org
      # Skipping CQ checks because original CL landed less than 1 days ago.
      NOPRESUBMIT=true
      NOTREECHECKS=true
      NOTRY=true
      BUG=v8:4280, v8:4690
      
      Review URL: https://codereview.chromium.org/1834733002
      
      Cr-Commit-Position: refs/heads/master@{#35065}
      25d2b247
    • mythria's avatar
      [Interpreter] Adds support to fetch return value on break at return. · fb65527b
      mythria authored
      Debugger fetches the return value of a function when we break at return.
      Interpreter holds the return value in accumulator. This is not stored in a
      specified location on stack and hence it is not possible to look it up from
      stack similar to full-codegen or optimized frames. This cl adds support to
      store the value of accumulator on debug breaks. The value of accumulator is
      passed to the runtime function and is then stored in thread local data.
      
      Also changes full-codegen implementation to match that of ignition.
      The return value from full-codegen is also stored in thread local data.
      The return value is fetched directly thread local data instead of
      finding it by iterating over frames.
      
      BUG=v8:4280, v8:4690
      LOG=N
      
      Review URL: https://codereview.chromium.org/1818873003
      
      Cr-Commit-Position: refs/heads/master@{#35060}
      fb65527b
  28. 15 Mar, 2016 2 commits
  29. 01 Mar, 2016 1 commit