Skip to content

V
V8
Switch branch/tag
  1. 26 Apr, 2011 1 commit
  3. 21 Apr, 2011 1 commit
  5. 09 Mar, 2011 1 commit
  7. 02 Feb, 2011 1 commit
  9. 19 Jan, 2011 1 commit
    • vitalyr@chromium.org's avatar
      Support StringCharCodeAt in hydrogen/lithium. · b4ff318e
      vitalyr@chromium.org authored 
      This patch adds H- and L-variants of StringCharCodeAt and StringLength.

StringCharCodeAt is used to inline a constant function call of
String.prototype.charCodeAt and to implement the corresponding inline
runtime function. It does not yet use the recently introduced extra IC
state. (We can specialize on string encoding and avoid deopts because
of out of bounds accesses.)

StringLength needs more work because the stub version of it also
supports strings wrappers and it matters in some cases. (We have to
separate the string only case.)

Review URL: http://codereview.chromium.org/6243008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6408 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      b4ff318e
  11. 22 Dec, 2010 1 commit
  13. 20 Dec, 2010 1 commit
  15. 07 Dec, 2010 3 commits
  17. 15 Nov, 2010 1 commit
  19. 09 Nov, 2010 1 commit
  21. 25 Oct, 2010 1 commit
  23. 30 Sep, 2010 1 commit
  25. 28 Sep, 2010 2 commits
  27. 24 Sep, 2010 2 commits
    • dimich@chromium.org's avatar
      Add CODE_POINTER_ALIGN, use it in Page to align generated code. · 589eb4a8
      dimich@chromium.org authored 
      The object's space in Page starts after Page header and is aligned to kMapAlignment which is 32 bytes on 32-bit and 8 bytes on 64-bit.

In case of 64-bit target, the current page header size is exactly 32 bytes so we get the code magically aligned at 32 bytes but it is better to have a separate CODE_POINTER_ALIGN macro to make sure the object space in Page is aligned properly for both maps and code.

There could be a small waste of bytes sometimes (since both Page header and Code header sizes are aligned separately) but it seems the optimal one would involve cross-dependencies between .h files and not clear if it's worth it.

This is a back-port from Isolates branch.

Review URL: http://codereview.chromium.org/3461021

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5526 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      589eb4a8
    • kaznacheev@chromium.org's avatar
      Prevent modification of cached normalized maps. · cfbc1eed
      kaznacheev@chromium.org authored 
      Finally sovles the problem that r5342 attempted to solve.
When adding a stub to a map's code cache we need to make
sure that this map is not used by object that do not need
this stub.

Existing solution had 2 flaws:
1. It checked that the map is cached by asking the current context.
If the object escaped into another context then NormalizedMapCache::Contains
returns false negative.

2. If a map gets evicted from the cache we should not try to modify it
even though Contains returns false.

This patch implements much less fragile solution of the same problem:
A map now has a flag (is_shared) that is set once the map is added
to a cache, stays set even after the cache eviction, and is cleared
if the object goes back to fast mode.

Added a regression test.

Review URL: http://codereview.chromium.org/3472006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5518 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      cfbc1eed
  29. 25 Aug, 2010 1 commit
  31. 18 Aug, 2010 1 commit
  33. 16 Aug, 2010 1 commit
    • vitalyr@chromium.org's avatar
      Copy-on-write arrays. · 3202df6c
      vitalyr@chromium.org authored 
      Object model changes
----------------------------------------
New fixed_cow_array_map is used for the elements array of a JSObject
to mark it as COW. The JSObject's map and other fields are not
affected. The JSObject's map still has the "fast elements" bit set. It
means we can do only the receiver map check in keyed loads and the
receiver and the elements map checks in keyed stores. So introducing
COW arrays doesn't hurt performance of these operations. But note that
the elements map check is necessary in all mutating operations because
the "has fast elements" bit now means "has fast elements for reading".
EnsureWritableFastElements can be used in runtime functions to perform
the necessary lazy copying.

Generated code changes
----------------------------------------
Generic keyed load is updated to only do the receiver map check (this
could have been done earlier). FastCloneShallowArrayStub now has two
modes: clone elements and use COW elements. AssertFastElements macro
is added to check the elements when necessary. The custom call IC
generators for Array.prototype.{push,pop} are updated to avoid going
to the slow case (and patching the IC) when calling the builtin should
work.

COW enablement
----------------------------------------
Currently we only put shallow and simple literal arrays in the COW
mode. This is done by the parser.

Review URL: http://codereview.chromium.org/3144002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5275 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      3202df6c
  35. 02 Aug, 2010 1 commit
  37. 28 Jul, 2010 1 commit
  39. 13 Jul, 2010 1 commit
  41. 24 Jun, 2010 1 commit
  43. 17 Jun, 2010 1 commit
  45. 27 May, 2010 1 commit
  47. 26 May, 2010 1 commit
  49. 25 May, 2010 1 commit
    • vegorov@chromium.org's avatar
      Cardmarking writebarrier. · 675e711f
      vegorov@chromium.org authored 
      - New сardmarking write barrier handles large objects and normal objects in a similar fashion (no more additional space for pointer tracking is required, no conditional branches in WB code).
- Changes to enable oldspaces iteration without maps decoding:
-- layout change for FixedArrays: length is stored as a smis (initial patch by
Kevin Millikin)
-- layout change for SharedFunctionInfo: integer fields are stored as smi on
arm, ia32 and rearranged on x64.
-- layout change for String: meaning of LSB bit is fliped (1 now means hash not
computed); on x64 padding is added.
-- layout of maps is _not_ changed. Map space is currently iterated in a special
way.

Review URL: http://codereview.chromium.org/2144006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@4715 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
      675e711f
  51. 21 May, 2010 2 commits
  53. 20 May, 2010 2 commits
  55. 04 May, 2010 1 commit
  57. 19 Apr, 2010 1 commit
  59. 23 Mar, 2010 1 commit
  61. 11 Mar, 2010 1 commit
  63. 09 Mar, 2010 1 commit
  65. 25 Feb, 2010 2 commits