Refactoring out object printing functions into objects-printer.cc.

Patch by Mark Lam from Hewlett-Packard Development Company, LP

Review URL: http://codereview.chromium.org/6083001


git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@6110 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

src/SConscript

@@ -229,9 +229,10 @@ SOURCES = {
   'os:win32':   ['platform-win32.cc'],
   'mode:release': [],
   'mode:debug': [
-    'objects-debug.cc', 'prettyprinter.cc', 'regexp-macro-assembler-tracer.cc'
+    'objects-debug.cc', 'objects-printer.cc', 'prettyprinter.cc',
+    'regexp-macro-assembler-tracer.cc'
   ],
-  'objectprint:on': ['objects-debug.cc']
+  'objectprint:on': ['objects-printer.cc']
 }
 
 

test/cctest/test-assembler-ia32.cc

@@ -74,7 +74,7 @@ TEST(AssemblerIa320) {
                                   Handle<Object>(Heap::undefined_value()))->
       ToObjectChecked();
   CHECK(code->IsCode());
-#ifdef DEBUG
+#ifdef PRINT_OBJECT
   Code::cast(code)->Print();
 #endif
   F2 f = FUNCTION_CAST<F2>(Code::cast(code)->entry());
@@ -112,7 +112,7 @@ TEST(AssemblerIa321) {
                                   Handle<Object>(Heap::undefined_value()))->
       ToObjectChecked();
   CHECK(code->IsCode());
-#ifdef DEBUG
+#ifdef PRINT_OBJECT
   Code::cast(code)->Print();
 #endif
   F1 f = FUNCTION_CAST<F1>(Code::cast(code)->entry());
@@ -155,7 +155,7 @@ TEST(AssemblerIa322) {
       Handle<Object>(Heap::undefined_value()))->ToObjectChecked();
 
   CHECK(code->IsCode());
-#ifdef DEBUG
+#ifdef PRINT_OBJECT
   Code::cast(code)->Print();
 #endif
   F1 f = FUNCTION_CAST<F1>(Code::cast(code)->entry());
@@ -329,7 +329,7 @@ TEST(AssemblerIa328) {
       Code::ComputeFlags(Code::STUB),
       Handle<Object>(Heap::undefined_value()))->ToObjectChecked());
   CHECK(code->IsCode());
-#ifdef DEBUG
+#ifdef PRINT_OBJECT
   Code::cast(code)->Print();
 #endif
   F6 f = FUNCTION_CAST<F6>(Code::cast(code)->entry());
@@ -384,7 +384,7 @@ TEST(AssemblerIa329) {
       Code::ComputeFlags(Code::STUB),
       Handle<Object>(Heap::undefined_value()))->ToObjectChecked());
   CHECK(code->IsCode());
-#ifdef DEBUG
+#ifdef PRINT_OBJECT
   Code::cast(code)->Print();
 #endif
 

test/cctest/test-disasm-ia32.cc

@@ -443,7 +443,7 @@ TEST(DisasmIa320) {
       Code::ComputeFlags(Code::STUB),
       Handle<Object>(Heap::undefined_value()))->ToObjectChecked();
   CHECK(code->IsCode());
-#ifdef DEBUG
+#ifdef PRINT_OBJECT
   Code::cast(code)->Print();
   byte* begin = Code::cast(code)->instruction_start();
   byte* end = begin + Code::cast(code)->instruction_size();

tools/gyp/v8.gyp

@@ -438,6 +438,7 @@
         '../../src/messages.h',
         '../../src/natives.h',
         '../../src/objects-debug.cc',
+        '../../src/objects-printer.cc',
         '../../src/objects-inl.h',
         '../../src/objects-visiting.cc',
         '../../src/objects-visiting.h',

tools/visual_studio/v8_base.vcproj

@@ -792,6 +792,10 @@
         RelativePath="..\..\src\objects-inl.h"
         >
       </File>
+      <File
+        RelativePath="..\..\src\objects-printer.cc"
+        >
+      </File>
       <File
         RelativePath="..\..\src\objects-visiting.cc"
         >

tools/visual_studio/v8_base_arm.vcproj

@@ -792,6 +792,10 @@
         RelativePath="..\..\src\objects-inl.h"
         >
       </File>
+      <File
+        RelativePath="..\..\src\objects-printer.cc"
+        >
+      </File>
       <File
         RelativePath="..\..\src\objects-visiting.cc"
         >

tools/visual_studio/v8_base_x64.vcproj

@@ -769,6 +769,10 @@
         RelativePath="..\..\src\objects-inl.h"
         >
       </File>
+      <File
+        RelativePath="..\..\src\objects-printer.cc"
+        >
+      </File>
       <File
         RelativePath="..\..\src\objects-visiting.cc"
         >