- 24 Feb, 2020 1 commit
-
-
Vadim authored
The Python builtin `basestring` has been removed from all [currently supported version of Python](https://devguide.python.org/#status-of-python-branches) so define `basestring` in Python3 so that line 60 does not raise a NameError at runtime. Related task: https://github.com/v8/v8/pull/38 Bug: v8:10256 Change-Id: I087c561fff5a19aab1fec71e1ea0435cbfeca5d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2069317Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#66403}
-
- 20 Feb, 2020 1 commit
-
-
Michael Achenbach authored
TBR=mathias@chromium.org Bug: chromium:1054390 Change-Id: I9533a0ca0faa0afa7032aa7dde144df48408c9d5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2066958Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66377}
-
- 18 Feb, 2020 1 commit
-
-
Michael Achenbach authored
This adds tests for the mock logic used in differential fuzzing. The tests uncovered a couple of issues in the mock files that are also fixed. This also does some minor code clean up in the mock code. Bug: chromium:1044942 Change-Id: I5b67f70f8b104bb681548f742ab863395a88360f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2043843 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#66304}
-
- 17 Feb, 2020 2 commits
-
-
Michael Achenbach authored
This reduces the pointer-compression experiment by 3% as it is in production since a while. This also uses turbofan when comparing across architectures as tests run faster and likely find the same or more relevant bugs. No-Try: true Change-Id: I35ec97188a101a7cb43454903f7bf9765e57893c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2059995 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#66290}
-
Michael Achenbach authored
Pass --no-lazy-feedback-allocation in all second runs depending on a probability. Also combine with --interrupt-budget=100. This also allows adding several extra flags behind one probability. The tests are improved to ensure valid flags and configs. No-Try: true Bug: v8:10215 Change-Id: I2766ef5044cd8c7096f6b76f39b60b568f550bde Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2059991 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Mythri Alle <mythria@chromium.org> Cr-Commit-Position: refs/heads/master@{#66289}
-
- 12 Feb, 2020 3 commits
-
-
Michael Achenbach authored
This will allow sharing the configs between Python and JavaScript based fuzzers. No-Try: true Bug: chromium:1044942 Change-Id: Idd47ad31430cfed0629dbb5b9dd5fd2ef8c764f6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051951Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66243}
-
Michael Achenbach authored
We ensure now that fuzzers don't produce the f.arguments pattern and instead replace it with a random variable. No-Try: true Bug: chromium:1044942, chromium:1020573 Change-Id: I899985f1a238f36d10fb22f76d93b7d5f444eab1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2051944Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66238}
-
Michael Achenbach authored
Un-ignore some files that only failed in obsolete comparisons. We don't compare eager anymore and console functions are mocked out in d8 by now. The exponentiation operator bug doesn't repro anymore. No-Try: true Bug: chromium:1044942 Change-Id: I0a572836bc9a4a6aa4736447f638a522ff8e8168 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2050400Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66233}
-
- 11 Feb, 2020 1 commit
-
-
Michael Achenbach authored
The assumtion that V8 has no output differences within a single line before a stack overflow, didn't hold. The prefix of e.g. console.info can lead to a difference in a recursive call. This change makes foozzie's output capping before a crash work on the level of characters instead of lines to fix this. No-Try: true Bug: chromium:1050942 Change-Id: I13f747caf4f5848d40c31bd4232811285bab3c17 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2049844Reviewed-by: Liviu Rau <liviurau@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66217}
-
- 05 Feb, 2020 1 commit
-
-
Michael Achenbach authored
The bug appears to be fixed. No-Try: true Bug: chromium:693426 Change-Id: Ibd029c906dca87a3fd0c3e00be0b795e87390bd4 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2037439Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66134}
-
- 04 Feb, 2020 4 commits
-
-
Michael Achenbach authored
This will allow uploading repro test cases to clusterfuzz for already suppressed known issues. This will allow tracking if those issues still reproduce and that suppressions don't become stale. No-Try: true Bug: chromium:1044942 Change-Id: I997f11293c51836b97d143b0fea992055b39955e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2036083 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Liviu Rau <liviurau@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#66114}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1048620 Change-Id: I399144a9d8075efe40125dfcbe1dbbd0aabe0fe9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2036080Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66112}
-
Michael Achenbach authored
No-Try: true Bug: chromium:99679 Change-Id: I38af71ff062cb3662034f2e52da86a8f1de9280c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2036081Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66104}
-
Michael Achenbach authored
Respective differences were fixed and the suppressions didn't fire anymore according to the statistics. No-Try: true Bug: chromium:664068, chromium:667678 Change-Id: I5e1aa802e0b0288a73d0f236c154289ab45314a0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2035878Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66100}
-
- 03 Feb, 2020 1 commit
-
-
Michael Achenbach authored
Crashes in the presence of RangeError happen often during differential fuzzing. Until now we have ignored such cases completely. After this change we compare as much output as possible when one or both runs have crashed, dramatically increasing the coverage. No-Try: true Bug: chromium:1048099 Change-Id: I923c10e9064b5dc6cae1e39a254e221d2867e0e7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030914 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#66085}
-
- 31 Jan, 2020 2 commits
-
-
Michael Achenbach authored
This adds two flags for whitelisting natives on fuzzers: --allow-natives-for-fuzzing: Enables a small subset of runtime functions and replaces others with undefined. --allow-natives-for-differential-fuzzing Restricts the allowed runtime functions even further, excluding the ones that break differential fuzzing. Bug: chromium:1044942 Change-Id: I890bd4a6ff7c2e483dd74155290a7ace06f85239 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020773Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66068}
-
Michael Achenbach authored
No-Try: true Bug: chromium:1047632 Change-Id: I01f02cf5ffa53d261311b8265e0005cfe5257f4a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2030739Reviewed-by: Mythri Alle <mythria@chromium.org> Reviewed-by: Maya Lekova <mslekova@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66065}
-
- 27 Jan, 2020 1 commit
-
-
Michael Achenbach authored
No-Try: true Bug: chromium:1045795 Change-Id: I8313194bd1b0706291bd6a041d370a0b43215e10 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020956Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#66005}
-
- 09 Jan, 2020 1 commit
-
-
Clemens Backes authored
This is a cleanup to remove unneeded flags after these changes (in https://crrev.com/c/1988548): * --future does not imply --wasm-tier-up any more, and * --wasm-tier-up does not imply --liftoff any more. Instead, now * --wasm-tier-up is enabled by default, * --wasm-tier-up has no effect if --liftoff is not set, and * --future implies --liftoff. R=ahaas@chromium.org Bug: chromium:1040061 Change-Id: I5d04ee1f1d84ddcd0654df0e0a4c6298f80aee9e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1993280Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65666}
-
- 16 Dec, 2019 1 commit
-
-
Michael Achenbach authored
Some test cases stress all global functions and hang when calling readline. No-Try: true Bug: chromium:1034285 Change-Id: I0eaf64437c0806cf3df0a5306aecea4367763cad Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1967381 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#65460}
-
- 09 Dec, 2019 1 commit
-
-
Michael Achenbach authored
Some fuzz test cases set Math.min to a different function. Let the fake typed array constructors remember the original Math.min. No-Try: true Bug: chromium:1024815 Change-Id: Ia389439fe6757f2497e22187042c5cdf1d1c649f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958050 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#65383}
-
- 25 Nov, 2019 1 commit
-
-
Michael Achenbach authored
This adds a regresson test case for the revert reason of: https://crrev.com/c/1906378 The test data is tidied up by keeping the different fake d8s in separate build directories like it would be in production. A new test simulates an architecture difference and ensures we pass the architecture mocks in all runs. No-Try: true Bug: chromium:1023091 Change-Id: Ic33c426ba8eb9c4b6b0fbb66d43c0859dc2edfcd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1918248 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#65140}
-
- 15 Nov, 2019 1 commit
-
-
Michael Achenbach authored
This adds an abstraction for command-line arguments for each of the two comparison runs done in correctness fuzzing. No functional changes intended. No-Try: true Bug: chromium:1023091 Change-Id: I9421715c4904416b9aaf53848954a5248c79ffd9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906372 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#64979}
-
- 14 Nov, 2019 1 commit
-
-
Michael Achenbach authored
This is a reland of 1d493d31 Original change's description: > [foozzie] Refactor command abstraction > > This moves code for running d8 into its own class. No functional > changes intended. > > No-Try: true > Bug: chromium:1023091 > Change-Id: I7cbfeebd2911dc758322f89cf93666550f2956d9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906378 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64928} Bug: chromium:1023091 Change-Id: I7df6e12084e20510a400ce209827c2bba8325f86 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914209Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64966}
-
- 13 Nov, 2019 2 commits
-
-
Michael Achenbach authored
This reverts commit 1d493d31. Reason for revert: Fails on clusterfuzz: https://crbug.com/1024241 Original change's description: > [foozzie] Refactor command abstraction > > This moves code for running d8 into its own class. No functional > changes intended. > > No-Try: true > Bug: chromium:1023091 > Change-Id: I7cbfeebd2911dc758322f89cf93666550f2956d9 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906378 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Tamer Tas <tmrts@chromium.org> > Cr-Commit-Position: refs/heads/master@{#64928} TBR=machenbach@chromium.org,tmrts@chromium.org,almuthanna@google.com,liviurau@chromium.org Change-Id: I22aede0d2c8bd3cde48c45f4663b43caa4d60b65 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:1023091,chromium:1024241 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1914208Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64933}
-
Michael Achenbach authored
This moves code for running d8 into its own class. No functional changes intended. No-Try: true Bug: chromium:1023091 Change-Id: I7cbfeebd2911dc758322f89cf93666550f2956d9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906378 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Tamer Tas <tmrts@chromium.org> Cr-Commit-Position: refs/heads/master@{#64928}
-
- 12 Nov, 2019 1 commit
-
-
Michael Achenbach authored
We used the same random seed for all test cases of a fuzz session for transitioning from choosing the flags on V8 side. Since the grace period for stable bisection is over, we now use the same random number generator throughout the fuzz session which leads to a wider range of differently chosen flags. TBR=tmrts@chromium.org No-Try: true Bug: chromium:813833 Change-Id: I07b9fe5de378c01344afd486bfd85fcbf0fcd8d2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906377Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64910}
-
- 11 Nov, 2019 1 commit
-
-
Michael Achenbach authored
No-Try: true Bug: chromium:1023247 Change-Id: I23abb26425d7adcd69d07af906738a69bac8688d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906380 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#64871}
-
- 08 Nov, 2019 1 commit
-
-
Michael Achenbach authored
No-Try: true Bug: chromium:1021463 Change-Id: I15d45a51b7341b5767d8eb4c16e7d41508a2811b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1906568Reviewed-by: Clemens Backes <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64862}
-
- 06 Nov, 2019 1 commit
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:9946 Change-Id: If5b5470709edeaa13f7dea4ca83948e28356f352 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1901268Reviewed-by: Georg Neis <neis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64810}
-
- 07 Oct, 2019 1 commit
-
-
Michael Achenbach authored
This adds a fake toolchain for pointer compression, used for correctness fuzzing. The toolchain enables us to have an extra build with inverse pointer-compression defaults side-by-side. The extra build is used similarly to existing x64/x86 comparisons, except that we now compare builds with different compile-time flags. Change-Id: I75491371262204b86eaa006ca8d04848f49121ac Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829275Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64123}
-
- 30 Sep, 2019 2 commits
-
-
Michael Achenbach authored
NOTRY=true Change-Id: Icb4c3a1a544331baab5d6637daa12bea87044715 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829268 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#64038}
-
Michael Achenbach authored
NOTRY=true Change-Id: Ie96e645851beb26e9a777379ad68f1c173acd80d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1829266Reviewed-by: Clemens Backes [né Hammacher] <clemensb@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#64036}
-
- 02 Sep, 2019 3 commits
-
-
Michael Achenbach authored
NOTRY=true Bug: v8:9601 Change-Id: I0406326dab681843ef8accadefa10a9e85593fb1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1781055Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63507}
-
Michael Achenbach authored
The sanity checks never really worked since the file was missing in the output dir. Runs bailed out with "Error loading file". As both configurations bailed out in the same way, the correctness fuzzer treated it as pass. NOTRY=true Bug: chromium:933076 Change-Id: Id3a2f7e8e3fa8c6654e3e08654d2e9e6b7010484 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778289Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63495}
-
Michael Achenbach authored
This also ignores the line number for type errors. NOTRY=true Bug: chromium:995075 Change-Id: I9d9a91842383eba60db858c2c2e02df7dda1a9e1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1778287Reviewed-by: Tamer Tas <tmrts@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#63494}
-
- 12 Aug, 2019 1 commit
-
-
Yang Guo authored
R=machenbach@chromium.org Bug: chromium:992584 Change-Id: I301013731a502689f2edd5c90e5e7bf2136198c5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1745337Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#63159}
-
- 19 Jul, 2019 1 commit
-
-
Michael Starzinger authored
This makes sure the language mode of the module is correctly propagated through the WebAssembly module, so that exported functions are allocated with the correct language mode. It extends the existing {ModuleOrigin} enum to consist of three values now. R=clemensh@chromium.org TEST=mjsunit/regress/wasm/regress-985154 BUG=chromium:985154 Change-Id: Id7b566738b1e710cc5001b894022bcd0f2c01bc3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1708484 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Clemens Hammacher <clemensh@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62826}
-
- 12 Jul, 2019 1 commit
-
-
Michael Achenbach authored
NOTRY=true Bug: chromium:813833,chromium:983128 Change-Id: I449796b761f53bb15a3563604d5a4a9018035cb6 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1697255Reviewed-by: Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62662}
-
- 11 Jul, 2019 1 commit
-
-
Michael Achenbach authored
In order to migrate the extra flags into the fuzzer and keep bisection stable, we need to use the same RNG state for each call to generating fuzz flags. Throughout one fuzzing session the same random-seed is used (https://crbug.com/983128) and we'll pass it to the fuzz config in a follow up. TBR=tmrts@chromium.org NOTRY=true Bug: chromium:813833 Change-Id: I3203c86028a5d283238e6ef739f82eccee1302b1 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1697254 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#62646}
-