- 19 Jan, 2018 6 commits
-
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:6105 Change-Id: Ieb0de4d0ee031d61d7af1a89607bfbcb64151bcb Reviewed-on: https://chromium-review.googlesource.com/874353Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50705}
-
Yang Guo authored
Change-Id: Ia0d50a989e02e916ff6a65a5d0d6a6fc980c2c80 Reviewed-on: https://chromium-review.googlesource.com/869933Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#50704}
-
Jaroslav Sevcik authored
Bug: v8:5267 Change-Id: I7a580b77650452a7cf2151d4faa8c629e18e42d8 Reviewed-on: https://chromium-review.googlesource.com/873915 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#50703}
-
Benedikt Meurer authored
This avoids the call to the StringCharCodeAt builtin from within TurboFan optimized code and instead emits a loop that does the character load. This (together with previously reverted CL to the JSCallReducer) almost completely recovers the performance regression caused when we shipped TurboFan. Without untrusted code mitigations the benchmark goes from 580ms to roughly 490ms, and with the patch to the JSCallReducer the time goes down to 280ms, which is very close to what we had with Crankshaft. This also renames the LoadFromString helper method in the EffectControlLinearizer to LoadFromSeqString to make it clear what it does. Bug: v8:7326 Change-Id: Ibe0ec1847911a234f244bd8dcec6be18b241fda0 Reviewed-on: https://chromium-review.googlesource.com/873376Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#50702}
-
v8-autoroll authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/b3a78cd..972ab23 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/buildtools/+log/6fe4a32..437a616 Rolling v8/third_party/android_tools: https://chromium.googlesource.com/android_tools/+log/c78b258..c9f9bbf Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b4826a5..b4706e7 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2708887..e80cb0b TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic95248a169651c4730974b310e9a51f590733830 Reviewed-on: https://chromium-review.googlesource.com/874573 Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#50701}
-
Sathya Gunasekaran authored
Bug: v8:6889 Change-Id: Id79989b5ea65fa4a622205769e961a6e200641b7 Reviewed-on: https://chromium-review.googlesource.com/874996 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#50700}
-
- 18 Jan, 2018 34 commits
-
-
Malcolm White authored
This is the v8 side of changes; blink changes are at https://chromium-review.googlesource.com/c/chromium/src/+/809228 BUG=chromium:716320 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: Ia77764aed09dd609bf2304fe3c392a0e8ee16334 Reviewed-on: https://chromium-review.googlesource.com/847337Reviewed-by:
Ben Smith <binji@chromium.org> Cr-Commit-Position: refs/heads/master@{#50699}
-
Martyn Capewell authored
Remove final csp instances, missed in the earlier patch due to being outside the arm64 tree. Bug: v8:6644 Change-Id: I2b5a2716568949740991c368b64c0a06105e4ff2 Reviewed-on: https://chromium-review.googlesource.com/874310Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/master@{#50698}
-
Michael Achenbach authored
This prepares to add the stress-marking flag on the infra side. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:6972 Change-Id: Ibee30beadb167d06fd7965dfd3cc05fb523158cb Reviewed-on: https://chromium-review.googlesource.com/874350Reviewed-by:
-
Clemens Hammacher authored
Remove an unused constructor and an unused field, and compute a more tight {kMaxSize}. Beside being a cleanup, this might sometimes allow us to allocate a little bit less memory on 32 bit systems. R=mstarzinger@chromium.org Change-Id: Ibf8fef231325f1b9047e2c7f4c66430797729fc1 Reviewed-on: https://chromium-review.googlesource.com/873534Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50696}
-
Clemens Hammacher authored
It took me a while to understand that the {index} is actually a signature index. This CL changes the name to {sig_index} to make this more clear. Drive-by: Fix a CHECK to check the canonical signature index instead of the original index. This ensures that there is a canonical signature index in the signature map. Drive-by^2: Un-templatize a method. R=titzer@chromium.org Change-Id: Ifdaec59806c4d5c976170807596503d2874f04e4 Reviewed-on: https://chromium-review.googlesource.com/871190Reviewed-by:Ben Titzer <titzer@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50695}
-
Eric Holk authored
Bug: chromium:798964 Change-Id: I5452775388addb5f4647297d190d88a45eec19bd Reviewed-on: https://chromium-review.googlesource.com/869134 Commit-Queue: Eric Holk <eholk@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50694}
-
Ivica Bogosavljevic authored
Fix 45833d9b The original CL introduced new define V8_ENABLE_ALLOCATION_TIMEOUT but this change hasn't been ported to GYP. This CL fixed this. Change-Id: I37f9e958c704f12d5997034f25d216f269cbd25f Reviewed-on: https://chromium-review.googlesource.com/873913Reviewed-by:
-
Clemens Hammacher authored
This prepares a reland of https://crrev.com/c/869468. Drive-by: Add a static_assert, also to document why kV8MaxWasmMemoryPages was chosed to be slightly below 2GB. R=titzer@chromium.org CC=bradnelson@chromium.org Bug: v8:6600 Change-Id: I6417bec191803c791fa5b218024ebcfde27e2aea Reviewed-on: https://chromium-review.googlesource.com/873912Reviewed-by:
-
peterwmwong authored
- Add Map, WeakMap, Set, and WeakSet initial prototype maps to native context. - Set and WeakSet constructors check whether prototype map differs from initial before choosing the fast path. Bug: chromium:798026 Change-Id: I5f9cc2463f89e17f06a66b565c625fce133d01fb Reviewed-on: https://chromium-review.googlesource.com/853698 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#50691}
-
Michael Hablich (vacation) authored
This reverts commit 7dbfec50. Reason for revert: breaks libfuzzer build Bug: chromium:803330 Original change's description: > [api] Advance deprecation of v8::Script APIs > > The calls in Chromium were removed in https://crrev.com/c/865160. > > Bug: v8:7269, v8:7273, v8:7274 > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng > Change-Id: Id68649c479483679bf97bc66c14ce8dfa3f7d05c > Reviewed-on: https://chromium-review.googlesource.com/868459 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Adam Klein <adamk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50663} TBR=adamk@chromium.org,yangguo@chromium.org Change-Id: Iaf8ae89da9920c82d162ecb505502d5842d7c9b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7269, v8:7273, v8:7274 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/873831Reviewed-by:
Michael Hablich (vacation) <hablich@chromium.org> Commit-Queue: Michael Hablich (vacation) <hablich@chromium.org> Cr-Commit-Position: refs/heads/master@{#50690}
-
Clemens Hammacher authored
On mips64, all arguments must be sign-extended, even unsigned types. R=mstarzinger@chromium.org CC=sreten.kovacevic@mips.com, ivica.bogosavljevic@mips.com Change-Id: If5229d34e1da684928f54bbcf389bb8e472d7d61 Reviewed-on: https://chromium-review.googlesource.com/868651 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Marja Hölttä authored
This adds a test-preparser cctest corresponding to the regression test added in https://chromium-review.googlesource.com/865900 BUG=chromium:801772 Change-Id: I33d74e242fd765b91b7c148b9a0af4960a7b05ea Reviewed-on: https://chromium-review.googlesource.com/870311Reviewed-by:
-
Martyn Capewell authored
Rename csp to sp and remove support for the stack pointer abstraction and switching stack pointers. Bug: v8:6644 Change-Id: I616633aabc1cee9926249fe95ce6c37ed6544fe3 Reviewed-on: https://chromium-review.googlesource.com/870870Reviewed-by:
-
Michael Achenbach authored
This reverts commit a7c91c77. Reason for revert: changes a layout test https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/21031 Original change's description: > [typedarray] Port ConstructByTypedArray to CSA. > > This is needed to easily port the constructor dispatcher to CSA. > > Bug: v8:7102 > Change-Id: I9672416495940ca12088a2980a9ecc61364aef9d > Reviewed-on: https://chromium-review.googlesource.com/785630 > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Toon Verwaest <verwaest@chromium.org> > Commit-Queue: Peter Marshall <petermarshall@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50671} TBR=petermarshall@chromium.org,bmeurer@chromium.org,verwaest@chromium.org Change-Id: I118a1cb0d873a1d2e159619e5f327f9f6f7974c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7102 Reviewed-on: https://chromium-review.googlesource.com/873790Reviewed-by:
-
Clemens Hammacher authored
Merge all of them to a single implementation, getting rid of all the duplication. R=marja@chromium.org Change-Id: I5201e81ec64f3d7789df5e72bf58c85231cb348c Reviewed-on: https://chromium-review.googlesource.com/868133 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
-
Tobias Tebbi authored
This works around a bug in the libc++ implementation of bitset (https://bugs.llvm.org/show_bug.cgi?id=35438) resulting in high bits outside the bitset leaking through, breaking the ordering invariant of PersistentMap::iterator. This did not surface so far because the hash values used in escape analysis so far all only used 32 bits. Bug: Change-Id: I18ce703020bf1fb3e1b412edaa899fa1afe0bba0 Reviewed-on: https://chromium-review.googlesource.com/793613 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#50684}
-
Hannes Payer authored
Bug: chromium:774108,v8:6792 Change-Id: I4736b86ad5bd5e0777dc7a121023c4ed34d69fb0 Reviewed-on: https://chromium-review.googlesource.com/873170 Commit-Queue: Hannes Payer <hpayer@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
Bug: v8:7327 Change-Id: Ic33a0d86f055ac5ec3607d8e57d796428f4b9d20 Reviewed-on: https://chromium-review.googlesource.com/873378Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#50682}
-
Yang Guo authored
R=adamk@chromium.org Bug: v8:7293 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I308fb8e87e6760664a33f3216af7a484ad1404c4 Reviewed-on: https://chromium-review.googlesource.com/864148Reviewed-by:
-
Dan Elphick authored
This removes the Javascript version of Array.of in js/array.js and adds a CodeStubAssembler version in src/builtins/builtins-array-gen.cc. Mostly this change is for code-health reasons but it also gives performance improvements for nearly all cases with the exception of "transplanted" arrays. E.g. function ArrayLike {} ArrayLike.of = Array.of ArrayLike.of(...) is now slower in the perf tests. Most of this change can be attributed to using CallRuntime(kSetProperty,...) to set the length. The JS version can do better due to inline caches trained on the same datatype for 1000s of iterations, but this kind of workload is unlikely. Change-Id: I18e5b19b185257e9e0d553e1183b40ba4a5d3289 Reviewed-on: https://chromium-review.googlesource.com/863625 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by:Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Ben L. Titzer authored
This is a further step to separate the implementation of the JavaScript API from the internals of the WASM implementation. Now, wasm-js.cc only needs to interact with the WASM engine and is (almost) independent of module-decoder.h and module-compiler.h. Also, move SyncCompileAndInstantiate() into wasm-module-runner.cc. Bug: v8:7316 R=clemensh@chromium.org, mstarzinger@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I7765af54ac16f53a5ff88c17a22c5d36bacaf926 Reviewed-on: https://chromium-review.googlesource.com/870871 Commit-Queue: Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Camillo Bruni authored
Record seperate virtual instance types for entries in FeedbackVectors: - FEEDBACK_VECTOR_ENTRY_TYPE Bug: v8:7266 Change-Id: Ibea0615ecd23099e0107505e5d33cf194aade7c0 Reviewed-on: https://chromium-review.googlesource.com/866878 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#50678}
-
Yang Guo authored
TBR=machenbach@chromium.org Bug: v8:6105 Change-Id: I56a08060c93fc86e752a7ef0156bbcca8a7ba261 Reviewed-on: https://chromium-review.googlesource.com/873132Reviewed-by:
-
Michael Hablich authored
TBR=machenbach@chromium.org NOTRY=true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng Change-Id: I0db40093d78433fa6304f5695969e5f0b259204e Reviewed-on: https://chromium-review.googlesource.com/873633 Commit-Queue: Michael Hablich (vacation) <hablich@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
With the current attempt, trying to iterate a const ZoneChunkList doesn't even compile. See the bug for more info. R=marja@chromium.org Bug: v8:6473 Change-Id: I8de7e887398be7ba5da14dc540dd40b30df2c3fe Reviewed-on: https://chromium-review.googlesource.com/868332Reviewed-by:
Marja Hölttä <marja@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#50675}
-
Georg Neis authored
Also fix a bogus test. R=bmeurer@chromium.org Bug: v8:5940 Change-Id: I6e201ce35f9021e12d1e4b6127d4accc1425cdb9 Reviewed-on: https://chromium-review.googlesource.com/870596 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
-
Michael Lippautz authored
No-try: true Bug: v8:7266 Change-Id: I8b8ec94c1909e7404774afd576968cf843c043ff Reviewed-on: https://chromium-review.googlesource.com/873033Reviewed-by:
-
Michael Hablich (vacation) authored
This reverts commit db129b65. Reason for revert: blocks roll: https://chromium-review.googlesource.com/c/chromium/src/+/873150 Original change's description: > [turbofan] Speculate on bounds checks for String#charAt and String#charCodeAt. > > With the new builtin optimization guard we can just speculatively assume > that the index passed to String#charAt and String#charCodeAt (in optimized > code) is going to be within the valid range for the receiver. This is > what Crankshaft used to do, and it avoids Smi checks on the result for > String#charCodeAt, since it can no longer return NaN. > > This gives rise to further optimizations of these builtins (i.e. to > completely avoid the tagging of char codes), and by itself already > improves the regression test originally reported from 650ms to > 610ms. > > Bug: v8:7127, v8:7326 > Change-Id: Ia25a555c5c1a48d229c094b1ecd2487eec81e390 > Reviewed-on: https://chromium-review.googlesource.com/872850 > Reviewed-by: Yang Guo <yangguo@chromium.org> > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50667} TBR=yangguo@chromium.org,bmeurer@chromium.org Change-Id: I6d393a0797cac2fdfd67487a26ac1b178bd52813 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7127, v8:7326 Reviewed-on: https://chromium-review.googlesource.com/873355Reviewed-by:
-
Peter Marshall authored
This is needed to easily port the constructor dispatcher to CSA. Bug: v8:7102 Change-Id: I9672416495940ca12088a2980a9ecc61364aef9d Reviewed-on: https://chromium-review.googlesource.com/785630Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#50671}
-
jgruber authored
This fuzzer randomly generates calls to regexp builtins, runs each on the slow and fast path, and verifies that their result is the same. Change-Id: Ia91b0c8afcdaf64835a9bb7b9a470610fbb75fc8 Reviewed-on: https://chromium-review.googlesource.com/833922 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Bug: v8:6105 Change-Id: Ie4a9ade13e280153c7ed55af03f9ff4c2d3cdd09 Reviewed-on: https://chromium-review.googlesource.com/873010 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Allow exporting the current selection as CSV. No-try: true Bug: v8:7266 Change-Id: Idd275e749506d2a195a132efa5ec08ebb21ca72f Reviewed-on: https://chromium-review.googlesource.com/870781Reviewed-by:
-
Benedikt Meurer authored
With the new builtin optimization guard we can just speculatively assume that the index passed to String#charAt and String#charCodeAt (in optimized code) is going to be within the valid range for the receiver. This is what Crankshaft used to do, and it avoids Smi checks on the result for String#charCodeAt, since it can no longer return NaN. This gives rise to further optimizations of these builtins (i.e. to completely avoid the tagging of char codes), and by itself already improves the regression test originally reported from 650ms to 610ms. Bug: v8:7127, v8:7326 Change-Id: Ia25a555c5c1a48d229c094b1ecd2487eec81e390 Reviewed-on: https://chromium-review.googlesource.com/872850Reviewed-by:
-
Benedikt Meurer authored
This reverts commit 183bc643. Reason for revert: https://logs.chromium.org/v/?s=chromium%2Fbb%2Fclient.v8%2FV8_Linux_-_debug%2F18780%2F%2B%2Frecipes%2Fsteps%2FCheck_-_extra%2F0%2Flogs%2Fmemory-size%2F0 Original change's description: > [wasm] Fix page size constant + test limits on max pages. > > BUG=chromium:801604 > R=bbudge@chromium.org,titzer@chromium.org > > Change-Id: I5fa57d5f8ea288d7aef7d466cbf11df46c4dcd1d > Reviewed-on: https://chromium-review.googlesource.com/869468 > Reviewed-by: Ben Titzer <titzer@chromium.org> > Reviewed-by: Bill Budge <bbudge@chromium.org> > Commit-Queue: Brad Nelson <bradnelson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#50665} TBR=bradnelson@chromium.org,bbudge@chromium.org,titzer@chromium.org Change-Id: I2b5a51f1a94e862f8ac4455d466e23d26c220202 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:801604 Reviewed-on: https://chromium-review.googlesource.com/872950Reviewed-by:
-
