• Benedikt Meurer's avatar
    [turbofan] Speculate on bounds checks for String#charAt and String#charCodeAt. · db129b65
    Benedikt Meurer authored
    With the new builtin optimization guard we can just speculatively assume
    that the index passed to String#charAt and String#charCodeAt (in optimized
    code) is going to be within the valid range for the receiver. This is
    what Crankshaft used to do, and it avoids Smi checks on the result for
    String#charCodeAt, since it can no longer return NaN.
    
    This gives rise to further optimizations of these builtins (i.e. to
    completely avoid the tagging of char codes), and by itself already
    improves the regression test originally reported from 650ms to
    610ms.
    
    Bug: v8:7127, v8:7326
    Change-Id: Ia25a555c5c1a48d229c094b1ecd2487eec81e390
    Reviewed-on: https://chromium-review.googlesource.com/872850Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50667}
    db129b65
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...