- 08 Jul, 2016 7 commits
-
-
Michael Starzinger authored
This enables tests which rely on the context available at "debugger" statements to be accurate. This is the case by now when deoptimization information is available. R=yangguo@chromium.org BUG=v8:4055 Review URL: https://codereview.chromium.org/2129123002 . Cr-Commit-Position: refs/heads/master@{#37604}
-
machenbach authored
Revert of [gn] Switch gcc bots to gn (patchset #3 id:40001 of https://codereview.chromium.org/2124263002/ ) Reason for revert: There are a bunch of goma errors on the gcc bot now. Maybe connected to this CL. https://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/builds/19068 Original issue's description: > [gn] Switch gcc bots to gn > > BUG=chromium:474921 > > Committed: https://crrev.com/73f154ba601dc70c4007968fa902d4beacba4393 > Cr-Commit-Position: refs/heads/master@{#37580} TBR=vogelheim@chromium.org,jochen@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2130303002 Cr-Commit-Position: refs/heads/master@{#37603}
-
yangguo authored
R=bmeurer@chromium.org, mstarzinger@chromium.org, rmcilroy@chromium.org Review-Url: https://codereview.chromium.org/2112853002 Cr-Commit-Position: refs/heads/master@{#37602}
-
ahaas authored
Handles are necessary in wasm::GetDebugInfo because a GC can be triggered in this function. R=titzer@chromium.org, mstarzinger@chromium.org Review-Url: https://codereview.chromium.org/2132553002 Cr-Commit-Position: refs/heads/master@{#37601}
-
brendan.kirby authored
BUG= Review-Url: https://codereview.chromium.org/2126423002 Cr-Commit-Position: refs/heads/master@{#37600}
-
lpy authored
BUG= Review-Url: https://codereview.chromium.org/2125023004 Cr-Commit-Position: refs/heads/master@{#37599}
-
jgruber authored
BUG=v8:5173 R=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2118283003 Cr-Commit-Position: refs/heads/master@{#37598}
-
- 07 Jul, 2016 31 commits
-
-
ben authored
Fix a TypeError when putting together the invocationText for a symbol method's stack frame. See https://github.com/nodejs/node/issues/7536. Review-Url: https://codereview.chromium.org/2122793003 Cr-Commit-Position: refs/heads/master@{#37597}
-
littledan authored
Reland of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2129533004/ ) Reason for revert: Performance stayed the same after the revert; relanding. Original issue's description: > Revert of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2116053003/ ) > > Reason for revert: > Revert to see if it addresses the performance regression observed in chromium:625956 in automated graphs > > Original issue's description: > > [esnext] ship --harmony-object-values-entries > > > > BUG=v8:4663 > > R=littledan@chromium.org, adamk@chromium.org > > > > Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf > > Cr-Commit-Position: refs/heads/master@{#37485} > > TBR=adamk@chromium.org,caitpotter88@gmail.com > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=v8:4663 > > Committed: https://crrev.com/1177750a98faaa11e92ece13b70115bf704baf3b > Cr-Commit-Position: refs/heads/master@{#37566} TBR=adamk@chromium.org,caitpotter88@gmail.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4663 Review-Url: https://codereview.chromium.org/2127253002 Cr-Commit-Position: refs/heads/master@{#37596}
-
franzih authored
Drive-by-fix: hydrogen code does not blindly return the byteLength offset, instead it executes what is defined in the byteLength getter. BUG= Review-Url: https://codereview.chromium.org/2123263002 Cr-Commit-Position: refs/heads/master@{#37595}
-
jochen authored
Such an object can be used to later create a context from it. It has to have access checks with handlers enabled, as it cannot be accessed otherwise. BUG=chromium:618305 R=verwaest@chromium.org Review-Url: https://codereview.chromium.org/2107673003 Cr-Commit-Position: refs/heads/master@{#37594}
-
machenbach authored
BUG=chromium:474921 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org, tandrii@chromium.org Review-Url: https://codereview.chromium.org/2126793004 Cr-Commit-Position: refs/heads/master@{#37593}
-
jbudorick authored
BUG=pdfium:38 Review-Url: https://codereview.chromium.org/2113413002 Cr-Commit-Position: refs/heads/master@{#37592}
-
jochen authored
BUG=v8:4909 R=hpayer@chromium.org Review-Url: https://codereview.chromium.org/2129933002 Cr-Commit-Position: refs/heads/master@{#37591}
-
mstarzinger authored
This enables tests which rely on the context available at "debugger" statements to be accurate. This is the case by now when deoptimization information is available. R=mvstanton@chromium.org BUG=v8:4035 Review-Url: https://codereview.chromium.org/2125773005 Cr-Commit-Position: refs/heads/master@{#37590}
-
mstarzinger authored
R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2127093002 Cr-Commit-Position: refs/heads/master@{#37589}
-
jarin authored
Review-Url: https://codereview.chromium.org/2110343003 Cr-Commit-Position: refs/heads/master@{#37588}
-
ishell authored
This should recover the regression caused by https://codereview.chromium.org/1993653003. (Same sympthoms as in http://crbug/619016). BUG=chromium:624309 Review-Url: https://codereview.chromium.org/2127103002 Cr-Commit-Position: refs/heads/master@{#37587}
-
ivica.bogosavljevic authored
Port de369129 Original commit message: In the current implementation of wasm an unrepresentable input of the float32-to-int32 conversion is detected by first truncating the input, then converting the truncated input to int32 and back to float32, and then checking whether the result is the same as the truncated input. This input check does not work on arm and arm64 for an input of (INT32_MAX + 1) because on these platforms the float32-to-int32 conversion results in INT32_MAX if the input is greater than INT32_MAX. When INT32_MAX is converted back to float32, then the result is (INT32_MAX + 1) again because INT32_MAX cannot be represented precisely as float32, and rounding-to-nearest results in (INT32_MAX + 1). Since (INT32_MAX + 1) equals the truncated input value, the input appears to be representable. With the changes in this CL, the result of the float32-to-int32 conversion is incremented by 1 if the original result was INT32_MAX. Thereby the detection of unrepresenable inputs in wasm works. Note that since INT32_MAX cannot be represented precisely in float32, it can also never be a valid result of the float32-to-int32 conversion. BUG=cctest/test-run-wasm/RunWasmCompiled_I32SConvertF32,cctest/test-run-wasm/RunWasmCompiled_I32UConvertF32 Review-Url: https://codereview.chromium.org/2130763002 Cr-Commit-Position: refs/heads/master@{#37586}
-
ishell authored
Now LookupIterator follows the same pattern of prepare transition, apply transition and write value when adding new properties to dictionary objects. JSGlobalObject case: * Prepare transition phase ensures that there is a "transition" property cell prepared for receiving a value. * Apply transition phase does nothing. * Prepare for data property phase ensures that the existing property cell can receive the value. * Write value phase writes value directly to the current property cell. JSObject case: * Prepare transition phase prepares the object for receiving a data value (which could switch an object to dictionary mode). * Apply transition phase migrates object to a transition map. If the map happened to be a dictionary mode object's map then an uninitialized entry added to the properties dictionary. * Prepare for data property phase does nothing. * Write value phase just puts value to the properties dictionary. BUG=chromium:576312 Review-Url: https://codereview.chromium.org/2127583002 Cr-Commit-Position: refs/heads/master@{#37585}
-
mstarzinger authored
R=mvstanton@chromium.org BUG=v8:4458 Review-Url: https://codereview.chromium.org/2129903002 Cr-Commit-Position: refs/heads/master@{#37584}
-
mstarzinger authored
R=mvstanton@chromium.org Review-Url: https://codereview.chromium.org/2132503002 Cr-Commit-Position: refs/heads/master@{#37583}
-
verwaest authored
In AstNumberingVisitor we always know what node we're dealing with, so there's no reason for this method to be virtual. This additionally deletes 3 calls to AssignFeedbackVectorSlots that would always end up in the empty version. BUG= Review-Url: https://codereview.chromium.org/2128613003 Cr-Commit-Position: refs/heads/master@{#37582}
-
ulan authored
For motivation see the bug. BUG=625865 LOG=NO Review-Url: https://codereview.chromium.org/2121273002 Cr-Commit-Position: refs/heads/master@{#37581}
-
machenbach authored
BUG=chromium:474921 Review-Url: https://codereview.chromium.org/2124263002 Cr-Commit-Position: refs/heads/master@{#37580}
-
machenbach authored
BUG=chromium:474921 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2130723002 Cr-Commit-Position: refs/heads/master@{#37579}
-
ulan authored
BUG=chromium:626256 LOG=NO Review-Url: https://codereview.chromium.org/2126193002 Cr-Commit-Position: refs/heads/master@{#37578}
-
jkummerow authored
BUG=v8:5181 Review-Url: https://codereview.chromium.org/2129563002 Cr-Commit-Position: refs/heads/master@{#37577}
-
mstarzinger authored
This changes the last few remaining RUNTIME_ASSERT calls that need to be intentionally robust because fuzzers or other callers can invoke the runtime functions in question with unsafe arguments. R=yangguo@chromium.org BUG=v8:5066 Review-Url: https://codereview.chromium.org/2122173003 Cr-Commit-Position: refs/heads/master@{#37576}
-
machenbach authored
BUG=chromium:474921 TBR=jochen@chromium.org, vogelheim@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2124003003 Cr-Commit-Position: refs/heads/master@{#37575}
-
machenbach authored
Needed for https://codereview.chromium.org/2124263002/ BUG=chromium:474921 TBR=jochen@chromium.org, vogelheim@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2125703005 Cr-Commit-Position: refs/heads/master@{#37574}
-
machenbach authored
BUG=chromium:474921 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org Review-Url: https://codereview.chromium.org/2129853002 Cr-Commit-Position: refs/heads/master@{#37573}
-
verwaest authored
Those virtual methods shouldn't live on the AST since they are crankshaft specific, and can easily be checked inline. BUG= Review-Url: https://codereview.chromium.org/2125933004 Cr-Commit-Position: refs/heads/master@{#37572}
-
neis authored
When reading the value property of an iterator result fails, we must not close the iterator. This was not discovered earlier because the tests had a subtle bug. This CL fixes both the desugaring and the tests. BUG= Review-Url: https://codereview.chromium.org/2119353002 Cr-Commit-Position: refs/heads/master@{#37571}
-
verwaest authored
A bit of browsing around indicates that the new fast-path is taken most of the time: 3496 Entering new 152295 Reentering same BUG= Review-Url: https://codereview.chromium.org/2131483002 Cr-Commit-Position: refs/heads/master@{#37570}
-
neis authored
For variables introduced as part of a catch pattern, we used to set their "initializer position" to the beginning of the pattern. This lead to full-codegen eliminating crucial hole checks when reading such variables inside the pattern itself. R=adamk@chromium.org, littledan@chromium.org BUG=v8:5178 Review-Url: https://codereview.chromium.org/2123953002 Cr-Commit-Position: refs/heads/master@{#37569}
-
v8-autoroll authored
Rolling v8/build to 6d9becf753310daf17f04ac4f0d8c109c364cdd2 Rolling v8/buildtools to aa47d9773d8f4d6254a587a1240b3dc023d54f06 Rolling v8/tools/gyp to bac4680ec9a5c55ab692490b6732999648ecf1e9 TBR=machenbach@chromium.org,vogelheim@chromium.org,hablich@chromium.org Review-Url: https://codereview.chromium.org/2123853004 Cr-Commit-Position: refs/heads/master@{#37568}
-
bjaideep authored
Port b86ac0e0 Original commit message: Both of these were broken in different ways: * On arm, the loop counter was passed as argc on the stack. * On arm64, we passed argc + 1 instead of argc. The result in both cases was an incorrect receiver for the builtin frame when generating stack traces. R=jgruber@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com BUG=v8:4815 LOG=N Review-Url: https://codereview.chromium.org/2125913004 Cr-Commit-Position: refs/heads/master@{#37567}
-
- 06 Jul, 2016 2 commits
-
-
littledan authored
Revert of [esnext] ship --harmony-object-values-entries (patchset #1 id:1 of https://codereview.chromium.org/2116053003/ ) Reason for revert: Revert to see if it addresses the performance regression observed in chromium:625956 in automated graphs Original issue's description: > [esnext] ship --harmony-object-values-entries > > BUG=v8:4663 > R=littledan@chromium.org, adamk@chromium.org > > Committed: https://crrev.com/ab529234853a1768642f8f6c907aaaa5ea8b19bf > Cr-Commit-Position: refs/heads/master@{#37485} TBR=adamk@chromium.org,caitpotter88@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:4663 Review-Url: https://codereview.chromium.org/2129533004 Cr-Commit-Position: refs/heads/master@{#37566}
-
franzih authored
Working on eliminating the use of ClassOf(). This function was checking IS_ARRAYBUFFER. BUG= Review-Url: https://codereview.chromium.org/2126603003 Cr-Commit-Position: refs/heads/master@{#37565}
-