Commits · 2b722b663eace2d9716cd93ae4779b8e1cfa7c64 · Linshizhi / V8

20 Mar, 2014 36 commits

Fix polymorphic hydrogen handling of SLOPPY_ARGUMENTS_ELEMENTS · 2b722b66

jkummerow@chromium.org authored Mar 20, 2014

BUG=chromium:354391
LOG=y
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/206073008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20137 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2b722b66

Reland "Implement ES6 symbol registry and predefined symbols" · b3b6987b

rossberg@chromium.org authored Mar 20, 2014

Only change relative to original CL is the updated assertion condition at objects-inl.h:2119

R=mstarzinger@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204913006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20136 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b3b6987b

MIPS: Implement flooring division by a constant via truncating division by a constant. · 2aadbc8f

plind44@gmail.com authored Mar 20, 2014

Port r20123 (31ab416)

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/206373004

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20135 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

2aadbc8f

Allow to push arbitrary revisions when pushing to trunk. · b12ff513

machenbach@chromium.org authored Mar 20, 2014

BUG=
R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/206133004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20132 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

b12ff513

A64: Restore the stack limit protection to 1KB. · bd69f653

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206393002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20131 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bd69f653

Fix assertions wrt concurrent OSR. · c9d391d8

yangguo@chromium.org authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206473002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20130 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c9d391d8

Remove outdated OOM tests. · 8f48dbb7

yangguo@chromium.org authored Mar 20, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/206373003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20129 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8f48dbb7

Callers of JSArray::SetContent() handlified. · 9f6be9c5

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206383003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20128 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9f6be9c5

Fix for performance issue 353661 - 23% regression in dromaeo. · c92de5d1

mvstanton@chromium.org authored Mar 20, 2014

The issue was that a previous fix to avoid a logic error was not
targeted enough: it allowed non-transitioning stores to fall
into a code path meant to preserve monomorphic state in the
case of a transitioning store.

BUG=353661
LOG=N
R=verwaest@chromium.org

Review URL: https://codereview.chromium.org/206353002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20127 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c92de5d1

Increase the "local variables in a function" limit. · e9358fa9

marja@chromium.org authored Mar 20, 2014

The limit was originally added to avoid having large user-controlled constants
(variable indexes) in the code generated by full-codegen.

History behind this change:

The original CL for adding the limit was https://codereview.chromium.org/7003030
and at that time, the limit was 32767.

Reason for adding the limit (in CL comments): "The motivation behind this change
is to avoid large user controlled constants in the code. The slot_operand used
in the IA32 full code generator uses a relative load where the local index is an
(negative) immediate."

The limit was then bumped to 65535 by https://codereview.chromium.org/10965063
and to 131071 by https://codereview.chromium.org/11099063.

R=dcarney@chromium.org, svenpanne@chromium.org, jkummerow@chromium.org, rossberg@chromium.org
BUG=v8:3205
LOG=Y

Review URL: https://codereview.chromium.org/206143004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20126 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

e9358fa9

Make PreParser track valid left hand sides. · d017e6ce

marja@chromium.org authored Mar 20, 2014

Notes:
- This makes PreParser produce invalid_lhs_in_assignment and
invalid_lhs_in_prefix_op. Other errors will follow as the corresponding funcs
move to ParserBase.
- PreParserExpression::IsStrictFunction and StrictFunction() are not needed any
more -> removed them.

R=rossberg@chromium.org
BUG=

Review URL: https://codereview.chromium.org/196343033

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20125 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d017e6ce

ArrayShift builtin handlified. · 68c91ea3

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206423002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20124 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

68c91ea3

Implement flooring division by a constant via truncating division by a constant. · 68237f65

svenpanne@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/204583002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20123 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

68237f65

ArrayPush builtin handlified. · 8e10eea9

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206183006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20122 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

8e10eea9

Revert "Implement ES6 symbol registry and predefined symbols" · 1088fbd1

rossberg@chromium.org authored Mar 20, 2014

TBR=yangguo@chromium.org
BUG=

Review URL: https://codereview.chromium.org/204353004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20121 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

1088fbd1

Use HBoundsCheck to check string length. · 00170e43

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/206183003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20120 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

00170e43

Reland "Throw exception on invalid string length instead of OOM." · 000be4d0

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/199583007

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20119 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

000be4d0

Implement ES6 symbol registry and predefined symbols · 0f71f617

rossberg@chromium.org authored Mar 20, 2014

R=mstarzinger@chromium.org, arv@chromium.org
BUG=
LOG=Y

Review URL: https://codereview.chromium.org/203243004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20118 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0f71f617

Handlify callers to GetElementNoException. · 77a28b73

yangguo@chromium.org authored Mar 20, 2014

R=ishell@chromium.org

Review URL: https://codereview.chromium.org/204693002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20117 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

77a28b73

A64: Minor cleaning in StoreStubCompiler::GenerateStoreField. · 50360315

alexandre.rames@arm.com authored Mar 20, 2014

Abstract a register to simplify code generation.

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/206183005

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20116 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

50360315

Revert "Throw exception on invalid string length instead of OOM." · a5a82ef1

yangguo@chromium.org authored Mar 20, 2014

This reverts r20112.

TBR=yangguo@chromium.org

Review URL: https://codereview.chromium.org/206383002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20114 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a5a82ef1

ElementsAccessor::Delete() handlified. · 107ea152

ishell@chromium.org authored Mar 20, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/200923006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

107ea152

Throw exception on invalid string length instead of OOM. · 9ba80269

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org
BUG=349329
LOG=Y

Review URL: https://codereview.chromium.org/199853004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20112 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9ba80269

A64: Remove Operand constructors where an implicit constructor can be used. · bfcc117f

alexandre.rames@arm.com authored Mar 20, 2014

R=jochen@chromium.org

Review URL: https://codereview.chromium.org/204293004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20111 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bfcc117f

A64: Improve the deoptimization exit code for LMathRound. · 0768479e

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203253004

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20109 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

0768479e

A64: In the Simulator, corrupt caller-saved registers after runtime printf call. · c8a6fd01

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203603002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20108 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c8a6fd01

A64: Abstract simulation of runtime calls in a separate function. · 948d8621

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203703002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20107 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

948d8621

A64: Abstract colour definitions for the Simulator tracing. · 9755b907

alexandre.rames@arm.com authored Mar 20, 2014

R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203563002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20106 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9755b907

Remove unnecessary 'explicit' attribute. · 9cd1057c

yangguo@chromium.org authored Mar 20, 2014

R=marja@chromium.org

Review URL: https://codereview.chromium.org/206183002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20104 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

9cd1057c

Deprecate prepare push commit when pushing to trunk. · d7d4452e

machenbach@chromium.org authored Mar 20, 2014

- This also deprecates using version.cc on bleeding edge.
- The deprecated push-to-trunk.sh is deleted.
- The script now commits bleeding edge HEAD by default. Committing different revisions will be added in a follow up CL.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/203753010

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20101 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

d7d4452e

A64: clean up pending reloc info if code generation was aborted. · f7dc76af

ulan@chromium.org authored Mar 20, 2014

This fixes assertion failure in destructor of Assembler.

BUG=352659
LOG=N
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/206213002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20100 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

f7dc76af

Make max size and max length of strings consistent. · 238f12e6

yangguo@chromium.org authored Mar 20, 2014

R=bmeurer@chromium.org

Review URL: https://codereview.chromium.org/196133030

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20099 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

238f12e6

A64: Fix write barrier input in KeyedStoreIC::GenerateSloppyArguments. · 41eab256

ulan@chromium.org authored Mar 20, 2014

This fixes flaky crashes in gc-stress bot:
> Fatal error in ../src/incremental-marking.cc, line 84
> CHECK(obj->IsHeapObject()) failed

BUG=353551
LOG=N
TEST=test/mjsunit/regress/regress-353551.js
R=m.m.capewell@googlemail.com

Review URL: https://codereview.chromium.org/204453002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20098 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

41eab256

Revert "Enable Concurrent OSR" due to A64 failures. · eb34943c

yangguo@chromium.org authored Mar 20, 2014

This reverts r20096.

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/206173002

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20097 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

eb34943c

Enable concurrent OSR. · 65d0d384

yangguo@chromium.org authored Mar 20, 2014

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/139983008

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20096 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

65d0d384

Prepare push to trunk. Now working on version 3.25.21. · 62e70637

machenbach@chromium.org authored Mar 20, 2014

R=jkummerow@chromium.org
TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/196243006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20093 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

62e70637

19 Mar, 2014 4 commits

Cleanup following MicrotaskQueue abstraction · c84ac519

rafaelw@chromium.org authored Mar 19, 2014

https://code.google.com/p/v8/source/detail?r=19344 failed to remove the promiseEvents InternalArray.

R=rossberg@chromium.org, rossberg
LOG=N

Review URL: https://codereview.chromium.org/203773006

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20092 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

c84ac519

MIPS: Pretenure call new support. · a03e80c3

plind44@gmail.com authored Mar 19, 2014

Port r20076 (b7b1372)

Original commit message:
When FLAG_pretenure_call_new is on, we emit mementos on new object creation
in full code, and consume the feedback in crankshaft. A key difference in the
generated code for stubs is the allocation of an additional type vector slot for the
CallNew AST node, which simplifies the CallConstructStub and CallFunctionStub
considerably.

Some performance tuning still needs to be addressed, therefore the flag is off at
this moment, though fully functional. The goal is to remove the flag as soon as
possible, which allows much code deletion (yay).

BUG=
R=plind44@gmail.com

Review URL: https://codereview.chromium.org/203463013

Patch from Balazs Kilvady <kilvadyb@homejinni.com>.

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20091 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

a03e80c3

ElementsAccessor::SetLength() handlified. · 158269c1

ishell@chromium.org authored Mar 19, 2014

R=yangguo@chromium.org

Review URL: https://codereview.chromium.org/204603003

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20090 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

158269c1

ARM: clean-up some stub call sequences. · bdea3e9a

rodolph.perfetta@arm.com authored Mar 19, 2014

BUG=
R=ulan@chromium.org

Review URL: https://codereview.chromium.org/203263016

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@20089 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

bdea3e9a