- 20 Nov, 2018 27 commits
-
-
Sergiy Byelozyorov authored
This reverts commit f401cd4b. Reason for revert: did not help Original change's description: > [tools] Re-land: Add retries when trying to discover the device > > This is an experimental change that may help mitigate the issue. > > TBR=machenbach@chromium.org > > No-Try: true > No-Tree-Checks: true > Bug: chromium:893593 > Change-Id: Idf15a63006c2c7ba2c31482e5103b2a0b1d64510 > Reviewed-on: https://chromium-review.googlesource.com/c/1339401 > Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57558} TBR=machenbach@chromium.org,sergiyb@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:893593 Change-Id: I30c529a627d1e6fa52099939c5c209110e9d0eb9 Reviewed-on: https://chromium-review.googlesource.com/c/1342931Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#57650}
-
Georg Neis authored
This is a reland of 9c91b687 after fixing undefined behavior in numeric conversion that caused trouble on arm32. Original change's description: > [turbofan] Use feedback when reducing global loads/stores. > > We already record the script context location or the property cell > as feedback of the global load/store IC, so Turbofan doesn't need > to do the lookups again. > > Change-Id: I6cbd2937de344729cd8e146b4ff85ddf3de6a56e > Reviewed-on: https://chromium-review.googlesource.com/c/1335691 > Commit-Queue: Georg Neis <neis@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57555} Change-Id: Ic2d09025de02f92199755ac860bb9e91fa08f4ec Reviewed-on: https://chromium-review.googlesource.com/c/1340043Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Georg Neis <neis@chromium.org> Cr-Commit-Position: refs/heads/master@{#57649}
-
Mythri authored
This cl updates: 1. Adds a new feedback cell map to specify that no feedback is collected 2. Checks if feedback vectors are valid before using then when creating closures 3. Runtime profiler to only tier up functions with feedback 4. Interpreter entry trampoline to check for feedback vector before using it. Bug: v8:8394 Change-Id: I0248c8cd35d841c2744b22f4c672fa2e82033f6e Reviewed-on: https://chromium-review.googlesource.com/c/1339866 Commit-Queue: Mythri Alle <mythria@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57648}
-
Toon Verwaest authored
Change-Id: I08af90a6bd863402309c1c65c829db6a955c67e3 Reviewed-on: https://chromium-review.googlesource.com/c/1342927Reviewed-by:
Igor Sheludko <ishell@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#57647}
-
Clemens Hammacher authored
This adds a {PrintRegister} method which prints the given register in a readable way (e.g. "eax", ... on ia32). This is currently only used in Liftoff. The {RegisterConfiguration} class has the same functionality, and I plan to make {RegisterConfiguration} also use the new {RegisterName} functions in a follow-up CL. R=mstarzinger@chromium.org Bug: v8:8238, v8:8423, v8:6600 Change-Id: If03901f1d8c5b043e0097e63920ab711bd7e2d17 Reviewed-on: https://chromium-review.googlesource.com/c/1340041Reviewed-by:Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#57646}
-
Tobias Tebbi authored
This enables more seamless interop between Torque and CSA: Since CodeStubAssembler can now inherit from the Torque base namespace, macros defined in the base namespace can be used in CodeStubAssembler macros, even without qualification. At the same time, macros in the base namespace can refer to CodeStubAssembler macros. The only new limitation is that types defined in code-stub-assembler.h cannot be referenced in the signature of macros defined in the base namespace, since this would produce a cyclic header dependency. A work-around for this woud be to put such types (like int31 in this CL) into a separate header included by both. I (mis-)used code-assembler.h for that. Another side-effec is that types and enums defined in CodeStubAssembler have to be accessed in a qualified way from Torque. Other assemblers can now inherit from their Torque equivalent, so porting macros into the corresponding Torque namespace doesn't require any change to the existing use-sites. To avoid C++ ambiguities, the Torque-generated assemblers must not define anything also defined in Code(Stub)Assembler. This includes the type aliases for TNode, PLabel, ... My workaround is to qualify everything in the generated C++. As a drive-by fix, I had to change the formatter to avoid a situation where it doesn't compute a fixed point: putting a keyword at the beginning of a line removes the '\s' in front of it, so I replaced that with '\b'. Bug: v8:7793 Change-Id: If3b9e9ad967a181b380a10d5673615606abd1041 Reviewed-on: https://chromium-review.googlesource.com/c/1341955Reviewed-by:
Daniel Clifford <danno@chromium.org> Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#57645}
-
Michael Lippautz authored
This is a reland of b1468242. Bug: chromium:843903, chromium:903586 Change-Id: Ida59ba4efd3abae6956b99aa104bbc66a3f01fdc Reviewed-on: https://chromium-review.googlesource.com/c/1342924Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:8457 Change-Id: I9893f675232f47ae1529fd773adb524f60418c92 Reviewed-on: https://chromium-review.googlesource.com/c/1342928Reviewed-by:
-
Yang Guo authored
R=jgruber@chromium.org Change-Id: I07d9c2f952f0ca3cf50f5faa4ad8db78be2a5b04 Reviewed-on: https://chromium-review.googlesource.com/c/1342926Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#57642}
-
Pierre Langlois authored
Emitting unwinding info for builtins for perf to consume doesn't make sense with embedded builtins so let's just remove the option. The perf support is meant for code on the heap and the builtins are not there anymore. If we want perf to be able to unwind through builtins we should emit the unwinding DWARF information directly into the binary, using the dedicated .eh_frame ELF section. This would also mean GDB would be able to unwind through builtins as well which would be great. Change-Id: I751cc5eb1e6f7c0eeae6b37a42986ae8ea47d6a0 Reviewed-on: https://chromium-review.googlesource.com/c/1340294Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
Clemens Hammacher authored
Just compute it from the number of outstanding units. R=ahaas@chromium.org Bug: v8:7921 Change-Id: I30db10accc032bc50e1bbeab599325e1e971972b Reviewed-on: https://chromium-review.googlesource.com/c/1341953 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57640}
-
Igor Sheludko authored
for storing embedder data in native context. We can't use FixedArray because with enabled pointer compression it would not be possible to fit raw aligned pointer into 32-bits of a tagged value so we will need to store both tagged and raw data in this array and therefore custom visitor is required. Bug: v8:7703 Change-Id: Iae23d9aa76c79a572d5f0f1f3c0f924e8e407dd0 Reviewed-on: https://chromium-review.googlesource.com/c/1340295 Commit-Queue: Igor Sheludko <ishell@chromium.org> Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
Ulan Degenbaev authored
The concurrent marker needs to access the kind_specific_flags to decide whether an embedded object reference is weak or not. This patch turns the Code::code_data_container() into an acquire/release atomic accessor and makes CodeDataContainer::kind_specific_flags a relaxed atomic accessor. Bug: v8:8459 Change-Id: I5251fed4e7b3315f8e229dfcfe2c23f611f4b333 Reviewed-on: https://chromium-review.googlesource.com/c/1337746Reviewed-by:
Hannes Payer <hpayer@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#57638}
-
Georg Neis authored
This has been on by default and the flag itself is no longer useful. R=jarin@chromium.org, mslekova@chromium.org Bug: v8:7790 Change-Id: Icdf111b974a01953ea775ccb96d50217f3c8321b Reviewed-on: https://chromium-review.googlesource.com/c/1342918 Commit-Queue: Georg Neis <neis@chromium.org> Reviewed-by:
Maya Lekova <mslekova@chromium.org> Reviewed-by:
-
Andreas Haas authored
In the chrome-side implementation I currently use the default trap handlers of V8, see https://crrev.com/c/1290955 Bug: chromium:906565 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I74c5a18c479ad1c69303d104ad4f040de436c4e7 Reviewed-on: https://chromium-review.googlesource.com/c/1282960 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Reviewed-by:
-
Toon Verwaest authored
If we're hashing a single sequential string we don't need the state that the string hasher itself tracks. This also drops first_char since we can simply check that array_index is still 0. Change-Id: Icb69709267426358f7c301eeb45936843ba261b0 Reviewed-on: https://chromium-review.googlesource.com/c/1340258 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#57635}
-
Predrag Rudic authored
Our toolchain fails to link unittests without this change. Change-Id: I48cc61f45fe5d533ed207f987371893caf54a919 Reviewed-on: https://chromium-review.googlesource.com/c/1340293Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Commit-Queue: Ivica Bogosavljevic <ibogosavljevic@wavecomp.com> Cr-Commit-Position: refs/heads/master@{#57634}
-
Benedikt Meurer authored
Previously the simplified operation `Number.min(x,y)` would lower to `Select(Float64LessThan(x, y), x, y)` which would yield `y` when both `x` and `y` are zeros, specifically when `x` was -0 and `y` was +0. For `NumberMin` we need to use `Float64LessThanOrEqual` since we generally allow -0 on the left hand side (in SimplifiedLowering). Bug: chromium:906870 Change-Id: I25ae8fb19608b77c90ed130e69d9d9fa93fcea9d Reviewed-on: https://chromium-review.googlesource.com/c/1342920 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
-
Yang Guo authored
Bug: chromium:906313 Change-Id: Ie5d91e086d02433e2dec7728e29e4ae87cdd34c3 Reviewed-on: https://chromium-review.googlesource.com/c/1340290Reviewed-by:
-
Camillo Bruni authored
This reverts commit b1468242. Reason for revert: breaking blink, v8:8480 Original change's description: > heap: Move embedder epilogue after first round of weak callbacks > > Bug: chromium:843903, chromium:903586 > Change-Id: I0441ab2cc0fcc0b2cb411be0c92860c64d808324 > Reviewed-on: https://chromium-review.googlesource.com/c/1340254 > Reviewed-by: Ulan Degenbaev <ulan@chromium.org> > Commit-Queue: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#57604} TBR=ulan@chromium.org,mlippautz@chromium.org Change-Id: I4f72fb4f6060d814d09fa9d75ff41b5e236c8505 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:843903, chromium:903586 Reviewed-on: https://chromium-review.googlesource.com/c/1342922Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#57631}
-
Sigurd Schneider authored
This change ensures that we do not try to check the conversion of a floating point constant, but insert the floating point constant instead. Change-Id: I1c65e3a69acaea2ff805ba10317f64c0ac0ba098 Reviewed-on: https://chromium-review.googlesource.com/c/1340257Reviewed-by:
-
Sigurd Schneider authored
This CL extends the lifetime of the typer in the pipeline until after load elimination. This is a two-line CL to make it easy to revert if we missed necessary brokerization. If the CL sticks, we can remove some SetType calls in optimizations. Change-Id: I4f27bfcada5221b2bae81297cd6b606881a7ccb8 Reviewed-on: https://chromium-review.googlesource.com/c/1341952 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Sigurd Schneider authored
This is pre-work to extend the typer phase until after load elinination. Load elimination uses maps from CheckMaps/MapGuard/CompareMaps/LoadField and this CL ensures they are brokerized. Bug: v8:7790 Change-Id: Ic04f9c374bc736f03abf2bc7d257deb268d723c8 Reviewed-on: https://chromium-review.googlesource.com/c/1341950Reviewed-by:
-
Michael Starzinger authored
R=ulan@chromium.org Change-Id: Ib2eb33688517324884c4172560387242c71094fb Reviewed-on: https://chromium-review.googlesource.com/c/1342518Reviewed-by:
-
Jaroslav Sevcik authored
Forgot to negate. Oops. Bug: chromium:906893 Change-Id: I6e7a5a87e8c513795cc598314c9f0a34e9389e69 Reviewed-on: https://chromium-review.googlesource.com/c/1342919Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/2fb6537..1f137f3 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/b81a9c7..1e54003 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/c6ffd7a..7da982a Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/1d879ce..aa6b9c8 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I7e874e531e589b194184067e0e5b7fd7230c371d Reviewed-on: https://chromium-review.googlesource.com/c/1342949 Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#57625}
-
Aseem Garg authored
Bug=v8:8075 R=adamk@chromium.org,binji@chromium.org Change-Id: I2367e24888a268ce93b1730195cb4767896861cc Reviewed-on: https://chromium-review.googlesource.com/c/1341126Reviewed-by:
Ben Smith <binji@chromium.org> Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Cr-Commit-Position: refs/heads/master@{#57624}
-
- 19 Nov, 2018 13 commits
-
-
Aseem Garg authored
Bug=v8:8075 R=adamk@chromium.org Change-Id: Ib7b18448d59e1f54f664e24908fbd3a8b4607a9f Reviewed-on: https://chromium-review.googlesource.com/c/1332153 Commit-Queue: Aseem Garg <aseemgarg@chromium.org> Reviewed-by:
-
Ben Smith authored
These instructions aren't implemented yet in TF or in Liftoff, but they are properly decoded. The table instructions (i.e. `table.{init,drop,copy}`) are validated, since the table and element sections occur before the code section. The memory instructions (i.e. `memory.{init,drop,copy,fill}`) are not validated because the data section occurs after the code section, so it can't be verified in one pass (without throwing a validation error later). There is currently a discussion about whether to add a new section (similar to `func`) that predefines the number of expected data segments. If we add this, then we can validate in one pass. For now, we'll leave it unimplemented. Bug: v8:7747 Change-Id: I839edf51721105a47a1fa8dd5e5e1bd855e72447 Reviewed-on: https://chromium-review.googlesource.com/c/1339241 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by: -
Deepti Gandluri authored
Change-Id: I16cc93b44bddbd8356a4098f3857db4f9808e13c Reviewed-on: https://chromium-review.googlesource.com/c/1336777Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#57621}
-
Junliang Yan authored
Port 72823c8c Original Commit Message: {RegisterConfiguration} is not used inside assembler.h. Instead, include it where needed. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Id79b6eda6f6ce9c105997ec65c9f72398af29954 Reviewed-on: https://chromium-review.googlesource.com/c/1342661Reviewed-by:
Muntasir Mallick <mmallick@ca.ibm.com> Commit-Queue: Junliang Yan <jyan@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#57620}
-
Junliang Yan authored
Port 2cf36eb8 Original Commit Message: Instead, include macro-assembler.h (and others) where needed. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I94320322584a39802aaaefd279ce8819ad8686d8 Reviewed-on: https://chromium-review.googlesource.com/c/1342978Reviewed-by:
-
Junliang Yan authored
Port 1952f928 Original Commit Message: The platform specific macro assembler headers can not be included directly. They require symbols declared in macro-assembler.h. We also cannot include macro-assembler.h from the platform specific headers, because that would form a cycle, and the include in macro-assembler.h would be skipped, which then also fails. This CL documents and enforces this unfortunate situation. This helps with further iwyu cleanups. Note that current code which includes the platform specific headers only works because we transitively included macro-assembler.h already before. R=clemensh@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: Iff6217ccb961d009a31f6adc50a7ef77ca1c8b70 Reviewed-on: https://chromium-review.googlesource.com/c/1342977Reviewed-by:
-
Junliang Yan authored
Port 6e5671e1 Original Commit Message: This marks the InterpreterEntryTrampoline as isolate-independent. With this change, all builtins are now embedded. Slight changes were needed to how we deopt into the trampoline. We now store the entry address within the Interpreter class instead of embedding the builtin code target. R=jgruber@chromium.org, joransiu@ca.ibm.com, michael_dawson@ca.ibm.com BUG= LOG=N Change-Id: I88aa263793c38cb60300fd795c0bd7011f337739 Reviewed-on: https://chromium-review.googlesource.com/c/1342738Reviewed-by:
-
Ulan Degenbaev authored
It removes special handling for Cells and PropertyCells. That handling was required before when new space objects were embedded in code objects via Cells. Since code objects support direct embedding now, the handling can be removed. The patch also makes sure to load the map of the object once using the synchronized accessor, which will be needed for concurrent visiting of code object. Bug: v8:8459 Change-Id: I83833e19ad1da4a92e1a9be60b7c1dcd05c2b2be Reviewed-on: https://chromium-review.googlesource.com/c/1337745Reviewed-by:
-
Joyee Cheung authored
This patch implements the parsing of private methods in the stage 3 proposal https://tc39.github.io/proposal-private-methods - Adds a --harmony-private-methods flag - Parse the private methods/accessors The design doc is in https://docs.google.com/document/d/1T-Ql6HOIH2U_8YjWkwK2rTfywwb7b3Qe8d3jkz72KwA/edit?usp=sharing This patch only makes sure the syntax parses, doesn't implement the semantics. Bug: v8:8330 Change-Id: I9007b3b3dd6a0df35db7bb14f38f1a38d52bc663 Reviewed-on: https://chromium-review.googlesource.com/c/1329706 Commit-Queue: Joyee Cheung <joyee@igalia.com> Reviewed-by:
-
Igor Sheludko authored
which will eventually replace kPointerSize[Log2] to make it explicit what kind of values is expected. With enabled pointer compression these sizes will not be equal anymore. This CL starts an incremental migration to proper constants. Bug: v8:8477, v8:8238 Change-Id: Ia134d5a1c0639d9f9103d7a88bf87211e353ad50 Reviewed-on: https://chromium-review.googlesource.com/c/1340298Reviewed-by:
-
Peter Marshall authored
Do less work in MultipleProfilers. Reduces runtime from ~8 mins to ~40 seconds. Bug: v8:8474 Change-Id: I72b3266941ce40c8d064deaf00fb06f8d9fa8a70 Reviewed-on: https://chromium-review.googlesource.com/c/1341956Reviewed-by:
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: I96fd746291aa2e1386ed40068d38f5140bb1e44f Reviewed-on: https://chromium-review.googlesource.com/c/1342031Reviewed-by:
-
Toon Verwaest authored
Change-Id: If5d5f45dbd7461db77d3da5ba050dbe67d87a442 Reviewed-on: https://chromium-review.googlesource.com/c/1342028 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by:
-
