- 25 Oct, 2016 1 commit
-
-
kozyatinskiy authored
To achieve this: - fixed crash on windows - String16::fromInteger used "%zu" which doesn't support by VS2013 compiler, wrapped with ifdef else. - fixed asan for d8 - unique_ptr on array has single element type. - force Debugger.disable at the end of test. BUG=chromium:635948 R=dgozman@chromium.org,yangguo@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2450653002 Cr-Commit-Position: refs/heads/master@{#40546}
-
- 24 Oct, 2016 1 commit
-
-
yangguo authored
R=machenbach@chromium.org Review-Url: https://codereview.chromium.org/2424313004 Cr-Commit-Position: refs/heads/master@{#40528}
-
- 20 Oct, 2016 1 commit
-
-
hablich authored
Revert of [inspector] align console implementation with spec (patchset #2 id:20001 of https://chromiumcodereview.appspot.com/2428473003/ ) Reason for revert: Breaks roll: https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/164610 See https://chromiumcodereview.appspot.com/2434733002/ for more context Original issue's description: > [inspector] align console implementation with spec > > console should be non enumerable. > > BUG=chromium:656826 > R=dgozman@chromium.org TBR=dgozman@chromium.org,kozyatinskiy@chromium.org NOTRY=true BUG=chromium:656826 Review-Url: https://chromiumcodereview.appspot.com/2435013002 Cr-Commit-Position: refs/heads/master@{#40464}
-
- 19 Oct, 2016 3 commits
-
-
kozyatinskiy authored
.. to make windows bot happy. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428213002 Cr-Commit-Position: refs/heads/master@{#40415}
-
kozyatinskiy authored
console should be non enumerable. BUG=chromium:656826 R=dgozman@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2428473003 Cr-Commit-Position: refs/heads/master@{#40414}
-
kozyatinskiy authored
* introduced v8::DebugInterface::ChangeBreakOnException(Isolate*,ExceptionBreakState); * migrated inspector to new API; * added cctest for new API; * added inspector test for setPauseOnExceptionState. BUG=chromium:652939,v8:5510 R=dgozman@chromium.org,yangguo@chromium.org Review-Url: https://chromiumcodereview.appspot.com/2396193002 Cr-Commit-Position: refs/heads/master@{#40413}
-
- 18 Oct, 2016 3 commits
-
-
jochen authored
R=jgruber@chromium.org,machenbach@chromium.org BUG= Review-Url: https://codereview.chromium.org/2421303002 Cr-Commit-Position: refs/heads/master@{#40410}
-
clemensh authored
This ensures that the stack traces show up correctly in DevTools. I will later extend it for source view. R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG=chromium:613110 Review-Url: https://codereview.chromium.org/2420093002 Cr-Commit-Position: refs/heads/master@{#40392}
-
clemensh authored
... instead of getting it from the FunctionMirror. For WASM frames (including asm.js -> WASM), the function is either unresolved or does not contain the script. The added test case failed before this CL. R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG=v8:4203, chromium:656622 Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615 Review-Url: https://codereview.chromium.org/2415073003 Cr-Original-Commit-Position: refs/heads/master@{#40348} Cr-Commit-Position: refs/heads/master@{#40387}
-
- 17 Oct, 2016 2 commits
-
-
machenbach authored
Revert of [debug] Consistently use script from FrameMirror (patchset #3 id:40001 of https://codereview.chromium.org/2415073003/ ) Reason for revert: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10706 https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [debug] Consistently use script from FrameMirror > > ... instead of getting it from the FunctionMirror. For WASM frames > (including asm.js -> WASM), the function is either unresolved or does > not contain the script. > > The added test case failed before this CL. > > R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org > BUG=v8:4203 > > Committed: https://crrev.com/ce32e2ffd835062d764f3c0ee6a32543417cb615 > Cr-Commit-Position: refs/heads/master@{#40348} TBR=kozyatinskiy@chromium.org,yangguo@chromium.org,titzer@chromium.org,clemensh@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4203 Review-Url: https://codereview.chromium.org/2427633002 Cr-Commit-Position: refs/heads/master@{#40362}
-
clemensh authored
... instead of getting it from the FunctionMirror. For WASM frames (including asm.js -> WASM), the function is either unresolved or does not contain the script. The added test case failed before this CL. R=kozyatinskiy@chromium.org, yangguo@chromium.org, titzer@chromium.org BUG=v8:4203 Review-Url: https://codereview.chromium.org/2415073003 Cr-Commit-Position: refs/heads/master@{#40348}
-
- 13 Oct, 2016 1 commit
-
-
kozyatinskiy authored
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. BUG=chromium:653424 R=dgozman@chromium.org Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 Review-Url: https://codereview.chromium.org/2410933002 Cr-Original-Commit-Position: refs/heads/master@{#40190} Cr-Commit-Position: refs/heads/master@{#40288}
-
- 12 Oct, 2016 2 commits
-
-
machenbach authored
Revert of [inspector] fix timestamp formatting with non C locales (patchset #7 id:120001 of https://codereview.chromium.org/2410933002/ ) Reason for revert: Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/10548 See also: https://github.com/v8/v8/wiki/Blink-layout-tests Original issue's description: > [inspector] fix timestamp formatting with non C locales > > If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. > > BUG=chromium:653424 > R=dgozman@chromium.org > > Committed: https://crrev.com/dde5ef75cbac1eb7e2dae59b246e4a0d0ba6a0f4 > Cr-Commit-Position: refs/heads/master@{#40190} TBR=dgozman@chromium.org,kozyatinskiy@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:653424 Review-Url: https://codereview.chromium.org/2419453002 Cr-Commit-Position: refs/heads/master@{#40200}
-
machenbach authored
BUG=chromium:635948 Review-Url: https://codereview.chromium.org/2393863002 Cr-Commit-Position: refs/heads/master@{#40194}
-
- 11 Oct, 2016 1 commit
-
-
kozyatinskiy authored
If current locale has "," as decimal separator then message for consoleAPICalled will be corrupted. BUG=chromium:653424 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2410933002 Cr-Commit-Position: refs/heads/master@{#40190}
-
- 10 Oct, 2016 1 commit
-
-
kozyatinskiy authored
* Inspector should depend on v8_libbase, v8 depedency is added in conditions section. * Inlined sources since they aren't used outside of this gyp file. BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2408833002 Cr-Commit-Position: refs/heads/master@{#40139}
-
- 07 Oct, 2016 3 commits
-
-
kozyatinskiy authored
This problem was detected only on linux64_gyp bot. It's safe to convert length string into int from size_t. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2402583004 Cr-Commit-Position: refs/heads/master@{#40101}
-
kozyatinskiy authored
String16 is not public part of src/inspector. All usage are replaced with vector of char/unit16_t to avoid potential linker problems. BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2403493002 Cr-Commit-Position: refs/heads/master@{#40098}
-
kozyatinskiy authored
Only subset of internal properties can be useful in preview, report only them. BUG=chromium:653610 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2399003003 Cr-Commit-Position: refs/heads/master@{#40064}
-
- 06 Oct, 2016 1 commit
-
-
kozyatinskiy authored
TBR=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2397193002 Cr-Commit-Position: refs/heads/master@{#40052}
-
- 05 Oct, 2016 4 commits
-
-
kozyatinskiy authored
v8::Integer::Value() method returns int64 but all scriptIds are 32 bit based. We can safely cast int64 into int here to make compilers happy. R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2394973002 Cr-Commit-Position: refs/heads/master@{#40016}
-
kozyatinskiy authored
BUG=chromium:496666 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2391323002 Cr-Commit-Position: refs/heads/master@{#40007}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org,machenbach@chromium.org Review-Url: https://codereview.chromium.org/2389133004 Cr-Commit-Position: refs/heads/master@{#40003}
-
kozyatinskiy authored
BUG=chromium:635948 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2384373002 Cr-Commit-Position: refs/heads/master@{#39998}
-
- 03 Oct, 2016 4 commits
-
-
kozyatinskiy authored
Introduce Protocol.Domain.method(args) and Protocol.Domain.onEventName() instead. Renamed InspectorTest.evaluateInPage -> InspectorTest.addScript. Improved InspectorTest.logMessage. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2390733002 Cr-Commit-Position: refs/heads/master@{#39942}
-
kozyatinskiy authored
Added a test that Runtime.getProperties doesn't truncate Set and Map properties in [[Entries]] in internalProperties. BUG=chromium:650729 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2376863002 Cr-Commit-Position: refs/heads/master@{#39940}
-
kozyatinskiy authored
BUG=chromium:644629 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2370033003 Cr-Commit-Position: refs/heads/master@{#39938}
-
kozyatinskiy authored
BUG=chromium:651211 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2381693002 Cr-Commit-Position: refs/heads/master@{#39933}
-
- 02 Oct, 2016 4 commits
-
-
kozyatinskiy authored
- added most part of inspector tests that depends only on JavaScript domains. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/9ddbdab195923fc87fae3587ae06c5c1c5ca6d79 Review-Url: https://codereview.chromium.org/2369753004 Cr-Original-Commit-Position: refs/heads/master@{#39897} Cr-Commit-Position: refs/heads/master@{#39931}
-
kozyatinskiy authored
- added inspector test suite definition in testcfg.py - added JS infrastructure for tests in protocol-test.js BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/4a5f5d0991656a6aa45b0021a0f5ba6a7ceabe15 Review-Url: https://codereview.chromium.org/2370743003 Cr-Original-Commit-Position: refs/heads/master@{#39895} Cr-Commit-Position: refs/heads/master@{#39930}
-
kozyatinskiy authored
- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/f3f9f4448dfa533d768878245a9bdbb57b4d941b Review-Url: https://codereview.chromium.org/2372793002 Cr-Original-Commit-Position: refs/heads/master@{#39891} Cr-Commit-Position: refs/heads/master@{#39929}
-
kozyatinskiy authored
- added the channel implementation, - added inspector implementation, - added v8::Extension for communication between backend and frontend. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/cceaa1225c6a96a28d2c7410d1db520423fb8c31 Review-Url: https://codereview.chromium.org/2368393003 Cr-Original-Commit-Position: refs/heads/master@{#39888} Cr-Commit-Position: refs/heads/master@{#39928}
-
- 30 Sep, 2016 5 commits
-
-
kozyatinskiy authored
- added a inspector folder, - added related GN and gyp files, - added task handling infrastructure for test runner. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Committed: https://crrev.com/dc1c71c0dc8a5c4ade4aa291f2ddcd02e90c64b2 Review-Url: https://codereview.chromium.org/2361623006 Cr-Original-Commit-Position: refs/heads/master@{#39866} Cr-Commit-Position: refs/heads/master@{#39918}
-
machenbach authored
Revert "[inspector] added inspector test runner [part 1]" This reverts commit dc1c71c0. Revert "[inspector] added inspector test runner [part 2]" This reverts commit cceaa122. Blocks the roll: https://codereview.chromium.org/2379053003/ In particular android debug: https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/137605 BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2387603002 Cr-Commit-Position: refs/heads/master@{#39909}
-
machenbach authored
Revert "[inspector] added inspector test runner [part 3]" This reverts commit f3f9f444. Revert "[inspector] added inspector test runner [part 4]" This reverts commit 4a5f5d09. Revert "[inspector] added inspector test runner [part 5]" This reverts commit 9ddbdab1. Reverting this in order to revert parts 1-2 which block the roll: https://codereview.chromium.org/2379053003/ BUG=chromium:635948 TBR=kozyatinskiy@chromium.org, NOTRY=true Review-Url: https://codereview.chromium.org/2379303002 Cr-Commit-Position: refs/heads/master@{#39908}
-
kozyatinskiy authored
- added most part of inspector tests that depends only on JavaScript domains. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2369753004 Cr-Commit-Position: refs/heads/master@{#39897}
-
kozyatinskiy authored
- added inspector test suite definition in testcfg.py - added JS infrastructure for tests in protocol-test.js BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2370743003 Cr-Commit-Position: refs/heads/master@{#39895}
-
- 29 Sep, 2016 3 commits
-
-
kozyatinskiy authored
- added test runner, that takes file names and V8 flags as arguments and run scripts from passed files with passed flags in frontend context BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2372793002 Cr-Commit-Position: refs/heads/master@{#39891}
-
kozyatinskiy authored
- added the channel implementation, - added inspector implementation, - added v8::Extension for communication between backend and frontend. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2368393003 Cr-Commit-Position: refs/heads/master@{#39888}
-
kozyatinskiy authored
- added a inspector folder, - added related GN and gyp files, - added task handling infrastructure for test runner. BUG=chromium:635948 R=dgozman@chromium.org,alph@chromium.org Review-Url: https://codereview.chromium.org/2361623006 Cr-Commit-Position: refs/heads/master@{#39866}
-