- 25 Mar, 2019 4 commits
-
-
Peter Marshall authored
This is used to convert files with binary proto data to the Trace Event .json format for use with the chrome://tracing viewer. Change-Id: Ib5478f6aa2326b5e085506859f4a7f30f95c79f5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535823 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#60422}
-
Benedikt Meurer authored
Inside V8 the TraceID class sits in v8::internal::tracing instead of trace_event_internal namespace (as in Chrome). Bug: v8:8834 Change-Id: I9464e6145c4fd4c794ac3f50052a5fa1b068aeed Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535834 Auto-Submit: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#60421}
-
Z Duong Nguyen-Huu authored
EmbedderDataArray, JSMessageObject, JSSet, JSMap, JSWeakSet, JSWeakMap Bug: v8:8952 Change-Id: I996d9e18006184b8ac7be7d362e8faf36e44aaef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534304Reviewed-by:
Simon Zünd <szuend@chromium.org> Commit-Queue: Z Nguyen-Huu <duongn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60420}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/724c206..625ee00 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4b0dd1e..347c5e4 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/e4e1dde..ba35c7f Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/8b6d3f9..a18ac39 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2e1c40d..ad70d89 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I9963ef2febd9ce74bdd0783822f8fe512b1d3977 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1537898Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#60419}
-
- 24 Mar, 2019 2 commits
-
-
Frank Tang authored
https://rawgit.com/fabalbon/proposal-intl-DateTimeFormat-formatRange/master/out/ Design Doc https://goo.gl/PGUQ1d Bug: v8:7729 Change-Id: I38b53ffdf610400b4132a25da99dac4be67bdf4b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1510574Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#60418}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/c52372f..724c206 Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/735271f..31e0bb5 Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/2f1832a..4b0dd1e Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/33bd582..e4e1dde Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/2116ee9..2e1c40d TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ie9b3b4889df9048f3bed1310dd05e852a6f98f45 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536506Reviewed-by:
-
- 22 Mar, 2019 16 commits
-
-
Sathya Gunasekaran authored
These flags are no longer necessary. Change-Id: Id686b2820ba05d7400cdb8ef9bb7f95c01cbe698 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1536451 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Nico Weber authored
Remove a special case on mac hosts that was needed when is_clang wasn't the default on Win, but is unnecessary now and gets in the way. Bug: chromium:801780,chromium:495204 Change-Id: I8d6783c73e0c240704830a46304482e3ce94418b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534634Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#60415}
-
Bill Budge authored
- Changes min and max sequences to propagate NaNs and signed zeroes. - Note that NaN propagation must preserve canonical NaNs. This is achieved by always returning canonical NaNs. This is also consistent with the WebAssembly scalar math spec. Bug: v8:8639 Change-Id: I04fdefabc54ea60f4d02e2081c32444a02dd6a83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1524634 Commit-Queue: Bill Budge <bbudge@chromium.org> Reviewed-by:
Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#60414}
-
Benedikt Meurer authored
The "V8.OptimizeCode" trace event (in "disabled-by-default-v8.compile" category) didn't include the setup of the OptimizedCompilationJob, which is quite expensive already and should be accounted for properly. Bug: v8:8598 Change-Id: Ieec139c8d555d02edfbc52e904ee214d1007afbd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533871Reviewed-by:
-
Santiago Aboy Solanes authored
Similar to x64's https://chromium-review.googlesource.com/c/v8/v8/+/1511486 Bug: v8:7703 Change-Id: Ifd634a36bb56a53cb9901d9dd0899b66229607ef Cq-Include-Trybots: luci.v8.try:v8_linux64_arm64_pointer_compression_rel_ng Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535828 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60412}
-
Georg Neis authored
Process feedback and hints for Lda/StaNamed bytecodes w.r.t. access on the global proxy. This stores the property cells (or their absence) on the JSGlobalProxyData. Bug: v8:7790 Change-Id: Iadedea5494611c1b2ed38b6ce75687e084cc27f9 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1499499 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#60411}
-
Milad Farazmand authored
Change-Id: I290ea07e4f6c66d04ee0daa04ac78a47d9f4432e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535519Reviewed-by:
Junliang Yan <jyan@ca.ibm.com> Reviewed-by:
Milad Farazmand <miladfar@ca.ibm.com> Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com> Cr-Commit-Position: refs/heads/master@{#60410}
-
Peter Marshall authored
We were hitting a DCHECK in WaitFor() when rel_time was negative. This was caused when GetNext() recalculated the wait time for a delayed task. In the first part of the loop we moved all delayed tasks which have passed their deadline into the immediate task queue. At the bottom of the loop we assume that all delayed tasks in the queue have a deadline in the future, but this isn't always the case as we use a new 'now' value for the calculation, and time could have elapsed. Fix this by using one 'now' value for an iteration of the loop. Bug: v8:9030 Change-Id: Ia49fb571f3c7c7d9f15c6a464ee0a9db814a7f03 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535820 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Hannes Payer <hpayer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60409}
-
Sigurd Schneider authored
This is a reland of 1ca08865 Original change's description: > Reland "[regalloc] Introduce deferred fixed ranges" > > This is a reland of b1769313 > > Original change's description: > > [regalloc] Introduce deferred fixed ranges > > > > Fixed ranges are used to express register constraints in the > > allocator. This change splits these fixed ranges into one for > > normal code and deferred code. The former are handeled as before > > whereas the latter are only made visible while allocating > > registers for deferred code. > > > > This prevents forward looking decisions in normal code to be > > impacted by register constraints from deferred code. > > > > Change-Id: I67d562bb41166194e62765d5ab051bc961054fc7 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1477742 > > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > > Reviewed-by: Sigurd Schneider <sigurds@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#60322} > > Change-Id: I1a31150256eb5608db985b144aab7ea457169d0d > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530810 > Commit-Queue: Sigurd Schneider <sigurds@chromium.org> > Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60364} Change-Id: If4a956716e7e4de132f706be2c395cdfdc04ec94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532328Reviewed-by:
-
Sven Sauleau authored
This CL changes the case of the variable name I introduced in a previous CL. Change-Id: I6d44eaf8361fa7e021c1107af49ce85238165449 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535821Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Commit-Queue: Sven Sauleau <ssauleau@igalia.com> Cr-Commit-Position: refs/heads/master@{#60407}
-
Sigurd Schneider authored
Bug: v8:8834 Change-Id: Ifd5384fab1a1450275b0e8f193498b43dcbc3a5e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532334Reviewed-by:
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:923304 Change-Id: I2f3cf3f314165a683d24cbf252d46bec6e5f011c Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1535822 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Sergiy Belozorov <sergiyb@chromium.org> Cr-Commit-Position: refs/heads/master@{#60405}
-
Sven Sauleau authored
In the int64 lowering pass some parameter nodes are considered special and don't require any transformation. For instance the Wasm instance. With the experimental-wasm-bigint proposal, two new special parameters are going through the pass, this CL avoids transforming them. Change-Id: Ie99ffaff125b9ef8c56e1883aac9e18e4072fc3e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532336 Auto-Submit: Sven Sauleau <ssauleau@igalia.com> Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/base/trace_event/common: https://chromium.googlesource.com/chromium/src/base/trace_event/common/+log/936ba8a..c7664bb Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/9dba2d4..c52372f Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a2a4845..735271f Rolling v8/buildtools/third_party/libc++/trunk: https://chromium.googlesource.com/chromium/llvm-project/libcxx/+log/a50f503..4daecde Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/bf564e0..2f1832a Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/cf9613f..33bd582 Rolling v8/tools/clang/dsymutil:chromium/llvm-build-tools/dsymutil: https://chrome-infra-packages.appspot.com/chromium/llvm-build-tools/dsymutil/+log/kykIT8m..OWlhXkm TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I219f5ee1d72c736285d680c8a3fec4ac918d85be Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1534975Reviewed-by:
-
Jakob Gruber authored
Just the outermost wrapper function (which does almost nothing). Bug: v8:8976 Change-Id: I8137f86bde5e10ba7edd5051e7c86bfc631bfe94 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1528531 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Peter Wong <peter.wm.wong@gmail.com> Cr-Commit-Position: refs/heads/master@{#60402}
-
peterwmwong authored
Bug: v8:8996 Change-Id: Iffe8fe46536ae6749e8dcad1e0e441c3626cba95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1527558 Commit-Queue: Peter Wong <peter.wm.wong@gmail.com> Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#60401}
-
- 21 Mar, 2019 18 commits
-
-
Georg Neis authored
ReduceArrayIndexOfIncludes didn't account for kUnreliableReceiverMaps. Will think about a more robust mechanism for this. Bug: chromium:944062 Change-Id: Ib2bdaf4399225de4413e12c5684f58dfe524a2cd Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532331 Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:923304 Change-Id: I65898b7edea8d696d957a8ba19809484e663cb27 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533864 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60399}
-
Sergiy Belozorov authored
TBR=sergiyb@chromium.org No-Try: true Bug: chromium:923304 Change-Id: Ide9451848e227d27ba7d5b413649e50ce29bb586 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533870 Commit-Queue: Sergiy Belozorov <sergiyb@chromium.org> Reviewed-by:
-
Michael Achenbach authored
This reverts commit 7b896836. Reason for revert: Lots of test failures on current roll: https://chromium-review.googlesource.com/c/chromium/src/+/1534141 Original change's description: > Reland "[ptr-compr][x64] Temporarily enable pointer compression on x64" > > This is a reland of 4f051fd5 > > Relanding because last revert was caused by unrelated flakes. > > Original change's description: > > [ptr-compr][x64] Temporarily enable pointer compression on x64 > > > > ... and make sure that the x64 ptr-compr bots proceed testing V8 without > > pointer compression in order to keep testing the full pointer mode. > > > > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng,v8_linux64_tsan_rel > > Bug: v8:7703 > > Change-Id: Ied4e7bacf99c9d63e0459613fec522273f595de8 > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1523327 > > Commit-Queue: Igor Sheludko <ishell@chromium.org> > > Auto-Submit: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#60339} > > Bug: v8:7703 > Change-Id: I9c588de77070d4fbf1bb1a21ae58c398a22eed9c > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng, v8_linux64_tsan_rel, v8_mac64_gc_stress_dbg > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1530819 > Commit-Queue: Igor Sheludko <ishell@chromium.org> > Reviewed-by: Michael Achenbach <machenbach@chromium.org> > Cr-Commit-Position: refs/heads/master@{#60370} TBR=machenbach@chromium.org,ishell@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: v8:7703 Change-Id: I1c037470b5895c4269c9574e6c93d0eed6fe90d5 Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng, v8_linux64_tsan_rel, v8_mac64_gc_stress_dbg Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533867Reviewed-by:
-
Ben Smith authored
Most of the mjsunit/wasm/table-copy.js tests have been ported to cctests, so they can be tested with all execution tiers. Bug: v8:8965 Change-Id: I448719be30a4b2bddb9e2cffb4c74d3134db2f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529548 Commit-Queue: Ben Smith <binji@chromium.org> Reviewed-by:
-
Sergiy Belozorov authored
The original config will be removed after infra-side change will land and start using new configs. R=machenbach@chromium.org, tmrts@chromium.org Bug: chromium:923304 Change-Id: I5323f0d01724cef2472592bd8e5beb15de232346 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533863Reviewed-by:
-
Cliff Smolinsky authored
V8_libbase.dll, in a component build where the dll is created, statically links against shlwapi.dll. Shlwapi is only needed for a single use within the debug stacktrace code and is therefore not needed in most cases. Statically loading shlwapi also brings in user32.dll and gdi32.dll, so this is a decent perf hit which is generally unnecessary. This changes delayloads shlwapi so that is only loaded when actually used. Bug: v8:9024 Change-Id: Ib8842893a43cde4b1110a333ae07d861088ba829 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533145Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Cliff Smolinsky <cliffsmo@microsoft.com> Cr-Commit-Position: refs/heads/master@{#60394}
-
Santiago Aboy Solanes authored
Said instructions look like ChangeTaggedXXXToCompressedXXX and ChangeCompressedXXXToTaggedXXX for XXX in ("", "Pointer", "Signed"). This change only affects 64 bit architectures (both for x64 and arm64). Also added tests for the machine operators. Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng,v8_linux64_arm64_pointer_compression_rel_ng Bug: v8:8977 Change-Id: I239d9de7f214424852e75b5d56996e8dfdacd400 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1526009 Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:Michael Stanton <mvstanton@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
This is a reland of 477d88a5 Original change's description: > Update V8 DEPS. > > Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/e8b8ab7..9dba2d4 > > Rolling v8/buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/a14f996..a2a4845 > > Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/4e9bccd..bf564e0 > > Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/24b5f90..cf9613f > > Rolling v8/third_party/googletest/src: https://chromium.googlesource.com/external/github.com/google/googletest/+log/efecb0b..8b6d3f9 > > Rolling v8/third_party/icu: https://chromium.googlesource.com/chromium/deps/icu/+log/8c67416..b10cc9f > > Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3dd606a..2116ee9 > > Rolling v8/tools/swarming_client: https://chromium.googlesource.com/infra/luci/client-py/+log/7a61cf3..aa60736 > > TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org > > Change-Id: I333f64ffea36d3925757b7c97f425bfc6334f266 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1529938 > Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> > Cr-Commit-Position: refs/heads/master@{#60366} Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng TBR=tmrts@chromium.org Bug: chromium:943614 Change-Id: Id1d875d9fd2b0022cfdf9ed7c97bea1b611fd05f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533859Reviewed-by:
Tamer Tas <tmrts@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#60392}
-
Igor Sheludko authored
Bug: v8:7703 Change-Id: Ic6cd8b337813ecff2a0d030aa3a57304e784378a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1511486Reviewed-by:
Toon Verwaest <verwaest@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#60391}
-
Igor Sheludko authored
... for decompression because the former is not used by register allocator and therefore always available. Bug: v8:7703 Change-Id: I72d738be69c339444311d75c69f04c104e90bb90 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533857Reviewed-by:
-
Michael Achenbach authored
This adds missing configuration from: https://crrev.com/c/1518245 TBR=tmrts@chromium.org Bug: chromium:943614 Change-Id: I4a21616aa3180e8c1c5a90b21f1678e62ebcf14a Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533837Reviewed-by:
-
Yun Liu authored
Bug: chromium:943614 Change-Id: I42fea5af3fdf040e5091f5342401c5e863e1b67e Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1533152 Commit-Queue: Tamer Tas <tmrts@chromium.org> Reviewed-by:
-
Milad Farazmand authored
Above test passes on simulator but may take up to a few mintues. Test passes normally on native PPC. Change-Id: I89b8feca1f6f0da41a5aff7c004718f0b63f76ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532343Reviewed-by:
-
Mike Stanton authored
Main changes: ContextData class to hold a map of slots to ObjectData for known necessary lookups. LdaGlobal* and StaGlobal now receive an accumulator hint of the constant found at the lookup slot for immutable global context operations. Bug: v8:7790 Change-Id: I63dc9eb8ebbbdfa4ce3b71c6aba63b3c06a3da9b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532074Reviewed-by:Georg Neis <neis@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#60386}
-
Michael Lippautz authored
FixedArray object in LO space are processed incrementally in ranges of slots size kProgressBarScanningChunk to reduce latency when returning to the processing loop is critical. A progress bar stores how much slots have been processed already. In the case of regular concurrent marking there was a guarantee that the object was only processed by one thread (main *or* concurrent marking thread) at the same time. However, some optimizations that avoid write barriers for each individual write operation emit a batched write barrier that requires re-visiting the FixedArray for the marking barrier. In such cases, the progress bar would be reset using relaxed stores which is problematic as the concurrent marking thread could race on setting its own progress on the progress bar. As a result, the array would only be re-scanned partially. The fix involves using CAS to set the progress bar and bail out in the case an inconsistent state was observed. In the following: MT... main thread CM... concurrent marking thread The interesting cases are: 1. MT *or* CM processes the array without interfering: Progress bar is updated monotonically without failing. 3. MT interferes with itself: The progress bar is just reset and the main thread will restart scanning from index 0. The object is added twice to the marking worklist and processed each time one of the entries is retrieved from the worklist. 4. MT interferes with CM: 4.a.: CM processes a range of slots and re-adds the left overs by setting the progress bar and re-adding the array to the worklist. In this case CM *and* MT process the array from index 0. The first time the CAS for setting the progress bar fails on either of the threads, the looser will bail out and leave processing for the winner. 4.b.: CM is interrupted while processing a range of the array and fails in setting the progress bar for the left overs. In this case the CM bails out right away and the main thread starts processing from index 0. In addition, there is a transition from index 0 to the index of the first actual slot. This transition makes it possible to observe a reset while processing the first actual chunk of slots. Bug: chromium:942699 Change-Id: I0b06f47ee075030dadfc959528cd77b6b69bbec2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532325Reviewed-by:
-
Clemens Hammacher authored
This ensures that the actual instructions are in their final form when adding them to the NativeModule. R=titzer@chromium.org Change-Id: Ia20698823e5a18a3c3ef7d2370769b70addfc4e2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532075 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#60384}
-
Pierre Langlois authored
The `compiler-trace-flags.js` test just makes sure the various --trace-turbo* flags do not cause V8 to crash. However, on builds with no snapshot, they would generate a *lot* of output as they were tracing the compiler while generating the snapshot. Let's set the `--trace-turbo-filter` flag to make sure we only trace the test functions. Sadly, WASM functions do not have a name, just an index, so we have to split this test into two. Bug: chromium:943064 Cq-Include-Trybots: luci.v8.try:v8_win_nosnap_shared_rel_ng Change-Id: I30b3935f63d412ab8c96cc5156d342c428229865 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1532078Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Pierre Langlois <pierre.langlois@arm.com> Cr-Commit-Position: refs/heads/master@{#60383}
-
