Skip to content

V
V8
Switch branch/tag
  1. 10 Mar, 2016 1 commit
  3. 01 Mar, 2016 1 commit
    • yangguo's avatar
      [debugger] fix break locations for assignments and return. · d9fe836d
      yangguo authored 
      We used to emit debug break location on block entry. This cannot be
ported to the interpreted as we do not emit bytecode for block entry.
This made no sense to begin with though, but accidentally added
break locations for var declarations.

With this change, the debugger no longer breaks at var declarations
without initialization. This is in accordance with the fact that the
interpreter does not emit bytecode for uninitialized var declarations.

Also fix the bytecode to match full-codegen's behavior wrt return
positions:
- there is a break location before the return statement, with the source
  position of the return statement.
- right before the actual return, there is another break location. The
  source position points to the end of the function.

R=rmcilroy@chromium.org, vogelheim@chromium.org
TBR=rossberg@chromium.org
BUG=v8:4690
LOG=N

Review URL: https://codereview.chromium.org/1744123003

Cr-Commit-Position: refs/heads/master@{#34388}
      d9fe836d
  5. 25 Feb, 2016 1 commit
  7. 22 Feb, 2016 1 commit
  9. 12 Feb, 2016 1 commit
  11. 11 Feb, 2016 1 commit
  13. 10 Feb, 2016 1 commit
  15. 28 Jan, 2016 1 commit
  17. 26 Jan, 2016 1 commit
  19. 21 Jan, 2016 1 commit
  21. 18 Dec, 2015 1 commit
  23. 16 Dec, 2015 2 commits
    • yangguo's avatar
      [debugger] simplify step over recursive function call. · 2bb6e197
      yangguo authored 
      The problem is this: when stepping over a recursive function call,
the recursive function is flooded with one-shot break points so that
we break after the call, but since the callee is the same function,
the callee is also flooded, resulting a break in the callee. That
however would have been a "step in" instead of "step over".

The original solution was to recognize this by comparing FP. If we
end up in Debug::Break, we still have to check the current FP against
the remembered FP to see whether we are on the same stack height.
If we are deeper, then it's not a "step over", and we do not trigger
a debug break event. In that case, we queue up the step-over, and
temporarily step out until we hit the desired stack height. Note that
in order to step out, we flood the caller, which in our example is
the same function as the callee. So we break at every flooded break
location, and comparing with FP to make sure we stepped out prevents
us from triggering debug break events.

The new solution simply ignores breaks when the FP compare fails.
We simply carry on until we hit a break where the FP compare succeeds.
There is no need to do a step out. The number of calls to Debug::Break
that do not trigger a debug break event due to failing FP compare is
the same. But the code is a lot easier to read.

R=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/1527253002

Cr-Commit-Position: refs/heads/master@{#32897}
      2bb6e197
    • yangguo's avatar
      [debugger] remove some dead code. · b68f7e4c
      yangguo authored 
      credits to gcov.

R=cbruni@chromium.org

Review URL: https://codereview.chromium.org/1522273003

Cr-Commit-Position: refs/heads/master@{#32877}
      b68f7e4c
  25. 15 Dec, 2015 2 commits
  27. 04 Dec, 2015 3 commits
  29. 03 Dec, 2015 2 commits
  31. 02 Dec, 2015 1 commit
  33. 01 Dec, 2015 1 commit
  35. 27 Nov, 2015 2 commits
  37. 26 Nov, 2015 3 commits
  39. 25 Nov, 2015 2 commits
  41. 19 Nov, 2015 1 commit
  43. 17 Nov, 2015 1 commit
  45. 02 Nov, 2015 1 commit
  47. 23 Oct, 2015 1 commit
  49. 13 Oct, 2015 1 commit
  51. 30 Sep, 2015 2 commits
  53. 28 Sep, 2015 1 commit
  55. 01 Sep, 2015 1 commit
  57. 20 Aug, 2015 1 commit
  59. 14 Aug, 2015 1 commit