- 07 Sep, 2018 5 commits
-
-
Clemens Hammacher authored
Since https://crrev.com/c/1112003, the memory size is stored as size_t instead of uint32_t in order to support 4GB memories. This CL fixes Liftoff to load and handle that field as ptrsized field instead of 32 bit integer. Drive-by: Fix wrong machine type on Phi in TF wasm compiler. R=titzer@chromium.org Bug: v8:8130 Change-Id: I40a92a2c24f6311e05b5e2608a0902674a2ce411 Reviewed-on: https://chromium-review.googlesource.com/1206008 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Ben Titzer <titzer@chromium.org> Cr-Commit-Position: refs/heads/master@{#55702}
-
Michael Achenbach authored
This is a reland of 8ac91f6c Skips failing tests on gc stress and fixes predictable testing. Original change's description: > [test] Increase coverage of d8_default test suites > > NOTRY=true > > Bug: v8:7285,v8:8140 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 > Reviewed-on: https://chromium-review.googlesource.com/1208496 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55682} Bug: v8:7285, v8:8140, v8:8141 Change-Id: Ia7a437b874d5c8712f6def30382404e527145610 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Cq-Include-Trybots: luci.v8.try:v8_android_arm64_n5x_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux_optional_rel_ng Cq-Include-Trybots: luci.v8.try:v8_linux_gc_stress_dbg Cq-Include-Trybots: luci.v8.try:v8_mac64_gc_stress_dbg Reviewed-on: https://chromium-review.googlesource.com/1209762Reviewed-by:
Sergiy Byelozyorov <sergiyb@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#55701}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: Id459da19e009b2203b12ba04d185dc857e4913c1 Reviewed-on: https://chromium-review.googlesource.com/1209786Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
-
Simon Zünd authored
The functionality of "FillFixedArrayWithSmiZero" got merged into "AllocateZeroedFixedArray", making these calls superfluous. R=jgruber@chromium.org Bug: v8:8015 Change-Id: I5453ea4b16a1446717517fe1676d611d987ad0a3 Reviewed-on: https://chromium-review.googlesource.com/1212842Reviewed-by:
Jakob Gruber <jgruber@chromium.org> Commit-Queue: Simon Zünd <szuend@google.com> Cr-Commit-Position: refs/heads/master@{#55699}
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/ebaffbc..6533d05 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/0f5a0b4..dd2c588 Rolling v8/third_party/instrumented_libraries: https://chromium.googlesource.com/chromium/src/third_party/instrumented_libraries/+log/d8cf40c..a90cbf3 Rolling v8/tools/clang: https://chromium.googlesource.com/chromium/src/tools/clang/+log/3aa6139..e9dadb9 TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: I2a894bf58f4c42036bbfa48b738479229a082426 Reviewed-on: https://chromium-review.googlesource.com/1212523 Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#55698}
-
- 06 Sep, 2018 30 commits
-
-
Igor Sheludko authored
... broken in https://chromium-review.googlesource.com/c/v8/v8/+/1209343 Change-Id: If2d630276530dc8d85de7d17e561f703937f4988 Reviewed-on: https://chromium-review.googlesource.com/1210922Reviewed-by:
Stephan Herhut <herhut@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55697}
-
Bill Budge authored
- Removes workarounds in test-run-native_calls for ARM and adds ARM 32-bit aliasing-aware register allocation. - Uses wasm::LinkageAllocator instead of custom allocator to avoid duplication of this logic. - Fixes a problem in wasm::LinkageAllocator with high 16 VFP regs, and makes member variable naming consistent. Bug: v8:8015 Change-Id: Ie8bb8bad06bebce2cef3da0f6ad5c59d5f3b3b36 Reviewed-on: https://chromium-review.googlesource.com/1199907Reviewed-by:
Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#55696}
-
Clemens Hammacher authored
These methods were deprecated in 7.0, now we can remove them. R=adamk@chromium.org Bug: v8:7868 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I60badb378a055152bdd27aed67d11ddf74fce174 Reviewed-on: https://chromium-review.googlesource.com/1209283Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55695}
-
Michael Lippautz authored
Previously explicit calls to external memory adjustment could yield in lowering the limit below the initial default limit. The consequence is repeated useless garbage collections when e.g. passing around ArrayBuffers. Bug: chromium:880036 Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Change-Id: I429f5adcd9ae523e5ac7621cf7976686b0dec71b Reviewed-on: https://chromium-review.googlesource.com/1209784Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#55694}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I6b1283f893944ca45ff7816d51e0c7fb26c8a8e1 Reviewed-on: https://chromium-review.googlesource.com/1209785Reviewed-by:
-
Igor Sheludko authored
This CL adds CheckRange() which will be used in DCHECKs in BoundedPageAllocator and renames "min_region_size" to "page_size" for better readability. Bug: v8:8096 Change-Id: I62cf7a92e50d0a11d462a9fbc34ddc5eda5456e1 Reviewed-on: https://chromium-review.googlesource.com/1209284Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#55692}
-
Florian Sattler authored
Bug: v8:8015 Change-Id: Ice0c5994ff5695c06be307c3e37d90daf14c643c Reviewed-on: https://chromium-review.googlesource.com/1209763 Commit-Queue: Florian Sattler <sattlerf@google.com> Reviewed-by:
Tobias Tebbi <tebbi@chromium.org> Cr-Commit-Position: refs/heads/master@{#55691}
-
Igor Sheludko authored
... like AllocatePage[s](), FreePages() and SetPermissions(). This CL also changes base::PageAllocator to cache AllocatePageSize and CommitPageSize values returned by the OS. This is a necessary cleanup before introducing BoundedPageAllocator. Bug: v8:8096 Change-Id: Ifb7cdd2caa6a1b029ce0fca6545c61df9d281be2 Reviewed-on: https://chromium-review.googlesource.com/1209343Reviewed-by:
-
Clemens Hammacher authored
If a web worker terminates while a wasm finisher task is scheduled, we try to cancel that task even though the platform already deleted it. This results in UBSan failures, ASan failures or crashes. This CL fixes this by deregistering the foreground task when it is deleted before being executed. A layout test for this will be added to chromium in https://crrev.com/c/1209602. R=ahaas@chromium.org Bug: chromium:875579 Change-Id: Icae43a9dcc6dc16c872851961894bf8bc0872de8 Reviewed-on: https://chromium-review.googlesource.com/1209344 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#55689}
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: I681dbe1bc115f284994d9ecdb0d2061aed1dbb5e Reviewed-on: https://chromium-review.googlesource.com/1208514Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5367 Change-Id: Id3c2075e3c0a8f9b81a9c6b5f0578b6ecfa58001 Reviewed-on: https://chromium-review.googlesource.com/1205834Reviewed-by:
Georg Neis <neis@chromium.org> Reviewed-by:
-
Simon Zünd authored
Also changes occurrences of 'length' with kLengthString. R=mvstanton@chromium.org Bug: v8:8015 Change-Id: Ida205a7d69939d7d3473e1ab8e82d0cdba4c8668 Reviewed-on: https://chromium-review.googlesource.com/1209302Reviewed-by:
-
Florian Sattler authored
Bug: v8:8015 Change-Id: I7f63989a897857c2258ec2bee59aed6100bc689e Reviewed-on: https://chromium-review.googlesource.com/1209346Reviewed-by:
-
Yang Guo authored
R=machenbach@chromium.org Change-Id: I59a373d838678ec8659a3014e5e3184e5c2d5c12 Reviewed-on: https://chromium-review.googlesource.com/1209462Reviewed-by:
Michael Achenbach <machenbach@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#55684}
-
Michael Achenbach authored
This reverts commit 8ac91f6c. Reason for revert: Some actual failures on Mac and debugger: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20GC%20Stress/2914 Failing message tests need to be skipped for predictable testing: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20predictable/18967 Original change's description: > [test] Increase coverage of d8_default test suites > > NOTRY=true > > Bug: v8:7285,v8:8140 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 > Reviewed-on: https://chromium-review.googlesource.com/1208496 > Commit-Queue: Michael Achenbach <machenbach@chromium.org> > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> > Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55682} TBR=rmcilroy@chromium.org,machenbach@chromium.org,sergiyb@chromium.org Change-Id: I701abe28317028acbf65769674f15517020d3496 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7285, v8:8140 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1209347Reviewed-by:
-
Michael Achenbach authored
NOTRY=true Bug: v8:7285,v8:8140 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I9cb216de302bc787189f8f12f5b254909b0f5773 Reviewed-on: https://chromium-review.googlesource.com/1208496 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
-
Michael Stanton authored
This reverts commit 34625fdb. Reason for revert: Test caused timeout, investigating. Original change's description: > [Builtins] Array.prototype.forEach perf regression on dictionaries. > > An unnecessary call to ToString() on the array index caused trips to > the runtime. The fix also includes performance micro-benchmarks so > we'll have a harder time regressing this case in future. > > Bug: v8:8112 > Change-Id: Iada5bd2e3c6d2246fb1225e7094f3d9c66ddafbd > Reviewed-on: https://chromium-review.googlesource.com/1206355 > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55653} TBR=mvstanton@chromium.org,tebbi@chromium.org Change-Id: I21de9b9b33edf03f2173f579c4ba0fc3dfd8ff88 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8112 Reviewed-on: https://chromium-review.googlesource.com/1209288Reviewed-by:
Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#55681}
-
Michael Achenbach authored
NOTRY=true TBR=yangguo@chromium.org,mvstanton@chromium.org Change-Id: I8e558509dc324aa5efe1ccb09cb9959eaabc5720 Reviewed-on: https://chromium-review.googlesource.com/1209303Reviewed-by:
-
Michael Starzinger authored
This adds the ability to add exception types to the export section of a module and reference them via the local exception index. Currently the export object then just contains the local index as a number, which is only temporary until we have proper export wrappers for exceptions. Also note that this tightens the restriction for the modules exception section to be located in between the import and the export section. R=clemensh@chromium.org TEST=mjsunit/wasm/exceptions-export BUG=v8:8091 Change-Id: Ie26081c3f94e71cb576057db7e45ec5bd0e112f9 Reviewed-on: https://chromium-review.googlesource.com/1206873 Commit-Queue: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by:
Clemens Hammacher <clemensh@chromium.org> Cr-Commit-Position: refs/heads/master@{#55679}
-
Simon Zünd authored
Some helpers in array.js are now dead code after the recent changes to array builtins (splice/unshift). R=jgruber@chromium.org Bug: v8:8015 Change-Id: I3e0c0280516b539533bcc3b21d84e448112e4ec7 Reviewed-on: https://chromium-review.googlesource.com/1208632Reviewed-by:
-
Daniel Bratell authored
In jumbo builds, many files are compiled in the same translation unit and share the same anonymous namespace. Now both gap_resolver.cc and register-allocator.cc defined kFloat32Bit (a mask representation of MachineRepresentation::kFloat32) which clashed if those files were compiled together. This patch inlines and removed one of the constants. Change-Id: Ic79e077e62ce9866b6201ec61a9df1e66d5e4a13 Reviewed-on: https://chromium-review.googlesource.com/1206572Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#55677}
-
Michael Achenbach authored
This optional trybot runs all tests not run by the CQ bot, but run by the CI release or debug bot. TBR=sergiyb@chromium.org NOTRY=true Bug: v8:7285 Change-Id: Ifda294448ba92b8055a633ef1e26b4045a38f718 Reviewed-on: https://chromium-review.googlesource.com/1207852 Commit-Queue: Michael Achenbach <machenbach@chromium.org> Reviewed-by:
-
Yang Guo authored
We use signed comparison when we compare the difference between SP and stack limit to the size we are going to push, but need to use unsigned comparison when we compare SP and stack limit directly. R=mvstanton@chromium.org Bug: chromium:876210 Change-Id: I3ca5233677c42aebadb78920592a7c6d8e33a825 Reviewed-on: https://chromium-review.googlesource.com/1206870Reviewed-by:
-
Michael Achenbach authored
Bug: chromium:866862 Change-Id: Ib6c89d88344c2348de155fd54eafa03cf18ea88d Reviewed-on: https://chromium-review.googlesource.com/1206631Reviewed-by:
-
Yutaka Hirano authored
Currently, neither IsSharedCrossOrigin nor IsOpaque is set for an empty script. Hence an exception thrown from it (e.g., an exception thrown from native promise implementation) is treated as an error with blink::kNotSharableCrossOrigin. On the other hand, as the script is empty, there is no meaningful URL attached, which means the ExecutionContext's URL is used as the script's name in blink::SourceLocation::FromMessage. In other words, it works virtually as same as blink::kSharableCrossOrigin corresponding to ScriptOriginOptions with IsSharedCrossOrigin set and IsOpaque unset. With this CL, a ScriptOriginOptions with IsSharedCrossOrigin is set and IsOpaque is not set is attached to the empty script, as a preliminary step to deprecate kNotSharableCrossOrigin. Bug: chromium:875153,chromium:876248 Change-Id: I39279a43994337329b8bd9d28b6ca29f0ac30d9c Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1201689Reviewed-by:
-
v8-ci-autoroll-builder authored
Rolling v8/build: https://chromium.googlesource.com/chromium/src/build/+log/4ca6fa3..ebaffbc Rolling v8/third_party/catapult: https://chromium.googlesource.com/catapult/+log/70783e3..bcc3e49 Rolling v8/third_party/depot_tools: https://chromium.googlesource.com/chromium/tools/depot_tools/+log/f215ae6..0f5a0b4 Rolling v8/third_party/fuchsia-sdk: https://chromium.googlesource.com/chromium/src/third_party/fuchsia-sdk/+log/e0c4613..0953bbd TBR=machenbach@chromium.org,hablich@chromium.org,sergiyb@chromium.org Change-Id: Ic41cdb4c6db298364c6adf399d49ddc8e0e8c787 Reviewed-on: https://chromium-review.googlesource.com/1208304Reviewed-by:
-
Sathya Gunasekaran authored
Bug: v8:5751, chromium:881021 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I22514ceb5fb0953b728e67ba5266926e912ce9c1 Reviewed-on: https://chromium-review.googlesource.com/1208516Reviewed-by:
-
Simon Zünd authored
This CL implements a generic baseline version of Array.p.unshift in Torque, enabling us to remove the JS fall-back. The elements-accessor fast-path is still used, but the check whether to use it is also moved to Torque. Support for sparse JSArrays is removed. Drive-by change: Small refactoring in builtins-array that will get extended to other array builtins in a follow-up CL. R=cbruni@chromium.org, jgruber@chromium.org Bug: v8:7624 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7b23ce15e7b922eb333f61a408050dedec77c95a Reviewed-on: https://chromium-review.googlesource.com/1189902 Commit-Queue: Simon Zünd <szuend@google.com> Reviewed-by:
Camillo Bruni <cbruni@chromium.org> Reviewed-by:
-
Yang Guo authored
This reverts commit f2c943fa. Reason for revert: Non-flaky failures here: https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/20374 Original change's description: > [intl] Port collator#resolvedOptions to C++ > > Bug: v8:5751 > Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng > Change-Id: I236dd3a1b5390911a6c668201aec33e7db1cbd53 > Reviewed-on: https://chromium-review.googlesource.com/1208650 > Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Cr-Commit-Position: refs/heads/master@{#55668} TBR=yangguo@chromium.org,gsathya@chromium.org,usharma1998@gmail.com Change-Id: I018815ec7e3e692cc76a25590c2197a6cf37cc37 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Reviewed-on: https://chromium-review.googlesource.com/1208571Reviewed-by:
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I236dd3a1b5390911a6c668201aec33e7db1cbd53 Reviewed-on: https://chromium-review.googlesource.com/1208650 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#55668}
-
- 05 Sep, 2018 5 commits
-
-
Sathya Gunasekaran authored
Bug: v8:7834 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: Ie66f443b86d3cf7bd64cc338d84231045ca5e3c6 Reviewed-on: https://chromium-review.googlesource.com/1208517Reviewed-by:
-
Deepti Gandluri authored
BUG: v8:6532, chromium:874809 Change-Id: I55c00e8563741908cf0daf263152ce927ae18e7c Reviewed-on: https://chromium-review.googlesource.com/1205812 Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Reviewed-by:
Ben Smith <binji@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Bug: v8:5751 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I7b126a318480c0d35d6440aa7aea109529ea8ee2 Reviewed-on: https://chromium-review.googlesource.com/1208651 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Sathya Gunasekaran authored
Previously in the JS implementation, this would throw (on property access) but this new behavior is more in line with how all the other intl objects work. Bug: v8:5751, chromium:880697 Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng Change-Id: I0bd073b2a0a6fc1eacd686083d8f1a72252cea53 Reviewed-on: https://chromium-review.googlesource.com/1207579 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
Ujjwal Sharma authored
Bug: v8:5751 Change-Id: I978b5b1da41040132204b64dde3f44985b44255d Reviewed-on: https://chromium-review.googlesource.com/1208110 Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by:
-
