• Yutaka Hirano's avatar
    Use ScriptOriginOptions with IsSharedCrossOrigin set for empty script · c4bffcd5
    Yutaka Hirano authored
    Currently, neither IsSharedCrossOrigin nor IsOpaque is set for an empty
    script. Hence an exception thrown from it (e.g., an exception thrown
    from native promise implementation) is treated as an error with
    blink::kNotSharableCrossOrigin. On the other hand, as the script is
    empty, there is no meaningful URL attached, which means the
    ExecutionContext's URL is used as the script's name in
    blink::SourceLocation::FromMessage. In other words, it works virtually
    as same as blink::kSharableCrossOrigin corresponding to
    ScriptOriginOptions with IsSharedCrossOrigin set and IsOpaque unset.
    
    With this CL, a ScriptOriginOptions with IsSharedCrossOrigin is set
    and IsOpaque is not set is attached to the empty script, as a
    preliminary step to deprecate kNotSharableCrossOrigin.
    
    Bug: chromium:875153,chromium:876248
    Change-Id: I39279a43994337329b8bd9d28b6ca29f0ac30d9c
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/1201689Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55673}
    c4bffcd5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...