- 25 Feb, 2019 4 commits
-
-
Caitlin Potter authored
Turns --harmony-hashbang on by default. Intent to ship: https://groups.google.com/d/msg/v8-dev/hlCVa_XZ3TM/UWjjyOq3FwAJ ChromeStatus page: https://www.chromestatus.com/feature/5134505706782720 BUG=v8:8523 R=gsathya@chromium.org, mathias@chromium.org, adamk@chromium.org Change-Id: I821f69e45eb0a63a3f49181e2b88b0bcd091af2c Reviewed-on: https://chromium-review.googlesource.com/c/1486113Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Caitlin Potter <caitp@igalia.com> Cr-Commit-Position: refs/heads/master@{#59847}
-
Frank Tang authored
This is a reland of f1b21a10 Original change's description: > [Intl] Ship Intl.Locale > > Bug: v8:7684 > Change-Id: I5994c3fc4b97c4322c4e0cf20305da75e66efd5a > Reviewed-on: https://chromium-review.googlesource.com/c/1478220 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59780} Bug: v8:7684 Change-Id: I4f73205398a9649e2f55a1b090cd3afffade68c4 Reviewed-on: https://chromium-review.googlesource.com/c/1480918Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#59845}
-
Benedikt Meurer authored
When calling a known function from optimized code, where the number of actual arguments does not match the number of expected arguments, TurboFan has to call indirectly via the arguments adaptor trampoline, which creates an argument adaptor frame underneath the activation record for the callee. This is done so that the callee can still get to the actual arguments, using either 1. the arguments object, or 2. rest parameters (to get to superfluous arguments), or 3. the non-standard Function.arguments accessor (for sloppy mode functions), or 4. direct eval(), where we don't know whether there's a use of the arguments object hiding somewhere in the string. However going through the arguments adaptor trampoline is quite expensive usually, it seems to be responsible for over 60% of the call overhead in those cases. So this adds a fast path for the case of calling strict mode functions where we have an arguments mismatch, but where we are sure that the callee cannot observe the actual arguments. We use a bit on the SharedFunctionInfo to indicate that this is safe, which is controlled by hints from the Parser which knows whether the callee uses either arguments object or rest parameters. In those cases we use a direct call from optimized code, passing the expected arguments instead of the actual arguments. This improves the benchmark on the document below by around 60-65%, which is exactly the overhead of the arguments adaptor trampoline that we save in this case. This also adds a runtime flag --fast_calls_with_arguments_mismatches, which can be used to turn off the new behavior. This might be handy for checking the performance impact via Finch. Bug: v8:8895 Change-Id: Idea51dba7ee6cb989e86e0742eaf3516e5afe3c4 Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Doc: http://bit.ly/v8-faster-calls-with-arguments-mismatch Reviewed-on: https://chromium-review.googlesource.com/c/1482735 Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59825}
-
Jakob Gruber authored
Field representation tracking is only used by TurboFan. Bug: v8:7777 Change-Id: I0d930f8dc0b68ff030111f12092b183c4c257ac6 Reviewed-on: https://chromium-review.googlesource.com/c/1481218 Commit-Queue: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Igor Sheludko <ishell@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59820}
-
- 22 Feb, 2019 2 commits
-
-
Deepti Gandluri authored
This reverts commit 4950dec7. Reason for revert: Breaks on stress_background_compile variant https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8920804687849034208/+/steps/Mjsunit/0/logs/number-divide/0 Original change's description: > Temporarily unship constant field tracking > > This is to get better handle on improvements and regressions. > > Bug: v8:8361, chromium:930680 > Change-Id: I2963b55f3480036ada885267a277a95d24a67656 > Reviewed-on: https://chromium-review.googlesource.com/c/1482737 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59800} TBR=jarin@chromium.org,ishell@chromium.org Change-Id: Ibf38c9cb2bf0921b7d93972a1e6cdd4c3d57c592 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8361, chromium:930680 Reviewed-on: https://chromium-review.googlesource.com/c/1483610Reviewed-by: Deepti Gandluri <gdeepti@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#59801}
-
Jaroslav Sevcik authored
This is to get better handle on improvements and regressions. Bug: v8:8361, chromium:930680 Change-Id: I2963b55f3480036ada885267a277a95d24a67656 Reviewed-on: https://chromium-review.googlesource.com/c/1482737Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59800}
-
- 21 Feb, 2019 4 commits
-
-
Sathya Gunasekaran authored
This reverts commit f1b21a10. Reason for revert: breaks https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/24373 Original change's description: > [Intl] Ship Intl.Locale > > Bug: v8:7684 > Change-Id: I5994c3fc4b97c4322c4e0cf20305da75e66efd5a > Reviewed-on: https://chromium-review.googlesource.com/c/1478220 > Reviewed-by: Adam Klein <adamk@chromium.org> > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59780} TBR=adamk@chromium.org,gsathya@chromium.org,ftang@chromium.org Change-Id: I7ae570d3cd0dd62f2b1a37c43b7f8b9ca51d7a5b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7684 Reviewed-on: https://chromium-review.googlesource.com/c/1481901Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#59782}
-
Frank Tang authored
Bug: v8:7684 Change-Id: I5994c3fc4b97c4322c4e0cf20305da75e66efd5a Reviewed-on: https://chromium-review.googlesource.com/c/1478220Reviewed-by: Adam Klein <adamk@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59780}
-
Sathya Gunasekaran authored
Bug: v8:5368 Change-Id: I0d33076f8e9d31e07535b28f783e33cd24b946ad Reviewed-on: https://chromium-review.googlesource.com/c/1481024Reviewed-by: Mathias Bynens <mathias@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Commit-Queue: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#59779}
-
Stephan Herhut authored
This change adds two spilling modes: SpillAtDefinition and SpillDeferred. The former is the known spilling mode where we spill at definition. The latter spills only in deferred code regions. This is implemented based on control flow aware allocation and its invariants. The effect is mostly the same as splintering with the exception of forward looking allocation decisions still being impacted by register constraints in deferred code. Change-Id: Ia708e5765dd095196a8127deb2d8bec950d37e04 Reviewed-on: https://chromium-review.googlesource.com/c/1437118Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Stephan Herhut <herhut@chromium.org> Cr-Commit-Position: refs/heads/master@{#59759}
-
- 20 Feb, 2019 1 commit
-
-
Frank Tang authored
Bug: v8:7684 Change-Id: I27586a06816863c71fc69342e8b4721ac0c32a0a Reviewed-on: https://chromium-review.googlesource.com/c/1476293 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Cr-Commit-Position: refs/heads/master@{#59712}
-
- 19 Feb, 2019 6 commits
-
-
Ulan Degenbaev authored
This is a reland of 932a5ca8 Original change's description: > [heap] Enable large objects in young generation > > Bug: chromium:852420 > Change-Id: Id1cde3450c5ca046029b17eee5dbe5132f299c3d > Reviewed-on: https://chromium-review.googlesource.com/c/1477212 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59669} Bug: chromium:852420 Change-Id: If6dc439e410542da72c3edc08c9926b3edd1186e Reviewed-on: https://chromium-review.googlesource.com/c/1477736Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59701}
-
Dan Elphick authored
Also disables tests in Lite mode that currently fail with lazy source positions. Bug: v8:8510 Change-Id: Id27b7cb31682559173b137ef51eaf06d517ee9ec Reviewed-on: https://chromium-review.googlesource.com/c/1477129 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59700}
-
Ulan Degenbaev authored
This reverts commit d74840b7. Reason for revert: breaks stress sampling profiler Original change's description: > Reland "[heap] Enable large objects in young generation" > > This is a reland of 932a5ca8 > > The GC stress failure was caused by v8:8801 > > Original change's description: > > [heap] Enable large objects in young generation > > > > Bug: chromium:852420 > > Change-Id: Id1cde3450c5ca046029b17eee5dbe5132f299c3d > > Reviewed-on: https://chromium-review.googlesource.com/c/1477212 > > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#59669} > > Bug: chromium:852420 > Change-Id: I1fd28869f21715798fe49508efb7f3a622803ffc > Reviewed-on: https://chromium-review.googlesource.com/c/1477218 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Reviewed-by: Hannes Payer <hpayer@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59683} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: Ieb81de35df1ccb9ef5c6d59c13f34ba294b848ed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/c/1477732Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59690}
-
Ulan Degenbaev authored
This is a reland of 932a5ca8 The GC stress failure was caused by v8:8801 Original change's description: > [heap] Enable large objects in young generation > > Bug: chromium:852420 > Change-Id: Id1cde3450c5ca046029b17eee5dbe5132f299c3d > Reviewed-on: https://chromium-review.googlesource.com/c/1477212 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59669} Bug: chromium:852420 Change-Id: I1fd28869f21715798fe49508efb7f3a622803ffc Reviewed-on: https://chromium-review.googlesource.com/c/1477218Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Reviewed-by: Hannes Payer <hpayer@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59683}
-
Ulan Degenbaev authored
This reverts commit 932a5ca8. Reason for revert: breaks GC stress Original change's description: > [heap] Enable large objects in young generation > > Bug: chromium:852420 > Change-Id: Id1cde3450c5ca046029b17eee5dbe5132f299c3d > Reviewed-on: https://chromium-review.googlesource.com/c/1477212 > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Ulan Degenbaev <ulan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59669} TBR=ulan@chromium.org,hpayer@chromium.org,mlippautz@chromium.org Change-Id: I16f0705cf37fdc1708c605abd76d79dac3f1e825 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:852420 Reviewed-on: https://chromium-review.googlesource.com/c/1477278Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59672}
-
Ulan Degenbaev authored
Bug: chromium:852420 Change-Id: Id1cde3450c5ca046029b17eee5dbe5132f299c3d Reviewed-on: https://chromium-review.googlesource.com/c/1477212Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59669}
-
- 18 Feb, 2019 3 commits
-
-
Ulan Degenbaev authored
Bug: chromium:933107 Change-Id: Ie3a485447f96228d5c8d7fc169c9aabf8ccf6599 Reviewed-on: https://chromium-review.googlesource.com/c/1477057Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#59658}
-
Mike Stanton authored
Reason for revert/reland: UBSan complained of unaligned reads. To improve the Torque debugging experience, we can add source positions for each line. This information is carried through the generated CSA code (in <output directory>/gen/torque-generated/*.cc) and embedded as SourcePositions in the Code object. At snapshot time, these SourcePositions are stripped from the Code object and turned into platform-appropriate line number debug information. At this time on Linux, you'll need to build with "is_clang=false" in order to use GCC, because crucial steps are missing in Clang's ability to convey the information into the binary successfully. This CL also introduces a flag to control the existing source information in CSA code. --enable-source-at-csa-bind is now set to false by default because it's a bit confusing to "hop" between source lines in .TQ files and in .CC files. I expect to continue making adjustments there, as I want to provide helpful debugging aids at the CSA level as well as the Torque level. The current configuration prioritizes Torque. TBR=tebbi@chromium.org Bug: v8:8418 Change-Id: Idb80467d3679ec2361386fe9b67597b93d7f72cf Reviewed-on: https://chromium-review.googlesource.com/c/1475763Reviewed-by: Michael Stanton <mvstanton@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59657}
-
Jakob Gruber authored
Correctness fuzzers need the global object to have a consistent shape across build configs. Bug: chromium:932877,chromium:932656,v8:7777 Change-Id: Id4e1251e50965b822bc4ef36c5ae2777864273d5 Reviewed-on: https://chromium-review.googlesource.com/c/1475768Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59654}
-
- 15 Feb, 2019 3 commits
-
-
Michael Stanton authored
This reverts commit 0a24e67a. Reason for revert: Broke Linux 64 UBSan build with unaligned read in the snapshot. Will investigate... Original change's description: > [Torque] Add source positions for Torque files > > To improve the Torque debugging experience, we can add source positions > for each line. This information is carried through the generated > CSA code (in <output directory>/gen/torque-generated/*.cc) and > embedded as SourcePositions in the Code object. > > At snapshot time, these SourcePositions are stripped from the Code > object and turned into platform-appropriate line number debug > information. > > At this time on Linux, you'll need to build with "is_clang=false" > in order to use GCC, because crucial steps are missing in Clang's > ability to convey the information into the binary successfully. > > This CL also introduces a flag to control the existing source > information in CSA code. --enable-source-at-csa-bind is now set > to false by default because it's a bit confusing to "hop" between > source lines in .TQ files and in .CC files. I expect to continue > making adjustments there, as I want to provide helpful > debugging aids at the CSA level as well as the Torque level. > The current configuration prioritizes Torque. > > A detailed guide on usage to follow (also on v8.dev). > > Bug: v8:8418 > Change-Id: Ib4226877ce4cae451bb4d0c546927e89f4e66b58 > Reviewed-on: https://chromium-review.googlesource.com/c/1475473 > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Commit-Queue: Michael Stanton <mvstanton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59636} TBR=mvstanton@chromium.org,tebbi@chromium.org Change-Id: I4ccf94dfdb8b2ba238a60db9ecc8e3ceebef2699 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8418 Reviewed-on: https://chromium-review.googlesource.com/c/1475757Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59637}
-
Mike Stanton authored
To improve the Torque debugging experience, we can add source positions for each line. This information is carried through the generated CSA code (in <output directory>/gen/torque-generated/*.cc) and embedded as SourcePositions in the Code object. At snapshot time, these SourcePositions are stripped from the Code object and turned into platform-appropriate line number debug information. At this time on Linux, you'll need to build with "is_clang=false" in order to use GCC, because crucial steps are missing in Clang's ability to convey the information into the binary successfully. This CL also introduces a flag to control the existing source information in CSA code. --enable-source-at-csa-bind is now set to false by default because it's a bit confusing to "hop" between source lines in .TQ files and in .CC files. I expect to continue making adjustments there, as I want to provide helpful debugging aids at the CSA level as well as the Torque level. The current configuration prioritizes Torque. A detailed guide on usage to follow (also on v8.dev). Bug: v8:8418 Change-Id: Ib4226877ce4cae451bb4d0c546927e89f4e66b58 Reviewed-on: https://chromium-review.googlesource.com/c/1475473Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Michael Stanton <mvstanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#59636}
-
Tobias Tebbi authored
To address previously observed regressions, this CL also introduces unchecked FixedArray accessors and uses them to access collections. Bug: v8:8029 Change-Id: I6bcd8db2b89b29b7acb3b8431ec5405b737bcef2 Reviewed-on: https://chromium-review.googlesource.com/c/1473033 Commit-Queue: Tobias Tebbi <tebbi@chromium.org> Reviewed-by: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59631}
-
- 14 Feb, 2019 3 commits
-
-
Frank Tang authored
Part 2 after part 1 removed flags from all tests. Bug: v8:8705 Change-Id: Id2e299cc574228548460a562496d7905b834dc6b Reviewed-on: https://chromium-review.googlesource.com/c/1461800 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59611}
-
Dan Elphick authored
If enable_omit_source_positions is true (defaults to false), source position tables are not generated when compiling bytecode. They will then be regenerated when exceptions are thrown. This adds a new function Compiler::CollectSourcePositions which given a SharedFunctionInfo with bytecode but no source position table re-parses and regenerates the bytecode but this time with source positions collection enabled. Note this will reparse all inner functions that have previously been compiled since the preparse data is no longer available. With the flag enabled there still 18 test failures mostly related to debugging. v8: 8510 Change-Id: I46dff9818d8a89c901ba8ae8df94dcaca83aa658 Reviewed-on: https://chromium-review.googlesource.com/c/1385165 Commit-Queue: Dan Elphick <delphick@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Ulan Degenbaev <ulan@chromium.org> Reviewed-by: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#59595}
-
Mathias Bynens authored
It shipped in Chrome 70. Bug: v8:7807, v8:8562 Change-Id: I5c5a9fc23656018ee6e9115af7a0c779230e681b Reviewed-on: https://chromium-review.googlesource.com/c/1450787 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Adam Klein <adamk@chromium.org> Cr-Commit-Position: refs/heads/master@{#59589}
-
- 13 Feb, 2019 3 commits
-
-
Jakob Gruber authored
This is a reland of c79a63e6 Original change's description: > [nojit] Don't expose wasm in jitless mode > > Wasm currently still creates executable memory even in > interpreter-only mode, and is thus unsupported in jitless mode. This > hides wasm completely, which will help e.g. fuzzers that attempt to > run wasm code (and currently crash on the CHECK in AddOwnedCode). > > Bug: v8:7777,chromium:931068 > Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8 > Reviewed-on: https://chromium-review.googlesource.com/c/1470124 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59561} Tbr: mstarzinger@chromium.org Bug: v8:7777, chromium:931068 Change-Id: I535c3f598c90cd5c4072a73544cc33c5bf5460c1 Reviewed-on: https://chromium-review.googlesource.com/c/1470132Reviewed-by: Jakob Gruber <jgruber@chromium.org> Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59571}
-
Jakob Gruber authored
This reverts commit c79a63e6. Reason for revert: Needs addtl test skips: https://chromium-review.googlesource.com/c/1470124 Original change's description: > [nojit] Don't expose wasm in jitless mode > > Wasm currently still creates executable memory even in > interpreter-only mode, and is thus unsupported in jitless mode. This > hides wasm completely, which will help e.g. fuzzers that attempt to > run wasm code (and currently crash on the CHECK in AddOwnedCode). > > Bug: v8:7777,chromium:931068 > Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8 > Reviewed-on: https://chromium-review.googlesource.com/c/1470124 > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> > Commit-Queue: Jakob Gruber <jgruber@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59561} TBR=mstarzinger@chromium.org,jgruber@chromium.org Change-Id: Ic242db3efe73ef362e0f0c3efde90682db6de4a8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:7777, chromium:931068 Reviewed-on: https://chromium-review.googlesource.com/c/1470131Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59570}
-
Jakob Gruber authored
Wasm currently still creates executable memory even in interpreter-only mode, and is thus unsupported in jitless mode. This hides wasm completely, which will help e.g. fuzzers that attempt to run wasm code (and currently crash on the CHECK in AddOwnedCode). Bug: v8:7777,chromium:931068 Change-Id: Iee692cb947d482ba16fb0f4da32490d42d5daef8 Reviewed-on: https://chromium-review.googlesource.com/c/1470124Reviewed-by: Michael Starzinger <mstarzinger@chromium.org> Commit-Queue: Jakob Gruber <jgruber@chromium.org> Cr-Commit-Position: refs/heads/master@{#59561}
-
- 08 Feb, 2019 4 commits
-
-
Frank Tang authored
This is a reland of 048a3a3e Original change's description: > [Intl] Cleans up intl-relative-time-format flag > > Cleans up always=true intl-relative-time-format flag > It shipped in m71 in Dec 2018. > > Bug: v8:8704 > Change-Id: I52d86aea9aedf201a216a1df0773a486fbee37b9 > Reviewed-on: https://chromium-review.googlesource.com/c/1417299 > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> > Commit-Queue: Frank Tang <ftang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58904} Bug: v8:8704 Change-Id: I0b3c58b89a81200e9ac8303494317d21d8936319 Reviewed-on: https://chromium-review.googlesource.com/c/1420360Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Commit-Queue: Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#59475}
-
Toon Verwaest authored
--parse-only only invokes the parser but does not compile / run the scripts --max-lazy ignores eager compilation hints from IIFE. Change-Id: Icd156cab16d796b9f676b95bb1542ad07c67546d Reviewed-on: https://chromium-review.googlesource.com/c/1460939 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Leszek Swirski <leszeks@chromium.org> Cr-Commit-Position: refs/heads/master@{#59469}
-
Toon Verwaest authored
Change-Id: Iad53e1a3b6ef0148dc5aa9c5c04c25c446dcdfa2 Reviewed-on: https://chromium-review.googlesource.com/c/1460468Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/master@{#59464}
-
Matheus Marchini authored
This is a reland of 97628eee. Original change's description: > [error] extend error stack w/ function parameters > > Extend FrameArray to hold weak references to parameters forfunctions in > the call stack. The goal here is to provide more metadata for postmortem > tools (such as llnode), especially in cases of rethrowing (this will be > particularly useful when using postmortem with promises on Node.js). > > Besides postmortem, these changes allow us to print a more detailed > stack trace for errors with parameters types (or even values), which can > be useful since JavaScript functions can receive any number of > parameters of any type, and having a function behave differently > according to the number of parameters received as well as their types is > a common pattern on JS libraries and frameworks. > > R=<U+200B>bmeurer@google.com, yangguo@google.com > > Change-Id: Idf0984d0dbac16041f11d738d4b1c095a8eecd61 > Reviewed-on: https://chromium-review.googlesource.com/c/1289489 > Commit-Queue: Yang Guo <yangguo@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#58468} R=bmeurer@google.com, jkummerow@chromium.org, yangguo@google.com Change-Id: I53d90bb862d9c5e9541116b375fa4de70e3e76dd Reviewed-on: https://chromium-review.googlesource.com/c/1405568 Commit-Queue: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#59458}
-
- 07 Feb, 2019 1 commit
-
-
Jaroslav Sevcik authored
This is a reland of 78ed0e3f The breakage was unrelated to constant field tracking (see the linked bugs). Original change's description: > Ship constant field tracking > > Bug: v8:8361 > Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a > Reviewed-on: https://chromium-review.googlesource.com/c/1456089 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59415} Bug: v8:8361, v8:8799, v8:8801 Change-Id: I318768b925f3efd285cb27aa93e6de35fdcced42 Reviewed-on: https://chromium-review.googlesource.com/c/1458238Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59440}
-
- 06 Feb, 2019 3 commits
-
-
Sigurd Schneider authored
This reverts commit 78ed0e3f. Reason for revert: Weird breakage on https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/24063 Two tests should not run on GC stress, but this one is really curious: https://logs.chromium.org/logs/v8/buildbucket/cr-buildbucket.appspot.com/8922258236346866528/+/steps/Mjsunit/0/logs/templates/0 Original change's description: > Ship constant field tracking > > Bug: v8:8361 > Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a > Reviewed-on: https://chromium-review.googlesource.com/c/1456089 > Reviewed-by: Igor Sheludko <ishell@chromium.org> > Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#59415} TBR=jarin@chromium.org,ishell@chromium.org Change-Id: I0017230c840f4ab712852ba338f0119503688ec9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: v8:8361 Reviewed-on: https://chromium-review.googlesource.com/c/1456108Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59421}
-
Jaroslav Sevcik authored
Bug: v8:8361 Change-Id: I25c52c708517cf27add89e0c5c97e6d21abb2a9a Reviewed-on: https://chromium-review.googlesource.com/c/1456089Reviewed-by: Igor Sheludko <ishell@chromium.org> Commit-Queue: Jaroslav Sevcik <jarin@chromium.org> Cr-Commit-Position: refs/heads/master@{#59415}
-
Benedikt Meurer authored
This turns the previous compile time constant IC::kMaxPolymorphicMapCount into a runtime flag --max-polymorphic-map-count (defaults to 4 still), which makes it easier to play with different number of maps in POLYMORPHIC state. Bug: v8:8765 Change-Id: I86c04d9b2d8be21a3bc6b31f70b0bbc359067467 Reviewed-on: https://chromium-review.googlesource.com/c/1456097Reviewed-by: Toon Verwaest <verwaest@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#59398}
-
- 02 Feb, 2019 1 commit
-
-
Mathias Bynens authored
It shipped in Chrome 69. Bug: v8:7220, v8:8562 Change-Id: I09d5ee9e98fc32ae3163c8983d552b99ac4f08e6 Reviewed-on: https://chromium-review.googlesource.com/c/1450781Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> Commit-Queue: Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#59309}
-
- 01 Feb, 2019 1 commit
-
-
Frank Tang authored
See https://github.com/tc39/proposal-intl-datetime-style Design Doc: https://goo.gl/v7n7zV Bug: v8:8702 Change-Id: If45a901e369003ded6c0c690a65f0429800d5ecc Reviewed-on: https://chromium-review.googlesource.com/c/1417372 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org> Reviewed-by: Jakob Kummerow <jkummerow@chromium.org> Cr-Commit-Position: refs/heads/master@{#59264}
-
- 30 Jan, 2019 1 commit
-
-
Stephan Herhut authored
This change lands a change to the register allocator. Other than classical linear scan, we now take control flow events into account when deciding spill descisions. The basic idea is to restore the state of a predecessor on entry of a successor. In the case of multiple predecessors, we use heuristics to compute the new state based on the predecessors. The main addition to the machinery is to support unspilling live ranges and to undo live range splitting in certain cases. Currently, disabled behind a flag. Change-Id: I37a70c948be826a90d8b806a52856ad81f475573 Reviewed-on: https://chromium-review.googlesource.com/c/1426129 Commit-Queue: Stephan Herhut <herhut@chromium.org> Reviewed-by: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#59195}
-